Re: [PATCH 2/2] MMC: P2020 SDHC: Fix bug when writing to SDHCI_HOST_CONTROL register

2013-06-13 Thread Anton Vorontsov
On Wed, Jun 12, 2013 at 04:54:37PM +0300, Oded Gabbay wrote: > The P2020 has a non-standard implementation of the SDHCI_HOST_CONTROL > register. This patch adds a QUIRK in the SDHCI header to signal that > a host controller has a non-standard SDHCI_HOST_CONTROL register. The > patch adds a check to

Re: [PATCH 1/2] MMC: P2020 SDHC: Add support for 8-bit bus width and non-removable card

2013-06-13 Thread Anton Vorontsov
On Wed, Jun 12, 2013 at 04:53:25PM +0300, Oded Gabbay wrote: > @@ -262,7 +288,23 @@ static const struct sdhci_pltfm_data sdhci_esdhc_pdata = > { > > static int sdhci_esdhc_probe(struct platform_device *pdev) > { > - return sdhci_pltfm_register(pdev, &sdhci_esdhc_pdata); > + struct sdhc

[RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-06-13 Thread Zoran Markovic
This is a reworked implementation of wakelocks for the MMC core from Android kernel, originally authored by Colin Cross and San Mehat. The patch makes sure that whenever a MMC device is inserted/removed, the system stays awake until it's reconfigured for the new state. It is assumed that 1/2 second

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Mark Brown
On Thu, Jun 13, 2013 at 09:29:38AM -0700, Tony Lindgren wrote: > * Linus Walleij [130613 08:35]: > > No. If we go down that road *anything* that is connected to a > > pad becomes part of the pinctrl subsystem, then pinctrl-single > > becomes some kind of hardware abstraction or BIOS, and that > >

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Tony Lindgren
* Linus Walleij [130613 08:35]: > On Thu, Jun 13, 2013 at 4:41 PM, Balaji T K wrote: > > > You mean regulator via pinctrl APIs, I think It will just move the code > > from omap_hsmmc to a new regulator file with it own init data for pinctrl. > > No I'm not saying you should use pinctrl as a "ba

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Lee Jones
On Thu, 13 Jun 2013, Balaji T K wrote: > On Thursday 13 June 2013 04:17 PM, Lee Jones wrote: > >On Thu, 13 Jun 2013, Linus Walleij wrote: > > > >>On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > >> > >>>PBIAS register configuration is based on the regulator voltage > >>>which supplies these pb

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 4:41 PM, Balaji T K wrote: >[Me] >>> This seem so intuitively wrong as it can possibly get, clearly this >>> is regulator territory. > > It is not really a regulator, CONTROL_PBIAS_LITE is just a register > in control module which configures pad/pin on SOC. In this case PB

[PATCH] mmc: omap: remove unnecessary #if 0's

2013-06-13 Thread Luciano Coelho
In commit 3451c067 (mmc: omap: add DMA engine support), some #if 0's were used to comment out parts of the code. This has been in the code for over a year and are not needed anymore (and the commented-out code doesn't even compile). Remove them. Signed-off-by: Luciano Coelho --- drivers/mmc/ho

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Balaji T K
On Thursday 13 June 2013 04:17 PM, Lee Jones wrote: On Thu, 13 Jun 2013, Linus Walleij wrote: On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: PBIAS register configuration is based on the regulator voltage which supplies these pbias cells, sd i/o pads. With PBIAS register address and bit de

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Balaji T K
On Thursday 13 June 2013 03:32 PM, Laurent Pinchart wrote: On Thursday 13 June 2013 02:53:54 Tony Lindgren wrote: * Linus Walleij [130613 02:42]: On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: PBIAS register configuration is based on the regulator voltage which supplies these pbias cells,

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Laurent Pinchart
Hi, On Thursday 13 June 2013 20:22:42 Balaji T K wrote: > On Thursday 13 June 2013 03:32 PM, Laurent Pinchart wrote: > > On Thursday 13 June 2013 02:53:54 Tony Lindgren wrote: > >> * Linus Walleij [130613 02:42]: > >>> On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > PBIAS register confi

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Balaji T K
On Thursday 13 June 2013 03:23 PM, Tony Lindgren wrote: * Linus Walleij [130613 02:42]: On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: PBIAS register configuration is based on the regulator voltage which supplies these pbias cells, sd i/o pads. With PBIAS register address and bit definiti

[PATCH] mmc: sdhci: fix ctrl_2 on super-speed selection

2013-06-13 Thread Giuseppe CAVALLARO
This patch fixes the HC ctrl_2 programming where, in case of SDR104 and HS200, we have to write 100b in the the UHS Mode bits. We wrote 101b that is reserved from Arasan Specs. Reported-by: Youssef Triki Signed-off-by: Giuseppe Cavallaro --- drivers/mmc/host/sdhci.c |7 +++ 1 files chan

Re: [PATCH 0/8] sdhci: Move real work out of an atomic context

2013-06-13 Thread Jeremie Samuel
Hi, I posted these patches a few weeks ago. Is it possible to get a feedback for this submission? Thank you for your help. -- Jeremie Samuel Parrot S.A. Software Engineer 14, quai de Jemmapes R&D/OS Platform 75010 Paris, France http://www.parrot.com On 24/05

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 11:53 AM, Tony Lindgren wrote: > * Linus Walleij [130613 02:42]: >> On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: >> > + /* 100ms delay required for PBIAS configuration */ >> > + msleep(100); >> > + if (!vdd && host->pinctrl && host->pbias_off) { >>

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Lee Jones
On Thu, 13 Jun 2013, Linus Walleij wrote: > On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > > > PBIAS register configuration is based on the regulator voltage > > which supplies these pbias cells, sd i/o pads. > > With PBIAS register address and bit definitions different across > > omap[3,4,

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Laurent Pinchart
On Thursday 13 June 2013 02:53:54 Tony Lindgren wrote: > * Linus Walleij [130613 02:42]: > > On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > > > PBIAS register configuration is based on the regulator voltage > > > which supplies these pbias cells, sd i/o pads. > > > With PBIAS register addres

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Tony Lindgren
* Linus Walleij [130613 02:42]: > On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > > > PBIAS register configuration is based on the regulator voltage > > which supplies these pbias cells, sd i/o pads. > > With PBIAS register address and bit definitions different across > > omap[3,4,5], Simpli

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Linus Walleij
On Wed, Jun 12, 2013 at 4:37 PM, Tony Lindgren wrote: > Linus W may have some comments on this, although this is not the standard > muxing stuff. It's in the wrong subsystem and needs to be rewritten IMO. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mm

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Linus Walleij
On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > PBIAS register configuration is based on the regulator voltage > which supplies these pbias cells, sd i/o pads. > With PBIAS register address and bit definitions different across > omap[3,4,5], Simplify PBIAS configuration under three different

Re: [PATCH] mmc: sh_mmcif: add SET_BLOCK_COUNT support

2013-06-13 Thread Shimoda, Yoshihiro
Hello Guennadi-san, (2013/06/13 17:33), Guennadi Liakhovetski wrote: < snip > >> +static bool sh_mmcif_send_sbc(struct sh_mmcif_host *host, >> + struct mmc_request *mrq) >> +{ >> +struct mmc_request req_orig = *mrq; >> +long time; >> + >> +/* Switch the command

Re: [PATCH (v2)] mmc: sdhci: fix caps2 for HS200

2013-06-13 Thread Philip Rakity
On Jun 12, 2013, at 7:16 AM, Giuseppe CAVALLARO wrote: > Although the HC supports HS200 (eMMC) the caps2 are always zero; this means > that > no way to use the super speed mode (when init the card). > > If the HC support SDR104, for SD3.0, so it also supports HS200 for eMMC and > this patch ju

[PATCH v4 3/3] mmc: dw_mmc-pltfm: add Rockchip variant

2013-06-13 Thread Heiko Stübner
Cortex-A9 SoCs from Rockchip use a slightly modified variant of dw_mmc controllers that seems to require the SDMMC_CMD_USE_HOLD_REG bit to always be set. There also seem to be no other modifications (additional register etc) present, so to keep the footprint low, add this small variant to the pltf

[PATCH v4 2/3] mmc: dw_mmc-pltfm: move probe and remove below dt match table

2013-06-13 Thread Heiko Stübner
In a subsquent patch probe will need to do some handling of data from the dt match table. So to prevent the need for forward declarations, move probe and remove below the match table. Signed-off-by: Heiko Stuebner Acked-by: Seungwon Jeon --- drivers/mmc/host/dw_mmc-pltfm.c | 28 ++

[PATCH v4 0/3] mmc: dw_mmc: Add support for Rockchip variant

2013-06-13 Thread Heiko Stübner
The driver support for the mmc host is not needed for the core SoC support and in the same way the mmc support does not need the SoC code to function. Therefore it can be submitted (and hopefully merged) on its own. Changes since v3: - submit mmc driver standalone - add dt binding documentation

[PATCH v4 1/3] mmc: dw_mmc-pltfm: remove static from dw_mci_pltfm_remove

2013-06-13 Thread Heiko Stübner
dw_mci_pltfm_remove gets exported and used by dw_mmc-exynos, so should not be static. Signed-off-by: Heiko Stuebner Acked-by: Jaehoon Chung Acked-by: Seungwon Jeon --- drivers/mmc/host/dw_mmc-pltfm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc

[PATCH 1/2] mmc: sdhci-pci: add support for eMMC hardware reset for BYT eMMC.

2013-06-13 Thread Adrian Hunter
Add support for eMMC hardware reset for BYT eMMC. Signed-off-by: Adrian Hunter --- drivers/mmc/host/sdhci-pci.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c index 611331a..e082fac

[PATCH 2/2] mmc: sdhci-acpi: add support for eMMC hardware reset for HID 80860F14

2013-06-13 Thread Adrian Hunter
Add support for eMMC hardware reset for HID 80860F14. Signed-off-by: Adrian Hunter --- drivers/mmc/host/sdhci-acpi.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c index a51e603..baa57

[PATCH 0/2] mmc: add support for eMMC hardware reset for BYT eMMC

2013-06-13 Thread Adrian Hunter
Hi Here are 2 patches to add support for eMMC hardware reset for BYT eMMC. Adrian Hunter (2): mmc: sdhci-pci: add support for eMMC hardware reset for BYT eMMC. mmc: sdhci-acpi: add support for eMMC hardware reset for HID 80860F14 drivers/mmc/host/sdhci-acpi.c | 28 +

Re: [PATCH] mmc: sh_mmcif: add SET_BLOCK_COUNT support

2013-06-13 Thread Guennadi Liakhovetski
Hello Shimoda-san Thank you for your patch. On Thu, 13 Jun 2013, Shimoda, Yoshihiro wrote: > This patch adds SET_BLOCK_COUNT(CMD23) support to sh_mmcif driver. > If we add MMC_CAP_CMD23 to ".caps" of sh_mmcif_plat_data, the mmc > core driver will use CMD23. Then, the sh_mmcif driver can use > Re

[PATCH] mmc: sh_mmcif: add SET_BLOCK_COUNT support

2013-06-13 Thread Shimoda, Yoshihiro
This patch adds SET_BLOCK_COUNT(CMD23) support to sh_mmcif driver. If we add MMC_CAP_CMD23 to ".caps" of sh_mmcif_plat_data, the mmc core driver will use CMD23. Then, the sh_mmcif driver can use Reliable Write feature. Signed-off-by: Yoshihiro Shimoda --- This patch is based on the latest mmc-ne