Re: [PATCH v4 2/5] mmc: atmel-mci: prepare clk before calling enable

Hello Chris, On 25/08/2013 05:18, Chris Ball wrote: Hi, On Thu, Jul 18 2013, Boris BREZILLON wrote: Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to avoid common clk framework warnings. Signed-off-by: Boris BREZILLON Acked-by: Ludovic Desroches Okay, pushed to mmc-ne

Re: [PATCH] mmc: omap_hsmmc: get capabilities from DT

Hi, On Wed, Aug 14 2013, Daniel Mack wrote: > When used in DT mode, the omap hsmmc driver has to take capabilites > given in DT by calling mmc_of_parse(). > > Signed-off-by: Daniel Mack > --- > drivers/mmc/host/omap_hsmmc.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > di

Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add a new compatible string for exynos5420

Hi Yuvaraj, On Fri, May 24 2013, Yuvaraj Kumar C D wrote: > The Exynos5420 has a DWMMC controller which is different from prior > versions.This patch adds a new compatible string for Exynos5420. > > Signed-off-by: Abhilash Kesavan > Reviewed-by: Alim Akhtar > Signed-off-by: Yuvaraj Kumar C D T

Re: [PATCH V3] mmc:of_spi: Update the code of getting voltage-ranges

Hi Haijun, On Sun, Aug 11 2013, Haijun Zhang wrote: > Using function mmc_of_parse_voltage() to get voltage-ranges. > > Signed-off-by: Haijun Zhang The patchset contains patches 1-3 of 3, and also this unnumbered patch v3. Which order should I use to apply this patch? Thanks, - Chris. -- Chri

Re: my outstanding patches for 3.12

Hi Guennadi, On Fri, Aug 09 2013, Guennadi Liakhovetski wrote: > Hi Chris > > There are still a number of MMC patches from me for 3.12, that still > aren't in next. Unless I'm missing anything, here's the list of patches > with their respective patchwork IDs: > > mmc: SDHI: add DT compatibility

Re: [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling

Hi Guennadi, On Wed, Jul 10 2013, Guennadi Liakhovetski wrote: > This patch series adds version-specific support for Command Completion > Signal and the CE_CLK_CTRL2 register. Presumably, the first two patches > will go via the MMC tree, the rest should be applied after them. > > Cc: Guennadi Li

Re: [PATCH v2] mmc: sh_mmcif: add support for Device Tree DMA bindings

Hi Guennadi, On Mon, Jun 24 2013, Guennadi Liakhovetski wrote: > To use DMA in the Device Tree case the driver has to be modified > to use suitable API to obtain DMA channels. > > Signed-off-by: Guennadi Liakhovetski Thanks, pushed to mmc-next for 3.12. - Chris. -- Chris Ball

Re: [PATCH] mmc: sh_mmcif: move header include from header into .c

Hi Guennadi, On Fri, Aug 02 2013, Guennadi Liakhovetski wrote: > sh_dma.h isn't needed in sh_mmcif.h, move it into sh_mmcif.c. > > Signed-off-by: Guennadi Liakhovetski > --- > drivers/mmc/host/sh_mmcif.c |1 + > include/linux/mmc/sh_mmcif.h |1 - > 2 files changed, 1 insertions(+), 1 de

Re: [PATCH v4 5/7] mmc: SDHI: add DT compatibility strings for further SoCs

Hi Simon, On Tue, Jul 16 2013, Simon Horman wrote: >> Thanks, I have queued this up for v3.12 in the dt branch. >> It should appear in renesas-next-20130710 > > Reviewing this, I now think that it should got through the MMC tree. > Chris, could you consider the patch below? > > From: Guennadi Liak

Re: [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR

Hi Andy, On Thu, Aug 08 2013, Andy Shevchenko wrote: > There is a typo when the mapped space is from BAR 2, but BAR 0 is used > instead. > This patch fixes the typo. > > Signed-off-by: Andy Shevchenko > --- > drivers/mmc/host/dw_mmc-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v3 00/14] Remove platform callbacks from mmc_spi, sh_mmcif and sh_mobile_sdhi drivers

Hi Laurent, On Thu, Aug 08 2013, Laurent Pinchart wrote: > This patch set replaces callbacks to board code with regulators and GPIOs in > the mmc_spi, sh_mmcif and sh_mobile_sdhi MMC drivers. > > Most of the required infrastructure is in place already on the drivers side, > except for CD debouncin

Re: [PATCH] mmc: dw_mmc-pltfm: include 'dw_mmc-pltfm.h'

Hi Seungwon, On Fri, Aug 09 2013, Seungwon Jeon wrote: > On Tue, August 06, 2013,Jingoo Han wrote: >> Include 'dw_mmc-pltfm.h' header file in order to fix >> the following sparse warnings: >> >> drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol >> dw_mci_pltfm_register' was not declared. Shou

Re: [PATCH v2] tmio_mmc_dma: fix PIO fallback on SDHI

Hi, On Sat, Aug 03 2013, Guennadi Liakhovetski wrote: > On Sat, 3 Aug 2013, Sergei Shtylyov wrote: > >> I'm testing SH-Mobile SDHI driver in DMA mode with a new DMA >> controller using >> 'bonnie++' and getting DMA error after which the tmio_mmc_dma.c code >> falls back >> to PIO but all commands

Re: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA

Hi, On Fri, Aug 09 2013, Seungwon Jeon wrote: > On Thu, August 01, 2013, Jingoo Han wrote: >> Added missing MFD_SYSCON dependency for SOCFPGA in order to fix >> the following link error. >> >> drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to >> syscon_regmap_lookup_by_compatible' >>

Re: [PATCH] mmc: core: mmc bus test data timeout setting

Hi, On Fri, Aug 23 2013, Ulf Hansson wrote: > On 26 July 2013 07:06, Minjian Wu (minjianwu) wrote: >> Add data timeout setting for mmc bus test command(CMD14 and CMD19). >> >> Signed-off-by: Minjian Wu > > Acked-by: Ulf Hansson Thanks, pushed to mmc-next for 3.12. - Chris. -- Chris Ball

Re: [PATCH] mmc: fix null pointer use in mmc_blk_remove_req

Hi Franck, On Wed, Jul 24 2013, franck.jull...@gmail.com wrote: > From: Franck Jullien > > A previous commit (fdfa20c1631210d0) reordered the > shutdown sequence in mmc_blk_remove_req. However, > mmc_cleanup_queue is now called before we get the > card pointer and, sadly, mmc_cleanup_queue set >

Re: [PATCH] mmc: mmc_test: replace strict_strtol() with kstrtol_from_user()

Hi Jingoo, On Fri, Jul 19 2013, Jingoo Han wrote: > The usage of strict_strtol() is not preferred, because > strict_strtol() is obsolete. Thus, kstrtol() should be > used. > > Also, both kstrtol() and copy_from_user() can be replaced > with kstrtol_from_user() to make the code simpler. > > Signed-

Re: [PATCH v4 2/5] mmc: atmel-mci: prepare clk before calling enable

Hi, On Thu, Jul 18 2013, Boris BREZILLON wrote: > Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to > avoid common clk framework warnings. > > Signed-off-by: Boris BREZILLON > Acked-by: Ludovic Desroches Okay, pushed to mmc-next for 3.12. Boris, you got feedback from Thom

Re: [PATCH] mmc: sd: fix the maximum au_size for SD3.0

Hi Jaehoon, Pushed to mmc-next for 3.12 with the following minor change, let me know if you disagree: On Thu, Jul 18 2013, Jaehoon Chung wrote: > Since SD Physical Layer specification V3.0, AU_SIZE is supported up to 0xf. > So If SD-card is supported v3.0, then max_au should be 0xf. > > Signed-of

Re: [PATCH] mmc/core: free mmc_card when cmd 3,9,7 got failed in mmc_sd_init_card

Hi Wei, On Wed, Jul 17 2013, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > In function mmc_sd_init_card, if command 3/9/7 got failed, mmc_card > allocated just before won't be freed. This would cause memory leak. > > Signed-off-by: Wei WANG > --- > drivers/mmc/core/sd.c |6 +++--- > 1

Re: [PATCH] mmc:host: Remove a duplicate line in Makefile

Hi Wei, On Tue, Jul 16 2013, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Signed-off-by: Wei WANG > --- > drivers/mmc/host/Makefile |2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile > index d422e21..c41d0c3 100644 > --- a/d

Re: [PATCH] mmc: omap_hsmmc: fix dependency on indirect header inclusion

Hi, On Fri, Aug 16 2013, Balaji T K wrote: > On Thursday 11 July 2013 06:39 PM, Felipe Balbi wrote: >> omap_hsmmc.c depends on being >> included indirectly by another header. Once we >> enable COMPILE_TEST for this driver, we might >> compile under architectures which won't include >> for us. In

Re: [PATCH] mmc: dw_mmc: Handle DW_MCI_QUIRK_IDMAC_DTO properly

Hi, On Wed, Jul 10 2013, Seungwon Jeon wrote: > On Wed, July 10, 2013, Doug Anderson wrote: >> In (1fb5f68 mmc: dw_mmc: Don't loop when handling an interrupt), the >> code for handling DW_MCI_QUIRK_IDMAC_DTO became dead code. Move it to >> where it ought to live. >> >> Found by code inspection a

Re: [PATCH] mmc: sdhci: request irq after sdhci_init() is called

Hi Shawn, On Fri, Jul 05 2013, Shawn Guo wrote: > Generally request_irq() should be called after hardware has been > initialized into a sane state. However, sdhci driver currently calls > request_irq() before sdhci_init(). At least, the following kernel panic > seen on i.MX6 is caused by that.

Re: [PATCH 1/2] mmc: mxs-mmc: Use devm_clk_get()

Hi Fabio, On Wed, Jul 03 2013, Shawn Guo wrote: > On Wed, Jul 03, 2013 at 05:02:37PM -0300, Fabio Estevam wrote: >> Using devm_clk_get() allows us to remove the clk_put() calls, so let's use it >> to simplify the code. >> >> Rename the 'out_clk_put' label to 'out_clk_disable' now that clk_put >>

Re: [PATCH] mmc: omap_hsmmc: clear status flags before starting a new command

Hi Balaji, On Sat, Jun 29 2013, Francesco Lavra wrote: > Commit 1f6b9fa40e76fffaaa0b3bd6a0bfdcf1cdc06efa consolidated writes to > the STAT register in one location, moving them from omap_hsmmc_do_irq() > to omap_hsmmc_irq(). This move has the unwanted side effect that the > controller status fl

Re: [PATCH -next] mmc: jz4740: fix return value check in jz4740_mmc_probe()

Hi Wei, On Fri, Jun 28 2013, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). Also there is already a error message within > dev

Re: [PATCH 6/8] sdhci: Turn host->lock into a mutex

Hi Jeremie, I'm sorry for a very late review. On Tue, Jul 09 2013, Jeremie Samuel wrote: > @@ -118,7 +119,7 @@ struct sdhci_host { > enum led_brightness brightness; > #endif > > - spinlock_t lock;/* Mutex */ > + struct mutex lock; /* Mutex */ > > int flags;

Re: [PATCH 1/1] mmc: vub300: Staticize vub300_init_card

Hi Sachin, On Wed, Jun 26 2013, Sachin Kamat wrote: > 'vub300_init_card' is used only in this file. Make it > static. > > Signed-off-by: Sachin Kamat > --- > drivers/mmc/host/vub300.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/vub300.c b/drivers/

Re: [PATCH 1/1] mmc: sdhci-bcm2835: Staticize bcm2835_sdhci_get_min_clock

Hi Sachin, On Wed, Jun 26 2013, Sachin Kamat wrote: > 'bcm2835_sdhci_get_min_clock' is used only in this file. > Make it static. > > Signed-off-by: Sachin Kamat > --- > drivers/mmc/host/sdhci-bcm2835.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/s