Re: [PATCH V3 2/4] mmc: mmci: Use optional sleep pinctrl state

2013-09-03 Thread Linus Walleij
On Tue, Sep 3, 2013 at 11:29 AM, Ulf Hansson wrote: > By optionally putting the pins into sleep state in the .runtime_suspend > callback we can accomplish two things. One is to minimize current leakage > from pins and thus save power, second we can prevent the IP from driving > pins output in an

Re: [PATCH V3 1/4] mmc: mmci: Adapt to new pinctrl handling

2013-09-03 Thread Linus Walleij
On Tue, Sep 3, 2013 at 11:29 AM, Ulf Hansson wrote: > There is no need for every driver to fetch a pinctrl handle and to > select the default state. Instead this is handled by the device driver > core, thus we can remove this piece of code from mmci. > > Signed-off-by: Ulf Hansson > Cc: Linus Wa

Re: [PATCH] mmc: enable BKOPS for supported eMMC(4.41)

2013-09-03 Thread Jaehoon Chung
Hi Prasanna, You can refer to http://permalink.gmane.org/gmane.linux.kernel.mmc/15430 Best Regards, Jaehoon Chung On 09/03/2013 06:34 PM, Nitin Singla wrote: > Hi Prasanna, > > MMC-Utils open source utility for enabling and disabling features. > It use ioctl defined in block/card to send comma

RE: [PATCH v2] mmc: add ignorance case for CMD13 CRC error

2013-09-03 Thread Seungwon Jeon
On Tue, September 03, 2013, Ulf Hansson wrote: > On 26 August 2013 09:20, Seungwon Jeon wrote: > > While speed mode is changed, CMD13 cannot be guaranteed. > > According to the spec., it is not recommended to use CMD13 > > to check the busy completion of the timing change. > > If CMD13 is used in

Re: BCM57765: timeout waiting for hardware interrupt

2013-09-03 Thread Daniel J Blueman
On 3 September 2013 19:04, Chris Ball wrote: > On Tue, Sep 03 2013, Daniel J Blueman wrote: >> Please let me know if there's a better vector for reporting and >> looking into this issue, if you can. > > Do you know whether it's ever worked on this hardware? If so, could > you try bisecting to fin

Re: [PATCH v4 2/6] dma: edma: Write out and handle MAX_NR_SG at a given time

2013-09-03 Thread Joel Fernandes
On 09/02/2013 11:08 PM, Vinod Koul wrote: > On Thu, Aug 29, 2013 at 06:05:41PM -0500, Joel Fernandes wrote: >> Process SG-elements in batches of MAX_NR_SG if they are greater >> than MAX_NR_SG. Due to this, at any given time only those many >> slots will be used in the given channel no matter how l

Re: [PATCH v2] mmc: add ignorance case for CMD13 CRC error

2013-09-03 Thread Ulf Hansson
On 26 August 2013 09:20, Seungwon Jeon wrote: > While speed mode is changed, CMD13 cannot be guaranteed. > According to the spec., it is not recommended to use CMD13 > to check the busy completion of the timing change. > If CMD13 is used in this case, CRC error must be ignored. > > Signed-off-by:

Re: [PATCH v2 3/4] mmc: sdhci-s3c: revert "fix missing clock for gpio card-detect"

2013-09-03 Thread Jaehoon Chung
Hi, On 08/30/2013 10:22 AM, Chris Ball wrote: > Hi, > > On Fri, Aug 02 2013, Jaehoon Chung wrote: >> Fixed the warning message.(clk_disable/enable didn't pair) >> [..] >> >> Signed-off-by: Jaehoon Chung >> Signed-off-by: Kyungmin Park >> Acked-by: Heiko Stuebner >> Tested-by: Heiko Stuebner >

[PATCH V4 3/4] mmc: mmci: Adapt to register write restrictions

2013-09-03 Thread Ulf Hansson
After a write to the MMCICLOCK register data cannot be written to this register for three feedback clock cycles. Writes to the MMCIPOWER register must be separated by three MCLK cycles. Previously no issues has been observered, but using higher ARM clock frequencies on STE- platforms has triggered

Re: [PATCH V3 3/4] mmc: mmci: Adapt to register write restrictions

2013-09-03 Thread Ulf Hansson
On 3 September 2013 11:50, Daniel Lezcano wrote: > On 09/03/2013 11:29 AM, Ulf Hansson wrote: >> After a write to the MMCICLOCK register data cannot be written to this >> register for three feedback clock cycles. Writes to the MMCIPOWER >> register must be separated by three MCLK cycles. Previousl

Re: MMC_SWITCH command doesn't update the ext_csd data structure

2013-09-03 Thread Dirk Behme
On 03.09.2013 13:26, Chris Ball wrote: Hi, On Tue, Sep 03 2013, Dirk Behme wrote: + if ((cmd.opcode == MMC_SWITCH) && ((cmd.arg >> 24) & 0x3)) { + /* In case the IOCTL has modified the EXT_CSD, update it, i.e. re-read the EXT_CSD */ + mmc_update_ext_csd(card->e

Re: MMC_SWITCH command doesn't update the ext_csd data structure

2013-09-03 Thread Chris Ball
Hi, On Tue, Sep 03 2013, Dirk Behme wrote: > + if ((cmd.opcode == MMC_SWITCH) && ((cmd.arg >> 24) & 0x3)) { > + /* In case the IOCTL has modified the EXT_CSD, update > it, i.e. re-read the EXT_CSD */ > + mmc_update_ext_csd(card->ext_csd); > + } > + Your analy

Re: [PATCH 00/22] mmc: dw_mmc: add driver's updates

2013-09-03 Thread Chris Ball
Hi, On Tue, Sep 03 2013, Seungwon Jeon wrote: > Please could you apply this updates for mmc-next? 3.11 is released, so it's too late to apply these to the 3.12-rc1 merge, since there would be no time to test them in linux-next. But it looks like many of them are fixes, so we can just send those

MMC_SWITCH command doesn't update the ext_csd data structure

2013-09-03 Thread Dirk Behme
Hi, using the MMC_SWITCH command via the ioctl to write registers of the EXT_CSD, it looks to us that in this case the internal ext_csd data structure isn't updated. Resulting in a mismatch of what the ext_csd data structure contains and what's written to the real hardware. We are using the

RE: [PATCH v2] mmc: add ignorance case for CMD13 CRC error

2013-09-03 Thread Seungwon Jeon
On Mon, August 26, 2013, Seungwon Jeon wrote: > While speed mode is changed, CMD13 cannot be guaranteed. > According to the spec., it is not recommended to use CMD13 > to check the busy completion of the timing change. > If CMD13 is used in this case, CRC error must be ignored. > > Signed-off-by:

Re: [PATCH V3 4/4] mmc: mmci: Save and restore register context

2013-09-03 Thread Daniel Lezcano
On 09/03/2013 11:29 AM, Ulf Hansson wrote: > If a corresponding power domain exists for the device and it manages > to cut the domain regulator while the device is runtime suspended, > the IP loses it's registers context. We restore the context in the > .runtime_resume callback from the existing re

Re: [PATCH V3 3/4] mmc: mmci: Adapt to register write restrictions

2013-09-03 Thread Daniel Lezcano
On 09/03/2013 11:29 AM, Ulf Hansson wrote: > After a write to the MMCICLOCK register data cannot be written to this > register for three feedback clock cycles. Writes to the MMCIPOWER > register must be separated by three MCLK cycles. Previously no issues > has been observered, but using higher ARM

Re: [PATCH] mmc: enable BKOPS for supported eMMC(4.41)

2013-09-03 Thread Nitin Singla
Hi Prasanna, MMC-Utils open source utility for enabling and disabling features. It use ioctl defined in block/card to send commands to host. git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git Thanks, Nitin On Tue, Sep 3, 2013 at 2:28 PM, Prasanna NAVARATNA wrote: > Hello Jaehoon, >

[PATCH V3 3/4] mmc: mmci: Adapt to register write restrictions

2013-09-03 Thread Ulf Hansson
After a write to the MMCICLOCK register data cannot be written to this register for three feedback clock cycles. Writes to the MMCIPOWER register must be separated by three MCLK cycles. Previously no issues has been observered, but using higher ARM clock frequencies on STE- platforms has triggered

[PATCH V3 0/4] mmc: mmci: Support ap_sleep in cpuidle for ux500

2013-09-03 Thread Ulf Hansson
To be able to enter ap_sleep state in cpuidle were the APE power domain regulator will be cut, a register save and restore mechanism needs to be implemented. This patchset adapts to these restrictions. Changes in v3: - Fold in a new patch, mmc: mmci: Adapt to new pinctrl handling -

[PATCH V3 2/4] mmc: mmci: Use optional sleep pinctrl state

2013-09-03 Thread Ulf Hansson
By optionally putting the pins into sleep state in the .runtime_suspend callback we can accomplish two things. One is to minimize current leakage from pins and thus save power, second we can prevent the IP from driving pins output in an uncontrolled manner, which may happen if the power domain drop

[PATCH V3 1/4] mmc: mmci: Adapt to new pinctrl handling

2013-09-03 Thread Ulf Hansson
There is no need for every driver to fetch a pinctrl handle and to select the default state. Instead this is handled by the device driver core, thus we can remove this piece of code from mmci. Signed-off-by: Ulf Hansson Cc: Linus Walleij --- drivers/mmc/host/mmci.c | 17 - dri

[PATCH V3 4/4] mmc: mmci: Save and restore register context

2013-09-03 Thread Ulf Hansson
If a corresponding power domain exists for the device and it manages to cut the domain regulator while the device is runtime suspended, the IP loses it's registers context. We restore the context in the .runtime_resume callback from the existing register caches to adapt to this siutuation. We also

Re: [PATCH] mmc: enable BKOPS for supported eMMC(4.41)

2013-09-03 Thread Prasanna NAVARATNA
Hello Jaehoon, > Why do you use MMC_CAP2_BKOPS_EN? Because BKOPS on eMMC4.41 is optional. So the capability is provided for the platform to either enable/disable this feature (its not mandatory to always enable BKOPS on 4.41) > Maybe we had discussed about this point. i know that we can enable th

RE: [PATCH 00/22] mmc: dw_mmc: add driver's updates

2013-09-03 Thread Seungwon Jeon
Hi Chris, Please could you apply this updates for mmc-next? Thanks, Seungwon Jeon On Sat, August 31, 2013, Seungwon Jeon wrote: > This patch set includes updates of dw_mmc driver. > > - Tuning scheme for high speed mode such as HS200. > - Support of HS200 mode in exynos host > - Involved some f

Re: [PATCH 1/5] powerpc/85xx: Add support for 85xx cpu type detection

2013-09-03 Thread Zhang Haijun
Hi, Anton and all I update all the patch send. Kindly for review. Thanks. On 09/03/2013 03:33 PM, Haijun Zhang wrote: Add this file to help detect cpu type in runtime. These macros will be more favorable for driver to apply errata and workaround to specified cpu type. Signed-off-by: Haijun Z

[PATCH 5/5] mmc:esdhc: eSDHC host don't have highspeed bit

2013-09-03 Thread Haijun Zhang
eSDHC host is not a standand host, there is no SDHCI_CTRL_HISPD bit in SDHCI_HOST_CONTROL register. Add this quirk to avoid changing the Data transfer width bit of eSDHC host. Signed-off-by: Haijun Zhang --- drivers/mmc/host/sdhci-esdhc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drive

[PATCH 3/5] mmc: esdhc: workaround for dma err in the last system transaction

2013-09-03 Thread Haijun Zhang
A-004388: eSDHC DMA might not stop if error occurs on system transaction eSDHC DMA(SDMA/ADMA) might not stop if an error occurs in the last system transaction. It may continue initiating additional transactions until software reset for data/all is issued during error recovery. There is not any dat

[PATCH 1/5] powerpc/85xx: Add support for 85xx cpu type detection

2013-09-03 Thread Haijun Zhang
Add this file to help detect cpu type in runtime. These macros will be more favorable for driver to apply errata and workaround to specified cpu type. Signed-off-by: Haijun Zhang Signed-off-by: Zhao Chenhui --- arch/powerpc/include/asm/mpc85xx.h | 92 ++ 1 fi

[PATCH 2/5] mmc:sdhc: Share function sdhci_reset for platform use

2013-09-03 Thread Haijun Zhang
In some case, sdhci_reset is need to be invoked in some platform related workaround. So export it for public use. Signed-off-by: Haijun Zhang --- drivers/mmc/host/sdhci.c | 3 ++- drivers/mmc/host/sdhci.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci

[PATCH 4/5] mmc: esdhc: Correct host version of T4240-R1.0-R2.0

2013-09-03 Thread Haijun Zhang
Vender version and sdhc spec version of T4240-R1.0-R2.0 is incorrect. The right value should be VVN=0x13, SVN = 0x1. The wrong version number will break down the ADMA data transfer. This defect only exist in T4240-R1.0-R2.0. Signed-off-by: Haijun Zhang --- - Depend on patch [1/5] driver