Re: [PATCH] mmc: sdhci: supporting PCI MSI

2013-11-07 Thread Aaron Lu
On 11/01/2013 05:45 PM, Jackey Shen wrote: > Enable MSI support in sdhci-pci driver and provide the mechanism > to fall back to Legacy Pin-based Interrupt if MSI register fails. > > Signed-off-by: Jackey Shen > Reviewed-by: Huang Rui > --- > drivers/mmc/host/Kconfig | 11 + > drivers/mmc/

Re: [PATCH 4/8] mmc: tmio: Keep host active while SDIO irq is enabled

2013-11-07 Thread Guennadi Liakhovetski
Hi Ulf, On Fri, 8 Nov 2013, Ulf Hansson wrote: > The host must be kept active to be able to serve with SDIO irqs. We > prevent it from being put into in-active while the SDIO irq is enabled > by simply adding balanced calls to pm_runtime_get|put. > > Cc: Guennadi Liakhovetski > Signed-off-by: U

Re: [PATCH] sdhci: do not program timer when tuning_count is zero

2013-11-07 Thread Aaron Lu
On 11/07/2013 06:59 PM, Arend van Spriel wrote: > When the host->tuning_count is zero it means that the If the tuning_count is zero, then the retuning timer shouldn't be started in the first place and not possible to run code there. Or is the tuning_count dynamically changed? Thanks, Aaron > ret

[PATCH 4/8] mmc: tmio: Keep host active while SDIO irq is enabled

2013-11-07 Thread Ulf Hansson
The host must be kept active to be able to serve with SDIO irqs. We prevent it from being put into in-active while the SDIO irq is enabled by simply adding balanced calls to pm_runtime_get|put. Cc: Guennadi Liakhovetski Signed-off-by: Ulf Hansson --- drivers/mmc/host/tmio_mmc.h |1 + dr

[PATCH 6/8] mmc: tmio: Extract bus_width modifications to a function

2013-11-07 Thread Ulf Hansson
Cc: Guennadi Liakhovetski Signed-off-by: Ulf Hansson --- drivers/mmc/host/tmio_mmc_pio.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c index 33a5e26..fefe86c 100644 --- a/drivers

[PATCH 8/8] mmc: tmio: Handle clock gating from runtime PM functions

2013-11-07 Thread Ulf Hansson
Add clock gating control as a part of the exported runtime PM functions to provide tmio variants to use this in a common way. Cc: Guennadi Liakhovetski Signed-off-by: Ulf Hansson --- drivers/mmc/host/tmio_mmc.h |3 ++- drivers/mmc/host/tmio_mmc_pio.c | 28

[PATCH 7/8] mmc: tmio: Restructure .set_ios and adapt probe sequence to it

2013-11-07 Thread Ulf Hansson
An internal power state machine has earlier been used to keep probe and .set_ios in sync. Moreover it was used to handle the specific scenario of using MMC_CLKGATE. A dependency to MMC_CLKGATE existed to handle runtime PM properly, which we moves away from here. By removing the state machine and i

[PATCH 5/8] mmc: tmio: Keep host active while serving requests

2013-11-07 Thread Ulf Hansson
Use runtime PM to keep the host active during I/O operations and other requests which requires the tmio hardware to be powered. Additionally make use of the runtime PM autosuspend feature with a default timeout of 50 ms. Cc: Guennadi Liakhovetski Signed-off-by: Ulf Hansson --- drivers/mmc/host

[PATCH 2/8] mmc: tmio_mmc: Convert from legacy to modern PM ops

2013-11-07 Thread Ulf Hansson
Signed-off-by: Ulf Hansson Acked-by: Guennadi Liakhovetski --- drivers/mmc/host/tmio_mmc.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c index 8860d4d..42da904 100644 --- a/drivers/

[PATCH 0/8] mmc: tmio: Convert to use runtime PM at request idle

2013-11-07 Thread Ulf Hansson
In a step in removing CONFIG_MMC_CLKGATE, host drivers can implement same functionality through runtime PM. This patchset is converting the tmio accordingly. On the way, it was reasonable to include some minor cleanups to simplify code. The first three patch has beend sent through an another patch

[PATCH 3/8] mmc: tmio: Adapt to proper PM configs for exported functions

2013-11-07 Thread Ulf Hansson
Since the users of the exported PM functions are now using the modern PM ops macros, we can convert to the proper corresponding PM configs. Signed-off-by: Ulf Hansson Acked-by: Guennadi Liakhovetski --- drivers/mmc/host/tmio_mmc.h |7 +++ drivers/mmc/host/tmio_mmc_pio.c |7 -

[PATCH 1/8] mmc: sh_mobile_sdhi: Use modern PM macros to define pm callbacks

2013-11-07 Thread Ulf Hansson
Signed-off-by: Ulf Hansson Acked-by: Guennadi Liakhovetski --- drivers/mmc/host/sh_mobile_sdhi.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c index 87ed3fb..2227a9f 100644 --- a/drivers/mmc/h

[PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-11-07 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao Tested-by: Zhigang Wang --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 83 +++ drivers/mmc/host/Kconfig | 10 + drivers/mmc/host/Makefile |1 + drivers/

[PATCH 1/2] mmc: dw_mmc: add dw_mci_of_get_cd_gpio to handle cd pin

2013-11-07 Thread Zhangfei Gao
Add function dw_mci_of_get_cd_gpio to check "cd-gpios" from dts. mmc_gpio_request_cd and mmc_gpio_get_cd are used to handle cd pin Signed-off-by: Zhangfei Gao CC: Jaehoon Chung --- drivers/mmc/host/dw_mmc.c | 52 + 1 file changed, 39 insertions(+),

[PATCH v3 0/2] mmc: dw_mmc: add dw_mmc-k3

2013-11-07 Thread Zhangfei Gao
v3: 0001: Put set/clear_bit DW_MMC_CARD_PRESENT in dw_mci_get_cd, Since dw_mci_request will check DW_MMC_CARD_PRESENT before sending cmd 0002: Follow suggestion from Chris, Kumar and Seungwon Sync to latest mmc-next, which is 3.12-rc2 Remove enum dw_mci_k3_type etc v2: Follow Jaehoon's suggesti

Re: [PATCH] mmc: sdhci-s3c: Remove unused define for NUM_GPIOS

2013-11-07 Thread Jaehoon Chung
Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung On 10/03/2013 05:59 PM, Axel Lin wrote: > NUM_GPIOS is not used after commit e19499ae > "mmc: sdhci-s3c: let device core setup the default pin configuration". > Thus remove it. > > Signed-off-by: Axel Lin > --- > drivers/mmc/host/sdhci-s3c.c

[RFC PATCH] mmc: core: add the sleep notification feature for eMMC5.0

2013-11-07 Thread Jaehoon Chung
Sleep notification is supported since eMMC5.0. Signed-off-by: Jaehoon Chung --- drivers/mmc/core/mmc.c | 30 +++--- include/linux/mmc/card.h |2 ++ include/linux/mmc/mmc.h |2 ++ 3 files changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/core

RE: [PATCH 3/3] mmc: add support for hs400 mode of eMMC5.0

2013-11-07 Thread Seungwon Jeon
Hi Jackey, On Thur, November 07, 2013, Shen, Jackey wrote > Hi Seungwon, > > > -Original Message- > > From: linux-mmc-ow...@vger.kernel.org > > [mailto:linux-mmc-ow...@vger.kernel.org] > > On Behalf Of Seungwon Jeon > > Sent: Tuesday, November 05, 2013 9:28 PM > > To: 'Chris Ball'; 'Ulf

[PATCH] sdhci: do not program timer when tuning_count is zero

2013-11-07 Thread Arend van Spriel
When the host->tuning_count is zero it means that the retuning is disabled. Doing a mod_timer() with a zero tuning_count does something else. Signed-off-by: Arend van Spriel --- drivers/mmc/host/sdhci.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdh

Re: [PATCH 1/1] MMC: Detect execution mode errors after r/w command

2013-11-07 Thread Oskar Andero
Hi Ulf, On 18:50 Tue 22 Oct , Ulf Hansson wrote: > > And this is after the patch has been applied: > > KB reclen write rewritereadreread > >51200 4 251 990 3280 3244 > >51200 8 4601545 4460 4463 > >