Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-02-13 Thread Nishanth Menon
On 02/13/2014 05:05 PM, Tony Lindgren wrote: > * Nishanth Menon [140205 06:15]: >> On Wed 05 Feb 2014 08:10:34 AM CST, Balaji T K wrote: > > Rather than ti,errata.. specific property, something like > caps no/disable multiblock read is more readable in my opinion, Otherwise I

[PATCH V2 2/2] ARM: dts: omap3-ldp: fix mmc configuration

2014-02-13 Thread Nishanth Menon
MMC1 is the only MMC interface available on the platform. Further, since the platform is based on older revision of SoC which is not capable of doing multi-block reads, mark it with compatibility for the same and add pinmux to ensure that all relevant pins are configured for non-MMC boot mode. Sig

[PATCH V2 0/2] mmc: omap_hsmmc: fix for pre es3.0 OMAP3

2014-02-13 Thread Nishanth Menon
Originally reported in: https://patchwork.kernel.org/patch/3514851/ https://patchwork.kernel.org/patch/3514881/ ES3.0+ provides MMC controller which is fixed for multi-block reads, however LDP platform Looking at the various IP revision register information: sdp2430: Revision: 1.2, Spec: 0.0, nor

[PATCH V2 1/2] mmc: omap_hsmmc: Add support for quirky omap3 hsmmc controller

2014-02-13 Thread Nishanth Menon
When device is booted using devicetree, platforms impacted by Erratum 2.1.1.128 is not detected easily in the mmc driver. This erratum indicates that the module cannot do multi-block transfers. Platforms such as LDP which use OMAP3 ES revision prior to ES3.0 are impacted by this. Provide a new com

[PATCH] mmc: omap_hsmmc: fix sparse/smatch warning for paranthesis

2014-02-13 Thread Nishanth Menon
commit 6c31b21 (mmc: omap_hsmmc: remove access to SYSCONFIG register) introduced an smatch(http://smatch.sf.net) warning for the following: drivers/mmc/host/omap_hsmmc.c:608 omap_hsmmc_context_restore() warn: add some parenthesis here? drivers/mmc/host/omap_hsmmc.c:608 omap_hsmmc_context_restore(

Re: [GIT PULL] MMC updates for mmc-next for 3.14, take 1

2014-02-13 Thread Chris Ball
Hi Ulf, On Fri, Dec 20 2013, Ulf Hansson wrote: > 11 files changed, 40 insertions(+), 179 deletions(-) Sorry for the delay, and thank you for the pleasing diffstat. :-) Pushed to mmc-next for 3.15. - Chris. -- Chris Ball -- To unsubscribe from this list: send the lin

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-02-13 Thread Tony Lindgren
* Nishanth Menon [140205 06:15]: > On Wed 05 Feb 2014 08:10:34 AM CST, Balaji T K wrote: > >>> > >>> Rather than ti,errata.. specific property, something like > >>> caps no/disable multiblock read is more readable in my opinion, Otherwise > >> > >> Is'nt the better definition to state i have quirk

Re: [PATCH] Fix uses of dma_max_pfn() when converting to a limiting address

2014-02-13 Thread Russell King - ARM Linux
On Thu, Feb 13, 2014 at 10:07:01AM -0800, James Bottomley wrote: > On Thu, 2014-02-13 at 17:11 +, Russell King - ARM Linux wrote: > > On Thu, Feb 13, 2014 at 08:58:10AM -0800, James Bottomley wrote: > > > This doesn't really look like the right fix. You replaced dev->dma_mask > > > with a calc

Re: [PATCH] Fix uses of dma_max_pfn() when converting to a limiting address

2014-02-13 Thread James Bottomley
On Thu, 2014-02-13 at 17:11 +, Russell King - ARM Linux wrote: > On Thu, Feb 13, 2014 at 08:58:10AM -0800, James Bottomley wrote: > > This doesn't really look like the right fix. You replaced dev->dma_mask > > with a calculation on dev_max_pfn(). Since dev->dma_mask is always u64 > > and dev_

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-02-13 Thread Olof Johansson
On Thu, Feb 13, 2014 at 05:13:14PM +0100, Arnd Bergmann wrote: > On Thursday 13 February 2014 14:41:06 Russell King - ARM Linux wrote: > > On Thu, Feb 13, 2014 at 01:48:55PM +0100, Arnd Bergmann wrote: > > > On Thursday 13 February 2014 10:42:48 Russell King - ARM Linux wrote: > > > > > > > > What

Re: [PATCH] Fix uses of dma_max_pfn() when converting to a limiting address

2014-02-13 Thread Russell King - ARM Linux
On Thu, Feb 13, 2014 at 08:58:10AM -0800, James Bottomley wrote: > This doesn't really look like the right fix. You replaced dev->dma_mask > with a calculation on dev_max_pfn(). Since dev->dma_mask is always u64 > and dev_max_pfn is supposed to be returning the pfn of the dma_mask, it > should un

Re: [PATCH] Fix uses of dma_max_pfn() when converting to a limiting address

2014-02-13 Thread James Bottomley
On Tue, 2014-02-11 at 17:28 +, Russell King wrote: > We must use a 64-bit for this, otherwise overflowed bits get lost, and > that can result in a lower than intended value set. > > Fixes: 8e0cb8a1f6ac ("ARM: 7797/1: mmc: Use dma_max_pfn(dev) helper for > bounce_limit calculations") > Fixes:

Re: [PATCH v8 3/3] mmc: sdhci-msm: Add platform_execute_tunning implementation

2014-02-13 Thread Georgi Djakov
Hi Stephen, On 02/08/2014 05:23 AM, Stephen Boyd wrote: On 01/30, Georgi Djakov wrote: @@ -75,17 +110,389 @@ struct sdhci_msm_host { }; /* MSM platform specific tuning */ -int sdhci_msm_execute_tuning(struct sdhci_host *host, u32 opcode) +static inline int msm_dll_poll_ck_out_en(struct sdh

Re: [PATCH] Fix uses of dma_max_pfn() when converting to a limiting address

2014-02-13 Thread Santosh Shilimkar
On Tuesday 11 February 2014 12:28 PM, Russell King wrote: > We must use a 64-bit for this, otherwise overflowed bits get lost, and > that can result in a lower than intended value set. > > Fixes: 8e0cb8a1f6ac ("ARM: 7797/1: mmc: Use dma_max_pfn(dev) helper for > bounce_limit calculations") > Fixe

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-02-13 Thread Arnd Bergmann
On Thursday 13 February 2014 14:41:06 Russell King - ARM Linux wrote: > On Thu, Feb 13, 2014 at 01:48:55PM +0100, Arnd Bergmann wrote: > > On Thursday 13 February 2014 10:42:48 Russell King - ARM Linux wrote: > > > > > > What if we have a platform where things subtly change, like for instance, > >

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-02-13 Thread Russell King - ARM Linux
On Thu, Feb 13, 2014 at 01:48:55PM +0100, Arnd Bergmann wrote: > On Thursday 13 February 2014 10:42:48 Russell King - ARM Linux wrote: > > > > What if we have a platform where things subtly change, like for instance, > > the wiring on the SD slot to fix a problem with UHS-1 cards, which means > >

Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-13 Thread Ulf Hansson
On 10 February 2014 11:14, Ulf Hansson wrote: > On 5 February 2014 15:34, Linus Walleij wrote: >> On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote: >> >>> Since the device is active while a successful probe has been completed, >>> the reference counting for the clock will be screwed up and neve

[PATCH V2 12/17] i2c: nomadik: Remove redundant call to pm_runtime_disable

2014-02-13 Thread Ulf Hansson
The amba bus are responsible for pm_runtime_enable|disable, remove the redundant pm_runtime_disable at driver removal. Cc: Alessandro Rubini Cc: Linus Walleij Cc: Wolfram Sang Signed-off-by: Ulf Hansson --- Changes in v2: Rebased on top of latest i2c-nomadik branch. --- drivers/i2c/

[PATCH V2 15/17] i2c: nomadik: Convert to late and early system PM callbacks

2014-02-13 Thread Ulf Hansson
At system suspend_late, runtime PM has been disabled by the PM core which means we can safely operate on these resources. Consequentially we no longer have to wait until the noirq phase of the system suspend. Cc: Alessandro Rubini Cc: Linus Walleij Cc: Wolfram Sang Signed-off-by: Ulf Hansson -

[PATCH V2 17/17] i2c: nomadik: Fixup system suspend

2014-02-13 Thread Ulf Hansson
For !CONFIG_PM_RUNTIME, the device were never put back into active state while resuming. For CONFIG_PM_RUNTIME, we blindly trusted the device to be inactive while we were about to handle it at suspend late, which is just too optimistic. Even if the driver uses pm_runtime_put_sync() after each tra

[PATCH V2 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-13 Thread Ulf Hansson
Since the runtime PM state is expected to be active according to the amba bus, we must align our behaviour while probing to it. Moreover, this is needed to be able to have the driver fully functional without depending on CONFIG_RUNTIME_PM. Since the device is active while a successful probe has b

[PATCH V2 16/17] i2c: nomadik: Remove busy check for transfers at suspend late

2014-02-13 Thread Ulf Hansson
We should never be busy performing transfers at suspend late, thus there are no reason to check for it. Cc: Alessandro Rubini Cc: Linus Walleij Cc: Wolfram Sang Signed-off-by: Ulf Hansson --- Changes in v2: Rebased on top of latest i2c-nomadik branch. --- drivers/i2c/busses/i2c-noma

[PATCH V2 11/17] i2c: nomadik: Convert to devm functions

2014-02-13 Thread Ulf Hansson
Use devm_* functions to simplify code and error handling. Cc: Alessandro Rubini Cc: Linus Walleij Cc: Wolfram Sang Signed-off-by: Ulf Hansson --- Changes in v2: Rebased on top of latest i2c-nomadik branch. --- drivers/i2c/busses/i2c-nomadik.c | 29 + 1

Re: [RFT][PATCH v3] mmc: change cb710-mmc platform power management to use dev_pm_ops

2014-02-13 Thread Shuah Khan
On 02/13/2014 02:47 AM, Ulf Hansson wrote: On 12 February 2014 22:21, Shuah Khan wrote: Change cb710-mmc platform driver to register pm ops using dev_pm_ops instead of legacy pm_ops. The existing legacy suspend/resume routines are identical and simply clear IRQ mask in the device in case it got

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-02-13 Thread Arnd Bergmann
On Thursday 13 February 2014 10:42:48 Russell King - ARM Linux wrote: > > What if we have a platform where things subtly change, like for instance, > the wiring on the SD slot to fix a problem with UHS-1 cards, which means > you don't have UHS-1 support for some platforms but do for others. > > W

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-02-13 Thread Russell King - ARM Linux
On Tue, Jan 28, 2014 at 11:48:10AM +0100, Arnd Bergmann wrote: > I think there is another option, which does have its own pros and cons: > We could move all the power handling back into the sdio function driver > if we allow a secondary detection path using DT rather than the probing > of the SDIO

Re: [PATCH 0/3] RFC/RFT: Powering on MMC Wifi/BT modules in MMC core

2014-02-13 Thread Russell King - ARM Linux
Any comments on this? On Sat, Feb 01, 2014 at 04:14:20PM +, Russell King - ARM Linux wrote: > On Thu, Jan 30, 2014 at 09:49:17PM +, Russell King - ARM Linux wrote: > > On Sun, Jan 19, 2014 at 07:56:52PM -0800, Olof Johansson wrote: > > > This is a small series enhancing the MMC core code t

Re: [RFT][PATCH v3] mmc: change cb710-mmc platform power management to use dev_pm_ops

2014-02-13 Thread Ulf Hansson
On 12 February 2014 22:21, Shuah Khan wrote: > Change cb710-mmc platform driver to register pm ops using dev_pm_ops instead > of legacy pm_ops. The existing legacy suspend/resume routines are identical > and simply clear IRQ mask in the device in case it got undefined during sleep > state. Changed

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-02-13 Thread Tomasz Figa
On 13.02.2014 09:56, Ulf Hansson wrote: On 28 January 2014 11:48, Arnd Bergmann wrote: On Tuesday 28 January 2014, Ulf Hansson wrote: On 28 January 2014 01:59, Tomasz Figa wrote: On 27.01.2014 11:19, Ulf Hansson wrote: There is already a host capability that I think we could use to handle

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-02-13 Thread Ulf Hansson
On 28 January 2014 11:48, Arnd Bergmann wrote: > On Tuesday 28 January 2014, Ulf Hansson wrote: >> On 28 January 2014 01:59, Tomasz Figa wrote: >> > On 27.01.2014 11:19, Ulf Hansson wrote: >> >> There is already a host capability that I think we could use to handle >> >> this. MMC_CAP_NONREMOVABL