RE: autosleep suspend too frquent problem

Hi Thanks for your clarification. One problem is the sd card driver itself . In addition, I also think kernel's autosleep.c module Have problem too. It just test wake up count ,if the count is zero, then enter suspend. This will result in frequent suspend / resume problems sometimes, It is no

Re: [PATCHv5 2/2] ARM: dts: unuse the slot-node and deprecated supports-highspeed for dw-mmc.

On 06/05/2014 10:13 AM, Jaehoon Chung wrote: > dw-mmc controller can support multiple slots. > But, there are no use-cases anywhere. So we don't need to support the > slot-node for dw-mmc controller. > And "supports-highspeed" property in dw-mmc is deprecated. > "supports-highspeed" property can be

[PATCHv5 2/2] ARM: dts: unuse the slot-node and deprecated supports-highspeed for dw-mmc.

dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And "supports-highspeed" property in dw-mmc is deprecated. "supports-highspeed" property can be replaced to "cap-sd/mmc-highspeed". Signed-off-by: Ja

[PATCHv5 0/2] mmc: fixed the mmc_of_parse for dwmmc

This patch-set is fixed the dw-mmc controller problem. dw-mmc controller have the slot, but mmc_of_parse didn't parse the slot sub-node. So dw-mmc controller didn't work correctly. Jaehoon Chung (2): mmc: dw_mmc: replace "disable-wp" from slot's quirk to host's quirk ARM: dts: unuse the slot-

[PATCHv5 1/2] mmc: dw_mmc: replace "disable-wp" from slot's quirk to host's quirk

Replaced the "disable-wp" into host's quirks. (Because the slot-node is removed at dt-file.) Signed-off-by: Jaehoon Chung --- Changelog V5: - Modify comment. Changelog V4: - Rename Subject "[PATCHv3 2/4] mmc: dw_mmc: use the __mmc_of_parse to parse the slot node"

Re: [PATCHv4 2/2] ARM: dts: unuse the slot-node and deprecated support-highspeed for dw-mmc.

On 06/05/2014 12:09 PM, Tushar Behera wrote: > On 06/05/2014 07:52 AM, Jaehoon Chung wrote: >> dw-mmc controller can support the multiple slot. > > 'the' can be omitted, /s/slot/slots/ > >> But, there is not use-case anywhere. So we don't need to support the > > /s/is not use-case/are no use-cas

RE: how to creat watchpoint in kernel for data access debug

Hi Will, Thanks for your point out very much , I see your meaning , And I do a try , But Seems it can just work when you register a Perf event with a NULL callback function, https://git.kernel.org/cgit/linux/kernel/git/will/linux.git/tree/arch/arm/kernel/hw_breakpoint.c#n758 i don't know why i

Re: [PATCHv4 2/2] ARM: dts: unuse the slot-node and deprecated support-highspeed for dw-mmc.

On 06/05/2014 07:52 AM, Jaehoon Chung wrote: > dw-mmc controller can support the multiple slot. 'the' can be omitted, /s/slot/slots/ > But, there is not use-case anywhere. So we don't need to support the /s/is not use-case/are no use-cases/ > slot-node for dw-mmc controller. > And "support-high

[PATCHv4 1/2] mmc: dw_mmc: replace "disable-wp" from slot's quirk to host's quirk

Replaced the "disable-wp" into host's quirks. (Assume to support the one slot per a host) Signed-off-by: Jaehoon Chung --- Changelog V4: - Rename Subject "[PATCHv3 2/4] mmc: dw_mmc: use the __mmc_of_parse to parse the slot node" - Replace the "disable-wp" into hos

[PATCHv4 2/2] ARM: dts: unuse the slot-node and deprecated support-highspeed for dw-mmc.

dw-mmc controller can support the multiple slot. But, there is not use-case anywhere. So we don't need to support the slot-node for dw-mmc controller. And "support-highspeed" property in dw-mmc is deprecated. "support-highspeed" property can be replaced to "cap-sd/mmc-highspeed". Signed-off-by: Ja

[PATCHv4 0/4] mmc: fixed the mmc_of_parse for dwmmc

This patch-set is fixed the dw-mmc controller problem. dw-mmc controller have the slot, but mmc_of_parse didn't parse the slot sub-node. So dw-mmc controller didn't work correctly. Jaehoon Chung (2): mmc: dw_mmc: replace "disable-wp" from slot's quirk to host's quirk ARM: dts: unuse the slot-

Re: [PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists

Hi, On Wed, Jun 04 2014, Jaehoon Chung wrote: > Didn't you want to merge the below patch? > > https://patchwork.kernel.org/patch/4239541/ > > I have tested with exynos series, and working fine. Oops, of course -- thanks! Pushed to mmc-next for 3.16. - Chris. -- Chris Ball

Re: [PATCH v2 2/3] mmc: Add APM X-Gene SoC SDHC controller support to Arasan SDHCI driver

Hi, >> #define SDHCI_ARASAN_CLK_CTRL_OFFSET 0x2c >> @@ -34,6 +36,19 @@ >> */ >> struct sdhci_arasan_data { >> struct clk *clk_ahb; >> + struct platform_device *pdev; >> + void __iomem*ahb_aim_csr; >> + const struct sdhci_arasan_ahb_ops *ahb_ops; >> +}; >> + >> +/** >

Re: [PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists

Hi, Chris. Didn't you want to merge the below patch? https://patchwork.kernel.org/patch/4239541/ I have tested with exynos series, and working fine. Best Regards, Jaehoon Chung On 06/05/2014 04:08 AM, Chris Ball wrote: > "mmc: sdhci: push card_tasklet into threaded irq handler" removed > the c

[PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists

"mmc: sdhci: push card_tasklet into threaded irq handler" removed the card_tasklet, but it is still in use by sdhci-s3c.c. Signed-off-by: Chris Ball --- Hi, sdhci-s3c is currently failing to build due to the removal of card_tasklet. I think this trivial patch might do the right thing -- please

Re: how to creat watchpoint in kernel for data access debug

On Wed, Jun 04, 2014 at 04:05:03AM +0100, Wang, Yalin wrote: > Hi Will, > > Thanks for your proposal, > The patch google made is just like > The one I tried before , > Then the problems come : > After register the perf_event callback, > In the callback function , > In google's patch , it is func

[PATCH v3 04/10] ARM: STi: DT: Add sdhci controller for stih416

This patch adds device tree config for both sdhci controllers on the stih416 SoC. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stih416.dtsi | 24 1 file changed, 24 insertions(+) di

[PATCH v3 01/10] mmc: sdhci-st: Intial support for ST SDHCI controller

This platform driver adds initial support for the SDHCI host controller found on STMicroelectronics SoCs. It has been tested on STiH41x b2020 platforms currently. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- drivers/mmc/host

[PATCH v3 03/10] ARM: STi: DT: Add sdhci pins for stih416

This adds the required pin config for both SDHCI controllers on the stih416 SoC. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stih416-pinctrl.dtsi | 39 ++ 1 file changed, 39

[PATCH v3 02/10] mmc: sdhci-st: ST Microelectronics SDHCI binding documentation.

This patch adds the device tree binding documentation for the ST SDHCI driver. It documents the differences between the core properties described by mmc.txt and the properties used by the sdhci-st driver. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-b

[PATCH v3 05/10] ARM: STi: DT: Add sdhci pin configuration for stih415

This patch adds the required pin config for the sdhci controller present in the stih415 SoC. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stih415-pinctrl.dtsi | 21 + 1 file changed, 21 i

[PATCH v3 09/10] ARM: update multi_v7_defconfig for STI

This patch enables SDHCI STI platform driver. Signed-off-by: Peter Griffin --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index d4e8a47..48951fc 100644 --- a/arch/arm/configs/m

[PATCH v3 08/10] ARM: STi: DT: Enable second sdhci controller for stih416 b2020 boards.

The second controller is only present on the stih416 SoC. Also mark this as non-removeable as its eMMC. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stih416-b2020-revE.dts | 6 ++ arch/arm/boot/dts/stih4

[PATCH v3 10/10] MAINTAINERS: Add sdhci-st file to ARCH/STI architecture

Signed-off-by: Peter Griffin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6dc67b1..19dc265 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1306,6 +1306,7 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F: driver

[PATCH v3 06/10] ARM: STi: DT: Add sdhci controller for stih415

This patch adds device tree config for the sdhci controller on the stih415 SoC. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stih415.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arc

[PATCH v3 07/10] ARM: STi: DT: Enable mmc0 for both stih415 and stih416 SoCs

Because the first sdhci controller is present on both stih415 and stih416 SoC which can both populate the b2020 board, it can be enabled in the generic DT file. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/s

[PATCH v3 00/10] Add SDHCI support for ST Microelectronics SoCs

This series adds a SDHCI platform driver for ST SoCs, along with the additional device tree bindings and configuration to enable the controller to work properly. Initially it supports the stih416 and stih415 SoCs, and has been tested on a stih416-b2020 board. regards, Peter. Changes since v1 -

[PATCH v2 08/10] ARM: STi: DT: Enable second sdhci controller for stih416 b2020 boards.

The second controller is only present on the stih416 SoC. Also mark this as non-removeable as its eMMC. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stih416-b2020-revE.dts | 6 ++ arch/arm/boot/dts/stih4

[PATCH v2 10/10] MAINTAINERS: Add sdhci-st file to ARCH/STI architecture

Signed-off-by: Peter Griffin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6dc67b1..19dc265 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1306,6 +1306,7 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F: driver

[PATCH v2 01/10] mmc: sdhci-st: Intial support for ST SDHCI controller

This platform driver adds initial support for the SDHCI host controller found on STMicroelectronics SoCs. It has been tested on STiH41x b2020 platforms currently. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- drivers/mmc/host

[PATCH v2 02/10] mmc: sdhci-st: ST Microelectronics SDHCI binding documentation.

This patch adds the device tree binding documentation for the ST SDHCI driver. It documents the differences between the core properties described by mmc.txt and the properties used by the sdhci-st driver. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-b

[PATCH v2 06/10] ARM: STi: DT: Add sdhci controller for stih415

This patch adds device tree config for the sdhci controller on the stih415 SoC. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stih415.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arc

[PATCH v2 09/10] ARM: update multi_v7_defconfig for STI

This patch enables SDHCI STI platform driver. Signed-off-by: Peter Griffin --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index d4e8a47..48951fc 100644 --- a/arch/arm/configs/m

[PATCH v2 04/10] ARM: STi: DT: Add sdhci controller for stih416

This patch adds device tree config for both sdhci controllers on the stih416 SoC. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stih416.dtsi | 24 1 file changed, 24 insertions(+) di

[PATCH v2 03/10] ARM: STi: DT: Add sdhci pins for stih416

This adds the required pin config for both SDHCI controllers on the stih416 SoC. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stih416-pinctrl.dtsi | 39 ++ 1 file changed, 39

[PATCH v2 05/10] ARM: STi: DT: Add sdhci pin configuration for stih415

This patch adds the required pin config for the sdhci controller present in the stih415 SoC. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stih415-pinctrl.dtsi | 21 + 1 file changed, 21 i

[PATCH v2 07/10] ARM: STi: DT: Enable mmc0 for both stih415 and stih416 SoCs

Because the first sdhci controller is present on both stih415 and stih416 SoC which can both populate the b2020 board, it can be enabled in the generic DT file. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones Acked-by: Maxime Coquelin --- arch/arm/boot/dts/s

[PATCH v2 00/10] Add SDHCI support for STMicroelectronics SoCs

This series adds a SDHCI platform driver for ST SoCs, along with the additional device tree bindings and configuration to enable the controller to work properly. Initially it supports the stih416 and stih415 SoCs, and has been tested on a stih416-b2020 board. regards, Peter. Changes since v1 -

Re: RFC: representing sdio devices oob interrupt, clks, etc. in device tree

On Tue, Jun 03, 2014 at 12:57:52PM +0200, Ulf Hansson wrote: > On 28 May 2014 13:03, Mark Brown wrote: > > No, runtime PM isn't really fine grained - I'm talking about things > > like starting and stopping individual resources or configuring them. > Are you saying that you have several levels of

[PATCH] mmc: sdhci: Remove unused ret variables

Remove those unused ret variables to make it obvious that these function will not return any errors in the current implementation. Signed-off-by: Markus Pargmann --- drivers/mmc/host/sdhci.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/dri

Re: [PATCH 6/6] mmc: sh-mmcif: final error path cleanup

On 4 June 2014 13:42, Ben Dooks wrote: > Remove the error path items that are no longer needed. The mmc card-detect > code cleans up after itself (and registers with devm) and the host error > is the same as the clock disable. > > Signed-off-by: Ben Dooks Signed-off-by: Ulf Hansson > --- > dr

Re: [PATCH 5/6] mmc: sh-mmcif: no need to call pm_runtime_suspend on error

On 4 June 2014 13:42, Ben Dooks wrote: > The pm_runtime call should implicitly disable the device once the > probe is over if there is no explicit reference gained. There is no > need to call pm_runtime_suspend() before the pm_runtime_disable() > call. > > Signed-off-by: Ben Dooks Signed-off-by:

Re: [PATCH 4/6] mmc: sh-mmcif: use devm_ for irq management

On 4 June 2014 13:42, Ben Dooks wrote: > Use devm_request_threaded_irq() for the host interrupt handlers so we > do not have to worry about freeing them on exit or error. Tidies up the > exit path code for the driver. > > Signed-off-by: Ben Dooks Signed-off-by: Ulf Hansson > --- > drivers/mmc

Re: [PATCH 3/6] mmc: sh-mmcif: use devm_ for clock management

On 4 June 2014 13:42, Ben Dooks wrote: > Use the devm_clk_get() code to get the clock and allow it to be freed > automatically on release. > > Signed-off-by: Ben Dooks Signed-off-by: Ulf Hansson > --- > drivers/mmc/host/sh_mmcif.c | 18 -- > 1 file changed, 8 insertions(+), 10

Re: [PATCH 2/6] mmc: sh-mmcif: use devm_ for ioremap

On 4 June 2014 13:42, Ben Dooks wrote: > Start tidying the probe/release code by using devm_ioremap_resource() to > map the IO registers. > > Signed-off-by: Ben Dooks Signed-off-by: Ulf Hansson > --- > Fixes from v1: > - return the PTR_ERR() from devm_ioremap > - remove error p

Re: [PATCH 1/6] mmc: sh-mmcif: update to print version and bus clock rate on probe

On 4 June 2014 13:42, Ben Dooks wrote: > Change the initial print to show chip version and the bus rate it is > working at instead of the driver version. This is more useful information > as we already know which driver version from the kernel it is in. > > Signed-off-by: Ben Dooks Signed-off-by

RE: [linux-sunxi] [PATCH v2 1/4] dt: bindings: mmc: Document the practice of using subnodes for slots

On Tue, June 03, 2014, Jaehoon Chung wrote: > +Suegnwon Jeon > > On 06/02/2014 05:48 PM, Ulf Hansson wrote: > > On 2 June 2014 10:38, Jaehoon Chung wrote: > >> On 06/02/2014 05:29 PM, Ulf Hansson wrote: > >>> On 1 June 2014 11:23, Hans de Goede wrote: > Hi, > > > On 05/31/201

[PATCH 1/6] mmc: sh-mmcif: update to print version and bus clock rate on probe

Change the initial print to show chip version and the bus rate it is working at instead of the driver version. This is more useful information as we already know which driver version from the kernel it is in. Signed-off-by: Ben Dooks --- drivers/mmc/host/sh_mmcif.c | 9 + 1 file changed,

[PATCH 4/6] mmc: sh-mmcif: use devm_ for irq management

Use devm_request_threaded_irq() for the host interrupt handlers so we do not have to worry about freeing them on exit or error. Tidies up the exit path code for the driver. Signed-off-by: Ben Dooks --- drivers/mmc/host/sh_mmcif.c | 26 -- 1 file changed, 8 insertions(+),

[PATCH 5/6] mmc: sh-mmcif: no need to call pm_runtime_suspend on error

The pm_runtime call should implicitly disable the device once the probe is over if there is no explicit reference gained. There is no need to call pm_runtime_suspend() before the pm_runtime_disable() call. Signed-off-by: Ben Dooks --- drivers/mmc/host/sh_mmcif.c | 6 ++ 1 file changed, 2 ins

[PATCH 2/6] mmc: sh-mmcif: use devm_ for ioremap

Start tidying the probe/release code by using devm_ioremap_resource() to map the IO registers. Signed-off-by: Ben Dooks --- Fixes from v1: - return the PTR_ERR() from devm_ioremap - remove error print as it already shows an error --- drivers/mmc/host/sh_mmcif.c | 24 ++---

[PATCH 6/6] mmc: sh-mmcif: final error path cleanup

Remove the error path items that are no longer needed. The mmc card-detect code cleans up after itself (and registers with devm) and the host error is the same as the clock disable. Signed-off-by: Ben Dooks --- drivers/mmc/host/sh_mmcif.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(

[PATCH 3/6] mmc: sh-mmcif: use devm_ for clock management

Use the devm_clk_get() code to get the clock and allow it to be freed automatically on release. Signed-off-by: Ben Dooks --- drivers/mmc/host/sh_mmcif.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif

resend - sh mmcif driver cleanup patch series

This is a re-send of the mmcif driver cleanups that seem to have been missed. If possible, could this be merged for the current merge window? These should be available at: http://git.codethink.co.uk/linux.git bjdooks/315-rc8/mmcif -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 1/8] mmc: sdhci-st: Intial support for ST SDHCI controller

On 4 June 2014 10:48, Peter Griffin wrote: > Hi Ulf, > > Thanks for reviewing, see my comments below: - > > On Fri, 23 May 2014, Ulf Hansson wrote: >> > +static unsigned int sdhci_st_get_max_clk(struct sdhci_host *host) >> > +{ >> > + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); >

Re: [PATCH 1/8] mmc: sdhci-st: Intial support for ST SDHCI controller

Hi Maxime, Thanks fo reviewing, see my comments below: - > >+struct st_mmc_platform_data { > >+struct reset_control *rstc; > >+}; > Since it uses the generic reset framework, could we imagine moving > the reset to the sdhci_pltfm_host struct? > Doing this, we could get rid of st_mmc_platfo

Re: [PATCH 1/8] mmc: sdhci-st: Intial support for ST SDHCI controller

Hi Srini, Thanks for reviewing, see my comments below: - On Fri, 23 May 2014, Srinivas Kandagatla wrote: > >+struct st_mmc_platform_data { > >+struct reset_control *rstc; > >+}; > > st_mmc_platform_data name is bit missleading as this data is not > part of platform data. Probably you cou

Re: [PATCH v3] mmc: sdhci-pci-o2micro: Add SeaBird SeaEagle SD3 support

On 4 June 2014 04:03, Peter Guo wrote: > Hi Hansson, > > Have you include this patch to PR? If so could you tell me at which git > repository it is. It has been included in those PRs I have sent to Chris during this release cycle. So currently it sits in Chris mmc tree on his next branch. Yes,