Re: sdhci_s3c_consider_clock scheduling while atomic - clk_round_rate

Hi, It's also related with clock-gating. Mainline kernel is using the "clkgate-delay = 0" by default. If we use this value, Every request time should be gated/ungated... Then it may be faced the race-condition...In my experiment, it occasionally occurred the CRC error or other problem. And it's a

[PATCH] mmc: sdhci: support eMMC, SD, SDIO on Moorefield.

This patch is to enable eMMC, SD and SDIO on Moorefield. Signed-off-by: yisun1 --- drivers/mmc/host/sdhci-pci.c | 62 ++ drivers/mmc/host/sdhci-pci.h |3 ++ 2 files changed, 65 insertions(+) diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/ho

Re: One bug of SDHCI driver

From: Chris Ball Subject: [PATCH] mmc: core: sdio: Fix unconditional wake_up_process() on sdio thread 781e989cf59 ("mmc: sdhci: convert to new SDIO IRQ handling") and bf3b5ec66bd ("mmc: sdio_irq: rework sdio irq handling") disabled the use of our own custom threaded IRQ handler, but left in an u

Re: One bug of SDHCI driver

On 07/15/2014 11:54 AM, Fu, Zhonghui wrote: > > Hi, > > The data type of "host" is "struct mmc_host", and there is not "quirks" > member in this structure. Sorry for wrong typo. You use the "host->caps2" instead of "host->quirks". Best Regards, Jaehoon Chung > > > Thanks, > Zhonghui > > On

Re: One bug of SDHCI driver

Hi, The data type of "host" is "struct mmc_host", and there is not "quirks" member in this structure. Thanks, Zhonghui On 2014/7/14 21:26, Chris Ball wrote: > Hi Zhonghui, > > On Tue, Jul 08 2014, Fu, Zhonghui wrote: >> Why add "mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;" ? How to fix this bu

Re: [PATCH] mmc: Do not advertise secure discard if it is blacklisted

Hi, Lukas. I think it's reasonable. And CC'd Ulf. Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung On 07/14/2014 05:10 PM, Lukáš Czerner wrote: > On Wed, 18 Jun 2014, Lukas Czerner wrote: > >> Date: Wed, 18 Jun 2014 13:18:07 +0200 >> From: Lukas Czerner >> To: linux-mmc@vger.kernel.org >>

[PATCHv6] mmc: dw_mmc: change to use recommended reset procedure

This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao Signed-off-by: Yuvaraj Kumar C D --- v2: Add Generic DMA support per the documentation, move interrupt clear before wait m

Re: [PATCH 2/8] mmc: sdhci: host: add new f_sdh30

On Sunday 13 July 2014 14:29:31 Mollie Wu wrote: > +Required properties: > +- compatible: "fujitsu,f-sdh30" > +- voltage-ranges : This is a list of pairs. In each pair, two cells > + are required. First cell specifies minimum slot voltage (mV), second > + cell specifies maximum slot voltage (mV).

Re: One bug of SDHCI driver

Hi Zhonghui, On Tue, Jul 08 2014, Fu, Zhonghui wrote: > Why add "mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;" ? How to fix this bug? > > Could you please give out some idea about this bug? Jaehoon already gave you a patch to fix this bug. Here it is again in proper patch form. Please can you tes

RE: [PATCH] mmc: blk: add emmc cache flush in shutdown callback

Thanks a lot for the review and comments. This patch was derived from our old mmc driver code base, which was based on kernel 3.10 and did not implemented the mmc_shutdown() callback in mmc.c yet. So it added shutdown callback in drivers/mmc/card/block.c to fix data corruption issue observed at

Re: [PATCH] mmc: blk: add emmc cache flush in shutdown callback

Hi, On 07/14/2014 06:34 PM, Yunpeng Gao wrote: > If eMMC Cache feature enabled, we'd better flush > eMMC cache in the shutdown callback. Otherwise > data corruption issue may be observed. I knew mmc_flush_cache() is called into mmc_shutdown() (driver/mmc/core/mmc.c) Which data corruption is occur

[PATCH] mmc: blk: add emmc cache flush in shutdown callback

If eMMC Cache feature enabled, we'd better flush eMMC cache in the shutdown callback. Otherwise data corruption issue may be observed. Signed-off-by: Yunpeng Gao --- drivers/mmc/card/block.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/bl

Re: [PATCH] mmc: Do not advertise secure discard if it is blacklisted

On Wed, 18 Jun 2014, Lukas Czerner wrote: > Date: Wed, 18 Jun 2014 13:18:07 +0200 > From: Lukas Czerner > To: linux-mmc@vger.kernel.org > Cc: linux-fsde...@vger.kernel.org, ch...@printf.net, > Lukas Czerner > Subject: [PATCH] mmc: Do not advertise secure discard if it is blacklisted > > Cur

Re: [PATCH 1/6] mmc: sdhci-s3c: Fix local I/O clock gating

Looks good to me. Acked-by: Jaehoon Chung On 06/24/2014 10:57 PM, Tomasz Figa wrote: > For internal card detection mechanism it is required that the local I/O > clock is always running. However while current implementation accounts > for this, it does so incorrectly leading to race conditions an