Re: [PATCH 1/5] mmc: msm_sdcc: Switch to using managed resources

2014-09-16 Thread Pramod Gurav
Thanks Srini. :) I should have known this. Thanks again. On Wed, Sep 17, 2014 at 3:41 AM, Srinivas Kandagatla wrote: > Hi Pramod, > Thankyou for the patches. > > You should be aware that this driver is due to be *Removed* very soon. > > Basically msm_sdcc is a hacked version of mmci driver. > Fr

Re: [PATCH] mmc: dw_mmc-exynos: fixed wrong sample-clock selection

2014-09-16 Thread Jaehoon Chung
Hi, Alim. On 09/17/2014 07:27 AM, Alim Akhtar wrote: > Hi Jaehoon, > > On Mon, Sep 15, 2014 at 3:56 PM, Jaehoon Chung wrote: >> Almost all case is selected to 0. >> (It's not correct sample-clock value.) >> Since it set to wrong value, HS200 mode don't work fine. > Can you please explain what pr

Re: [PATCH] mmc: dw_mmc-exynos: fixed wrong sample-clock selection

2014-09-16 Thread Alim Akhtar
Hi Jaehoon, On Mon, Sep 15, 2014 at 3:56 PM, Jaehoon Chung wrote: > Almost all case is selected to 0. > (It's not correct sample-clock value.) > Since it set to wrong value, HS200 mode don't work fine. Can you please explain what problem you are facing here? It is not clear from your patch descri

Re: [PATCH 1/5] mmc: msm_sdcc: Switch to using managed resources

2014-09-16 Thread Srinivas Kandagatla
Hi Pramod, Thankyou for the patches. You should be aware that this driver is due to be *Removed* very soon. Basically msm_sdcc is a hacked version of mmci driver. From v3.17 mmci driver added support for qualcomm specific customization to pl180. So msm platform should be able to use pl180 mmci

[PATCH] [RESEND 4] mmc: add Toshiba PCI SD controller driver

2014-09-16 Thread Ondrej Zary
This patch resurrects an old never-finished driver for Toshiba PCI SD controllers found in some older Toshiba laptops (such as Portege R100): 02:0d.0 System peripheral [0880]: Toshiba America Info Systems SD TypA Controller [1179:0805] (rev 05) The hardware is slow (around 2 MB/s - same in Windo

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-16 Thread Ulf Hansson
On 12 September 2014 03:39, wrote: > From: Roger Tseng > > Some platform have both UEFI driver and MFD/mmc driver, if entering > linux while card in the slot, the card power is already on, and rtsx-mmc > driver have no chance to make card power off. This will lead UHSI card > failed to enter UHS

Re: "Card stuck in programming state! __mmc_switch" problem on i.MX6 + eMMC

2014-09-16 Thread Jean-Michel Hautbois
Hi David, 2014-09-16 16:37 GMT+02:00 David Müller (ELSOFT AG) : > Hello > > I have a custom i.MX6Q based board with a Hynix eMMC chip attached to > USDHC3. OS is a vanilla Linux 3.16 with some patches. > > Loading the iMX SDHC driver results in the following error: > > modprobe sdhci-esdhc-imx > s

"Card stuck in programming state! __mmc_switch" problem on i.MX6 + eMMC

2014-09-16 Thread ELSOFT AG
Hello I have a custom i.MX6Q based board with a Hynix eMMC chip attached to USDHC3. OS is a vanilla Linux 3.16 with some patches. Loading the iMX SDHC driver results in the following error: modprobe sdhci-esdhc-imx sdhci: Secure Digital Host Controller Interface driver sdhci: Copyright(c) Pierre

[PATCH 4/5] mmc: msm_sdcc: Remove duplicate check around dmares

2014-09-16 Thread Pramod Gurav
This removes duplicate check on host->dmares. As function msmsdcc_init_dma() is called only after host->dmares is found true, it is unnecessary to recheck inside the function. Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-mmc@vger.kernel.org CC: linux-arm-...@v

[PATCH 5/5] mmc: msm_sdcc: Remove unwanted initializations in probe

2014-09-16 Thread Pramod Gurav
This removes unnecessary initialisations of resource pointers and does away with a lable and just returns error on fail instead. Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-mmc@vger.kernel.org CC: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav ---

[PATCH 2/5] mmc: msm_sdcc: Add support for platform_driver remove function

2014-09-16 Thread Pramod Gurav
This change adds remove function in platform_driver to clean unloading Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-mmc@vger.kernel.org CC: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/msm_sdcc.c | 18 ++ 1

[PATCH 1/5] mmc: msm_sdcc: Switch to using managed resources

2014-09-16 Thread Pramod Gurav
This change makes changes to use managed version of ioremap, clk_get, request_irq etc for clean unloading of modules. This does away with lables to release these resources. Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-mmc@vger.kernel.org CC: linux-arm-...@vger

[PATCH 3/5] mmc: msm_sdcc: Replace pr_ with dev_

2014-09-16 Thread Pramod Gurav
This replaces pr_* with dev_ for message logging and also does away with printing function names in logs. Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-mmc@vger.kernel.org CC: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/msm_

[PATCH 1/5] mmc: msm_sdcc: Switch to using managed resources

2014-09-16 Thread Pramod Gurav
This change makes changes to use managed version of ioremap, clk_get, request_irq etc for clean unloading of modules. This does away with lables to release these resources. Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-mmc@vger.kernel.org CC: linux-arm-...@vger

[PATCH] mmc: dw_mmc: Remove unused function for !CONFIG_OF

2014-09-16 Thread Tobias Klauser
dw_mci_of_find_slot_node() is only used in dw_mci_of_get_slot_quirks() if CONFIG_OF is defined, thus there is no need to have a !CONFIG_OF version of it. Fixes the following compile warning with !CONFIG_OF: CC [M] drivers/mmc/host/dw_mmc.o drivers/mmc/host/dw_mmc.c:2223:28: warning: ‘dw_mci_of_