Re: [PATCH 0/7] mmc: Some Braswell patches

2014-10-01 Thread Adrian Hunter
Ping? On 30/09/14 15:03, Adrian Hunter wrote: > Hi > > Any comments on these? > > > On 24/09/14 10:27, Adrian Hunter wrote: >> Hi >> >> Here are some patches to further support for Intel Braswell >> SoC. >> >> >> Adrian Hunter (7): >> mmc: sdhci: Add quirk for always getting TC with stop

Re: [PATCH v5 07/11] mmc: sdio: Convert to dev_pm_domain_attach|detach()

2014-10-01 Thread Dmitry Torokhov
Hi Ulf, On Fri, Sep 19, 2014 at 08:27:40PM +0200, Ulf Hansson wrote: > Previously only the ACPI PM domain was supported by the sdio bus. > > Let's convert to the common attach/detach functions for PM domains, > which currently means we are extending the support to include the > generic PM domain

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-10-01 Thread Doug Anderson
Hi, On Wed, Oct 1, 2014 at 7:00 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, October 01, 2014 12:47:52 AM YUVARAJ CD wrote: > >> Since I am out of station, i dont have an access to my work set up. >> Can you send me the dts entries of sd crad and their corresponding regulator >

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-10-01 Thread Doug Anderson
Hi, On Wed, Oct 1, 2014 at 6:06 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, September 30, 2014 10:22:34 AM Doug Anderson wrote: >> Bartlomiej >> >> On Mon, Sep 29, 2014 at 5:31 AM, Bartlomiej Zolnierkiewicz >> wrote: >> > >> > Hi, >> > >> > On Friday, August 29, 2014 01:34:44 PM

Re: [PATCH v3] mmc: core: restore detect line inversion semantics

2014-10-01 Thread Ulf Hansson
On 1 October 2014 16:44, Ulf Hansson wrote: > On 1 October 2014 15:45, Linus Walleij wrote: >> commit 98e90de99a0c43bd434da814c882c4332441871e >> "mmc: host: switch OF parser to use gpio descriptors" >> switched the semantic behaviour of card detect and read >> only flags such that the inversion

Re: [PATCH v3] mmc: core: restore detect line inversion semantics

2014-10-01 Thread Ulf Hansson
On 1 October 2014 15:45, Linus Walleij wrote: > commit 98e90de99a0c43bd434da814c882c4332441871e > "mmc: host: switch OF parser to use gpio descriptors" > switched the semantic behaviour of card detect and read > only flags such that the inversion capability flag would > only be set if inversion wa

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-10-01 Thread Bartlomiej Zolnierkiewicz
On Wednesday, October 01, 2014 03:57:54 PM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, September 30, 2014 02:23:44 PM Jaehoon Chung wrote: > > Hi > > > > On 09/29/2014 09:31 PM, Bartlomiej Zolnierkiewicz wrote: > > > > > > Hi, > > > > > > On Friday, August 29, 2014 01:34:44 PM Ulf

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-10-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday, October 01, 2014 12:47:52 AM YUVARAJ CD wrote: > Since I am out of station, i dont have an access to my work set up. > Can you send me the dts entries of sd crad and their corresponding regulator > entries? >From arch/arm/boot/dts/exynos5420-arndale-octa.dts: ... mmc

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-10-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday, September 30, 2014 02:23:44 PM Jaehoon Chung wrote: > Hi > > On 09/29/2014 09:31 PM, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Friday, August 29, 2014 01:34:44 PM Ulf Hansson wrote: > >> On 22 August 2014 15:47, Yuvaraj Kumar C D wrote: > >>> This patch makes use

Re: [PATCH] mmc: card: not access RPMB partition for normal read and write

2014-10-01 Thread Michael Shigorin
Hello, what is the status of this patch to cope with MMC RPMB? http://permalink.gmane.org/gmane.linux.kernel.mmc/28281 I had to use this workaround having run into timeouts: https://dev-nell.com/rpmb-emmc-errors-under-linux.html Here's some arch/arm work by Ulf: https://patches.linaro.org

[PATCH v3] mmc: core: restore detect line inversion semantics

2014-10-01 Thread Linus Walleij
commit 98e90de99a0c43bd434da814c882c4332441871e "mmc: host: switch OF parser to use gpio descriptors" switched the semantic behaviour of card detect and read only flags such that the inversion capability flag would only be set if inversion was explicitly specified in the device tree, in the hopes t

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-10-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday, September 30, 2014 10:22:34 AM Doug Anderson wrote: > Bartlomiej > > On Mon, Sep 29, 2014 at 5:31 AM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Friday, August 29, 2014 01:34:44 PM Ulf Hansson wrote: > >> On 22 August 2014 15:47, Yuvaraj Kumar C D wrote: > >> > T

[PATCH 5/5] mmc: core: Fix error paths and messages in mmc_init_card

2014-10-01 Thread Andrew Gabbasov
In mmc_init_card function some of the branches in error handling paths go to "err" label, which skips removing of newly allocated card structure, that will actually not be used. Fix that by using proper "free_card" label. Also, some messages in these branches are reported as warnings, although the

[PATCH 4/5] mmc: core: Add debug message for SET_BLOCK_COUNT result

2014-10-01 Thread Andrew Gabbasov
The debug messages with commands execution results, that are printed after processing the request, do not include results of sbc (set block count) part of request. Add the debug message for that part too. Signed-off-by: Andrew Gabbasov --- drivers/mmc/core/core.c | 8 1 file changed, 8

[PATCH 2/5] mmc: sdhci: fix error conditions for controller reset

2014-10-01 Thread Andrew Gabbasov
Add the case of SET_BLOCK_COUNT command error to the error conditions check for making a controller reset at request handling finish. Otherwise, if the SET_BLOCK_COUNT command failed, e.g. with a timeout, the controller state was not reset, and the next command failed too. In the case of data erro

[PATCH 3/5] mmc: core: Initialize SET_BLOCK_COUNT request fields

2014-10-01 Thread Andrew Gabbasov
Some request fields are initialized just before request processing for sanity purposes. This is done for command, data, and stop parts of the request, but not for sbc (set block count) part. Add such initialization for that part too. Signed-off-by: Andrew Gabbasov --- drivers/mmc/core/core.c | 4

[PATCH 0/5] mmc: Miscellaneous fixes for SDHCI and MMC core

2014-10-01 Thread Andrew Gabbasov
Andrew Gabbasov (5): mmc: sdhci: Balance vmmc regulator_disable() mmc: sdhci: fix error conditions for controller reset mmc: core: Initialize SET_BLOCK_COUNT request fields mmc: core: Add debug message for SET_BLOCK_COUNT result mmc: core: Fix error paths and messages in mmc_init_card d

[PATCH 1/5] mmc: sdhci: Balance vmmc regulator_disable()

2014-10-01 Thread Andrew Gabbasov
As a follow-up of commit "mmc: sdhci: Balance vmmc regulator_enable(), and always enable vqmmc" vmmc regulator disable is also not needed in sdhci_remove_host. The regulator is completely controlled by mmc_power_up and mmc_power_off functions and is already disabled by the time of removing the host

[PATCH] mmc: sdhci-esdhc-imx: don't exit in case of no pinctrl states

2014-10-01 Thread Andrew Gabbasov
From: Dirk Behme The commit ad93220de7da ("mmc: sdhci-esdhc-imx: change pinctrl state according to uhs mode") exits the probe in case there are no valid pinctrl states found. As there are configurations doing the pin mux properly in the boot loader, don't exit. Just warn, but go on in case if th

Re: [PATCH 5/6] mmc: block: Fix SD card stop cmd response type

2014-10-01 Thread Ulf Hansson
On 30 September 2014 14:41, Adrian Hunter wrote: > On 30/09/14 15:09, Ulf Hansson wrote: >> On 30 September 2014 13:21, Adrian Hunter wrote: >>> On 25/09/14 12:20, Ulf Hansson wrote: On 23 September 2014 22:00, Adrian Hunter wrote: > Nowhere in the SD Association Specifications does >>>

Re: [PATCH v2] mmc: core: restore detect line inversion semantics

2014-10-01 Thread Ulf Hansson
On 1 October 2014 09:51, Linus Walleij wrote: > commit 98e90de99a0c43bd434da814c882c4332441871e > "mmc: host: switch OF parser to use gpio descriptors" > switched the semantic behaviour of card detect and read > only flags such that the inversion capability flag would > only be set if inversion wa

Re: [PATCH] mmc: core: restore detect line inversion semantics

2014-10-01 Thread Javier Martinez Canillas
Hello Linus, On Wed, Oct 1, 2014 at 9:54 AM, Linus Walleij wrote: > On Tue, Sep 30, 2014 at 5:07 PM, Javier Martinez Canillas > wrote: >>> >>> + *gpio_invert = gpiod_is_active_low(desc); >>> + >> >> The old code set gpio_inv_cd if (!(flags & OF_GPIO_ACTIVE_LOW)) so the >> above should be:

Re: [PATCH] mmc: core: restore detect line inversion semantics

2014-10-01 Thread Linus Walleij
On Tue, Sep 30, 2014 at 5:07 PM, Javier Martinez Canillas wrote: > On Tue, Sep 30, 2014 at 4:05 PM, Linus Walleij > wrote: >> @@ -316,6 +317,8 @@ int mmc_gpiod_request_cd(struct mmc_host *host, const >> char *con_id, >> return ret; >> } >> >> + *gpio_inver

[PATCH v2] mmc: core: restore detect line inversion semantics

2014-10-01 Thread Linus Walleij
commit 98e90de99a0c43bd434da814c882c4332441871e "mmc: host: switch OF parser to use gpio descriptors" switched the semantic behaviour of card detect and read only flags such that the inversion capability flag would only be set if inversion was explicitly specified in the device tree, in the hopes t