Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode

2015-02-25 Thread Jaehoon Chung
Dear, Rob. On 02/25/2015 11:38 PM, Rob Herring wrote: > On Wed, Jan 28, 2015 at 8:41 PM, Alim Akhtar wrote: >> From: Seungwon Jeon >> >> Implements HS400 mode support for exynos host driver. >> This also include some updates as new mode is added. >> >> Signed-off-by: Seungwon Jeon >> Signed-off

sdio sn8000 wifi module

2015-02-25 Thread angelo
Dear all, i am trying to have working this module with kernel 3.10 over sdio, 4 lines, high speed, on a imx6q. The bcm43362 CHIP_ID is still missing in kernel 3.10 so i merged some small parts of 3.14 wifi drivers into 3.10. Actually, seems this module does not reply to the SDIO probing command

[PATCH] mmc: mkfs takes hours on some combinations of eMMC device and host controller

2015-02-25 Thread Al Cooper
mkfs.ext4 will erase the entire partition on the eMMC device before writing the actual filesystem. The number of blocks erased on each erase eMMC command is determined at run time based on the max erase or trim time specified by the EXT_CSD in the eMMC device and the max eMMC command timeout suppor

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

2015-02-25 Thread Doug Anderson
Alim, On Tue, Feb 24, 2015 at 11:52 PM, Alim Akhtar wrote: >>> This looks a HACK to me. >>> If stabilizing host voltage regulator is the problem, can you try out >>> below patch, and see if this resolve your issue? >> >> Actually, IMHO Alim's patch is more of a hack than Addy's. There's >> alrea

Re: [PATCH v3 1/3] mmc: core: Add mmc_regulator_set_vqmmc()

2015-02-25 Thread Doug Anderson
Ulf, On Mon, Dec 15, 2014 at 4:22 PM, Doug Anderson wrote: > This adds logic to the MMC core to set VQMMC. This is expected to be > called by MMC drivers like dw_mmc as part of (or instead of) their > start_signal_voltage_switch() callback. > > A few notes: > > * When setting the signal voltage

Re: [PATCH 2/2] mmc: dw_mmc: Don't crash if we get an interrupt before slot has initted

2015-02-25 Thread Javier Martinez Canillas
Hello Doug, On 02/25/2015 07:11 PM, Doug Anderson wrote: > It's unlikely that this is really needed on any single-slot systems > where we disable card detects until the end of probe, but it still > seems safer to check to make sure that a slot has been initted before > we try to dereference it to

Re: [PATCH 1/2] mmc: dw_mmc: Only enable CD after setup and only if needed

2015-02-25 Thread Javier Martinez Canillas
Hello Doug, On 02/25/2015 07:11 PM, Doug Anderson wrote: > We really don't want to get a card detect interrupt during probe time > since it can confuse things. Let's disable the card detect interrupt > until we're in a really good place: the end of probe. Let's also > simply avoid enabling the c

Re: [PATCH 2/2] mmc: dw_mmc: Give a good reset after we give power

2015-02-25 Thread Javier Martinez Canillas
Hello Doug, On 02/20/2015 07:57 PM, Doug Anderson wrote: > We should give dw_mmc a good reset after we apply power. On some > boards vqmmc may actually be connected to the IP block in the SoC so > it's good to reset after power comes in. > > Without this we sometimes see failures enumerating car

Re: [PATCH v2] mmc: dw_mmc: Don't start commands while busy

2015-02-25 Thread Javier Martinez Canillas
Hello Doug, On 02/20/2015 09:31 PM, Doug Anderson wrote: > We've seen problems on some WiFi modules where we seem to send a CMD53 > (which requires the data lines) while the module is asserting busy. > We shouldn't do that. > > The Designware Databook says that before issuing a new data transfer

Re: [PATCH 1/2] mmc: dw_mmc: Make sure we only adjust the clock when power is on

2015-02-25 Thread Javier Martinez Canillas
Hello Doug, On 02/20/2015 07:57 PM, Doug Anderson wrote: > It appears that we can confuse things if we try to turn on the MMC > clock when the power is off. Adjust is so that we turn the clock on > (using dw_mci_setup_bus) after power is all the way on and we turn the > clock off before the power

Re: [PATCH v2] mmc: dw_mmc: fix bug that cause mmc_test failture

2015-02-25 Thread Javier Martinez Canillas
Hello Addy, On 02/20/2015 03:55 AM, Addy Ke wrote: > The STOP command can terminate a data transfer between a memory card and > mmc controller. > > As show in Synopsys DesignWare Cores Mobile Stroage Host Databook: s/Stroage/Storage but maybe Ulf can amend the typo when applying? > Data timeout

[PATCH 1/2] mmc: dw_mmc: Only enable CD after setup and only if needed

2015-02-25 Thread Doug Anderson
We really don't want to get a card detect interrupt during probe time since it can confuse things. Let's disable the card detect interrupt until we're in a really good place: the end of probe. Let's also simply avoid enabling the card detect interrupt if it's not used. It appears that (at least

[PATCH 2/2] mmc: dw_mmc: Don't crash if we get an interrupt before slot has initted

2015-02-25 Thread Doug Anderson
It's unlikely that this is really needed on any single-slot systems where we disable card detects until the end of probe, but it still seems safer to check to make sure that a slot has been initted before we try to dereference it to find the SDIO interrupt mask. Signed-off-by: Doug Anderson ---

Re: Help needed: Enabling HPI causes some eMMC devices to stop working

2015-02-25 Thread Hans de Goede
Hi, On 25-02-15 12:44, Jaehoon Chung wrote: Hi. On 02/19/2015 04:15 AM, Hans de Goede wrote: Hi, As part of the Linux Allwinner SoC support work I do in my spare time, I'm working on getting stock Linux running on the Utoo P66 Allwinner A13 based tablet. This tablet is interesting because it

Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode

2015-02-25 Thread Rob Herring
On Wed, Jan 28, 2015 at 8:41 PM, Alim Akhtar wrote: > From: Seungwon Jeon > > Implements HS400 mode support for exynos host driver. > This also include some updates as new mode is added. > > Signed-off-by: Seungwon Jeon > Signed-off-by: Alim Akhtar > [Alim: addressed review comments] > --- > .

Re: [PATCH/RFC] mmc: sh_mmcif: Add exclusion between cmd and interrupt

2015-02-25 Thread Yoshihiro Kaneko
Hello Sergei, 2015-02-16 1:02 GMT+09:00 Sergei Shtylyov : > Hello. > > On 02/15/2015 05:46 PM, Yoshihiro Kaneko wrote: > >> From: Kouichi Tomita > > >> A command end interrupt should not be processed between command issue >> and setting of wait_for flag. It expects already the flag to be set. >>

Re: Help needed: Enabling HPI causes some eMMC devices to stop working

2015-02-25 Thread Jaehoon Chung
Hi. On 02/19/2015 04:15 AM, Hans de Goede wrote: > Hi, > > As part of the Linux Allwinner SoC support work I do in my > spare time, I'm working on getting stock Linux running on > the Utoo P66 Allwinner A13 based tablet. > > This tablet is interesting because it uses an eMMC rather then > raw na

Re: [PATCH v2] mmc: dw_mmc: rockchip: add support MMC_CAP_RUNTIME_RESUME capability

2015-02-25 Thread Jaehoon Chung
Hi, Addy. Acked-by: Jaehoon Chung Thanks! Best Regards, Jaehoon Chung On 02/20/2015 11:37 AM, Addy Ke wrote: > To support HS200 and UHS mode, mmc core will call init_card() to > execute tuning: > - sdio: init_card can be executed at runtime resume. > - sd and mmc: init_card can be executed at

Re: [PATCH 2/2] mmc: dw_mmc: Give a good reset after we give power

2015-02-25 Thread Jaehoon Chung
Dear, Doug. Looks good to me. Thanks! Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung On 02/21/2015 03:57 AM, Doug Anderson wrote: > We should give dw_mmc a good reset after we apply power. On some > boards vqmmc may actually be connected to the IP block in the SoC so > it's good to reset

Re: [PATCH 1/2] mmc: dw_mmc: Make sure we only adjust the clock when power is on

2015-02-25 Thread Jaehoon Chung
Hi, Doug. It makes sense. Looks good to me. Thanks! Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung On 02/21/2015 03:57 AM, Doug Anderson wrote: > It appears that we can confuse things if we try to turn on the MMC > clock when the power is off. Adjust is so that we turn the clock on > (us

Re: [PATCH] mmc: pwrseq: simplify alloc/free hooks

2015-02-25 Thread Alexandre Courbot
Chris, Ulf, gentle ping? On Thu, Feb 12, 2015 at 1:36 PM, Alexandre Courbot wrote: > The alloc() and free() hooks required each pwrseq implementation to set > host->pwrseq themselves. This is error-prone and could be done at a > higher level if alloc() was changed to return a pointer to a struct

Re: [PATCH v2] mmc: dw_mmc: Don't start commands while busy

2015-02-25 Thread Javier Martinez Canillas
Hello Doug, On 02/25/2015 06:43 AM, Doug Anderson wrote: > > OK, so looking through things I _think_ I found another difference > that _might_ matter... > Yes it does! when adding the "sd1_bus1" the slot pinctrl I do have the WiFi module working, thanks a lot for your help! > Upstream (arch/ar

Re: [PATCH v4 1/3] mmc: dw_mmc: update clock after host reach a stable voltage

2015-02-25 Thread Jaehoon Chung
Hi, On 02/25/2015 04:52 PM, Alim Akhtar wrote: > Hi Doug, > > > On Fri, Feb 20, 2015 at 5:19 AM, Doug Anderson wrote: >> Alim and Addy, >> >> On Sun, Feb 15, 2015 at 3:28 PM, Alim Akhtar wrote: >>> Hi Addy, >>> >>> On Sat, Feb 14, 2015 at 11:47 AM, Addy Ke wrote: As show in mmc_power_up(

Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode

2015-02-25 Thread Alim Akhtar
Thanks Jaehoon, On Wed, Feb 25, 2015 at 12:04 PM, Jaehoon Chung wrote: > Hi, Alim. > > Tested-by: Jaehoon Chung > Acked-by: Jaehoon Chung > > I will include this patch into my tree, and i will request pull to Ulf. > If any rebase is required, I won't be able to do so until march 9th, hope you c