Re: [PATCH 3/3 v3] mmc: sh_mmcif: calculate best clock with parent clock

2015-04-21 Thread Kuninori Morimoto
Hi Laurent > > > +struct sh_mmcif_parent_clk { > > I'm not sure I would call this parent clock. It refers to the frequency of > the > functional clock provided to the MMCIF, there's no concept of parent there. > True, the clock referenced by the MMCIF DT node is an MSTP gate clock, and > fre

Re: [PATCH 3/3 v3] mmc: sh_mmcif: calculate best clock with parent clock

2015-04-21 Thread Kuninori Morimoto
Hi Geert Thank you for your review. > > +static const struct sh_mmcif_parent_clk mmcif_gen2_parent_clk = { > > + .max = 9750, > > + .min = 12187500, > > + .clkdiv_map = 0x3ff, > > Shouldn't this come from private data in the CPG clock driver, which supplies > the parent cl

Re: [PATCH V6 08/15] mmc: mmc: Hold re-tuning if the card is put to sleep

2015-04-21 Thread Arend van Spriel
On 04/21/15 14:26, Adrian Hunter wrote: On 21/04/15 14:53, Ulf Hansson wrote: On 21 April 2015 at 13:00, Adrian Hunter wrote: On 21/04/15 12:42, Ulf Hansson wrote: On 20 April 2015 at 14:09, Adrian Hunter wrote: Currently "mmc sleep" is used before power off and is not paired with waking up

[PATCH v2 RESEND 0/2] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller.

2015-04-21 Thread Suman Tripathi
This patch adds the SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller. v1 change: * Use the CONFIG_ARM64_DMA_HAS_IOMMU for dma-mapping. v2 change: * Drop the IOMMU support and switching to PIO mode for arasan controller integrated inside APM X-Gene SoC. Signed-off-by: Suman T

Re: [PATCH v2 RESEND 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c

2015-04-21 Thread Arnd Bergmann
On Tuesday 21 April 2015 21:12:39 Suman Tripathi wrote: > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-c

[PATCH v2 RESEND 1/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.

2015-04-21 Thread Suman Tripathi
This patch adds the arasan sdhc nodes to reuse the of-arasan driver for APM X-Gene SoC. Signed-off-by: Suman Tripathi --- arch/arm64/boot/dts/apm-storm.dtsi | 44 ++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm6

[PATCH v2 RESEND 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c

2015-04-21 Thread Suman Tripathi
This patch adds some quirks support to be read from fdt. Signed-off-by: Suman Tripathi --- drivers/mmc/host/sdhci-pltfm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index bef250e..9f6a4b9 100644 --- a/drive

[RFC/PATCH] mmc: block: use block layer pm helpers for pm of card device

2015-04-21 Thread Konstantin Dorfman
Use of block layer runtime PM helpers, implementing the block layer's request-based mechanism, simplifies data path of mmc core layer. It enables to remove synchronous call pm_runtime_get_sync() from mmc core data path. The idea and API is designed by Alan Stern and described here: http://marc

Re: [PATCH 3/3 v3] mmc: sh_mmcif: calculate best clock with parent clock

2015-04-21 Thread Laurent Pinchart
Hello, On Tuesday 21 April 2015 12:31:21 Geert Uytterhoeven wrote: > On Tue, Apr 21, 2015 at 10:31 AM, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > > > MMCIF IP on R-Car series has parent clock which can be set > > several rate, and it was not implemented on old SH-Mobile series > >

Re: [PATCH V6 08/15] mmc: mmc: Hold re-tuning if the card is put to sleep

2015-04-21 Thread Adrian Hunter
On 21/04/15 14:53, Ulf Hansson wrote: > On 21 April 2015 at 13:00, Adrian Hunter wrote: >> On 21/04/15 12:42, Ulf Hansson wrote: >>> On 20 April 2015 at 14:09, Adrian Hunter wrote: Currently "mmc sleep" is used before power off and is not paired with waking up. Nevertheless hold re

Re: [PATCH V6 08/15] mmc: mmc: Hold re-tuning if the card is put to sleep

2015-04-21 Thread Ulf Hansson
On 21 April 2015 at 13:00, Adrian Hunter wrote: > On 21/04/15 12:42, Ulf Hansson wrote: >> On 20 April 2015 at 14:09, Adrian Hunter wrote: >>> Currently "mmc sleep" is used before power off and >>> is not paired with waking up. Nevertheless hold >>> re-tuning. >>> >>> Signed-off-by: Adrian Hunter

Re: [PATCH V6 08/15] mmc: mmc: Hold re-tuning if the card is put to sleep

2015-04-21 Thread Adrian Hunter
On 21/04/15 12:42, Ulf Hansson wrote: > On 20 April 2015 at 14:09, Adrian Hunter wrote: >> Currently "mmc sleep" is used before power off and >> is not paired with waking up. Nevertheless hold >> re-tuning. >> >> Signed-off-by: Adrian Hunter >> --- >> drivers/mmc/core/mmc.c | 14 +++--- >

Re: [PATCH V6 02/15] mmc: core: Enable / disable re-tuning

2015-04-21 Thread Adrian Hunter
On 21/04/15 11:59, Ulf Hansson wrote: > On 20 April 2015 at 14:09, Adrian Hunter wrote: >> Enable re-tuning when tuning is executed and >> disable re-tuning when card is no longer initialized. >> >> In the case of SDIO suspend, the card can keep power. >> In that case, re-tuning need not be disabl

Re: [PATCH 3/3 v3] mmc: sh_mmcif: calculate best clock with parent clock

2015-04-21 Thread Geert Uytterhoeven
Hi Morimoto-san, On Tue, Apr 21, 2015 at 10:31 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > MMCIF IP on R-Car series has parent clock which can be set > several rate, and it was not implemented on old SH-Mobile series > (= SH-Mobile series parent clock was fixed rate) > R-Car serie

Re: [RFC PATCH 1/4] PM / QoS: Add pm_qos_cancel_request_lazy() that doesn't sleep

2015-04-21 Thread Adrian Hunter
On 21/04/15 13:18, Dov Levenglick wrote: >> On 20/04/15 17:00, Dov Levenglick wrote: Add pm_qos_cancel_request_lazy() which is convenient for contexts that may not sleep. Signed-off-by: Adrian Hunter --- include/linux/pm_qos.h | 2 ++ kernel/power/qos.c | 2

Re: [RFC PATCH 1/4] PM / QoS: Add pm_qos_cancel_request_lazy() that doesn't sleep

2015-04-21 Thread Dov Levenglick
> On 20/04/15 17:00, Dov Levenglick wrote: >>> Add pm_qos_cancel_request_lazy() which is convenient for >>> contexts that may not sleep. >>> >>> Signed-off-by: Adrian Hunter >>> --- >>> include/linux/pm_qos.h | 2 ++ >>> kernel/power/qos.c | 20 >>> 2 files changed, 22 i

linux-mmc@vger.kernel.org

2015-04-21 Thread Geert Uytterhoeven
On Tue, Apr 21, 2015 at 10:27 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Signed-off-by: Kuninori Morimoto > Tested-by: Keita Kobayashi Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [PATCH 1/3 v3] mmc: sh_mmcif: move mmcif_of_match to upside

2015-04-21 Thread Geert Uytterhoeven
On Tue, Apr 21, 2015 at 10:26 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Signed-off-by: Kuninori Morimoto > Tested-by: Keita Kobayashi Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [PATCH V6 08/15] mmc: mmc: Hold re-tuning if the card is put to sleep

2015-04-21 Thread Ulf Hansson
On 20 April 2015 at 14:09, Adrian Hunter wrote: > Currently "mmc sleep" is used before power off and > is not paired with waking up. Nevertheless hold > re-tuning. > > Signed-off-by: Adrian Hunter > --- > drivers/mmc/core/mmc.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions

Re: [PATCH V6 02/15] mmc: core: Enable / disable re-tuning

2015-04-21 Thread Ulf Hansson
On 20 April 2015 at 14:09, Adrian Hunter wrote: > Enable re-tuning when tuning is executed and > disable re-tuning when card is no longer initialized. > > In the case of SDIO suspend, the card can keep power. > In that case, re-tuning need not be disabled, but ensure > the re-tuning timer is disab

[PATCH 3/3 v3] mmc: sh_mmcif: calculate best clock with parent clock

2015-04-21 Thread Kuninori Morimoto
From: Kuninori Morimoto MMCIF IP on R-Car series has parent clock which can be set several rate, and it was not implemented on old SH-Mobile series (= SH-Mobile series parent clock was fixed rate) R-Car series MMCIF can use more high speed access if it setup parent clock. This patch adds parent c

Re: [RFC PATCH 1/4] PM / QoS: Add pm_qos_cancel_request_lazy() that doesn't sleep

2015-04-21 Thread Adrian Hunter
On 20/04/15 17:00, Dov Levenglick wrote: >> Add pm_qos_cancel_request_lazy() which is convenient for >> contexts that may not sleep. >> >> Signed-off-by: Adrian Hunter >> --- >> include/linux/pm_qos.h | 2 ++ >> kernel/power/qos.c | 20 >> 2 files changed, 22 insertions(

linux-mmc@vger.kernel.org

2015-04-21 Thread Kuninori Morimoto
From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto Tested-by: Keita Kobayashi --- v2 -> v3 - add SH-ML drivers/mmc/host/sh_mmcif.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_

[PATCH 1/3 v3] mmc: sh_mmcif: move mmcif_of_match to upside

2015-04-21 Thread Kuninori Morimoto
From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto Tested-by: Keita Kobayashi --- v2 -> v3 - add SH-ML drivers/mmc/host/sh_mmcif.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 2b6ef6b..

[PATCH 0/3 v3] mmc: sh_mmcif: add PLL support

2015-04-21 Thread Kuninori Morimoto
Hi Ulf These patches are v3 of sh_mmcif. Current sh_mmcif driver was used on Renesas SH-Mobile series, and it is also used on Renesas R-Car series. But, R-Car series can setup parent clock. We couldn't setup it when SH-Mobile. These patches are tested by Kobayashi-san on Lager board. Kuninori M

Re: [PATCH 0/3 v2] mmc: sh_mmcif: add PLL support

2015-04-21 Thread Kuninori Morimoto
Hi Ulf > These patches are v2 of sh_mmcif. > Current sh_mmcif driver was used on Renesas SH-Mobile series, > and it is also used on Renesas R-Car series. > But, R-Car series can setup parent clock. > We couldn't setup it when SH-Mobile. Sorry for many times. I will send v3 patches which will be

Re: [PATCH 3/3] mmc: sh_mmcif: calculate best clock with PLL

2015-04-21 Thread Kuninori Morimoto
Hi Laurent > > > From: Kuninori Morimoto > > > > > > MMCIF IP on R-Car series has PLL (= parent clock) which was not > > > implemented on old SH-Mobile series. MMCIF can use more high speed > > > access if it is possible to use PLL. > > > This patch adds PLL support for 8a7790/r8a7791. > > > >

[PATCH 1/3 v2] mmc: sh_mmcif: move mmcif_of_match to upside

2015-04-21 Thread Kuninori Morimoto
From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto Tested-by: Keita Kobayashi --- v1 -> v2 - no change drivers/mmc/host/sh_mmcif.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 2b6ef6b..

linux-mmc@vger.kernel.org

2015-04-21 Thread Kuninori Morimoto
From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto Tested-by: Keita Kobayashi --- v2 -> v3 - no change drivers/mmc/host/sh_mmcif.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_

[PATCH 3/3 v2] mmc: sh_mmcif: calculate best clock with parent clock

2015-04-21 Thread Kuninori Morimoto
From: Kuninori Morimoto MMCIF IP on R-Car series has parent clock which can be set several rate, and it was not implemented on old SH-Mobile series (= SH-Mobile series parent clock was fixed rate) R-Car series MMCIF can use more high speed access if it setup parent clock. This patch adds parent c

[PATCH 0/3 v2] mmc: sh_mmcif: add PLL support

2015-04-21 Thread Kuninori Morimoto
Hi Ulf These patches are v2 of sh_mmcif. Current sh_mmcif driver was used on Renesas SH-Mobile series, and it is also used on Renesas R-Car series. But, R-Car series can setup parent clock. We couldn't setup it when SH-Mobile. These patches are tested by Kobayashi-san on Lager board. Kuninori M

Re: [PATCH 3/3] mmc: sh_mmcif: calculate best clock with PLL

2015-04-21 Thread Laurent Pinchart
Hi Morimoto-san, On Tuesday 21 April 2015 07:43:33 Kuninori Morimoto wrote: > Hi Ulf > > > From: Kuninori Morimoto > > > > MMCIF IP on R-Car series has PLL (= parent clock) which was not > > implemented on old SH-Mobile series. MMCIF can use more high speed > > access if it is possible to use P

Re: [PATCH 3/3] mmc: sh_mmcif: calculate best clock with PLL

2015-04-21 Thread Kuninori Morimoto
Hi Ulf > From: Kuninori Morimoto > > MMCIF IP on R-Car series has PLL (= parent clock) which was not > implemented on old SH-Mobile series. MMCIF can use more high speed > access if it is possible to use PLL. > This patch adds PLL support for 8a7790/r8a7791. > > renesas,mmcif already contain r