Re: [PATCH 1/2] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-05-25 Thread Maxime Ripard
Hi Michal, The patch itself looks good, but there's a few style issues. On Sun, May 24, 2015 at 08:07:32PM +0200, Michal Suchanek wrote: > The 250ms timeout is too short. > > On my system enabling the oclk takes under 50ms and disabling slightly > over 100ms when idle. Under load disabling the c

Re: [PATCH 0/3 v6] mmc: sh_mmcif: add parent clk support

2015-05-25 Thread Kuninori Morimoto
Hi Ulf > >> Kuninori Morimoto (5): > >> 1) mmc: sh_mmcif: add sh_mmcif_host_to_dev() macro and use it. > >> 2) mmc: sh_mmcif: use sh_mmcif_xxx prefix for all functions > >> 3) mmc: sh_mmcif: calculate best clock with parent clock > >> 4) ARM: shmobile: r8a7790: add MMCIF m

Re: [PATCH V2 00/11] mmc: Add support for drive strength for eMMCs

2015-05-25 Thread Ulf Hansson
On 25 May 2015 at 09:01, Adrian Hunter wrote: > On 11/05/15 13:23, Ulf Hansson wrote: >> On 11 May 2015 at 11:29, Adrian Hunter wrote: >>> On 06/02/15 14:12, Adrian Hunter wrote: Hi Here is V2 of some patches to enable a host controller to select driver strength for eMMCs usin

Re: [PATCH 0/3 v6] mmc: sh_mmcif: add parent clk support

2015-05-25 Thread Ulf Hansson
On 22 May 2015 at 16:01, Ulf Hansson wrote: > On 14 May 2015 at 09:20, Kuninori Morimoto > wrote: >> >> Hi Ulf, Simon >> >> These patches are v6 of sh_mmcif clock support. >> >> 1) - 2) : cleanup patches >> 3) : v6 patch for clk >> 4) - 5) : DTS patch >> >> Simon >> >> 1) - 3) only : driver

Re: [PATCH V2 00/11] mmc: Add support for drive strength for eMMCs

2015-05-25 Thread Adrian Hunter
On 11/05/15 13:23, Ulf Hansson wrote: > On 11 May 2015 at 11:29, Adrian Hunter wrote: >> On 06/02/15 14:12, Adrian Hunter wrote: >>> Hi >>> >>> Here is V2 of some patches to enable a host controller to select >>> driver strength for eMMCs using HS200 or HS400. These are based >>> on top of the re-

Re: [PATCH 2/2] mmc: sunxi: Also set SDXC_LOW_POWER_ON

2015-05-25 Thread Hans de Goede
Hi, On 24-05-15 20:04, Michal Suchanek wrote: The function sunxi_mmc_oclk_onoff filters out the SDXC_LOW_POWER_ON flag but never sets it. Set SDXC_LOW_POWER_ON when oclk is disabled. Nack, looking at the datasheet I do not thing this patch actually does anything, according to the datasheet se