Re: [PATCH v3 0/6] UHS-I support for sh_mobile_sdhi

2015-06-26 Thread Ben Hutchings
I accidentally used an older shortlog and diffstat in that cover mail; here are the correct ones. Ben. Ben Hutchings (5): mmc: tmio: Add UHS-I mode support pinctrl: sh-pfc: Implement pinconf power-source param for voltage switching pinctrl: sh-pfc: r8a7790: Implement voltage switching f

[PATCH v3 6/6] ARM: shmobile: lager: Enable UHS-I SDR-50

2015-06-26 Thread Ben Hutchings
Add the "1v8" pinctrl state and sd-uhs-sdr50 property to SDHI{0,2}. Signed-off-by: Ben Hutchings --- arch/arm/boot/dts/r8a7790-lager.dts | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-la

[PATCH v3 4/6] mmc: sh_mobile_sdhi: Add UHS-I mode support

2015-06-26 Thread Ben Hutchings
Implement voltage switch, supporting modes up to SDR-50. Based on work by Shinobu Uehara, Rob Taylor, William Towle and Ian Molton. Signed-off-by: Ben Hutchings --- drivers/mmc/host/sh_mobile_sdhi.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/dri

[PATCH v3 5/6] ARM: shmobile: lager: Set clock rates for SDHI

2015-06-26 Thread Ben Hutchings
Set the input clocks to the highest supported speeds. Signed-off-by: Ben Hutchings --- arch/arm/boot/dts/r8a7790-lager.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index aaa4f258e279..5f68e53c58ae 100644

[PATCH v3 3/6] pinctrl: sh-pfc: r8a7790: Implement voltage switching for SDHI

2015-06-26 Thread Ben Hutchings
All the SHDIs can operate with either 3.3V or 1.8V signals, depending on negotiation with the card. Implement the {get,set}_low_voltage operations and set the low-voltage capability flag for the associated pins. Signed-off-by: Ben Hutchings --- drivers/pinctrl/sh-pfc/core.c| 2 +- driv

[PATCH v3 2/6] pinctrl: sh-pfc: Implement pinconf power-source param for voltage switching

2015-06-26 Thread Ben Hutchings
The pfc in the R8A7790 (and probably others in the R-Car gen 2 family) supports switching SDHI signals between 3.3V and 1.8V voltage, and the SD driver should do that when selecting a higher-speed mode. Add a flag for pins that support low voltage mode and SoC operations to get and set it. Implem

[PATCH v3 0/6] UHS-I support for sh_mobile_sdhi

2015-06-26 Thread Ben Hutchings
This series adds support for UHS-I in sh_mobile_sdhi, partly implemented in tmio_mmc. This does not yet include tuning for SDR-104, but SDR-50 now works on the R8A7790 Lager board and another development board. The pfc block needs to be reconfigured from 3.3V to 1.8V signalling on the pins wired

[PATCH v3 1/6] mmc: tmio: Add UHS-I mode support

2015-06-26 Thread Ben Hutchings
Based on work by Shinobu Uehara and Ben Dooks. This adds the voltage switch operation needed for all UHS-I modes, but not the tuning needed for SDR-104 which will come later. The card_busy implementation is a bit of a guess, but works for me on an R8A7790 chip. Signed-off-by: Ben Hutchings ---

Re: [PATCH v8 1/2] arm64: dts: Add the arasan mmc nodes in apm-storm.dtsi

2015-06-26 Thread Suman Tripathi
Any comments on this patch ?? On Fri, Jun 19, 2015 at 5:30 PM, Suman Tripathi wrote: > This patch adds the arasan mmc nodes to reuse the of-arasan > driver for APM X-Gene SoC. > > Signed-off-by: Suman Tripathi > --- > --- > arch/arm64/boot/dts/apm/apm-mustang.dts | 4 +++ > arch/arm64/boot/dts

[PATCH] mmc: MMC_MTK should depend on HAS_DMA

2015-06-26 Thread Geert Uytterhoeven
If NO_DMA=y: ERROR: "dma_alloc_coherent" [drivers/mmc/host/mtk-sd.ko] undefined! ERROR: "dma_unmap_sg" [drivers/mmc/host/mtk-sd.ko] undefined! ERROR: "dma_map_sg" [drivers/mmc/host/mtk-sd.ko] undefined! ERROR: "dma_free_coherent" [drivers/mmc/host/mtk-sd.ko] undefined! Add a depen

Re: [PATCH] mmc: sdhci: msm: Boost controller core clock

2015-06-26 Thread Ivan T. Ivanov
On Fri, 2015-06-26 at 14:34 +0300, Georgi Djakov wrote: > On 06/26/2015 02:16 PM, Ivan T. Ivanov wrote: > > Ensure SDCC is working with maximum clock otherwise card > > detection could be extremely slow, up to 7 seconds. > > > > Signed-off-by: Ivan T. Ivanov iva...@linaro.org> > > --- > > driver

Re: [PATCH] mmc: sdhci: msm: Boost controller core clock

2015-06-26 Thread Georgi Djakov
On 06/26/2015 02:16 PM, Ivan T. Ivanov wrote: > Ensure SDCC is working with maximum clock otherwise card > detection could be extremely slow, up to 7 seconds. > > Signed-off-by: Ivan T. Ivanov > --- > drivers/mmc/host/sdhci-msm.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/dri

[PATCH] mmc: sdhci: msm: Boost controller core clock

2015-06-26 Thread Ivan T. Ivanov
Ensure SDCC is working with maximum clock otherwise card detection could be extremely slow, up to 7 seconds. Signed-off-by: Ivan T. Ivanov --- drivers/mmc/host/sdhci-msm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 4

Re: [PATCH 1/3] mmc: sdhci: let GPIO based card detection have higher precedence

2015-06-26 Thread Ivan T. Ivanov
On Fri, 2015-06-26 at 14:09 +0300, Adrian Hunter wrote: > On 26/06/15 14:00, Ivan T. Ivanov wrote: > > On Fri, 2015-06-26 at 13:19 +0300, Adrian Hunter wrote: > > > On 26/06/15 13:00, Ivan T. Ivanov wrote: > > > > Controller could have BROKEN_CARD_DETECTION quirk set, but drivers > > > > could use

Re: [PATCH 1/3] mmc: sdhci: let GPIO based card detection have higher precedence

2015-06-26 Thread Adrian Hunter
On 26/06/15 14:00, Ivan T. Ivanov wrote: > > On Fri, 2015-06-26 at 13:19 +0300, Adrian Hunter wrote: >> On 26/06/15 13:00, Ivan T. Ivanov wrote: >>> Controller could have BROKEN_CARD_DETECTION quirk set, but drivers >>> could use GPIO to detect card present state. Let, when defined, GPIO >>> take

Re: [PATCH 0/3] mmc: sdhci: Card detection fixes

2015-06-26 Thread Ivan T. Ivanov
On Fri, 2015-06-26 at 19:31 +0900, Jaehoon Chung wrote: > Hi, Ivan. > > On 06/26/2015 07:00 PM, Ivan T. Ivanov wrote: > > Following changes aimed to fix some aspects of card detection, when > > BROKEN_CARD_DETECTION quirk is set. > > As i know, when there is no card detection scheme, BROKEN_CARD

Re: [PATCH 1/3] mmc: sdhci: let GPIO based card detection have higher precedence

2015-06-26 Thread Ivan T. Ivanov
On Fri, 2015-06-26 at 13:19 +0300, Adrian Hunter wrote: > On 26/06/15 13:00, Ivan T. Ivanov wrote: > > Controller could have BROKEN_CARD_DETECTION quirk set, but drivers > > could use GPIO to detect card present state. Let, when defined, GPIO > > take precedence, so drivers could properly detect c

Re: [PATCH 0/3] mmc: sdhci: Card detection fixes

2015-06-26 Thread Jaehoon Chung
Hi, Ivan. On 06/26/2015 07:00 PM, Ivan T. Ivanov wrote: > Following changes aimed to fix some aspects of card detection, when > BROKEN_CARD_DETECTION quirk is set. As i know, when there is no card detection scheme, BROKEN_CARD_DETECTION quirks is set. If it can use CD_GPIO, doesn't it need to se

Re: [PATCH 1/3] mmc: sdhci: let GPIO based card detection have higher precedence

2015-06-26 Thread Adrian Hunter
On 26/06/15 13:00, Ivan T. Ivanov wrote: > Controller could have BROKEN_CARD_DETECTION quirk set, but drivers > could use GPIO to detect card present state. Let, when defined, GPIO > take precedence, so drivers could properly detect card state and not > use polling. > > Signed-off-by: Ivan T. Ivan

[PATCH 3/3] mmc: sdhci: properly check card present state when quirk NO_CARD_NO_RESET is set

2015-06-26 Thread Ivan T. Ivanov
Controller could have both NO_CARD_NO_RESET and BROKEN_CARD_DETECTION quirks set. Use sdhci_do_get_cd() when applying NO_CARD_NO_RESET, which properly check for BROKEN_CARD_DETECTION quirk. Signed-off-by: Ivan T. Ivanov --- drivers/mmc/host/sdhci.c | 3 +-- 1 file changed, 1 insertion(+), 2 dele

[PATCH 2/3] mmc: sdhci: don't use card state polling when CD GPIO is defined

2015-06-26 Thread Ivan T. Ivanov
There is no reason to use polling for card detection state change when drivers are using dedicated GPIO for this. Don't poll in this case. Signed-off-by: Ivan T. Ivanov --- drivers/mmc/host/sdhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/d

[PATCH 1/3] mmc: sdhci: let GPIO based card detection have higher precedence

2015-06-26 Thread Ivan T. Ivanov
Controller could have BROKEN_CARD_DETECTION quirk set, but drivers could use GPIO to detect card present state. Let, when defined, GPIO take precedence, so drivers could properly detect card state and not use polling. Signed-off-by: Ivan T. Ivanov --- drivers/mmc/host/sdhci.c | 11 +++ 1

[PATCH 0/3] mmc: sdhci: Card detection fixes

2015-06-26 Thread Ivan T. Ivanov
Following changes aimed to fix some aspects of card detection, when BROKEN_CARD_DETECTION quirk is set. Ivan T. Ivanov (3): mmc: sdhci: let GPIO based card detection have higher precedence mmc: sdhci: don't use card state polling when CD GPIO is defined mmc: sdhci: properly check card presen