Re: [RFC PATCH v2 1/1] mmc: sprd: add MMC host driver for Spreadtrum SoC

2015-08-12 Thread Shawn Lin
On 2015/8/12 19:01, Hongtao Wu wrote: On Sat, Aug 8, 2015 at 5:20 PM, Shawn Lin mailto:shawn@rock-chips.com>> wrote: On 2015/8/4 21:16, Hongtao Wu wrote: This patch adds MMC host driver for Spreadtrum SoC. The following coding style may be not meet kernel coding style.

Re: [RFC PATCH v4 3/9] mips: pistachio_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-12 Thread Shawn Lin
在 2015/8/13 6:05, Ralf Baechle 写道: On Thu, Aug 06, 2015 at 02:45:15PM +0800, Shawn Lin wrote: DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Li

Re: [PATCH v2] DT: mmc: sh_mmcif: document R8A779[34] support

2015-08-12 Thread Simon Horman
[CC: Ulrich, Geert] On Wed, Aug 12, 2015 at 01:38:02PM +0300, Sergei Shtylyov wrote: > Hello. > > On 8/12/2015 3:59 AM, Simon Horman wrote: > > >>Renesas R8A7794 SoC also has the MMCIF controller... > > >>Signed-off-by: Sergei Shtylyov > > >This new compat string looks good to me. > > >Acked

Re: [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text

2015-08-12 Thread Simon Horman
On Wed, Aug 12, 2015 at 01:41:40PM +0300, Sergei Shtylyov wrote: > On 8/12/2015 3:56 AM, Simon Horman wrote: > > >>The "compatible" property text contradicts even the example given in the > >>MMCIF > >>binding document itself; moreover, the Renesas MMCIF driver only matches on > >>the generic "c

Re: [RFC PATCH v4 3/9] mips: pistachio_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-12 Thread Ralf Baechle
On Thu, Aug 06, 2015 at 02:45:15PM +0800, Shawn Lin wrote: > DesignWare MMC Controller's transfer mode should be decided > at runtime instead of compile-time. So we remove this config > option and read dw_mmc's register to select DMA master. > > Signed-off-by: Shawn Lin > --- > > Changes in v4:

Re: [PATCH] [wip] repair mci dma transfers for avr32

2015-08-12 Thread Andy Shevchenko
On Wed, 2015-08-12 at 17:49 +0200, Ludovic Desroches wrote: > Signed-off-by: Ludovic Desroches > --- > > Hi, > > Here is a rough draft to fix the regression. I have only compiled it. > I will > update all the boards later. > > I have removed the mci_dma_data since it is no more used for ARM >

[PATCH] [wip] repair mci dma transfers for avr32

2015-08-12 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches --- Hi, Here is a rough draft to fix the regression. I have only compiled it. I will update all the boards later. I have removed the mci_dma_data since it is no more used for ARM platforms. arch/avr32/boards/atngw100/setup.c | 1 + arch/avr32/mach-at

Re: [PATCH] mmc: sh_mmcif: Silence DMA slave ID compile warnings on 64-bit

2015-08-12 Thread Geert Uytterhoeven
Hi Arnd, On Wed, Aug 12, 2015 at 4:50 PM, Arnd Bergmann wrote: > On Tuesday 11 August 2015 14:48:34 Geert Uytterhoeven wrote: >> dma_cap_mask_t mask; >> @@ -413,12 +413,11 @@ sh_mmcif_request_dma_one(struct sh_mmcif_host *host, >> dma_cap_set(DMA_SLAVE, mask); >> >> if (pd

Re: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating.

2015-08-12 Thread Olliver Schinagl
The thing is, I never saw the prints in my console (i assume that it prints on the console by default with earlyprintk/debug stuff enabled as per sunxi-usual)? P.S. what I do as a basic test, is on our very very minimal empty debian image (think < 150 mb) i do a apt-get build-essential that in

Re: [PATCH] mmc: sh_mmcif: Silence DMA slave ID compile warnings on 64-bit

2015-08-12 Thread Arnd Bergmann
On Tuesday 11 August 2015 14:48:34 Geert Uytterhoeven wrote: > dma_cap_mask_t mask; > @@ -413,12 +413,11 @@ sh_mmcif_request_dma_one(struct sh_mmcif_host *host, > dma_cap_set(DMA_SLAVE, mask); > > if (pdata) > - slave_data = direction == DMA_MEM_TO_DEV ? > -

Re: [linux-sunxi] [PATCH v3 1/3] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-08-12 Thread Hans de Goede
Hi, On 08/12/2015 03:29 PM, Michal Suchanek wrote: The 250ms timeout is too short. On my system enabling the oclk takes under 50ms and disabling slightly over 100ms when idle. Under load disabling the clock can take over 350ms. This does not make mmc clock gating look like good option to have

Re: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating.

2015-08-12 Thread Michal Suchanek
On 12 August 2015 at 15:19, Olliver Schinagl wrote: > Hey, > > On 12-08-15 14:35, Hans de Goede wrote: >> >> Hi, >> >> On 12-08-15 14:23, Michal Suchanek wrote: >>> >>> When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable >>> automatic hardware controlled clock gating on the mmc inte

Re: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating.

2015-08-12 Thread Olliver Schinagl
Hey, On 12-08-15 14:35, Hans de Goede wrote: Hi, On 12-08-15 14:23, Michal Suchanek wrote: When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable automatic hardware controlled clock gating on the mmc interface. Signed-off-by: Michal Suchanek In general this looks good, but I wo

Re: [linux-sunxi] Re: [PATCH resend 1/3] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-08-12 Thread Michal Suchanek
On 12 August 2015 at 14:40, Olliver Schinagl wrote: > > On 12-08-15 14:32, Hans de Goede wrote: >> >> Hi, >> >> On 12-08-15 14:23, michal.sucha...@ruk.cuni.cz wrote: >>> >>> The 250ms timeout is too short. >>> >>> On my system enabling the oclk takes under 50ms and disabling slightly >>> over 100

Re: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating.

2015-08-12 Thread Michal Suchanek
On 12 August 2015 at 14:35, Hans de Goede wrote: > Hi, > > On 12-08-15 14:23, Michal Suchanek wrote: >> >> When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable >> automatic hardware controlled clock gating on the mmc interface. >> >> Signed-off-by: Michal Suchanek > > > In general t

Re: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating.

2015-08-12 Thread Hans de Goede
Hi, On 12-08-15 14:23, Michal Suchanek wrote: When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable automatic hardware controlled clock gating on the mmc interface. Signed-off-by: Michal Suchanek In general this looks good, but I wonder how intensively this has been tested ? Als

Re: [linux-sunxi] Re: [PATCH resend 1/3] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-08-12 Thread Olliver Schinagl
While I can't speak for Michal obviously, I left the debugging bit (in my v2 that i sent 2 minutes ago) as both you and Hans where content with it back then and both acked it. Michal, feel free to send the v3 without the debug info, unless you want me to do it ;) Olliver On 12-08-15 14:32,

[PATCH v2] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-08-12 Thread Olliver Schinagl
Hey all A few months ago, Michal Suchanek submitted the attached patch fixing the gating timeout issue. Until recently, about v4.0.0 I hadn't noticed any issues and ran all boards from SD card. Recently I upgraded to Hans's 4.2 tree where he added mmc: sunxi: Don't start commands while the c

Re: [PATCH resend 1/3] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-08-12 Thread Hans de Goede
Hi, On 12-08-15 14:23, michal.sucha...@ruk.cuni.cz wrote: The 250ms timeout is too short. On my system enabling the oclk takes under 50ms and disabling slightly over 100ms when idle. Under load disabling the clock can take over 350ms. This does not make mmc clock gating look like good option t

re: mmc: Driver for CB710/720 memory card reader (MMC part)

2015-08-12 Thread Dan Carpenter
Hello Michał Mirosław, The patch 5f5bac8272be: "mmc: Driver for CB710/720 memory card reader (MMC part)" from May 22, 2009, leads to the following static checker warning: drivers/mmc/host/cb710-mmc.c:579 cb710_mmc_set_ios() warn: 'err' can be either negative or positive drivers/m

Re: [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text

2015-08-12 Thread Sergei Shtylyov
On 8/12/2015 3:56 AM, Simon Horman wrote: The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string and doesn't look for the SoC specific strings at all. Thus describ

Re: [PATCH v2] DT: mmc: sh_mmcif: document R8A779[34] support

2015-08-12 Thread Sergei Shtylyov
Hello. On 8/12/2015 3:59 AM, Simon Horman wrote: Renesas R8A7794 SoC also has the MMCIF controller... Signed-off-by: Sergei Shtylyov This new compat string looks good to me. Acked-by: Simon Horman Thank you. I've messed up the subject, so need to re-post. --- The patch is agai