Re: [PATCH v3 02/15] mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get

2015-09-10 Thread Tony Lindgren
* Kevin Hilman [150910 10:03]: > On Tue, Sep 1, 2015 at 8:03 AM, Tony Lindgren wrote: > > * Grygorii Strashko [150901 07:57]: > >> On 09/01/2015 05:50 PM, Tony Lindgren wrote: > >> >> > >> >>On -next, Above crash signature could be related to race > >> >>"ARM: OMAP2+: omap-device: fix race defer

Re: [PATCH] mmc: block: Add new ioctl to send multi commands

2015-09-10 Thread Grant Grundler
On Thu, Sep 10, 2015 at 11:20 AM, Jon Hunter wrote: > > On 10/09/15 18:10, Grant Grundler wrote: ... >> struct mmc_ioc_multi_cmd { >> __u64 num_of_cmds; >> struct mmc_ioc_cmd cmds[0]; >> }; >> >> I think this would work just as well. But doesn't "pointer to an >> array" req

Re: [PATCH] mmc: block: Add new ioctl to send multi commands

2015-09-10 Thread Jon Hunter
On 10/09/15 18:10, Grant Grundler wrote: > On Thu, Sep 10, 2015 at 1:24 AM, Jon Hunter wrote: > ... >>> - you have some implicit padding after the structure and should replace that >>> with explictit pad bytes to extend the structure to a multiple of its >>> alignment (8 bytes). >> >> Would p

Re: [PATCH] mmc: block: Add new ioctl to send multi commands

2015-09-10 Thread Grant Grundler
On Thu, Sep 10, 2015 at 1:24 AM, Jon Hunter wrote: ... >> - you have some implicit padding after the structure and should replace that >> with explictit pad bytes to extend the structure to a multiple of its >> alignment (8 bytes). > > Would padding with __u32 at the end be sufficient here? I

Re: [PATCH v3 02/15] mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get

2015-09-10 Thread Kevin Hilman
On Tue, Sep 1, 2015 at 8:03 AM, Tony Lindgren wrote: > * Grygorii Strashko [150901 07:57]: >> On 09/01/2015 05:50 PM, Tony Lindgren wrote: >> >> >> >>On -next, Above crash signature could be related to race >> >>"ARM: OMAP2+: omap-device: fix race deferred probe of omap_hsmmc vs >> >>omap_device

Testing SD Host controller

2015-09-10 Thread Muni Sekhar
[ Please keep me in CC as I'm not subscribed to the list] Hello, We are having a SD Host controller hardware and I need to validate that hardware. We are using standard mmc host drivers. Can any one point me about the standard software(driver or user mode code) which can be used to validate t

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

2015-09-10 Thread Ulf Hansson
On 14 August 2015 at 18:55, Hongtao Wu wrote: > the Spreadtrum MMC host driver is used to supply EMMC, SD, and > SDIO types of memory cards Perhaps some more information about the controller. Are there any specific features it support or doesn't support!? Moreover it would be nice to know a bit

Re: [PATCH 3/8] mmc: core: Add mmc_regulator_set_vqmmc()

2015-09-10 Thread Ulf Hansson
On 2 September 2015 at 18:20, Doug Anderson wrote: > Ulf, > > On Wed, Sep 2, 2015 at 4:38 AM, Ulf Hansson wrote: >>> +/** >>> + * mmc_regulator_set_vqmmc - Set VQMMC as per the ios >>> + * >>> + * For 3.3V signaling, we try to match VQMMC to VMMC as closely as >>> possible. >> >> Looking at the

Re: [RFC PATCH v3 0/3] Add MMC host driver for Spreadtrum SoC

2015-09-10 Thread Ulf Hansson
Hi Hongtao, On 14 August 2015 at 18:55, Hongtao Wu wrote: > This patch adds MMC host driver for Spreadtrum SoC. > The following coding style may be not meet kernel coding style. I don't think you have any reason to why you shouldn't follow the kernel coding style. Please change! > I am not sure

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-10 Thread Ulf Hansson
On 10 September 2015 at 10:43, Jon Hunter wrote: > Hi Ulf, > > On 09/09/15 13:42, Ulf Hansson wrote: > > [snip] > >>> +static int mmc_blk_ioctl_cmd(struct block_device *bdev, >>> + struct mmc_ioc_cmd __user *ic_ptr) >>> +{ >>> + struct mmc_blk_ioc_data *idata; >>> +

Re: [PATCH v3] mmc: meson: Add driver for the SD/MMC host found on Amlogic MesonX SoCs

2015-09-10 Thread Ulf Hansson
Hi Carlo, Let me start by apologizing for the delayed reply! On 20 June 2015 at 11:22, Carlo Caione wrote: > From: Carlo Caione > > Add a driver for the SD/MMC host found on the Amlogic MesonX SoCs. It > is an MMC controller which provides an interface between the > application processor and va

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-10 Thread Jon Hunter
Hi Ulf, On 09/09/15 13:42, Ulf Hansson wrote: [snip] >> +static int mmc_blk_ioctl_cmd(struct block_device *bdev, >> + struct mmc_ioc_cmd __user *ic_ptr) >> +{ >> + struct mmc_blk_ioc_data *idata; >> + struct mmc_blk_data *md; >> + struct mmc_card *card; >>

Re: [PATCH] mmc: block: Add new ioctl to send multi commands

2015-09-10 Thread Arnd Bergmann
On Thursday 10 September 2015 09:24:19 Jon Hunter wrote: > On 09/09/15 21:22, Arnd Bergmann wrote: > > On Wednesday 09 September 2015 17:44:54 Jon Hunter wrote: > >> On 09/09/15 16:56, Arnd Bergmann wrote: > >>> On Wednesday 09 September 2015 16:06:01 Jon Hunter wrote: > > > - you have some implic

Re: [PATCH] mmc: block: Add new ioctl to send multi commands

2015-09-10 Thread Jon Hunter
Hi Arnd, On 09/09/15 21:22, Arnd Bergmann wrote: > On Wednesday 09 September 2015 17:44:54 Jon Hunter wrote: >> >> On 09/09/15 16:56, Arnd Bergmann wrote: >>> On Wednesday 09 September 2015 16:06:01 Jon Hunter wrote: + + idata = kcalloc(mcci.num_of_cmds, sizeof(*idata), GFP_KERNEL)

Re: sdhci: runtime suspend/resume on card insert/removal

2015-09-10 Thread Jisheng Zhang
Hi Russell, On Thu, 10 Sep 2015 09:02:33 +0100 Russell King - ARM Linux wrote: > On Thu, Sep 10, 2015 at 03:31:29PM +0800, Jisheng Zhang wrote: > > Hi Vaibhav, > > > > On Thu, 10 Sep 2015 12:40:48 +0530 > > Vaibhav Hiremath wrote: > > > > > Hi, > > > > > > During my testing of SDHCI-PXAV3 dr

Re: sdhci: runtime suspend/resume on card insert/removal

2015-09-10 Thread Russell King - ARM Linux
On Thu, Sep 10, 2015 at 03:31:29PM +0800, Jisheng Zhang wrote: > Hi Vaibhav, > > On Thu, 10 Sep 2015 12:40:48 +0530 > Vaibhav Hiremath wrote: > > > Hi, > > > > During my testing of SDHCI-PXAV3 driver on Marvell's pxa1928 > > based platform, I observed that runtime PM suspend/resume is having >

Re: sdhci: runtime suspend/resume on card insert/removal

2015-09-10 Thread Jisheng Zhang
On Thu, 10 Sep 2015 13:21:12 +0530 Vaibhav Hiremath wrote: > > > On Thursday 10 September 2015 01:01 PM, Jisheng Zhang wrote: > > Hi Vaibhav, > > > > On Thu, 10 Sep 2015 12:40:48 +0530 > > Vaibhav Hiremath wrote: > > > >> Hi, > >> > >> During my testing of SDHCI-PXAV3 driver on Marvell's pxa19

Re: sdhci: runtime suspend/resume on card insert/removal

2015-09-10 Thread Vaibhav Hiremath
On Thursday 10 September 2015 01:01 PM, Jisheng Zhang wrote: Hi Vaibhav, On Thu, 10 Sep 2015 12:40:48 +0530 Vaibhav Hiremath wrote: Hi, During my testing of SDHCI-PXAV3 driver on Marvell's pxa1928 based platform, I observed that runtime PM suspend/resume is having issues with card insertio

Re: sdhci: runtime suspend/resume on card insert/removal

2015-09-10 Thread Jisheng Zhang
Hi Vaibhav, On Thu, 10 Sep 2015 12:40:48 +0530 Vaibhav Hiremath wrote: > Hi, > > During my testing of SDHCI-PXAV3 driver on Marvell's pxa1928 > based platform, I observed that runtime PM suspend/resume is having > issues with card insertion and removal. > > Let me try to explain it using execu

sdhci: runtime suspend/resume on card insert/removal

2015-09-10 Thread Vaibhav Hiremath
Hi, During my testing of SDHCI-PXAV3 driver on Marvell's pxa1928 based platform, I observed that runtime PM suspend/resume is having issues with card insertion and removal. Let me try to explain it using execution sequence - During boot: MMC SD card gets detected as expected. [2.431012] m