Re: [PATCH v2] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2

2014-06-16 Thread Haojian Zhuang
off-by: Jean Delvare > Cc: Chris Ball > Cc: Ulf Hansson > Cc: Eric Miao > Cc: Haojian Zhuang > --- > Changes since v1: > * Rebased on kernel 3.16-rc1 > > drivers/mmc/host/Kconfig |2 ++ > 1 file changed, 2 insertions(+) > > --- linux-3.16-rc1.

Re: [PATCH 1/2] clk: hisilicon: add hi3620_mmc_clks

2014-01-15 Thread Haojian Zhuang
On 01/15/2014 04:29 PM, Mike Turquette wrote: Quoting Haojian Zhuang (2014-01-14 21:59:40) On 01/15/2014 11:53 AM, Mike Turquette wrote: Quoting zhangfei (2014-01-14 17:40:25) Dear Mike On 01/15/2014 04:17 AM, Mike Turquette wrote: Quoting Zhangfei Gao (2014-01-13 01:14:28) Suggest by

Re: [PATCH 1/2] clk: hisilicon: add hi3620_mmc_clks

2014-01-14 Thread Haojian Zhuang
On 01/15/2014 11:53 AM, Mike Turquette wrote: Quoting zhangfei (2014-01-14 17:40:25) Dear Mike On 01/15/2014 04:17 AM, Mike Turquette wrote: Quoting Zhangfei Gao (2014-01-13 01:14:28) Suggest by Arnd: abstract mmc tuning as clock behavior, also because different soc have different tuning met

Re: [PATCH v2 1/8] clk: flag to use upper half of the register as change indicator

2013-06-07 Thread Haojian Zhuang
On 7 June 2013 20:27, Heiko Stübner wrote: > Am Freitag, 7. Juni 2013, 13:46:32 schrieb Linus Walleij: >> On Thu, Jun 6, 2013 at 9:08 PM, Heiko Stübner wrote: >> > There exist platforms, namely at least all Rockchip Cortex-A9 based ones, >> > that don't use the paradigm of reading-changing-writin

Re: [PATCH 17/22] mmc: sdhci-pxa: remove unnecessary platform_set_drvdata()

2013-05-06 Thread Haojian Zhuang
to manually clear the device driver data to NULL. > > Signed-off-by: Jingoo Han > --- > drivers/mmc/host/sdhci-pxav2.c |2 -- > drivers/mmc/host/sdhci-pxav3.c |2 -- > 2 files changed, 0 insertions(+), 4 deletions(-) > Acked-by: Haojian Zhuang -- To unsubscr

Re: [PATCH 0/4] mmc: sdhci-pxav3: misc enhancements

2013-04-02 Thread Haojian Zhuang
pxav3: remove cd-broken quirk for permanently > mmc: sdhci-pxav3: enhance device tree parser code > mmc: sdhci-pxav3: controller should use SDCLK for > > drivers/mmc/host/sdhci-pxav3.c | 47 > ++-- > 1 file changed, 16 insertions(+

Re: [PATCH v6 2/4] ARM: pxa168: Add SDHCI support

2013-03-17 Thread Haojian Zhuang
ly >- start sdhci device numbering from 1 as other PXA168 devices > does that > > v4 - Use different names for SD clock registers for PXA168 instead > of redefining them in pxa168.c. Suggested by Haojian Zhuang > > v5 - Have two different clock enable functions for clo

Re: [PATCH v2 4/4] ARM: pxa168/gplugd: Add support for SD port 1

2013-03-17 Thread Haojian Zhuang
t; > pxa168_add_eth(&gplugd_eth_platform_data); > + pxa168_add_sdh(1, &gplugd_sdh_platdata); > } > > MACHINE_START(GPLUGD, "PXA168-based GuruPlug Display (gplugD) Platform") > -- > 1.7.9.5 > Acked-by: Haojian Zhuang -- To unsubscribe from this list: se

Re: [PATCH v6 05/14] mmc: sdhci: fix null return check of regulator_get

2012-11-13 Thread Haojian Zhuang
On Tue, Nov 13, 2012 at 11:00 AM, Kevin Liu wrote: > Updated Haojian and Philip's mail address. > > 2012/11/12 Kevin Liu : >> 2012/11/5 Chris Ball : >>> Hi, >>> >>> On Wed, Oct 17 2012, Kevin Liu wrote: From: Kevin Liu regulator_get() returns NULL when CONFIG_REGULATOR not defined,

Re: [PATCH] mmc: sdhci-pxav3: dt: Support "power-gpios" property

2012-09-16 Thread Haojian Zhuang
On Tue, Sep 11, 2012 at 1:00 PM, zhangfei gao wrote: > On Sun, Sep 9, 2012 at 11:06 AM, Chris Ball wrote: >> Tested on OLPC XO-4/MMP3, where the card power for two of the >> controllers is a sideband GPIO. The third cell in the power-gpios >> property controls whether the GPIO is active high/act

Re: [PATCH] mmc: sdhci-pxav3: dt: Support "cd-gpios" property

2012-09-11 Thread Haojian Zhuang
a->power_gpio)) > mmc_gpio_free_pwr(host->mmc); > + if (gpio_is_valid(pdata->ext_cd_gpio)) > + mmc_gpio_free_cd(host->mmc); > > sdhci_pltfm_free(pdev); > kfree(pxa); > -- > Chris Ball <http://printf.net/> > One Laptop Per Child Acked-by: Haojian Zhuang -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mmc: sdhci-pxav3: dt: Support "broken-cd"/"wp-inverted" properties

2012-09-11 Thread Haojian Zhuang
TECT; > + > return pdata; > } > #else > -- > Chris Ball <http://printf.net/> > One Laptop Per Child Acked-by: Haojian Zhuang -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mmc: sdhci-pxa: Add device tree support

2012-06-20 Thread Haojian Zhuang
gt;  drivers/mmc/host/sdhci-pxav3.c                     |   52 +++++++ >  3 files changed, 127 insertions(+) Acked-by: Haojian Zhuang -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] ARM: pxa168: Add SDHCI support

2011-12-29 Thread Haojian Zhuang
t;   - start sdhci device numbering from 1 as other PXA168 devices >     does that > > v4 - Use different names for SD clock registers for PXA168 instead >     of redefining them in pxa168.c. Suggested by Haojian Zhuang > > v5 - Have two different clock enable functions for cl

Re: [PATCH v4 2/4] ARM: pxa168: Add SDHCI support

2011-12-20 Thread Haojian Zhuang
On Wed, Dec 21, 2011 at 5:03 AM, Russell King - ARM Linux wrote: > Just two minor style issues in this patch. > > On Tue, Dec 20, 2011 at 06:43:01PM +0530, Tanmay Upadhyay wrote: >> +static inline int pxa168_add_sdh(int id, struct sdhci_pxa_platdata *data) >> +{ >> +     struct pxa_device_desc *d

Re: [PATCH v4 2/4] ARM: pxa168: Add SDHCI support

2011-12-20 Thread Haojian Zhuang
On Tue, Dec 20, 2011 at 9:25 PM, Haojian Zhuang wrote: > On Tue, Dec 20, 2011 at 9:13 PM, Tanmay Upadhyay > wrote: >> v2 - clock register for SDHCI are not common across all MMP SoCs. >>     So, move PXA168 implementation to pxa168.c >> >> v3 - sdhci-pxav1 driver c

Re: [PATCH v4 2/4] ARM: pxa168: Add SDHCI support

2011-12-20 Thread Haojian Zhuang
t;   - start sdhci device numbering from 1 as other PXA168 devices >     does that > > v4 - Use different names for SD clock registers for PXA168 instead >     of redefining them in pxa168.c. Suggested by Haojian Zhuang > > Signed-off-by: Tanmay Upadhyay > Reviewed-by: Ph

Re: [PATCH v3 2/4] ARM: pxa168: Add SDHCI support

2011-12-18 Thread Haojian Zhuang
On Mon, Dec 19, 2011 at 1:24 PM, Philip Rakity wrote: > > Haojian, > > Should the APMU definitions be moved to a separate include for pxa168 and say > given the name pxa168_apmu.h ? > > Same comment applies to all the register set since they are not really common. > > Philip I think it's unneces

Re: [PATCH v3 2/4] ARM: pxa168: Add SDHCI support

2011-12-18 Thread Haojian Zhuang
On Mon, Dec 19, 2011 at 1:17 PM, Tanmay Upadhyay wrote: > > > On Monday 19 December 2011 10:32 AM, Haojian Zhuang wrote: >> >> On Mon, Dec 19, 2011 at 12:55 PM, Tanmay Upadhyay >>  wrote: >>> >>> >>> On Monday 19 December 2011 10:15 AM, Hao

Re: [PATCH v3 2/4] ARM: pxa168: Add SDHCI support

2011-12-18 Thread Haojian Zhuang
On Mon, Dec 19, 2011 at 12:55 PM, Tanmay Upadhyay wrote: > > > On Monday 19 December 2011 10:15 AM, Haojian Zhuang wrote: >> >> On Fri, Dec 16, 2011 at 7:15 AM, Chris Ball  wrote: >>> >>> Hi Eric and Jason, >>> >>> On Thu, Dec 01 2011, Chr

Re: [PATCH v3 2/4] ARM: pxa168: Add SDHCI support

2011-12-18 Thread Haojian Zhuang
On Fri, Dec 16, 2011 at 7:15 AM, Chris Ball wrote: > Hi Eric and Jason, > > On Thu, Dec 01 2011, Chris Ball wrote: >> Hi Eric, Jason, >> >> Please could you ACK this patch if you agree with it, and I'll take it >> and the rest of the series via the MMC tree?  Thanks. > > Ping? > > Thanks, > > - Ch

Re: [PATCH 15/23] Alternative mmc structure to support pxa168, pxa910, mmp2 family SD

2010-12-30 Thread Haojian Zhuang
On Fri, Dec 31, 2010 at 2:03 PM, Philip Rakity wrote: > > On Dec 30, 2010, at 9:46 PM, Haojian Zhuang wrote: > >> On Thu, Dec 23, 2010 at 6:58 AM, Philip Rakity wrote: >>> >>> On Dec 22, 2010, at 6:10 AM, Arnd Bergmann wrote: >>> >>>> On W

Re: [PATCH 15/23] Alternative mmc structure to support pxa168, pxa910, mmp2 family SD

2010-12-30 Thread Haojian Zhuang
On Thu, Dec 23, 2010 at 6:58 AM, Philip Rakity wrote: > > On Dec 22, 2010, at 6:10 AM, Arnd Bergmann wrote: > >> On Wednesday 22 December 2010 08:09:58 Philip Rakity wrote: >>> The PXA168, PXA910, and MMP2 are not the same SOC.  The family >>> of embedded processors have slightly different interna

Re: [PATCH v1 1/1]sdhci-pxa: init_sdh for different platform

2010-11-23 Thread Haojian Zhuang
On Mon, Nov 22, 2010 at 11:38 AM, Haojian Zhuang wrote: > On Thu, Nov 18, 2010 at 3:42 PM, zhangfei gao wrote: >> Different platform will provide different init_sdh to handle private >> register is not same in various platform. >> Put init_sdh in set_clock is we don't

Re: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig

2010-11-22 Thread Haojian Zhuang
On Tue, Nov 23, 2010 at 11:22 AM, Philip Rakity wrote: > > I implemented the first sdhci-pxa.c controller for the pxa168 over a year > ago.  Also fixed issues on Tavor. > > This approach is not sufficient to make Aspen nor Tavor work. > > There are a number of silicon issues that need to be addre

Re: [PATCH v1 1/1]sdhci-pxa: init_sdh for different platform

2010-11-21 Thread Haojian Zhuang
On Thu, Nov 18, 2010 at 3:42 PM, zhangfei gao wrote: > Different platform will provide different init_sdh to handle private > register is not same in various platform. > Put init_sdh in set_clock is we don't want to add more call back > function to sdhci.c to keep sdhci.c as simple as possible. >

Re: [PATCH v2 1/1]sdhci-pxa: support tune_timming for various cards

2010-11-15 Thread Haojian Zhuang
On Thu, Nov 11, 2010 at 9:19 PM, zhangfei gao wrote: > Hi, Chirs & Eric > > Thanks for review, here is updated version. > 1. After clk_gating is enabled, set_clock will transfer clock=0, so > clk_disable will be called, currently set_clock will never transfer > clock=0. > Later tune_timing only oc

Re: [PATCH v2 1/2] MMC: add support for the Marvell Dove SDHCI controller

2010-10-27 Thread Haojian Zhuang
On Wed, Oct 27, 2010 at 8:35 PM, Saeed Bishara wrote: > >> >>Let's add a little text here -- something like "Implement an >>sdhci-pltfm >>driver for the controller found on Marvell Dove and MMP SoCs" is fine. > This driver for Dove only. I think MMP uses sdhci-pxa. Yes, MMP can use sdhci-pxa. --

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-22 Thread Haojian Zhuang
/mmc/host/sdhci-pxa.c >> >> I'll take the drivers/mmc/ hunks, but you should send the plat-pxa/ >> patch through the ARM tree. > > Oh.  If we do that then the driver won't compile until everything's > together, because it #includes .  Haojian/Eric, what do >

Re: [patch 2/2] mmc: add support of sdhci-pxa driver

2010-09-26 Thread Haojian Zhuang
On Mon, Sep 27, 2010 at 1:48 AM, Chris Ball wrote: > Hi Haojian, > > On Mon, Sep 27, 2010 at 12:09:17AM +0800, Haojian Zhuang wrote: >> If the name is sdhci-mmp2, it's a big confusion that people will think >> mmp(ttc/aspen) is using another IP. >> >> sdhci

Re: [patch 2/2] mmc: add support of sdhci-pxa driver

2010-09-26 Thread Haojian Zhuang
On Sun, Sep 26, 2010 at 11:59 PM, Chris Ball wrote: > On Sun, Sep 26, 2010 at 10:45:02PM +0800, Haojian Zhuang wrote: >> > I prefer we rename it to something like sdhci-mmp.c and the 'pxa' in the >> > source code to 'mmp' to cause less confusion with px

Re: [patch 2/2] mmc: add support of sdhci-pxa driver

2010-09-26 Thread Haojian Zhuang
On Sun, Sep 26, 2010 at 8:39 PM, Eric Miao wrote: > On Sun, Sep 26, 2010 at 6:56 PM, zhangfei gao wrote: >> >> --- >>  arch/arm/plat-pxa/include/plat/sdhci.h |   32 +++ >>  drivers/mmc/host/Kconfig               |   11 +++ >>  drivers/mmc/host/Makefile              |    1 + >>  drivers/mmc/ho

Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-15 Thread Haojian Zhuang
On Wed, Sep 15, 2010 at 6:29 PM, Saeed Bishara wrote: > > >>-Original Message----- >>From: Haojian Zhuang [mailto:haojian.zhu...@gmail.com] >>Sent: Wednesday, September 15, 2010 1:21 PM >>To: Saeed Bishara >>Cc: Mark Brown; Chris Ball; Andrew Morton; &g

Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-15 Thread Haojian Zhuang
On Wed, Sep 15, 2010 at 6:06 PM, Saeed Bishara wrote: > >>Which CPUs does the driver actually support?  The Kconfig and >>commit log >>just say "Marvell" so I went for the conservative option and included >>all Marvell CPUs I was aware of. > The Marvell Dove SoC includes this device, this SoC defi