Re: [PATCH V2] mmc: omap_hsmmc: Fix sleep too long in ISR context.

2013-08-20 Thread Hein Tibosch
Becasue those codes in ISR context, it can't use timer_before/after. > I divived the time into 1ms and used udelay(1) to instead. > It will cause do additional udelay(1).But from my test,it looks good. > > Reported-by: Yuzheng Ma > Tested-by: Yuzheng Ma > Reviewed-by: Hein

Re: [PATCH] mmc: omap_hsmmc: Fix sleep too long in ISR context.

2013-08-01 Thread Hein Tibosch
Hi Jianpeng Ma, On 8/1/2013 10:18 AM, majianpeng wrote: > We found a problem when we removed a working sd card that the irqaction > of omap_hsmmc can sleep to 3.6s. This cause our watchdog to work. > In func omap_hsmmc_reset_controller_fsm, it should watch a 0->1 > transition.It used loops_per_jif

Re: [PATCH] ARM: pxa: propagate errors from regulator_enable() to pxamci

2013-07-08 Thread Hein Tibosch
Hi Arnd, On 7/5/2013 11:51 PM, Arnd Bergmann wrote: > The em_x270_mci_setpower() and em_x270_usb_hub_init() functions > call regulator_enable(), which may return an error that must > be checked. > > This changes the em_x270_usb_hub_init() function to bail out > if it fails, and changes the pxamci_

[PATCH v2 2/2] mmc: atmel-mci: AP700x PDC is not connected to MCI

2012-08-30 Thread Hein Tibosch
, the connection is not done for AVR chips This patch makes the use of PDC depend on CONFIG_AVR32 Signed-off-by: Hein Tibosch --- drivers/mmc/host/atmel-mci-regs.h |7 +++ drivers/mmc/host/atmel-mci.c |2 +- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/driver

[PATCH v2 0/2] mmc: atmel-mci: repair driver for use with AVR32 (AP7000)

2012-08-30 Thread Hein Tibosch
Due to changes after 2.6.38, the drivers atmel-mci and dw_dmac got broken for the AVR32 platform: the AP7000. These two patches repair the atmel-mci driver Thanks to Ludovic and Hans-Christian for their comments Hein Tibosch (2): mmc: atmel-mci: DMA can be used with other controller mmc

[PATCH v2] avr32: at32ap700x: set DMA slave properties for MCI dw_dmac

2012-08-30 Thread Hein Tibosch
: Hein Tibosch --- arch/avr32/mach-at32ap/at32ap700x.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c index 0445c4f..7250c70 100644 --- a/arch/avr32/mach-at32ap/at32ap700x.c +++ b/arch/avr32/mach

[PATCH v2 1/2] mmc: atmel-mci: DMA can be used with other controller

2012-08-30 Thread Hein Tibosch
s can be used with a different controller than the Atmel AHB DMA one. For instance, some AVR chips use the Synopsys DesignWare AHB DMA controller. v2: in atmci_configure_dma: check both pdata and pdata->dma_slave Signed-off-by: Hein Tibosch Acked-by: Ludovic Desroches --- drivers/mmc/ho

[PATCH] avr32-linux: at32ap700x: set DMA slave properties for MCI dw_dmac

2012-08-26 Thread Hein Tibosch
width limits value for SRC/DST_TR_WID register Signed-off-by: Hein Tibosch --- arch/avr32/mach-at32ap/at32ap700x.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c index 0445c4f..e7202af 100644 --- a

[PATCH 0/2] mmc: atmel-mci: repair driver for use with AVR32 (AP7000)

2012-08-26 Thread Hein Tibosch
Due to changes after 2.6.38, the drivers atmel-mci and dw_dmac got broken for the AVR32 platform: the AP7000. These two patches repair the atmel-mci driver Thanks to Ludovic for reviewing/styling! Hein Tibosch (2): mmc: atmel-mci: DMA can be used with other controller mmc: atmel-mci

[PATCH 2/2] mmc: atmel-mci: AP700x PDC is not connected to MCI

2012-08-26 Thread Hein Tibosch
f PDC depend on CONFIG_AVR32 Signed-off-by: Hein Tibosch --- drivers/mmc/host/atmel-mci-regs.h |7 +++ drivers/mmc/host/atmel-mci.c |2 +- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/atmel-mci-regs.h b/drivers/mmc/host/atmel-mci-regs.h index ab

[PATCH 1/2] mmc: atmel-mci: DMA can be used with other controller

2012-08-26 Thread Hein Tibosch
After the latest changes to atmel-mci, it could not be used with DMA on the AVR32 platform. This patch will allow to use DMA again and it will avoid access to MCI register ATMCI_DMA. Signed-off-by: Hein Tibosch --- drivers/mmc/host/atmel-mci.c | 21 + 1 files changed, 9