[RESEND 7/7] mmc: omap: Add erase capability

This patch adds the erase capability to OMAP1/OMAP2420 MMC driver. Idea is the same than in commit 93caf8e ("omap_hsmmc: add erase capability") that we disable the data timeout interrupt for erases. Signed-off-by: Jarkko Nikula Acked-by: Tony Lindgren Tested-by: Aaro Koskinen --- d

[RESEND 4/7] mmc: omap: Remove mem_res field from struct mmc_omap_host

Field mem_res in struct mmc_omap_host is used only once in mmc_omap_probe when setting the phys_base field so we may just se the phys_base straight and remove needless mem_res. Signed-off-by: Jarkko Nikula Acked-by: Tony Lindgren Tested-by: Aaro Koskinen --- drivers/mmc/host/omap.c | 4

[RESEND 2/7] mmc: omap: Convert to devm_kzalloc

Signed-off-by: Jarkko Nikula Acked-by: Tony Lindgren Tested-by: Aaro Koskinen --- drivers/mmc/host/omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 42b665dfaa73..927ed24d0708 100644 --- a/drivers/mmc/host

[RESEND 6/7] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host

Because use_dma is set only in mmc_omap_probe and unset nowhere there is no need to carry that flag in struct mmc_omap_host for mmc_omap_prepare_data function. Signed-off-by: Jarkko Nikula Acked-by: Tony Lindgren Tested-by: Aaro Koskinen --- drivers/mmc/host/omap.c | 15 +-- 1

[RESEND 3/7] mmc: omap: Remove duplicate host->irq assignment

host-irq is set twice so remove needless one. Signed-off-by: Jarkko Nikula Acked-by: Tony Lindgren Tested-by: Aaro Koskinen --- drivers/mmc/host/omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 927ed24d0708..b438f0addb3c 100644

[RESEND 5/7] mmc: omap: Convert to devm_ioremap_resource

Simplify probe and cleanup code by using devm_ioremap_resource. This also makes probe code to follow more common allocate private struct followed by other initialization style. Signed-off-by: Jarkko Nikula Acked-by: Tony Lindgren Tested-by: Aaro Koskinen --- drivers/mmc/host/omap.c | 41

[RESEND 1/7] mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet

initialization before mmc_add_host call in mmc_omap_new_slot. Signed-off-by: Jarkko Nikula Acked-by: Tony Lindgren Tested-by: Aaro Koskinen --- v2: a snip of stack dump added to commit log --- drivers/mmc/host/omap.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers

[RESEND 0/7] mmc: omap: Fixes, cleanup and add ERASE capability

ince he no longer works for Samsung and I don't know his personal address. Set goes on top of mmc.git v3.14-rc2-10-g7536d3f83aa4. Jarkko Nikula (7): mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet mmc: omap: Convert to devm_kzalloc mmc: omap: Remove dupl

Re: [PATCH 0/7] mmc: omap: Fixes, cleanup and add ERASE capability

On 12/06/2013 01:41 PM, Aaro Koskinen wrote: >> Set goes on top of v3.13-rc2-208-g8ecffd791448. > > Patch 5 had some fuzz with plain 3.13-rc2. Otherwise these look fine. > I tested these on 770 and N800, so for all patches: > > Tested-by: Aaro Koskinen > Yes, reason for your fuzz observation is

[PATCH 7/7] mmc: omap: Add erase capability

This patch adds the erase capability to OMAP1/OMAP2420 MMC driver. Idea is the same than in commit 93caf8e ("omap_hsmmc: add erase capability") that we disable the data timeout interrupt for erases. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 18 +++--- 1 fi

[PATCH 3/7] mmc: omap: Remove duplicate host->irq assignment

host-irq is set twice so remove needless one. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 927ed24..b438f0a 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c

[PATCH 0/7] mmc: omap: Fixes, cleanup and add ERASE capability

ich also should fix the error introduced by 31ee9181eb92: http://www.spinics.net/lists/linux-omap/msg100790.html Patch 6 continue cleanup and 7 adds the ERASE capability to the driver so one could utilize discards with mkfs, mount option or with the fstrim. Set goes on top of v3.13-rc2-208-g8ecffd

[PATCH 4/7] mmc: omap: Remove mem_res field from struct mmc_omap_host

Field mem_res in struct mmc_omap_host is used only once in mmc_omap_probe when setting the phys_base field so we may just se the phys_base straight and remove needless mem_res. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH 2/7] mmc: omap: Convert to devm_kzalloc

Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 42b665d..927ed24 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -1345,7 +1345,8

[PATCH 1/7] mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet

initialization before mmc_add_host call in mmc_omap_new_slot. Signed-off-by: Jarkko Nikula --- v2: a snip of stack dump added to commit log --- drivers/mmc/host/omap.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index

[PATCH 6/7] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host

Because use_dma is set only in mmc_omap_probe and unset nowhere there is no need to carry that flag in struct mmc_omap_host for mmc_omap_prepare_data function. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff

[PATCH 5/7] mmc: omap: Convert to devm_ioremap_resource

Simplify probe and cleanup code by using devm_ioremap_resource. This also makes probe code to follow more common allocate private struct followed by other initialization style. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 41 - 1 file

Re: [PATCH] mmc: omap: Fix error introduced by fix to release_mem_region() path

On 12/02/2013 07:34 PM, Tony Lindgren wrote: > Commit 31ee9181eb92: (mmc: omap: Fix DMA configuration to not rely > on device id) fixed getting of the DMA resources when booted with > device tree. This patch however changed the handling of the > free_mem_region() error path by reusing the struct re

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

Hi On 11/27/2013 11:37 PM, Tony Lindgren wrote: > * Jarkko Nikula [131127 12:55]: > Bummer, sounds like some duplicate work could have been avoided :( > I suggest resend to Chris and linux-mmc one more time as Chris should > pick up the MMC patches in general. > Before that sho

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

Hi On 11/27/2013 11:59 PM, Tony Lindgren wrote: > * Chris Ball [131127 13:48]: >> Hi, >> >> On Wed, Nov 27 2013, Jarkko Nikula wrote: >>> Can you enlighten me what's the proper way to get patches to mmc since >>> I cannot figure out working methodol

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

Hi Chris On Tue, 26 Nov 2013 18:33:50 -0500 Chris Ball wrote: > Hi Tony, > > On Mon, Nov 18 2013, Tony Lindgren wrote: > > We are wrongly relying on device id for the DMA configuration > > which can lead to wrong DMA channel being selected. > > > > Fix the issue by using the standard resources

[RESEND 4/8] mmc: omap: Remove mem_res field from struct mmc_omap_host

Field mem_res in struct mmc_omap_host is used only once in mmc_omap_probe when setting the phys_base field so we may just se the phys_base straight and remove needless mem_res. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[RESEND 2/8] mmc: omap: Convert to devm_kzalloc

Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index df2d10f..4ea13e3 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -1355,7 +1355,8

[RESEND 7/8] mmc: omap: Get DMA request numbers via platform resource

MAP2: Use hwmod to initialize mmc for 2420") Note that mmc_omap_probe doesn't change failure mechanism in case if it fails get DMA request number or DMA channel. In that case it just falls back to PIO transfer for TX and/or RX. Signed-off-by: Jarkko Nikula --- dri

[RESEND 8/8] mmc: omap: Add erase capability

This patch adds the erase capability to OMAP1/OMAP2420 MMC driver. Idea is the same than in commit 93caf8e ("omap_hsmmc: add erase capability") that we disable the data timeout interrupt for erases. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 18 +++--- 1 fi

[RESEND 3/8] mmc: omap: Remove duplicate host->irq assignment

host-irq is set twice so remove needless one. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 4ea13e3..e6987ae 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c

[RESEND 1/8] mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet

. Call to omap_notify_cover_event on Nokia N810 happens from menelaus.c PMIC driver via board-n8x0.c during execution of mmc_add_host in case of open miniSD cover. Fix this by moving cover_timer and cover_tasklet initialization before mmc_add_host call in mmc_omap_new_slot. Signed-off-by: Jarkko

[RESEND 5/8] mmc: omap: Convert to devm_ioremap_resource

Simplify probe and cleanup code by using devm_ioremap_resource. This also makes probe code to follow more common allocate private struct followed by other initialization style. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 41 - 1 file

[RESEND 6/8] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host

Because use_dma is set only in mmc_omap_probe and unset nowhere there is no need to carry that flag in struct mmc_omap_host for mmc_omap_prepare_data function. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff

[PATCH] mmc: omap: Add erase capability

This patch adds the erase capability to OMAP1/OMAP2420 MMC driver. Idea is the same than in commit 93caf8e ("omap_hsmmc: add erase capability") that we disable the data timeout interrupt for erases. Signed-off-by: Jarkko Nikula --- This goes on top of my previous omap mmc pat

Re: [PATCH 1/6] mmc: omap: Convert to devm_kzalloc

Hi On 09/11/2013 09:01 PM, Jarkko Nikula wrote: > Signed-off-by: Jarkko Nikula > --- > drivers/mmc/host/omap.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > I resent this set with a subject prefix "PATCH FIX+RESEND" since I found a NULL pointer d

[PATCH FIX+RESEND 5/7] mmc: omap: Convert to devm_ioremap_resource

Simplify probe and cleanup code by using devm_ioremap_resource. This also makes probe code to follow more common allocate private struct followed by other initialization style. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 41 - 1 file

[PATCH FIX+RESEND 2/7] mmc: omap: Convert to devm_kzalloc

Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 31f33ac..1d0d21f 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -1356,7 +1356,8

[PATCH FIX+RESEND 4/7] mmc: omap: Remove mem_res field from struct mmc_omap_host

Field mem_res in struct mmc_omap_host is used only once in mmc_omap_probe when setting the phys_base field so we may just se the phys_base straight and remove needless mem_res. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH FIX+RESEND 3/7] mmc: omap: Remove duplicate host->irq assignment

host-irq is set twice so remove needless one. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 1d0d21f..7668d47 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c

[PATCH FIX+RESEND 7/7] mmc: omap: Get DMA request numbers via platform resource

MAP2: Use hwmod to initialize mmc for 2420") Note that mmc_omap_probe doesn't change failure mechanism in case if it fails get DMA request number or DMA channel. In that case it just falls back to PIO transfer for TX and/or RX. Signed-off-by: Jarkko Nikula --- Aaro: Sorry to bothe

[PATCH FIX+RESEND 6/7] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host

Because use_dma is set only in mmc_omap_probe and unset nowhere there is no need to carry that flag in struct mmc_omap_host for mmc_omap_prepare_data function. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff

[PATCH FIX+RESEND 1/7] mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet

. Call to omap_notify_cover_event on Nokia N810 happens from menelaus.c PMIC driver via board-n8x0.c during execution of mmc_add_host in case of open miniSD cover. Fix this by moving cover_timer and cover_tasklet initialization before mmc_add_host call in mmc_omap_new_slot. Signed-off-by: Jarkko

[PATCH 4/6] mmc: omap: Convert to devm_ioremap_resource

Simplify probe and cleanup code by using devm_ioremap_resource. This also makes probe code to follow more common allocate private struct followed by other initialization style. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 41 - 1 file

[PATCH 6/6] mmc: omap: Get DMA request numbers via platform resource

MAP2: Use hwmod to initialize mmc for 2420") Note that mmc_omap_probe doesn't change failure mechanism in case if it fails get DMA request number or DMA channel. In that case it just falls back to PIO transfer for TX and/or RX. Signed-off-by: Jarkko Nikula --- Aaro: Sorry to bothe

[PATCH 2/6] mmc: omap: Remove duplicate host->irq assignment

host-irq is set twice so remove needless one. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 03179da..4d9fc5c 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c

[PATCH 5/6] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host

Because use_dma is set only in mmc_omap_probe and unset nowhere there is no need to carry that flag in struct mmc_omap_host for mmc_omap_prepare_data function. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff

[PATCH 1/6] mmc: omap: Convert to devm_kzalloc

Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index b94f38e..03179da 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -1354,7 +1354,8

[PATCH 3/6] mmc: omap: Remove mem_res field from struct mmc_omap_host

Field mem_res in struct mmc_omap_host is used only once in mmc_omap_probe when setting the phys_base field so we may just se the phys_base straight and remove needless mem_res. Signed-off-by: Jarkko Nikula --- drivers/mmc/host/omap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

or omap1 and omap2+. Acked-by: Jarkko Nikula -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html