ptional! I wonder how I could let that patch
>> slip through, my bad!
>
I also wonder how I missed that in my patch, sorry for the mess :(
> OK good to hear :)
>
>> Thanks for fixing this!
>
+1
> No problem, thanks,
>
> Tony
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Ulf,
On 10/27/2015 11:10 AM, Ulf Hansson wrote:
> On 21 October 2015 at 17:15, Javier Martinez Canillas
> wrote:
>> The pwrseq_emmc driver does a eMMC card reset before a system reboot to
>> allow broken or limited ROM boot-loaders (that don't have an eMMC reset
Hello Doug,
On 10/22/2015 07:33 PM, Doug Anderson wrote:
> On Thu, Oct 22, 2015 at 9:07 AM, Javier Martinez Canillas
[snip]
>>
>> Do you know why the priority 200 was chosen for veyron gpi-restart ooi?
>
> In David Riley's original patch the example had 200:
>
ms that most default system restart handlers use 128 and that's
the reason why gpio-restart and mmc-pwrseq-emmc use 129 and other restart
handlers that can be registered via DT use 192 (which is in the middle of
128 and 255).
So I actually thought to use a number in between 192 and 255 (i.e
Hello Marek,
On 10/22/2015 12:07 PM, Marek Szyprowski wrote:
> On 2015-10-22 06:14, Alim Akhtar wrote:
>> On 10/22/2015 08:22 AM, Javier Martinez Canillas wrote:
>>> On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote:
>>>> On 22.10.2015 10:20, Javier Martinez Ca
Hello Anand,
On 10/22/2015 07:03 AM, Anand Moon wrote:
> Hi Javier,
>
> On 22 October 2015 at 08:22, Javier Martinez Canillas
> wrote:
>> Hello Krzysztof,
>>
>> On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote:
>>> On 22.10.2015 10:20, Javier Ma
Hello Krzysztof,
On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote:
> On 22.10.2015 10:20, Javier Martinez Canillas wrote:> Hello Krzysztof,
>>
>> Thanks for your feedback.
>>
>> On 10/22/2015 02:36 AM, Krzysztof Kozlowski wrote:
>>> On 22.10.2015 00:15, J
Hello Krzysztof,
Thanks for your feedback.
On 10/22/2015 02:36 AM, Krzysztof Kozlowski wrote:
> On 22.10.2015 00:15, Javier Martinez Canillas wrote:
>> The pwrseq_emmc driver does a eMMC card reset before a system reboot to
>> allow broken or limited ROM boot-loaders (that don
e the priority 128, there are other restart handlers (such as
the syscon-reboot one) that use a higher priority. So, use the highest
priority to make sure that the eMMC hw is reset before a system reboot.
Signed-off-by: Javier Martinez Canillas
Tested-by: Markus Reichl
Tested-by: Anand Moon
Reviewed-by:
The simple power sequence provider sets a value for multiple GPIOs in one
go so it is better to use the API already provided by the GPIO descriptor
API instead of open coding the same logic.
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/core/pwrseq_simple.c | 45
The driver prints if the data width is 8-bit but it's using a
binary OR instead of a binary AND so it will always report as
"is_8bit=Y" regardless of the flags in host->mmc->caps.
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
1 file
They aren't needed and are just creating null statements so remove it.
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/host/vub300.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index fbabbb8
It's not needed an is just creating a null statement, so remove it.
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/host/wbsd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c
index ca183ea767b3..c3fd16d997ca 1
Drivers needs to export the OF id table and this be built into
the module or udev won't have the necessary information to autoload
the driver module when the device is registered via OF.
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/host/mmc_spi.c | 1 +
1 file changed, 1 inse
The gpiod_get() function expands to gpiod_get_index() with index 0
so it's better to use it since is easier to read and more concise.
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/core/pwrseq_emmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc
Hello Brian,
On 08/20/2015 11:11 PM, Brian Norris wrote:
> On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote:
>> Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches
>
> ^^^ I'm dying to know how this sentence ends :)
>
Sigh,
first applying all the other patches in this series, will break
module autoloading for the drivers of devices registered using OF but
that lacks an of_match_table. I'll repost patch #18 once all the patches
in this series have landed.
[0]: https://lkml.org/lkml/2015/7/30/519
Best regards,
Jav
So, it's better to also export the OF table even when
is unused now to prevent breaking module loading when the core changes.
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/host/mmc_spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/
uot;)
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/core/pwrseq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/core/pwrseq.c b/drivers/mmc/core/pwrseq.c
index ab2129781161..4c1d1757dbf9 100644
--- a/drivers/mmc/core/pwrseq.c
+++ b/drivers/mmc/core/p
Hello Alim,
On Wed, Mar 18, 2015 at 4:08 AM, Alim Akhtar wrote:
> From: Seungwon Jeon
>
> HS400 timing values are added for SMDK5420, exynos5420-peach-pit
> and exynos5800-peach-pi boards.
> This also adds RCLK GPIO line, this gpio should be in pull-down
> state.
> This also enables HS400 on pea
dereference it to find the SDIO interrupt mask.
>
> Signed-off-by: Doug Anderson
On an Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800 Peach Pi:
Tested-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc&
t; * mmc_go_idle
> * mmc_rescan
> * process_one_work
> * worker_thread
> * kthread
>
> Signed-off-by: Doug Anderson
>
On an Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800 Peach Pi:
Tested-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this
failures enumerating cards on rk3288.
>
> Signed-off-by: Doug Anderson
On an Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800 Peach Pi:
Tested-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc"
f-by: Doug Anderson
>
On an Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800 Peach Pi:
Tested-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
f before the power goes off.
>
> Signed-off-by: Doug Anderson
On an Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800 Peach Pi:
Tested-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the
os5800
Peach Pi Chromebooks where I tested it.
Tested-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Doug,
On 02/25/2015 06:43 AM, Doug Anderson wrote:
>
> OK, so looking through things I _think_ I found another difference
> that _might_ matter...
>
Yes it does! when adding the "sd1_bus1" the slot pinctrl I do have
the WiFi module working, thanks a lot for your help!
> Upstream (arch/ar
Hello Doug,
On 02/23/2015 08:45 PM, Doug Anderson wrote:
> On Mon, Feb 23, 2015 at 8:33 AM, Javier Martinez Canillas
> wrote:
>>
>> Addy's "mmc: dw_mmc: fix bug that cause 'Timeout sending command" [0] patch
>> reset the controller if it was busy for
s enabled
correctly according to /sys/kernel/debug/clk/clk_summary and also by looking
at the value in the max77802 i2c register address that enables that clock.
Any hints will be highly appreciated.
Thanks a lot and best regards,
Javier
[0]: https://lkml.org/lkml/2015/2/5/222
[1]:
>From ced0974472
quences.
>
> Signed-off-by: NeilBrown
> Fixes: 934f1f48330ed695927a51fa068dc5d673f2da19
>
>
Right, sorry for the silly mistake.
Acked-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the
Hello Jaehoon,
On Mon, Feb 16, 2015 at 6:48 AM, Jaehoon Chung wrote:
> On 02/15/2015 08:41 PM, Javier Martinez Canillas wrote:
>> I modified [1] your patch #2 to do what Alim suggested and only with
>> that patch on top of linux-next I have neither the the "Timeout
>>
Hello Addy,
On Sat, Feb 14, 2015 at 7:17 AM, Addy Ke wrote:
> patch 1: This patch can fix bug that controller is still data busy after
> reset all blocks. After this patch, I still get data busy in
> set_ios().
>
> patch 2: This patch fix bug 'Timeout sending command'. After pat
samsung,dw-mshc-ddr-timing = <0 2>;
> pinctrl-names = "default";
> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>;
> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_cd>;
> bus-width
Hello Andrzej,
On Wed, Feb 11, 2015 at 10:06 AM, Andrzej Hajda wrote:
> On 02/11/2015 09:32 AM, Jaehoon Chung wrote:
>> On 02/11/2015 04:51 PM, Andrzej Hajda wrote:
>>> Hi,
>>>
>>> Thanks for comments.
>>>
>>> On 02/10/2015 03:54 PM, Alim Akhtar wrote:
Hi Andrzej,
On Tue, Feb 10, 2
Hello Kukjin,
On 02/04/2015 04:19 PM, Kukjin Kim wrote:
> On 02/05/15 00:06, Javier Martinez Canillas wrote:
>>
>> I noticed that you are applying patches to your Samsung tree, do you want me
>> to
>> re-send patches #5 and #6 or is OK for you to pick them from fro
Hello Kukjin,
On 01/30/2015 02:06 PM, Javier Martinez Canillas wrote:
> On 01/30/2015 12:13 PM, Ulf Hansson wrote:
>>>
>>> Patch #1 extends the simple MMC power sequence DT binding to support more
>>> than one GPIO and patch #2 adds the actual implementation.
>>
ached to
the SDIO interface in my Exynos5250 Snow Chromebook is reset / powered
up correctly so:
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Marek,
On Mon, Feb 2, 2015 at 9:33 AM, Marek Szyprowski
wrote:
> +
> +Required properties:
> +- compatible : contains "mmc-pwrseq-emmc".
> +- reset-gpios : contains a GPIO specifier. The reset GPIO is pulled
The DT binding says that the "reset-gpios" is a required property...
> +int mmc_p
m system reboot procedure.
>
Patches looks good to me, I've only one comment on patch 1/3. Once
that is addressed, feel free to add for all the series:
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" i
Hello Ulf,
On 01/30/2015 12:13 PM, Ulf Hansson wrote:
>>
>> Patch #1 extends the simple MMC power sequence DT binding to support more
>> than one GPIO and patch #2 adds the actual implementation.
>>
>> In the same way, patch #3 and #4 extend the simple MMC power sequence DT
>> binding and pwrseq_s
Hello Ulf,
On 01/30/2015 12:17 PM, Ulf Hansson wrote:
>> };
>> @@ -39,6 +42,11 @@ static void mmc_pwrseq_simple_pre_power_on(struct
>> mmc_host *host)
>> struct mmc_pwrseq_simple *pwrseq = container_of(host->pwrseq,
>> struct mmc_pwrseq_simple, pwr
Some WLAN chips attached to a SDIO interface, need an external clock
to be operational. Since this is very common, extend the simple MMC
power sequence DT binding to support an optional clock.
Signed-off-by: Javier Martinez Canillas
---
Changes since v2: None.
Changes since v1: None
number, it uses the of_gpio_named_count()
since the MMC power sequence is only built when CONFIG_OF is enabled.
Signed-off-by: Javier Martinez Canillas
Signed-off-by: Srinivas Kandagatla
---
Changes since v2: None.
Changes since v1:
- Many code cleanups suggested by Srinivas Kandagatla
found.
Signed-off-by: Javier Martinez Canillas
---
Changes since v2:
- Add a clk_enabled bool to struct mmc_pwrseq_simple to track clock
gate/ungate since .power_off can be called prior to .pre_power_on.
Suggested by Ulf Hansson.
- clk_get() does not return -ENOSYS so don't check for
Many SDIO/MMC attached WLAN chips need more than one ping for their reset
sequence. Extend the pwrseq_simple binding to support more than one pin.
Signed-off-by: Javier Martinez Canillas
---
Changes since v2: None.
Changes since v1:
- Make the explanation clearer by adding an explicit "
Enabling SDIO IRQ signalling for the wifi MMC/SDIO slot
doubles the transmission transfer rate.
Signed-off-by: Javier Martinez Canillas
---
Changes since v2: None.
Changes since v1: None, new patch.
---
arch/arm/boot/dts/exynos5250-snow.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a
MMC/SDIO slot.
Signed-off-by: Javier Martinez Canillas
---
Changes since v2: None.
Changes since v1:
- Remove cap-sdio-irq from mmc3 dev node since is a separate change.
Suggested by Arend van Spriel.
---
arch/arm/boot/dts/exynos5250-snow.dts | 25 -
1 file changed
clock.
This is the third version of the series that addressed issues pointed out
in the previous versions.
The series depend on v4 "mmc: core: Add support for MMC power sequences":
http://comments.gmane.org/gmane.linux.kernel.mmc/30665
Javier Martinez Canillas (6):
mmc: pwrseq: Doc
Hello Ulf,
Thanks a lot for your feedback.
On 01/29/2015 02:05 PM, Ulf Hansson wrote:
>>
>> struct mmc_pwrseq_simple {
>> struct mmc_pwrseq pwrseq;
>> + struct clk *ext_clk;
>
> You need to add a bool, maybe call it clk_enabled; See why below.
>
Ok
>> int nr_gpios;
>>
Hello Marek,
On Thu, Jan 29, 2015 at 10:15 AM, Marek Szyprowski
wrote:
>> Also, I wonder whether we could extend the mmc-pwrseq to cover your
>> case? Did you consider that as an option?
>
>
> I didn't consider mmc-pwrseq yet. For me it looked straightforward to
I agree with Ulf that using mmc-p
t; The simple MMC power sequence provider will initially support a reset
> GPIO. From several earlier posted patches, it's clear that such
> hardware exists. Especially some WLAN chips which are attached to an
> SDIO interface may use a GPIO reset.
>
> Signed-off-by: Ulf Hansson
> -
the SDIO wlan chip
in the Snow Chromebook after extending the pwrseq_simple driver so on
Exynos5250 Snow Chromebook:
Tested-by: Javier Martinez Canillas
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" i
alloc() and the
> ->free() callbacks.
>
> Signed-off-by: Ulf Hansson
> ---
>
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message
hough, did you cc
linux-mmc?
> May be we can merge goods in both :-)
>
Sure, I want $subject to be generic enough to be useful for other platforms.
> On 28/01/15 10:10, Javier Martinez Canillas wrote:
>> Many WLAN attached to a SDIO/MMC interface, needs more than one pin for
>
Hello Arend,
Thanks for your feedback.
On 01/28/2015 03:03 PM, Arend van Spriel wrote:
> On 01/28/15 11:10, Javier Martinez Canillas wrote:
>> &dp {
>> @@ -531,17 +538,33 @@
>> status = "okay";
>> num-slots =<1>;
>> bro
Srinivas,
On 01/28/2015 05:34 PM, Srinivas Kandagatla wrote:
>> -- reset-gpios : contains a GPIO specifier. The reset GPIO is asserted at
>> -initialization and prior we start the power up procedure of the card. It
>> -will be de-asserted right after the power has been provided to the card
> By extending you mean?
>
Sorry, I shoud had mentioned it. I meant the "Add multiple GPIO and
external clock to MMC pwrseq_simple" series [0] I posted before.
>>
>> Tested-by: Javier Martinez Canillas
>> Reviewed-by: Javier Martinez Canillas
>>
>> Best
number, it uses the of_gpio_named_count()
since the MMC power sequence is only built when CONFIG_OF is enabled.
Signed-off-by: Javier Martinez Canillas
Signed-off-by: Srinivas Kandagatla
---
Changes since v1:
- Many code cleanups suggested by Srinivas Kandagatla
* Rename reset_gpio array to
Some WLAN chips attached to a SDIO interface, need an external clock
to be operational. Since this is very common, extend the simple MMC
power sequence DT binding to support an optional clock.
Signed-off-by: Javier Martinez Canillas
---
Changes since v1: None.
---
Documentation/devicetree
MMC/SDIO slot.
Signed-off-by: Javier Martinez Canillas
---
Changes since v1:
- Remove cap-sdio-irq from mmc3 dev node since is a separate change.
Suggested by Arend van Spriel.
---
arch/arm/boot/dts/exynos5250-snow.dts | 25 -
1 file changed, 24 insertions(+), 1
Many SDIO/MMC attached WLAN chips need more than one ping for their reset
sequence. Extend the pwrseq_simple binding to support more than one pin.
Signed-off-by: Javier Martinez Canillas
---
Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt | 6 +++---
1 file changed, 3 insertions
external clock.
The series depend on v4 "mmc: core: Add support for MMC power sequences":
http://comments.gmane.org/gmane.linux.kernel.mmc/30665
Javier Martinez Canillas (5):
mmc: pwrseq: Document that simple sequence support more than one GPIO
mmc: pwrseq_simple: Extend to support more
clock.
This is the second version of the series that addressed issues pointed out
by Arend van Spriel and Srinivas Kandagatla.
The series depend on v4 "mmc: core: Add support for MMC power sequences":
http://comments.gmane.org/gmane.linux.kernel.mmc/30665
Javier Martinez Canillas
found.
Signed-off-by: Javier Martinez Canillas
---
Changes since v1:
- Rebase on top of latest changes.
- Use IS_ERR() instead of checking for NULL to see if the clock exists.
---
drivers/mmc/core/pwrseq_simple.c | 34 --
1 file changed, 32 insertions(+), 2
found.
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/core/pwrseq_simple.c | 33 -
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c
index 9e51fe1051c5..5ef6db7323f3 100644
Enabling SDIO IRQ signalling for the wifi MMC/SDIO slot
doubles the transmission transfer rate.
Signed-off-by: Javier Martinez Canillas
---
Changes since v1: None, new patch.
---
arch/arm/boot/dts/exynos5250-snow.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts
Many SDIO/MMC attached WLAN chips need more than one ping for their reset
sequence. Extend the pwrseq_simple binding to support more than one pin.
Signed-off-by: Javier Martinez Canillas
---
Changes since v1:
- Make the explanation clearer by adding an explicit "they".
Suggested b
number, it uses the of_gpio_named_count()
since the MMC power sequence is only built when CONFIG_OF is enabled.
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/core/pwrseq_simple.c | 54 ++--
1 file changed, 41 insertions(+), 13 deletions(-)
diff --git a
MMC/SDIO slot.
Signed-off-by: Javier Martinez Canillas
---
arch/arm/boot/dts/exynos5250-snow.dts | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index b9aeec430527
ind a GPIO for the consumer.
>
> Signed-off-by: Ulf Hansson
> ---
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@
Some WLAN chips attached to a SDIO interface, need an external clock
to be operational. Since this is very common, extend the simple MMC
power sequence DT binding to support an optional clock.
Signed-off-by: Javier Martinez Canillas
---
Documentation/devicetree/bindings/mmc/mmc-pwrseq
Hello Ulf,
On Fri, Jan 23, 2015 at 6:01 PM, Ulf Hansson wrote:
>>
>> Any reason to not use the devm_gpiod_get_index() managed version instead?
>
> This struct device don't have a bound driver to it. Thus this device
> won't be freed automagically from the ->remove() or failed ->probe()
> path.
>
Hello Ulf,
On Mon, Jan 19, 2015 at 10:13 AM, Ulf Hansson wrote:
>
> int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev)
> {
> struct mmc_pwrseq_simple *pwrseq;
> + int ret = 0;
>
> pwrseq = kzalloc(sizeof(struct mmc_pwrseq_simple), GFP_KERNEL);
>
Hello Ulf,
On Tue, Dec 30, 2014 at 11:29 AM, Ulf Hansson wrote:
> On 19 December 2014 at 20:02, Doug Anderson wrote:
>>
>>> It was a bit hard to follow the
>>> updated the revisions, please don't send patches "in-reply-to" for
>>> future sets.
>>
>> Very strange. I didn't send out anything in-r
Hello Linus,
On Wed, Oct 1, 2014 at 9:54 AM, Linus Walleij wrote:
> On Tue, Sep 30, 2014 at 5:07 PM, Javier Martinez Canillas
> wrote:
>>>
>>> + *gpio_invert = gpiod_is_active_low(desc);
>>> +
>>
>> The old code set gpio_inv_cd if (!(flags &am
re both ways of inversion are checked
> and the end result XOR:ed.
>
> Reported-by: Javier Martinez Canillas
> Signed-off-by: Linus Walleij
Thanks a lot for the quick patch. It makes the card detection work
again but needs two subtle changes to have the same semantics than
before.
>
Hello Linus,
On Wed, Aug 27, 2014 at 1:00 PM, Linus Walleij wrote:
> This switches the central MMC OF parser to use gpio descriptors
> instead of grabbing GPIOs explicitly from the device tree.
> This strips out an unecessary use of the integer-based GPIO
> API that we want to get rid of, cuts do
On 08/19/2014 02:43 PM, Ulf Hansson wrote:
>
> Well, currently this seems like the best approach. If we end up having
> some new regulator helper function, future wise, we can convert to
> such later on.
>
Great, thanks a lot for your help!
> Kind regards
> Uffe
>
Best regards,
Javier
--
To un
Hello Ulf,
On 08/15/2014 04:51 PM, Ulf Hansson wrote:
>
> Just wanted to add some input regarding the errors in the mmc case.
> These are of high importance. In principle if you get, "Failed getting
> OCR mask: -22", likely you will be using a wrong OCR mask while
> negotiating the voltage level
Hello Mark,
On 08/15/2014 11:55 AM, Mark Brown wrote:
> On Fri, Aug 15, 2014 at 09:48:43AM +0200, Javier Martinez Canillas wrote:
>
>> But now I wonder why regulator_list_voltage() even list the voltage for
>> fixed regulators (desc->fixed_uV) since they don't have
Hello Tim,
On 08/15/2014 07:36 AM, Tim Kryger wrote:
> On Thu, Aug 14, 2014 at 8:19 AM, Mark Brown wrote:
>
>> Right, there's two things going on here. One is that as you describe we
>> shouldn't be putting constraints in .dtsi files if we don't know they're
>> OK for a given board. The other
Hello Tim,
Thanks for your feedback.
On 08/14/2014 04:13 PM, Tim Kryger wrote:
>
> https://lkml.org/lkml/2014/8/12/377
>
> Perhaps I misunderstood the discussion in that thread but couldn't
> this failure also be addressed by adding proper constraints for each
> FET in individual DTS files to r
et_voltage().
Without this patch, the following warning is reported when
a FET is used as a vmmc-supply:
dwmmc_exynos 1222.mmc: Failed getting OCR mask: -22
Signed-off-by: Javier Martinez Canillas
---
drivers/mmc/core/core.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletion
e(mmc->supply.vmmc) and
regulator_disable(mmc->supply.vmmc) by mmc_regulator_set_ocr(mmc,
mmc->supply.vmmc, ios->vdd) and mmc_regulator_set_ocr(mmc,
mmc->supply.vmmc, 0) respectively in your original patch.
Best regards,
Javier
[0]: http://lxr.free-electrons.com/source/drivers/mmc/c
On Sat, Oct 19, 2013 at 1:14 AM, NeilBrown wrote:
> On Fri, 18 Oct 2013 12:12:48 +0200 Javier Martinez Canillas
> wrote:
>
>> On Fri, Oct 18, 2013 at 8:20 AM, NeilBrown wrote:
>> > On Sat, 5 Oct 2013 13:17:09 +0200 Andreas Fenkart
>> > wrote:
>> >
On Fri, Oct 18, 2013 at 8:20 AM, NeilBrown wrote:
> On Sat, 5 Oct 2013 13:17:09 +0200 Andreas Fenkart wrote:
>
>> The am335x can't detect pending cirq in PM runtime suspend.
>> This patch reconfigures dat1 as a GPIO before going to suspend.
>> SDIO interrupts are detected with the GPIO, while in
On Wed, Jul 18, 2012 at 11:11 AM, Shilimkar, Santosh
wrote:
> On Wed, Jul 18, 2012 at 2:19 PM, Javier Martinez Canillas
> wrote:
>> On Wed, Jul 18, 2012 at 10:36 AM, Shilimkar, Santosh
>> wrote:
>>> On Wed, Jul 18, 2012 at 1:14 PM, S, Venkatraman wrote:
>>&g
ndgren wrote:
>>>> > * Javier Martinez Canillas [120716 23:56]:
>>>> >> On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh
>>>> >> wrote:
>>>> >> > Hi,
>>>> >> >
>>>> >> > On Tue, Ju
On Wed, Jul 18, 2012 at 8:59 AM, Tony Lindgren wrote:
> * Javier Martinez Canillas [120716 23:56]:
>> On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh
>> wrote:
>> > Hi,
>> >
>> > On Tue, Jul 17, 2012 at 6:00 AM, Javier Martinez Canillas
>>
On Tue, Jul 17, 2012 at 9:09 AM, Shilimkar, Santosh
wrote:
> On Tue, Jul 17, 2012 at 12:33 PM, Javier Martinez Canillas
> wrote:
>> The OMAP MMC and OMAP High Speed MMC hosts now use entirely the DMA
>> engine API instead of the previous private DMA API implementation.
>>
cting automatically CONFIG_DMADEVICES and CONFIG_DMA_OMAP solves it.
While being there, also update drivers/spi/spi-omap2-mcspi which has been
ported to DMA engine API too.
Signed-off-by: Javier Martinez Canillas
---
Changes since v1:
- Also include drivers/spi/spi-omap2-mcspi.c as suggest
On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh
wrote:
> Hi,
>
> On Tue, Jul 17, 2012 at 6:00 AM, Javier Martinez Canillas
> wrote:
>> The OMAP MMC and OMAP High Speed MMC hosts now use entirely the DMA
>> engine API instead of the previous private DMA API implemen
92 matches
Mail list logo
