Re: [PATCH] mmc: sdhci-s3c: call sdhci_card_event() instead of card tasklet

2014-05-29 Thread Jingoo Han
io and mmc_of_parse(). > > https://patchwork.kernel.org/patch/4239541/ OK, I see. Please ignore my patch. Thank you for your comment. Best regards, Jingoo Han > > Best Regards, > Jaehoon Chung > > On 05/30/2014 12:56 PM, Jingoo Han wrote: > > The card tasklet was remo

[PATCH] mmc: sdhci-s3c: call sdhci_card_event() instead of card tasklet

2014-05-29 Thread Jingoo Han
has no member named 'card_tasklet' Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-s3c.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 781b8a9..4386e91 100644 --- a/drivers/mmc/host/sdhci-s3c.

[PATCH 3/3] mmc: sdhci-pci: remove unnecessary pci_set_drvdata()

2014-01-07 Thread Jingoo Han
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host

[PATCH 2/3] mmc: mmc_spi: remove unnecessary spi_set_drvdata()

2014-01-07 Thread Jingoo Han
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Sonic Zhang --- drivers/mmc/host/mmc_spi.c |2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 1/3] mmc: mmc_spi: use spi_get_drvdata() and spi_set_drvdata()

2014-01-07 Thread Jingoo Han
Use the wrapper functions for getting and setting the driver data using spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we can directly pass a struct spi_device. Signed-off-by: Jingoo Han Acked-by: Sonic Zhang --- drivers/mmc/host/mmc_spi.c |8 1 file

[PATCH 18/39] mmc: dw_mmc-pci: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-02 Thread Jingoo Han
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han --- drivers/mmc/host/dw_mmc-pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-pci.c index f70546a..6a

[PATCH] mmc: sdhci-pci: remove unnecessary pci_set_drvdata()

2013-10-02 Thread Jingoo Han
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host

[PATCH 1/2] mmc: mmc_spi: use spi_get_drvdata() and spi_set_drvdata()

2013-10-02 Thread Jingoo Han
Use the wrapper functions for getting and setting the driver data using spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we can directly pass a struct spi_device. Signed-off-by: Jingoo Han Acked-by: Sonic Zhang --- drivers/mmc/host/mmc_spi.c |8 1 file

[PATCH 2/2] mmc: mmc_spi: remove unnecessary spi_set_drvdata()

2013-10-02 Thread Jingoo Han
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/mmc/host/mmc_spi.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host

[PATCH] mmc: sdhci-pci: remove unnecessary pci_set_drvdata()

2013-09-22 Thread Jingoo Han
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host

[PATCH] mmc: mvsdio: use devm_ioremap_resource() instead of devm_request_and_ioremap()

2013-09-01 Thread Jingoo Han
Use devm_ioremap_resource() because devm_request_and_ioremap() is obsoleted by devm_ioremap_resource(). Signed-off-by: Jingoo Han --- drivers/mmc/host/mvsdio.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c

[PATCH RESEND] mmc: mmc_spi: use spi_get_drvdata() and spi_set_drvdata()

2013-08-20 Thread Jingoo Han
Use the wrapper functions for getting and setting the driver data using spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we can directly pass a struct spi_device. This is a cosmetic change in order to enhance the readability and make the code simpler. Signed-off-by: Jin

[PATCH] mmc: dw_mmc-pltfm: include 'dw_mmc-pltfm.h'

2013-08-05 Thread Jingoo Han
_pmops' was not declared. Should it be static? drivers/mmc/host/dw_mmc-pltfm.c:118:5: warning: symbol 'dw_mci_pltfm_remove' was not declared. Should it be static? Suggested-by: Dan Carpenter Signed-off-by: Jingoo Han --- drivers/mmc/host/dw_mmc-pltfm.c |1 + 1 file changed,

Re: [PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-08-05 Thread Jingoo Han
On Friday, August 02, 2013 5:34 PM, Dan Carpenter wrote: > On Fri, Aug 02, 2013 at 09:11:19AM +0900, Jingoo Han wrote: > > On Friday, August 02, 2013 1:19 AM, Dinh Nguyen wrote: [...] > > > drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol > > > 'dw_mci_

Re: [PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-08-01 Thread Jingoo Han
On Friday, August 02, 2013 1:19 AM, Dinh Nguyen wrote: > On Thu, 2013-08-01 at 15:30 +0900, Jingoo Han wrote: > > dw_mci_socfpga_probe() is used only in this file. > > Fix the following sparse warning: > > > > drivers/mmc/host/dw_mmc-socfpga.c:116:5: warning: symbol >

Re: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA

2013-08-01 Thread Jingoo Han
onfig SOC_IMX6Q 804:select MFD_SYSCON 813: config SOC_IMX6SL 825:select MFD_SYSCON (./drivers/regulator/Kconfig) 90: config REGULATOR_ANATOP 91:tristate "Freescale i.MX on-chip ANATOP LDO regulators" 92:depends on MFD_SYSCON Best regards, Jingoo Han > > Dinh >

[PATCH 2/2] mmc: vub300: Staticize vub300_init_card()

2013-07-31 Thread Jingoo Han
vub300_init_card() is used only in this file. Fix the following sparse warning: drivers/mmc/host/vub300.c:2082:6: warning: symbol 'vub300_init_card' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/mmc/host/vub300.c |2 +- 1 file changed, 1 inser

[PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-07-31 Thread Jingoo Han
dw_mci_socfpga_probe() is used only in this file. Fix the following sparse warning: drivers/mmc/host/dw_mmc-socfpga.c:116:5: warning: symbol 'dw_mci_socfpga_probe' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/mmc/host/dw_mmc-socfpga.c |2 +- 1 fi

[PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA

2013-07-31 Thread Jingoo Han
Added missing MFD_SYSCON dependency for SOCFPGA in order to fix the following link error. drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible' Signed-off-by: Jingoo Han --- drivers/mmc/host/Kconfig |2 +- 1 file changed, 1 insertion(

[PATCH 28/35] mmc: host: use dev_get_platdata()

2013-07-30 Thread Jingoo Han
Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. Signed-off-by: Jingoo Han --- drivers/mmc/host/atmel-mci.c |4 ++-- drivers/mmc/host/au1xmmc.c |2 +- drivers/mmc/host/bfin_sdh.c|2 +- drivers/mmc/h

[PATCH] mmc: mmc_test: replace strict_strtol() with kstrtol_from_user()

2013-07-19 Thread Jingoo Han
The usage of strict_strtol() is not preferred, because strict_strtol() is obsolete. Thus, kstrtol() should be used. Also, both kstrtol() and copy_from_user() can be replaced with kstrtol_from_user() to make the code simpler. Signed-off-by: Jingoo Han --- drivers/mmc/card/mmc_test.c | 14

[PATCH V2] mmc: host: use platform_{get,set}_drvdata()

2013-06-02 Thread Jingoo Han
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Jingoo Han Acked-by: Michał Mirosław --- Changes since v1: - Fixed the

Re: [PATCH] mmc: host: use platform_{get,set}_drvdata()

2013-06-02 Thread Jingoo Han
On Monday, June 03, 2013 10:39 AM, Michał Mirosław wrote: > On Sat, Jun 01, 2013 at 02:16:22PM +0900, Jingoo Han wrote: > > Use the wrapper functions for getting and setting the driver data using > > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,

[PATCH] mmc: host: use platform_{get,set}_drvdata()

2013-05-31 Thread Jingoo Han
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Jingoo Han --- drivers/mmc/host/cb710-mmc.c |2 +- drivers/m

Re: [PATCH] mmc: sdhci-acpi: fix error return code in sdhci_acpi_add_own_cd()

2013-05-27 Thread Jingoo Han
On Tuesday, May 28, 2013 2:26 PM, Wei Yongjun wrote: > > From: Wei Yongjun > > Fix to return a negative error code in the gpio_to_irq() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun It looks good. Reviewed-

Re: [PATCH V2] drivers: mmc: host: use devm_ioremap_resource()

2013-05-16 Thread Jingoo Han
rent Navet Reviewed-by: Jingoo Han --- > drivers/mmc/host/mvsdio.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > index 8960fc8..a66ee4b 100644 > --- a/drivers/mmc/host/mvsdio.c > +++ b

Re: [PATCH] drivers: mmc: host: use devm_ioremap_resource()

2013-05-13 Thread Jingoo Han
_ioremap_resource.cocci > > Signed-off-by: Laurent Navet It looks good. Reviewed-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/mmc/host/mvsdio.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/mvsdio.c b/driver

[PATCH 14/22] mmc: rtsx_pci_sdmmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/rtsx_pci_sdmmc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c index ad13f42..82a35b9 100644 --- a/drivers/mmc/host/rtsx_pci_sdmmc.c +++ b/drivers/mmc/host

Re: [PATCH 04/22] mmc: bfin_sdh: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
On Monday, May 06, 2013 3:21 PM, Zhang, Sonic wrote: > > Acked-by: Sonic Zhang Thank you for your Acked-by. :) Best regards, Jingoo Han > > >-Original Message- > >From: Jingoo Han [mailto:jg1@samsung.com] > >Sent: Monday, May 06, 2013 2:12 PM > >

[PATCH 22/22] mmc: wmt-sdmmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/wmt-sdmmc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c index 442f576..34231d5 100644 --- a/drivers/mmc/host/wmt-sdmmc.c +++ b/drivers/mmc/host/wmt-sdmmc.c @@ -927,8 +927,6

[PATCH 21/22] mmc: tmio_mmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/tmio_mmc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c index 139212e..8860d4d 100644 --- a/drivers/mmc/host/tmio_mmc.c +++ b/drivers/mmc/host/tmio_mmc.c @@ -112,8 +112,6 @@ static

[PATCH 20/22] mmc: sh_mmcif: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/sh_mmcif.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index ba76a53..117a1f7 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -1501,8 +1501,6 @@ static

[PATCH 19/22] mmc: sdhci-spear: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/sdhci-spear.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c index 7ae5b3a..2dba9f8 100644 --- a/drivers/mmc/host/sdhci-spear.c +++ b/drivers/mmc/host/sdhci-spear.c @@ -258,7

[PATCH 18/22] mmc: sdhci-s3c: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/sdhci-s3c.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index c6f6246..926aaf6 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -745,7 +745,6

[PATCH 17/22] mmc: sdhci-pxa: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/sdhci-pxav2.c |2 -- drivers/mmc/host/sdhci-pxav3.c |2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav2.c b/drivers/mmc/host/sdhci-pxav2.c index 6a3f702..98b5145 100644 --- a/drivers/mmc/host/sdhci-pxav2.c +++ b

[PATCH 16/22] mmc: sdhci-pltfm: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/sdhci-pltfm.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index cd0f1f6..252d1ce 100644 --- a/drivers/mmc/host/sdhci-pltfm.c +++ b/drivers/mmc/host/sdhci-pltfm.c @@ -197,7

[PATCH 15/22] mmc: sdhci-acpi: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/sdhci-acpi.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c index 7bcf74b..8e6c4da 100644 --- a/drivers/mmc/host/sdhci-acpi.c +++ b/drivers/mmc/host/sdhci-acpi.c @@ -211,7 +211,6

mmc: rtsx_pci_sdmmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/rtsx_pci_sdmmc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c index ad13f42..82a35b9 100644 --- a/drivers/mmc/host/rtsx_pci_sdmmc.c +++ b/drivers/mmc/host

[PATCH 13/22] mmc: pxamci: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/pxamci.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index 2b2f65a..847b199 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -834,8 +834,6 @@ static int

[PATCH 12/22] mmc: omap_hsmmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/omap_hsmmc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 6e44025..61bb87a 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -2034,7 +2034,6

[PATCH 11/22] mmc: omap: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/omap.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 4254975..4b3e0eb 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -1500,8 +1500,6 @@ static int mmc_omap_remove

[PATCH 10/22] mmc: mxs-mmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/mxs-mmc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 4278a17..d38f0da 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -708,8 +708,6 @@ static int

[PATCH 09/22] mmc: mxcmmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/mxcmmc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c index d503635..786448a 100644 --- a/drivers/mmc/host/mxcmmc.c +++ b/drivers/mmc/host/mxcmmc.c @@ -1219,8 +1219,6 @@ static int

[PATCH 08/22] mmc: mvsdio: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/mvsdio.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c index 8960fc8..d08fe6a 100644 --- a/drivers/mmc/host/mvsdio.c +++ b/drivers/mmc/host/mvsdio.c @@ -827,7 +827,6 @@ static int __exit

[PATCH 07/22] mmc: jz4740_mmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/jz4740_mmc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c index 2391c6b..1c47b34 100644 --- a/drivers/mmc/host/jz4740_mmc.c +++ b/drivers/mmc/host/jz4740_mmc.c @@ -932,7 +932,6

[PATCH 06/22] mmc: dw_mmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/dw_mmc-pltfm.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/host/dw_mmc-pltfm.c index 41c27b7..37873f1 100644 --- a/drivers/mmc/host/dw_mmc-pltfm.c +++ b/drivers/mmc/host/dw_mmc-pltfm.c @@ -72,7

[PATCH 05/22] mmc: davinci_mmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/davinci_mmc.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 3946a0e..b1b8202 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -1406,7

[PATCH 04/22] mmc: bfin_sdh: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/bfin_sdh.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c index fb4348c..94fae2f 100644 --- a/drivers/mmc/host/bfin_sdh.c +++ b/drivers/mmc/host/bfin_sdh.c @@ -621,8 +621,6 @@ static

[PATCH 03/22] mmc: au1xmmc: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/au1xmmc.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c index 127a8fa..df9becd 100644 --- a/drivers/mmc/host/au1xmmc.c +++ b/drivers/mmc/host/au1xmmc.c @@ -1149,7 +1149,6 @@ static int

[PATCH 02/22] mmc: atmel-mci: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/atmel-mci.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index e75774f..70fa449 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -2476,8 +2476,6

[PATCH 01/22] mmc: android-goldfish: remove unnecessary platform_set_drvdata()

2013-05-05 Thread Jingoo Han
: Jingoo Han --- drivers/mmc/host/android-goldfish.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/android-goldfish.c b/drivers/mmc/host/android-goldfish.c index 7780c14..8b4e20a 100644 --- a/drivers/mmc/host/android-goldfish.c +++ b/drivers/mmc/host/android

[PATCH V2] mmc: atmel-mci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-04-29 Thread Jingoo Han
spend' defined but not used [-Wunused-function] drivers/mmc/host/atmel-mci.c:2539:12: warning: 'atmci_resume' defined but not used [-Wunused-function] Acked-by: Ludovic Desroches Signed-off-by: Jingoo Han --- Changes since v1: - added Ludovic Desroches's Acked-by - re-b

[PATCH] mmc: mmc_spi: use spi_get_drvdata() and spi_set_drvdata()

2013-04-05 Thread Jingoo Han
Use the wrapper functions for getting and setting the driver data using spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we can directly pass a struct spi_device. Signed-off-by: Jingoo Han --- drivers/mmc/host/mmc_spi.c |8 1 files changed, 4 insertion

[PATCH 2/2] mmc: sdhci-spear: add CONFIG_PM_SLEEP to suspend/resume functions

2013-03-29 Thread Jingoo Han
: 'sdhci_suspend' defined but not used [-Wunused-function] drivers/mmc/host/sdhci-spear.c:308:12: warning: 'sdhci_resume' defined but not used [-Wunused-function] Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-spear.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH 1/2] mmc: atmel-mci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-03-29 Thread Jingoo Han
spend' defined but not used [-Wunused-function] drivers/mmc/host/atmel-mci.c:2556:12: warning: 'atmci_resume' defined but not used [-Wunused-function] Signed-off-by: Jingoo Han --- drivers/mmc/host/atmel-mci.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-)

[PATCH v3] mmc: sdhci-s3c: Use devm_clk_get()

2013-03-06 Thread Jingoo Han
Use devm_clk_get() rather than clk_get() to make cleanup paths more simple. Reviewed-by: Ulf Hansson Acked-by: Jaehoon Chung Signed-off-by: Jingoo Han --- Changes since v2: - added Ulf Hansson's Reviewed-by - added Jaehoon Chung's Acked-by Changes since v1: - modified the comm

[PATCH 2/2] mmc: mvsdio: use module_platform_driver_probe()

2013-03-04 Thread Jingoo Han
This patch uses module_platform_driver_probe() macro which makes the code smaller and simpler. Signed-off-by: Jingoo Han --- drivers/mmc/host/mvsdio.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c

[PATCH 1/2] mmc: davinci_mmc: use module_platform_driver_probe()

2013-03-04 Thread Jingoo Han
This patch uses module_platform_driver_probe() macro which makes the code smaller and simpler. Signed-off-by: Jingoo Han --- drivers/mmc/host/davinci_mmc.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host

[PATCH v2 RESEND] mmc: sdhci-s3c: Use devm_clk_get()

2013-02-11 Thread Jingoo Han
Use devm_clk_get() rather than clk_get() to make cleanup paths more simple. Signed-off-by: Jingoo Han --- Changes since v1: - modified the commit message drivers/mmc/host/sdhci-s3c.c | 17 ++--- 1 files changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/mmc/host

[PATCH v2] mmc: sdhci-s3c: Use devm_clk_get()

2013-01-09 Thread Jingoo Han
Use devm_clk_get() rather than clk_get() to make cleanup paths more simple. Signed-off-by: Jingoo Han --- Changes since v1: - modified the commit message drivers/mmc/host/sdhci-s3c.c | 17 ++--- 1 files changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/mmc/host

[PATCH] mmc: sdhci-s3c: Use devm_clk_get()

2013-01-08 Thread Jingoo Han
The devm_ functions allocate memory that is released when a driver detaches. This patch uses devm_clk_get() for these functions. These make the code smaller and a bit simpler. Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-s3c.c | 17 ++--- 1 files changed, 2 insertions

[PATCH] mmc: sdhci-s3c: fix checkpatch error and warnings

2012-08-28 Thread Jingoo Han
single statement blocks Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-s3c.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index a50c205..00969ba 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b

RE: [PATCH] mmc: sdhci-s3c: use dev_pm_ops

2011-12-13 Thread Jingoo Han
ver power management. > > Signed-off-by: Jingoo Han > --- > drivers/mmc/host/sdhci-s3c.c | 19 +-- > 1 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index cb60c41..5272c74

[PATCH] mmc: sdhci-s3c: use dev_pm_ops

2011-12-13 Thread Jingoo Han
Instead of using legacy suspend/resume methods, using newer dev_pm_ops structure allows better control over power management. Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-s3c.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host

[PATCH] mmc: sdhci-s3c: use S3C_SDHCI_CONTROL2 instead of hardcoded offeset value

2011-12-13 Thread Jingoo Han
Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-s3c.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index cb60c41..62ff6b4 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c

[PATCH] mmc: sdhci-s3c: fix checkpatch error and warning

2011-12-13 Thread Jingoo Han
This patch fixes the checkpatch error and warning listed below: ERROR: return is not a function, parentheses are not required WARNING: line over 80 characters Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-s3c.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a