[PATCH v4] mmc: moxart: fix probe logic

2015-02-03 Thread Jonas Jensen
From: Arnd Bergmann Jonas Jensen wanted to submit a patch for these, but apparently forgot about it. I stumbled over this symptom first: drivers/built-in.o: In function `moxart_probe': :(.text+0x2af128): undefined reference to `of_dma_request_slave_channel' This

[PATCH v3] mmc: moxart: fix probe logic

2015-02-02 Thread Jonas Jensen
Jonas Jensen wanted to submit a patch for these, but apparently forgot about it. I stumbled over this symptom first: drivers/built-in.o: In function `moxart_probe': :(.text+0x2af128): undefined reference to `of_dma_request_slave_channel' This is because of_dma_request_slave_cha

Re: [PATCH v2] mmc: moxart: fix probe logic

2015-02-02 Thread Jonas Jensen
Thanks for taking the time. On 29 January 2015 at 23:06, Arnd Bergmann wrote: > Jonas Jensen wanted to submit a patch for these, but apparently > forgot about it. I stumbled over this symptom first: Sorry about this, I remember thinking about the changes but only made a mental note (whi

Re: mmc: moxart: Add MOXA ART SD/MMC driver

2014-05-21 Thread Jonas Jensen
On 21 May 2014 14:28, Dan Carpenter wrote: > Hello Jonas Jensen, > > The patch 1b66e94e6b99: "mmc: moxart: Add MOXA ART SD/MMC driver" > from Apr 9, 2014, leads to the following static checker warning: > > drivers/mmc/host/moxart-mmc.c:691 moxart_remov

[PATCH v8] mmc: moxart: Add MOXA ART SD/MMC driver

2014-04-09 Thread Jonas Jensen
Add SD/MMC driver for MOXA ART SoCs. The "MOXA ART MMC controller" is likely a faraday "ftsdc010", a controller with support in U-Boot: http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/mmc/ftsdc010_mci.c Signed-off-by: Jonas Jensen --- Notes: This has been cleaned up

[PATCH v7] mmc: moxart: Add MOXA ART SD/MMC driver

2014-01-21 Thread Jonas Jensen
Add SD/MMC driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: v6 was supposed to fix a panic from dmaengine_tx_status() but it still happened. This is the sort of panic that lasts between reboots but not between kernel reflash. dmaengine_tx_status() is used

[PATCH v6] mmc: sdhci-moxart: Add MOXA ART SDHCI driver

2014-01-17 Thread Jonas Jensen
Add SDHCI driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: Changes in v6 fixes a kernel panic in moxart_dma_complete(). Panic only happens with CONFIG_SLAB or CONFIG_SLOB, the same code works for CONFIG_SLUB, and happens because a cookie belonging to the

[PATCH v5] mmc: sdhci-moxart: Add MOXA ART SDHCI driver

2013-12-11 Thread Jonas Jensen
Add SDHCI driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: Changes since v4: 1. remove dma_chan_cur pointer from host structure 2. add local dma_chan_cur pointer in moxart_transfer_dma() 3. add dma_async_tx_descriptor pointer (host structure) 4. save

[PATCH v4] mmc: sdhci-moxart: Add MOXA ART SDHCI driver

2013-08-06 Thread Jonas Jensen
Add SDHCI driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: Changes since v3: 1. don't rely on structs for register offsets 2. use DT probed DMA, remove extern bool moxart_filter_fn() 3. remove unnecessary ternary operator in moxart_get_ro 4. check r

[PATCH v3] mmc: sdhci-moxart: Add MOXA ART SDHCI driver

2013-07-29 Thread Jonas Jensen
Add SDHCI driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: Changes since v2: 1. #include because BIT() comes from there 2. reinsert dev_set_drvdata() in moxart_remove 3. remove MODULE_VERSION() device tree bindings document: 4. describe

[PATCH v2] mmc: sdhci-moxart: Add MOXA ART SDHCI driver

2013-07-17 Thread Jonas Jensen
Add SDHCI driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: Changes since v1: 1. remove IRQF_DISABLED 2. use devm_request_irq, remove free_irq 3. remove unnecessary dev_set_drvdata in moxart_remove 4. add devicetree bindings document 5. use BIT macro

[PATCH] mmc: sdhci-moxart: Add MOXA ART SDHCI driver

2013-07-10 Thread Jonas Jensen
Add SDHCI driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: Applies to next-20130703 I know this is a large chunk and there are many pitfalls with the controller. I give you my word it does work / seem to be stable, with or without DMA. Any feedback is

Re: [PATCH] ARM: mach-moxart: platform port for MOXA ART SoC

2013-03-17 Thread Jonas Jensen
Thank you for the feedback. Some of the changes are sure to be a challenge for me, but I want to move this forward, and having a list helps. 3.2.40 is as far as it'll go right now, nothing prints to UART starting with 3.3.8 (last tested, it's somewhere around there). I have been advised to enabl

[PATCH] ARM: mach-moxart: platform port for MOXA ART SoC

2013-03-13 Thread Jonas Jensen
Hi, I ask for feedback and to submit (if possible) a new ARM SoC platform port. This is now near complete (I think) (tested on UC-7112-LX Plus) and applies to 2.6.34.14. The patch contains the following drivers and platform specific implementations: * ARCH_MOXART (FA526 processor) * 100Hz interr