Re: [PATCH] mmc: sdhci-of-arasan: Get quirks from device tree

2015-07-27 Thread Lars-Peter Clausen
On 07/27/2015 10:04 AM, Shawn Lin wrote: This patch adds the interface to get quirks from dts, and there is no need to assign different quirks by condition statement of arasan IP version. Signed-off-by: Shawn Lin --- drivers/mmc/host/sdhci-of-arasan.c | 7 +++ 1 file changed, 7 insertio

[PATCH 1/2] mmc: sdhci: Add quirk to disable write-protect detection

2015-04-28 Thread Lars-Peter Clausen
-protect status when set. Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/sdhci.c | 3 +++ drivers/mmc/host/sdhci.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index c80287a..7448757 100644 --- a/drivers/mmc/host/sdhci.c +++ b

[PATCH 2/2] mmc: sdhci: DT: Allow to specify that no write protect signal is present

2015-04-28 Thread Lars-Peter Clausen
signal is connected. The name for the new property is 'disable-wp' and was chosen based on the property with the same function from the Synopsys designware mobile storage host controller DT bindings specification. Signed-off-by: Lars-Peter Clausen Cc: Rob Herring Cc: Pawel Moll Cc: Mark R

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-07 Thread Lars-Peter Clausen
On 01/07/2015 05:13 PM, Arnd Bergmann wrote: On Wednesday 07 January 2015 15:29:36 Lars-Peter Clausen wrote: On 01/06/2015 02:48 PM, Arnd Bergmann wrote: On Tuesday 06 January 2015 11:45:58 Lars-Peter Clausen wrote: On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-07 Thread Lars-Peter Clausen
On 01/06/2015 02:48 PM, Arnd Bergmann wrote: On Tuesday 06 January 2015 11:45:58 Lars-Peter Clausen wrote: On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Lars-Peter Clausen
On 01/06/2015 01:47 PM, Måns Rullgård wrote: Lars-Peter Clausen writes: On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use is really incompatible with the

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Lars-Peter Clausen
On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use is really incompatible with the way that other drivers use the dmaengine API, so we should get rid of it. Do

Re: [PATCH] mmc: jz4740: don't wait for PRG_DONE after stop command with R1 response

2014-04-29 Thread Lars-Peter Clausen
er sending the stop command: it will not get raised when the busy flag is not set, causing the request to fail with a timeout. Signed-off-by: Alex Smith Cc: Lars-Peter Clausen Cc: Ulf Hansson Cc: Chris Ball Cc: James Hogan Acked-by: Ulf Hansson Acked-by: Lars-Peter Clausen -- To unsubs

Re: [PATCH v2 03/16] ARM: dts: provide DMA config to pxamci

2013-12-16 Thread Lars-Peter Clausen
On 12/16/2013 12:47 PM, Sergei Ianovich wrote: > On Mon, 2013-12-16 at 10:58 +0100, Daniel Mack wrote: >> On 12/14/2013 08:34 PM, Sergei Ianovich wrote: >>> On Sat, 2013-12-14 at 20:06 +0100, Arnd Bergmann wrote: >> The patch looks ok in case we are merging your patches for 3.14 and Danie

Re: [PATCH] mmc: jz4740: simplify use of SIMPLE_DEV_PM_OPS

2013-08-19 Thread Lars-Peter Clausen
remove the JZ4740_MMC_PM_OPS indirection. Compile tested with CONFIG_PM_SLEEP enabled and disabled. Signed-off-by: James Hogan Cc: Lars-Peter Clausen Cc: Chris Ball Cc: linux-mmc@vger.kernel.org Nack, the generated code is not the same. --- drivers/mmc/host/jz4740_mmc.c | 7 ++- 1 file

Re: [PATCH] dma: edma: add device_slave_caps() support

2013-07-24 Thread Lars-Peter Clausen
On 07/24/2013 08:55 PM, Joel Fernandes wrote: On 07/24/2013 03:40 AM, Lars-Peter Clausen wrote: On 07/24/2013 10:28 AM, Fernandes, Joel wrote: On Jul 24, 2013, at 3:23 AM, "Lars-Peter Clausen" wrote: On 07/24/2013 10:11 AM, Joel Fernandes wrote: On 07/24/2013 03:03 AM, Lars-Pet

Re: [PATCH] dma: edma: add device_slave_caps() support

2013-07-24 Thread Lars-Peter Clausen
On 07/24/2013 10:28 AM, Fernandes, Joel wrote: > > On Jul 24, 2013, at 3:23 AM, "Lars-Peter Clausen" wrote: > >> On 07/24/2013 10:11 AM, Joel Fernandes wrote: >>> On 07/24/2013 03:03 AM, Lars-Peter Clausen wrote: >>>> On 07/23/2013 0

Re: [PATCH] dma: edma: add device_slave_caps() support

2013-07-24 Thread Lars-Peter Clausen
On 07/24/2013 10:11 AM, Joel Fernandes wrote: > On 07/24/2013 03:03 AM, Lars-Peter Clausen wrote: >> On 07/23/2013 06:43 PM, Joel Fernandes wrote: >>> Implement device_slave_caps(). EDMA has a limited number of slots. >>> Slave drivers such as omap_hsmmc will query the d

Re: [PATCH] dma: edma: add device_slave_caps() support

2013-07-24 Thread Lars-Peter Clausen
On 07/23/2013 06:43 PM, Joel Fernandes wrote: > Implement device_slave_caps(). EDMA has a limited number of slots. > Slave drivers such as omap_hsmmc will query the driver to make > sure they don't pass in more than these many scatter segments. > > Signed-off-by: Joel Fernandes > --- > Vinod, or

[PATCH 2/6] mmc: JZ4740: Remove duplicated code.

2013-06-09 Thread Lars-Peter Clausen
From: Paul Cercueil Signed-off-by: Paul Cercueil Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/jz4740_mmc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c index c4f3872..b31359d 100644 --- a/drivers/mmc/host

[PATCH 1/6] mmc: jz4740: Use clk_prepare_enable/clk_disable_unprepare

2013-06-09 Thread Lars-Peter Clausen
In preparation to switching the jz4740 clk driver to the common clk framework update the clk enable/disable calls to clk_prepare_enable/clk_disable_unprepare. Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/jz4740_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 6/6] mmc: jz4740: Use managed resources

2013-06-09 Thread Lars-Peter Clausen
Use managed resources for the mmio memory region and the clock. Makes the code a bit shorter. Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/jz4740_mmc.c | 37 ++--- 1 file changed, 6 insertions(+), 31 deletions(-) diff --git a/drivers/mmc/host

[PATCH 5/6] mmc: jz4740: Use slot-gpio helpers

2013-06-09 Thread Lars-Peter Clausen
Use the slot-gpio helpers to handle the write protect and card detect GPIO pins instead of re-implementing the same functionality in the driver. Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/jz4740_mmc.c | 113 +- 1 file changed, 23 insertions

[PATCH 4/6] mmc: jz4740: Use SIMPLE_DEV_PM_OPS

2013-06-09 Thread Lars-Peter Clausen
It's a bit shorter than open-conding it. While we are at it also make jz4740_mmc_pm_ops static. Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/jz4740_mmc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc

[PATCH 3/6] mmc: jz4740: Fix handling of read errors.

2013-06-09 Thread Lars-Peter Clausen
From: Paul Cercueil For no reason, the code handling write errors was implemented while the code handling read errors was missing. Signed-off-by: Paul Cercueil Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/jz4740_mmc.c | 8 1 file changed, 8 insertions(+) diff --git a

[PATCH] mmc: jz4740: Use clk_prepare_enable/clk_disable_unprepare

2013-05-12 Thread Lars-Peter Clausen
In preparation to switching the jz4740 clk driver to the common clk framework update the clk enable/disable calls to clk_prepare_enable/clk_disable_unprepare. Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/jz4740_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v3 3/3] mmc: sdhci: Constify sdhci_ops structs where possible

2013-03-13 Thread Lars-Peter Clausen
optional_qualifier@ identifier ops != r1.ops; @@ static +const struct sdhci_ops ops = { ... }; // Signed-off-by: Lars-Peter Clausen Acked-by: Shawn Guo --- drivers/mmc/host/sdhci-bcm2835.c | 2 +- drivers/mmc/host/sdhci-cns3xxx.c | 2 +- drivers/mmc/host/sdhci-dove.c | 2 +- drivers/mmc

[PATCH v3 2/3] mmc: sdhci-pltfm: Constify the ops field of sdhci_pltfm_data struct

2013-03-13 Thread Lars-Peter Clausen
allows us to declare sdhci_ops structs as const in drivers using the sdhci-pltfm helper code. Signed-off-by: Lars-Peter Clausen Acked-by: Shawn Guo --- drivers/mmc/host/sdhci-pltfm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host

[PATCH v3 1/3] mmc: sdhci_pltfm: Constify sdhci_pltfm_data

2013-03-13 Thread Lars-Peter Clausen
possible. Signed-off-by: Lars-Peter Clausen Acked-by: Shawn Guo --- Changes since v2: * Also make sdhci_tegra114_pdata const --- drivers/mmc/host/sdhci-bcm2835.c | 2 +- drivers/mmc/host/sdhci-cns3xxx.c | 2 +- drivers/mmc/host/sdhci-dove.c | 2 +- drivers/mmc/host/sdhci-esdhc

[PATCH 2/3] mmc: sdhci-pltfm: Constify the ops field of sdhci_pltfm_data struct

2013-03-12 Thread Lars-Peter Clausen
allows us to declare sdhci_ops structs as const in drivers using the sdhci-pltfm helper code. Signed-off-by: Lars-Peter Clausen Acked-by: Shawn Guo --- drivers/mmc/host/sdhci-pltfm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host

[PATCH 3/3] mmc: sdhci: Constify sdhci_ops structs where possible

2013-03-12 Thread Lars-Peter Clausen
optional_qualifier@ identifier ops != r1.ops; @@ static +const struct sdhci_ops ops = { ... }; // Signed-off-by: Lars-Peter Clausen Acked-by: Shawn Guo --- drivers/mmc/host/sdhci-bcm2835.c | 2 +- drivers/mmc/host/sdhci-cns3xxx.c | 2 +- drivers/mmc/host/sdhci-dove.c | 2 +- drivers/mmc

[PATCH 1/3] mmc: sdhci_pltfm: Constify sdhci_pltfm_data

2013-03-12 Thread Lars-Peter Clausen
possible. Signed-off-by: Lars-Peter Clausen Acked-by: Shawn Guo --- No changes since the last submission, just rebased onto of the latest mmc-next --- drivers/mmc/host/sdhci-bcm2835.c | 2 +- drivers/mmc/host/sdhci-cns3xxx.c | 2 +- drivers/mmc/host/sdhci-dove.c | 2 +- drivers/mmc/host

Re: [PATCH v4 1/3] dmaengine: add dma_get_slave_sg_limits()

2013-03-11 Thread Lars-Peter Clausen
[...] > * struct with auxiliary transfer status information, otherwise the call > * will just return a simple status code > * @device_issue_pending: push pending transactions to hardware > + * @device_slave_sg_limits: return the slave SG capabilities > */ > struct dma_device { > > @@

[PATCH 3/3] mmc: sdhci: Constify sdhci_ops structs where possible

2013-02-14 Thread Lars-Peter Clausen
optional_qualifier@ identifier ops != r1.ops; @@ static +const struct sdhci_ops ops = { ... }; // Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/sdhci-bcm2835.c | 2 +- drivers/mmc/host/sdhci-cns3xxx.c | 2 +- drivers/mmc/host/sdhci-dove.c | 2 +- drivers/mmc/host/sdhci-esdhc

[PATCH 2/3] mmc: sdhci-pltfm: Constify the ops field of sdhci_pltfm_data struct

2013-02-14 Thread Lars-Peter Clausen
allows us to declare sdhci_ops structs as const in drivers using the sdhci-pltfm helper code. Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/sdhci-pltfm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h index

[PATCH 1/3] mmc: sdhci_pltfm: Constify sdhci_pltfm_data

2013-02-14 Thread Lars-Peter Clausen
possible. Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/sdhci-bcm2835.c | 2 +- drivers/mmc/host/sdhci-cns3xxx.c | 2 +- drivers/mmc/host/sdhci-dove.c | 2 +- drivers/mmc/host/sdhci-esdhc-imx.c | 2 +- drivers/mmc/host/sdhci-of-esdhc.c | 2 +- drivers/mmc/host/sdhci-of-hlwd.c

Re: [PATCH] mmc: sdhci-pltfm: Add a common clk API based implementation of get_timeout_clock

2013-01-29 Thread Lars-Peter Clausen
On 01/29/2013 06:45 AM, Stephen Warren wrote: > On 01/28/2013 11:27 AM, Lars-Peter Clausen wrote: >> Quite a few drivers have a implementation of the get_timeout_clock callback >> which simply returns the result of clk_get_rate on devices clock. This patch >> adds a common i

[PATCH] mmc: sdhci-pltfm: Add a common clk API based implementation of get_timeout_clock

2013-01-28 Thread Lars-Peter Clausen
-Peter Clausen --- I've only runtime tested this patch on a platform which is not yet upstream. For the drivers which are modified in this patch I've only done compile time testing. But I think all changes, but maybe the bcm2835 one, are straight forward. --- drivers/mmc/host/sdhci-bcm283

[PATCH 07/11] mmc: Remove redundant spi driver bus initialization

2011-11-24 Thread Lars-Peter Clausen
; @@ struct spi_driver _driver = { .driver = { - .bus = &spi_bus_type, }, }; // Signed-off-by: Lars-Peter Clausen Cc: Chris Ball Cc: linux-mmc@vger.kernel.org --- drivers/mmc/host/mmc_spi.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dri

Re: [PATCH] mmc: fix handling NULL returned from regulator_get()

2011-05-18 Thread Lars-Peter Clausen
On 05/18/2011 02:47 PM, Chris Ball wrote: > Hi Antonio, thanks for doing this, > > On Wed, May 18 2011, Antonio Ospite wrote: >> When regulator_get() is stubbed down it returns NULL, handle this case >> when deciding whether the driver can use the regulator or not. >> >> Remember: IS_ERR(NULL) is

Re: [PATCH] mmc: sdhci: Conditionalize regulator_get() on CONFIG_REGULATOR

2011-04-30 Thread Lars-Peter Clausen
On 04/30/2011 06:35 AM, Chris Ball wrote: > The regulator subsystem provides stubbed out versions of its calls that > are always present (so that they can be used without needing #ifdefs). > But the regulator_get() stub always returns an error value according > to IS_ERR(), which leads sdhci to pri

Re: [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'

2011-03-30 Thread Lars-Peter Clausen
On 03/29/2011 03:57 AM, Chris Ball wrote: > Hi Shawn, > > On Mon, Mar 28 2011, Shawn Guo wrote: >> Hi Chris, >> >> Any comment on this one? > > Yep, I'll push it to mmc-next once -rc1 is released. > > Thanks, > > - Chris. That patch doesn't make much sense. The config options are used to decid

[PATCH] MMC: jz4740: Fixed card change detection.

2010-08-03 Thread Lars-Peter Clausen
From: Maarten ter Huurne The GPIO validity check was reversed. Also removed some dead code. Signed-off-by: Maarten ter Huurne Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/jz4740_mmc.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host

Re: [PATCH v6] MMC: Add JZ4740 mmc driver

2010-07-15 Thread Lars-Peter Clausen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Morton wrote: > On Thu, 15 Jul 2010 23:06:04 +0200 > Lars-Peter Clausen wrote: > >> This patch adds support for the mmc controller on JZ4740 SoCs. >> >> >> ... >> >> +

[PATCH v6] MMC: Add JZ4740 mmc driver

2010-07-15 Thread Lars-Peter Clausen
This patch adds support for the mmc controller on JZ4740 SoCs. Signed-off-by: Lars-Peter Clausen Acked-by: Matt Fleming Cc: Andrew Morton Cc: Matt Fleming Cc: linux-mmc@vger.kernel.org --- Changes since v1 - Do not request IRQ with IRQF_DISABLED since it is a noop now - Use a generous slack

Re: [PATCH v5] MMC: Add JZ4740 mmc driver

2010-07-12 Thread Lars-Peter Clausen
Hi Joe Perches wrote: > On Tue, 2010-07-13 at 00:20 +0200, Lars-Peter Clausen wrote: >> This patch adds support for the mmc controller on JZ4740 SoCs. >> +static bool jz4740_mmc_write_data(struct jz4740_mmc_host *host, >> +struct mmc_data *data) >> +{ >> +

[PATCH v5] MMC: Add JZ4740 mmc driver

2010-07-12 Thread Lars-Peter Clausen
This patch adds support for the mmc controller on JZ4740 SoCs. Signed-off-by: Lars-Peter Clausen Acked-by: Matt Fleming Cc: Andrew Morton Cc: Matt Fleming Cc: linux-mmc@vger.kernel.org --- Changes since v1 - Do not request IRQ with IRQF_DISABLED since it is a noop now - Use a generous slack

Re: [PATCH v4] MMC: Add JZ4740 mmc driver

2010-07-12 Thread Lars-Peter Clausen
Hi Randy Dunlap wrote: > Lars-Peter Clausen wrote: >> This patch adds support for the mmc controller on JZ4740 SoCs. >> >> Signed-off-by: Lars-Peter Clausen >> Acked-by: Matt Fleming >> Cc: Andrew Morton >> Cc: Matt Fleming >> Cc: linux-mmc@vger.k

[PATCH v4] MMC: Add JZ4740 mmc driver

2010-07-12 Thread Lars-Peter Clausen
This patch adds support for the mmc controller on JZ4740 SoCs. Signed-off-by: Lars-Peter Clausen Acked-by: Matt Fleming Cc: Andrew Morton Cc: Matt Fleming Cc: linux-mmc@vger.kernel.org --- Changes since v1 - Do not request IRQ with IRQF_DISABLED since it is a noop now - Use a generous slack

Re: [PATCH v3] MMC: Add JZ4740 mmc driver

2010-07-01 Thread Lars-Peter Clausen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Matt Fleming wrote: > On Mon, 28 Jun 2010 03:20:41 +0200, Lars-Peter Clausen > wrote: >> This patch adds support for the mmc controller on JZ4740 SoCs. >> >> Signed-off-by: Lars-Peter Clausen >> Cc: Andrew Morton >

Re: [PATCH v3] MMC: Add JZ4740 mmc driver

2010-07-01 Thread Lars-Peter Clausen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Andrew Morton wrote: > On Mon, 28 Jun 2010 03:20:41 +0200 > Lars-Peter Clausen wrote: > >> This patch adds support for the mmc controller on JZ4740 SoCs. >> >> Signed-off-by: Lars-Peter Clausen >> Cc: Andrew M

[PATCH v3] MMC: Add JZ4740 mmc driver

2010-06-27 Thread Lars-Peter Clausen
This patch adds support for the mmc controller on JZ4740 SoCs. Signed-off-by: Lars-Peter Clausen Cc: Andrew Morton Cc: Matt Fleming Cc: linux-mmc@vger.kernel.org --- Changes since v1 - Do not request IRQ with IRQF_DISABLED since it is a noop now - Use a generous slack for the timeout timer

Re: [PATCH v2 18/26] MMC: Add JZ4740 mmc driver

2010-06-19 Thread Lars-Peter Clausen
Hi Matt Fleming wrote: > On Sat, 19 Jun 2010 07:08:23 +0200, Lars-Peter Clausen wrote: >> This patch adds support for the mmc controller on JZ4740 SoCs. >> > > Hey Lars-Peter, > > I had a quick look over this patch and it looks OK. Just a few comments. > >

[PATCH v2 18/26] MMC: Add JZ4740 mmc driver

2010-06-18 Thread Lars-Peter Clausen
This patch adds support for the mmc controller on JZ4740 SoCs. Signed-off-by: Lars-Peter Clausen Cc: Andrew Morton Cc: linux-mmc@vger.kernel.org --- Changes since v1 - Do not request IRQ with IRQF_DISABLED since it is a noop now - Use a generous slack for the timeout timer. It does not need to

[PATCH v2 00/26] Add support for the Ingenic JZ4740 System-on-a-Chip

2010-06-18 Thread Lars-Peter Clausen
@vger.kernel.org Cc: linux-...@lists.infradead.org Cc: linux-...@vger.kernel.org Cc: lm-sens...@lm-sensors.org Cc: rtc-li...@googlegroups.com Lars-Peter Clausen (26): MIPS: Add base support for Ingenic JZ4740 System-on-a-Chip MIPS: jz4740: Add IRQ handler code MIPS: JZ4740: Add clock API support. MIPS

[RFC][PATCH 18/26] MMC: Add JZ4740 mmc driver

2010-06-02 Thread Lars-Peter Clausen
This patch adds support for the mmc controller on JZ4740 SoCs. Signed-off-by: Lars-Peter Clausen Cc: Andrew Morton Cc: linux-mmc@vger.kernel.org --- drivers/mmc/host/Kconfig |8 + drivers/mmc/host/Makefile |1 + drivers/mmc/host/jz4740_mmc.c | 1000

[PATCH resend] s3cmci: s3cmci_card_present: Use no_detect to decide whether there is a card detect pin

2010-02-25 Thread Lars-Peter Clausen
Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/s3cmci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c index b9c96cc..2fdf768 100644 --- a/drivers/mmc/host/s3cmci.c +++ b/drivers/mmc/host/s3cmci.c @@ -1179,7

[PATCH resend] s3cmci: Initialize default platform data no_wprotect and no_detect with 1

2010-02-25 Thread Lars-Peter Clausen
r unusable Previously to the introduction of no_wprotect and no_detect the behavior was to assume that if no platform data was given there is no write protect or card detect pin. This patch restores that behavior. Signed-off-by: Lars-Peter Clausen --- drivers/mmc/host/s3cmci.c |2 ++ 1 files

Re: [PATCH 1/2] s3cmci: Initialize default platform data no_wprotect and no_detect with 1

2010-01-20 Thread Lars-Peter Clausen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Sergei Shtylyov wrote: > Hello. > > Lars-Peter Clausen wrote: > >> If no platform_data was givin to the device it's going to use it's >> default >> platform data struct which has all fields initialized to zer

[PATCH 2/2] s3cmci: s3cmci_card_present: Use no_detect to decide whether there is a card detect pin

2010-01-20 Thread Lars-Peter Clausen
--- drivers/mmc/host/s3cmci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c index b9c96cc..2fdf768 100644 --- a/drivers/mmc/host/s3cmci.c +++ b/drivers/mmc/host/s3cmci.c @@ -1179,7 +1179,7 @@ static int s3cmci_card_p

[PATCH 1/2] s3cmci: Initialize default platform data no_wprotect and no_detect with 1

2010-01-20 Thread Lars-Peter Clausen
If no platform_data was givin to the device it's going to use it's default platform data struct which has all fields initialized to zero. As a result the driver is going to try to request gpio0 both as write protect and card detect pin. Which of course will fail and makes the driver unusable Previ