if the error code returned is not
> -EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER.
>
> Signed-off-by: Peter Ujfalusi
> CC: Laurent Pinchart
> CC: Mauro Carvalho Chehab
> ---
> drivers/media/platform/omap3isp/isphist.c | 12 +---
> 1 file
ar
binding defines generic compatible strings those should be made mandatory by
that binding.
In the MMCIF case, I would propose wording it as
- compatible: must contain one of the following
- "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
- "renesas,mmcif-r8
FC_FUNCTION(audio_clk),
> SH_PFC_FUNCTION(avb),
> @@ -5586,8 +5649,14 @@ static const struct pinmux_cfg_reg
> pinmux_config_regs[] = { { },
> };
>
> +static const struct sh_pfc_soc_operations pinmux_ops = {
> + .get_io_voltage = sdhi_get_io_voltage,
> + .set_io_voltage = sdhi_set_io_voltage,
> +};
> +
> const struct sh_pfc_soc_info r8a7790_pinmux_info = {
> .name = "r8a77900_pfc",
> + .ops = &pinmux_ops,
> .unlock_reg = 0xe606, /* PMMR */
>
> .function = { PINMUX_FUNCTION_BEGIN, PINMUX_FUNCTION_END },
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
and from UHS modes.
>
> Add a flag for pins that have configurable I/O voltage and SoC
> operations to get and set the nominal voltage. Implement the pinconf
> power-source parameter using these operations.
>
> Signed-off-by: Ben Hutchings
Acked-by: Laurent Pinchart
&g
On Tuesday 30 June 2015 08:05:34 Linus Walleij wrote:
> On Mon, Jun 15, 2015 at 4:02 AM, Laurent Pinchart
>
> wrote:
> > On a side note, I have a patch to support the standard "groups",
> > "functions" and "pins" properties instead of the R
> + sh_pfc_write_raw_reg(mapped_reg, 32, data);
> +}
> +
> static const struct sh_pfc_function pinmux_functions[] = {
> SH_PFC_FUNCTION(audio_clk),
> SH_PFC_FUNCTION(avb),
> @@ -5586,8 +5645,14 @@ static const struct pinmux_cfg_reg
> pinmux_config_regs[] =
c;
> +
I don't think this is needed, struct sh_pfc is already forward-declared right
above struct sh_pfc_soc_operations.
> struct sh_pfc_pin {
> u16 pin;
> u16 enum_id;
> @@ -121,6 +125,8 @@ struct sh_pfc_soc_operations {
> unsigned int (*get_bias)(struct
Hi Ben,
On Monday 15 June 2015 01:40:40 Ben Hutchings wrote:
> On Fri, 2015-06-12 at 22:07 +0300, Laurent Pinchart wrote:
> > On Friday 12 June 2015 14:23:55 Ben Hutchings wrote:
> >> On Fri, 2015-06-12 at 10:18 +0300, Laurent Pinchart wrote:
> >>> On Wednesday 10 Ju
Hi Ben,
On Friday 12 June 2015 14:23:55 Ben Hutchings wrote:
> On Fri, 2015-06-12 at 10:18 +0300, Laurent Pinchart wrote:
> > Hi Ben,
> >
> > (CC'ing Linus Walleij)
> >
> > Thank you for the patch.
> >
> > On Wednesday 10 June 2015 00:23:31 Be
4689,14 @@ static const struct sh_pfc_function
> pinmux_functions[] = { SH_PFC_FUNCTION(scifb0),
> SH_PFC_FUNCTION(scifb1),
> SH_PFC_FUNCTION(scifb2),
> - SH_PFC_FUNCTION(sdhi0),
> - SH_PFC_FUNCTION(sdhi1),
> - SH_PFC_FUNCTION(sdhi2),
> - SH_PFC_FUNCTION(sdhi3),
&g
> + if (0 != of_property_read_u32_array(np, "clk-range",
> + range, ARRAY_SIZE(range)))
> + goto sh_mmcif_clk_setup_default;
> +
> + if (range[0] > range[1])
> +
ve_channel_compat(mask, shdma_chan_filter,
> slave_data, &host->pd->dev,
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> 1) mmc: sh_mmcif: move mmcif_of_match to upside
> 2) mmc: sh_mmcif: cleanup to use dev instead of &pdev->dev
> 3) mmc: sh_mmcif: remove unnecessary int clk from struct sh_mmcif_host
> 4) mmc: sh_mmcif: separate sh_mmcif_clk_update() into setup and prepare
For patches 1-4,
cy as 97.5 MHz in the CPG section.
However, I have a feeling the constraint doesn't come from the DIV6 which
should be able to output higher frequencies, but from the MMCIF, the clock
distribution tree, or both.
There's also the option of specifying the admissible clock range in DT, either
in the CPG node or the MMCIF node.
> > +};
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t; > host->clk = clk_get_rate(host->hclk);
> > host->mmc->f_max = host->clk / 2;
> > host->mmc->f_min = host->clk / 512;
> >
> > + } else {
> > + const struct sh_mmcif_parent_clk *p
On Wednesday 16 July 2014 11:53:21 Laurent Pinchart wrote:
> On Wednesday 16 July 2014 15:50:09 Xiang Wang wrote:
> > From: Xiang Wang
> >
> > Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved error
> > handling of sdhci_add_host. However, "err_of_parse
sdhci_pxa *pxa = pltfm_host->priv;
>
> pm_runtime_get_sync(&pdev->dev);
> sdhci_remove_host(host, 1);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert,
On Monday 04 August 2014 11:01:28 Geert Uytterhoeven wrote:
> On Wed, Jul 16, 2014 at 12:45 AM, Laurent Pinchart wrote:
> > Add references to the transmit and receive DMA channels in the four
> > SDHI nodes.
> >
> > Signed-off-by: Laurent Pinchart
> >
Commit "mmc: sdhci-pxav3: Use devm_* managed helpers" made the pxa local
variable in the sdhci_pxav3_remove function unused. Remove it.
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/sdhci-pxav3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c
This simplifies probe error and remove code paths.
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/sdhci-pxav3.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
This patch applies on top of Xiang Wang's " mmc: sdhci-pxav3: fix error
handling of sdhci_add_h
be placed after "pm_runtime_disable(&pdev->dev)".
>
> Signed-off-by: Xiang Wang
Acked-by: Laurent Pinchart
While we're touching the probe error path, how about converting the driver to
the devm_* helpers ? I'll send a patch shortly.
> ---
> drivers/mmc/host/
Hi Morimoto-san,
Thank you for the review.
On Tuesday 15 July 2014 18:39:04 Kuninori Morimoto wrote:
> Hi Laurent
>
> > DMA reads from the data buffer register must be offset by 0x2000
> > according to the hardware documentation.
> >
> > S
Even though some implementations support 4-bytes data register access,
the tmio driver never configures the hardware in such a way and always
performs 2-bytes accesses. Hardcode the DMA transfer size to 2 bytes.
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/tmio_mmc_dma.c | 2 ++
1 file
Commit e5a233cb647d749de2f188477c9a54b94d90477f ("mmc: sh_mmcif:
Factorize DMA channel request and configuration code") incorrectly
set the destination address for both slave channels instead of setting
the source address for the receive channel. Fix that.
Signed-off-by: Lauren
Add references to the transmit and receive DMA channels in the MMCIF
node.
Signed-off-by: Laurent Pinchart
---
arch/arm/boot/dts/r8a7791.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index 6738bc9..ff0d415 100644
--- a
Add the MMCIF0 device to the r8a7791 device tree.
Signed-off-by: Laurent Pinchart
---
arch/arm/boot/dts/r8a7791.dtsi | 9 +
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index c23e72f..6738bc9 100644
--- a/arch/arm/boot/dts
The sh-mmcif driver implements DT support but the bindings are not
documented. Document them.
Cc: devicet...@vger.kernel.org
Signed-off-by: Laurent Pinchart
---
.../devicetree/bindings/mmc/renesas,mmcif.txt | 32 ++
1 file changed, 32 insertions(+)
create mode 100644
Add references to the transmit and receive DMA channels in the four
SDHI nodes.
Signed-off-by: Laurent Pinchart
---
arch/arm/boot/dts/r8a7790.dtsi | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 465008a..2ea3b2a
oller
driver".
The first five patches (driver changes) should go through the DMA engine tree,
while the last six patches (platform changes) should go through the Renesas
tree. If the driver changes could make it to v3.17 merging the platform
changes will be easier.
Laurent Pinchart (
Add references to the transmit and receive DMA channels in the three
SDHI nodes.
Signed-off-by: Laurent Pinchart
---
arch/arm/boot/dts/r8a7791.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index ff0d415..88be0cc
The data register is 4 bytes wide, hardcode the DMA transfer size to
4 bytes in both directions.
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/sh_mmcif.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
DMA reads from the data buffer register must be offset by 0x2000
according to the hardware documentation.
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/tmio_mmc_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/tmio_mmc_dma.c b/drivers/mmc/host
Node names should describe the function of the device, not its IP core
name.
Cc: devicet...@vger.kernel.org
Signed-off-by: Laurent Pinchart
---
arch/arm/boot/dts/r8a7790.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts
Add references to the transmit and receive DMA channels in the two
MMCIF nodes.
Signed-off-by: Laurent Pinchart
---
arch/arm/boot/dts/r8a7790.dtsi | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 4fae298..465008a
rr(&pdev->dev, "Failed to request memory region\n");
> + goto err_free_host;
The devm_ioremap_resource() call below will handle the mem_res == NULL case
and print a message, so you could remove this check.
> + }
> +
> + host->base = devm_ioremap
ole series,
Reviewed-by: Laurent Pinchart
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
disable(&pdev->dev);
> eofparse:
> mmc_free_host(mmc);
> -ealloch:
> - iounmap(reg);
> return ret;
> }
>
> @@ -1525,9 +1518,6 @@ static int sh_mmcif_remove(struct platform_device
> *pdev) */
> cancel_delayed_work_sync(&host->timeo
is defined as "2010-04-28", I'd take this as an
opportunity to remove it completely. You could combine the dev_info and
dev_dbg message into something similar to
dev_info(&pdev->dev, "Chip version 0x%04x found, clock rate %luMHz\n",
sh_mmcif_readl(
s/built-in.o: In function `sh_mmcif_start_dma_rx':
> sh_mmcif.c:(.text+0x5a33fc): undefined reference to `dma_map_sg'
> drivers/built-in.o: In function `sh_mmcif_end_cmd':
> sh_mmcif.c:(.text+0x5a3668): undefined reference to `dma_unmap_sg'
>
> Signed-off-by
On Tuesday 07 January 2014 15:50:45 Chris Ball wrote:
> On Tue, Jan 07 2014, Laurent Pinchart wrote:
> > On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote:
> >> Hi Chris,
> >>
> >> Could you please pick this patch (and patch 08/15 in the same serie
Hi Chris,
On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote:
> Hi Chris,
>
> Could you please pick this patch (and patch 08/15 in the same series) up for
> v3.14 ?
Ping ?
> On Wednesday 27 November 2013 02:18:29 Laurent Pinchart wrote:
> > This helps inc
Hi Chris,
On Wednesday 11 December 2013 20:29:56 Chris Ball wrote:
> Hi Laurent,
>
> On Wed, Dec 11 2013, Laurent Pinchart wrote:
> > PING ?
>
> I'm sorry about the delay -- it's in mmc-next for 3.14 now.
Thanks a lot and sorry about shouting. Don't worr
Hi Sergei,
On Wednesday 11 December 2013 22:22:19 Sergei Shtylyov wrote:
> On 11-12-2013 22:06, Laurent Pinchart wrote:
> >>> This helps increasing build testing coverage.
> >>>
> >>> The driver doesn't compile on (at least) x86 due (possibly among
On Wednesday 11 December 2013 22:01:53 Sergei Shtylyov wrote:
> Hello.
>
> On 27-11-2013 5:18, Laurent Pinchart wrote:
> > This helps increasing build testing coverage.
> >
> > The driver doesn't compile on (at least) x86 due (possibly among others)
> > t
Hi Chris,
Could you please pick this patch (and patch 08/15 in the same series) up for
v3.14 ?
On Wednesday 27 November 2013 02:18:29 Laurent Pinchart wrote:
> This helps increasing build testing coverage.
>
> The driver doesn't compile on (at least) x86 due (possibly amon
Hi Chris,
On Tuesday 26 November 2013 03:02:48 Laurent Pinchart wrote:
> On Saturday 09 November 2013 13:56:40 Laurent Pinchart wrote:
> > Hi Chris,
> >
> > Could you please pick this patch up ?
>
> Ping ?
PING ?
> As this patch is a dependency for oth
From: Laurent Pinchart
Casting an integer to a void * generates a "cast to pointer from integer
of different size" warning. Cast the integer to an uintptr_t first to
fix it.
Cc: Chris Ball
Cc: Guennadi Liakhovetski
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart
--
This helps increasing build testing coverage.
Cc: Chris Ball
Cc: Guennadi Liakhovetski
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart
Acked-by: Simon Horman
---
drivers/mmc/host/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host
l
Cc: Guennadi Liakhovetski
Cc: Ian Molton
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart
Acked-by: Simon Horman
---
drivers/mmc/host/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 7fc5099..ca
From: Laurent Pinchart
Casting an integer to a void * generates a "cast to pointer from integer
of different size" warning. Cast the integer to an unsigned long first
to fix it.
Cc: Chris Ball
Cc: Guennadi Liakhovetski
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Lauren
From: Laurent Pinchart
The channel request and configuration code is duplicated for the rx and
tx channels. Create a function that requests a single channel and call
it twice instead.
Cc: Chris Ball
Cc: Guennadi Liakhovetski
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart
Hi Chris,
On Saturday 09 November 2013 13:56:40 Laurent Pinchart wrote:
> Hi Chris,
>
> Could you please pick this patch up ?
Ping ?
As this patch is a dependency for other series that will go through different
trees, could you please provide a stable branch in your tree with t
ed here (not in a function)
>
> --- with regulator/driver.h --
> CC arch/arm/mach-shmobile/board-lager.o
> (no error)
I believe the enum regulator_type definition should be moved out of
regulator/driver.h, but that's out of scope of this patch set, so I'm fine
gt; > \
> >
> > You can make this structure const.
>
> (snip)
>
> > > +static struct gpio_regulator_config vccq_sdhi##idx##_info = {
> > > \
> >
> > You can make this structure const.
>
> I see.
> Thank you
--
Regards,
Laurent Pinch
Hi Linus,
On Tuesday 19 November 2013 10:57:43 Linus Walleij wrote:
> On Mon, Nov 18, 2013 at 3:00 PM, Laurent Pinchart wrote:
> > I'm not against moving the gpio-rcar initialization to postcore or subsys
> > initcall, but in that case I believe we should standardize (or at
_rcar gpio_rcar.1: driving 32 GPIOs
> gpio_rcar gpio_rcar.2: driving 32 GPIOs
> gpio_rcar gpio_rcar.3: driving 32 GPIOs
> gpio_rcar gpio_rcar.4: driving 32 GPIOs
> gpio_rcar gpio_rcar.5: driving 32 GPIOs
> ...
> SDHI0Vcc: 3300 mV
> SDHI2Vcc: 3300 mV
> vqmmc: 1800 <--> 3
ed_regulator_idx++,
> + &vcc_sdhi0_info, sizeof(struct
> fixed_voltage_config));
> + platform_device_register_data(&platform_bus, "reg-fixed-voltage",
> fixed_regulator_idx++,
> + &vcc_sdhi2_info, sizeof(st
&vcc_sdhi0_info,
> sizeof(struct fixed_voltage_config));
> + platform_device_register_data(&platform_bus, "reg-fixed-voltage",
> fixed_regulator_idx++, + &vcc_sdhi2_info,
> sizeof(struct
> fixed_voltage_config));
> +
> + platform_devic
o/fixed regulator for SDHI
As the second patches fixes a problem in the first one, I'd like to split them
differently. Could you please submit a first patch that adds the regulators,
and a second patch that adds SDHI0/2 support using the regulators ?
--
Regards,
Laurent Pinchart
--
To
p;gpio_rcar_device_driver);
> +}
> +module_exit(gpio_rcar_exit);
>
> MODULE_AUTHOR("Magnus Damm");
> MODULE_DESCRIPTION("Renesas R-Car GPIO Driver");
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Morimoto-san,
Thank you for the patch.
On Thursday 14 November 2013 02:27:50 Kuninori Morimoto wrote:
> sh73a0 != r8a7740
>
> Signed-off-by: Kuninori Morimoto
Acked-by: Laurent Pinchart
> ---
> arch/arm/boot/dts/sh73a0.dtsi |6 +++---
> 1 file changed, 3 insertio
Hi Morimoto-san,
Thank you for the patch.
On Thursday 14 November 2013 02:27:32 Kuninori Morimoto wrote:
> WP pin is not implemented on Marzen
>
> Signed-off-by: Kuninori Morimoto
Acked-by: Laurent Pinchart
> ---
> arch/arm/mach-shmobile/board-marzen.c |2 --
>
Hi Morimoto-san,
Thank you for the patch.
On Thursday 14 November 2013 02:27:16 Kuninori Morimoto wrote:
> WP pin is not implemented on Marzen
>
> Signed-off-by: Kuninori Morimoto
Acked-by: Laurent Pinchart
> ---
> arch/arm/boot/dts/r8a7779-marzen-reference.dts |3 +--
&g
>
> Signed-off-by: Kuninori Morimoto
Acked-by: Laurent Pinchart
> ---
> drivers/mmc/host/tmio_mmc_pio.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc_pio.c
> b/drivers/mmc/host/tmio_mmc_pio.c index 99f6d29..1f5
ireg);
> +
> + /* Clear the status except the interrupt status */
> + sd_ctrl_write32(host, CTL_STATUS, TMIO_MASK_IRQ);
You should write *status, not TMIO_MASK_IRQ, or you could loose an interrupt
if it gets triggered between the status read and status write.
> }
>
> static bool _
ide effect (when writing to the hardware) ? I'm also a bit surprised, do
upper layers transfer data to/from the card using odd number of bytes ?
> host->sg_off += count;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Chris,
Could you please pick this patch up ?
On Tuesday 29 October 2013 09:09:37 Guennadi Liakhovetski wrote:
> On Mon, 28 Oct 2013, Laurent Pinchart wrote:
> > Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
> > clk_disable_unprepare() to get ready fo
Hi Magnus,
On Thursday 31 October 2013 17:26:30 Magnus Damm wrote:
> On Wed, Oct 30, 2013 at 8:23 PM, Laurent Pinchart wrote:
> > Renesas ARM platforms are transitioning from single-platform to
> > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> > driver
Hi Uluf,
On Thursday 31 October 2013 00:27:23 Ulf Hansson wrote:
> On 31 October 2013 00:13, Laurent Pinchart wrote:
> > On Wednesday 30 October 2013 23:23:37 Guennadi Liakhovetski wrote:
> >> On Tue, 29 Oct 2013, Guennadi Liakhovetski wrote:
> >> > On Mon, 28 Oc
Hi Guennadi,
On Wednesday 30 October 2013 23:23:37 Guennadi Liakhovetski wrote:
> On Tue, 29 Oct 2013, Guennadi Liakhovetski wrote:
> > On Mon, 28 Oct 2013, Laurent Pinchart wrote:
> > > Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
> > > clk
From: Laurent Pinchart
Casting an integer to a void * generates a "cast to pointer from integer
of different size" warning. Cast the integer to an unsigned long first
to fix it.
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/sh_mmcif.c | 2 +-
1 file changed, 1 insertion(+),
Ball
Cc: Guennadi Liakhovetski
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 51957d4..4ba225f 100644
--- a/drivers/mmc/host
From: Laurent Pinchart
The channel request and configuration code is duplicated for the rx and
tx channels. Create a function that requests a single channel and call
it twice instead.
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/sh_mmcif.c | 100
The subject line should have read 'PATCH v3', my bad.
On Wednesday 30 October 2013 12:23:10 Laurent Pinchart wrote:
> Renesas ARM platforms are transitioning from single-platform to
> multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> driver available on a
e can
thus get rid of the conditional compilation completely without
introducing any further issue, and let future non-Renesas users deal
with the situation if it turns out to be a the problem.
Cc: Chris Ball
Cc: Guennadi Liakhovetski
Cc: Ian Molton
Cc: linux-mmc@vger.kernel.org
Signed-off-b
Ball
Cc: Guennadi Liakhovetski
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index d57effb..dcceeae 100644
--- a/drivers/mmc/host
deal
with the situation if it turns out to be a the problem.
Cc: Chris Ball
Cc: Guennadi Liakhovetski
Cc: Ian Molton
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/Kconfig| 2 +-
drivers/mmc/host/tmio_mmc_dma.c | 4 +---
2 files changed, 2 insertions
Hi Sergei,
On Tuesday 29 October 2013 23:47:36 Sergei Shtylyov wrote:
> On 10/29/2013 04:15 PM, Laurent Pinchart wrote:
> >>>>> Renesas ARM platforms are transitioning from single-platform to
> >>>>> multi-platform kernels using the new ARCH_SHMOBILE_MULT
Hi Sergei,
On Tuesday 29 October 2013 16:12:49 Sergei Shtylyov wrote:
> On 29-10-2013 13:52, Laurent Pinchart wrote:
> >>> Renesas ARM platforms are transitioning from single-platform to
> >>> multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> &
Hi Guennadi,
On Tuesday 29 October 2013 10:07:29 Guennadi Liakhovetski wrote:
> Hi Laurent
>
> On Tue, 29 Oct 2013, Laurent Pinchart wrote:
> > Renesas ARM platforms are transitioning from single-platform to
> > multi-platform kernels using the new ARCH_SHMOBILE_MULTI
@vger.kernel.org
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 51957d4..1f3a0c1 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -588,7
Liakhovetski
Cc: Ian Molton
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/Kconfig| 2 +-
drivers/mmc/host/tmio_mmc_dma.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index
Cc: Guennadi Liakhovetski
Cc: linux-mmc@vger.kernel.org
Cc: Felipe Balbi
Cc: linux-...@vger.kernel.org
Cc: Greg Kroah-Hartman
Cc: Yoshihiro Shimoda
Cc: Jean-Christophe Plagniol-Villard
Cc: Tomi Valkeinen
Cc: linux-fb...@vger.kernel.org
Laurent Pinchart (12):
clocksource: sh_cmt: Add clk_prepare/
Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
clk_disable_unprepare() to get ready for the migration to the common
clock framework.
Cc: Chris Ball
Cc: Guennadi Liakhovetski
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host/sh_mmcif.c
Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
clk_disable_unprepare() to get ready for the migration to the common
clock framework.
Cc: Chris Ball
Cc: Guennadi Liakhovetski
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart
---
drivers/mmc/host
(32);
> bypasses the architectures check on the DMA mask. It can be replaced
> with dma_coerce_mask_and_coherent(), avoiding the direct initialization
> of this mask.
>
> Signed-off-by: Russell King
Acked-by: Laurent Pinchart
> ---
> drivers/media/platform/omap3isp/isp.c
his patch converts the SDHI
> MMC driver and its users to the common standard. This is safe for now, since
> ATM no real products are using this driver with DT.
>
> Signed-off-by: Guennadi Liakhovetski
Acked-by: Laurent Pinchart
> ---
>
> Ok, the "no real products"
Hi Chris,
On Saturday 24 August 2013 23:58:14 Chris Ball wrote:
> On Thu, Aug 08 2013, Laurent Pinchart wrote:
> > This patch set replaces callbacks to board code with regulators and GPIOs
> > in the mmc_spi, sh_mmcif and sh_mobile_sdhi MMC drivers.
> >
> > Most of the
Hi Chris,
On Thursday 08 August 2013 12:38:30 Laurent Pinchart wrote:
> Hello,
>
> This patch set replaces callbacks to board code with regulators and GPIOs in
> the mmc_spi, sh_mmcif and sh_mobile_sdhi MMC drivers.
>
> Most of the required infrastructure is in place already o
The callback isn't used by the mmcif driver, don't initialize it in
board code.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
arch/sh/boards/mach-ecovec24/setup.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/arch/sh/boards/mach-ecovec24/setup.c
All platforms pass the CD GPIO number to the driver in the .cd_gpio
field. The .get_cd() callback isn't used anymore, remove it.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
drivers/mmc/host/sh_mobile_sdhi.c | 9 -
include/linux/mmc/sh_mobile_sdhi.h | 1
Pass the CD and RO GPIO numbers to the MMC SPI driver and remove the
custom .get_cd() and .get_ro() callback functions.
Signed-off-by: Laurent Pinchart
Acked-by: H Hartley Sweeten
---
arch/arm/mach-ep93xx/vision_ep9307.c | 57
1 file changed, 5 insertions
The SHDI platform data .set_pwr() callback is used to control the
vmmc/vqmmc power supplies. As the power supplies already register
control GPIOs there's no need to perform the operation manually.
Remove the callback functions.
Signed-off-by: Laurent Pinchart
---
arch/arm/mach-shmobile/
The .set_pwr() callback isn't used anymore as all platforms register
GPIO-controlled regulators. Remove it.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
drivers/mmc/host/sh_mobile_sdhi.c | 9 -
include/linux/mmc/sh_mobile_sdhi.h | 1 -
2 files change
The callback isn't used by the driver and isn't initialized by board
code. Remove it.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
include/linux/mmc/sh_mmcif.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/mmc/sh_mmcif.h b/include/linux/mmc/
All platforms pass the CD GPIO number to the driver in the .cd_gpio
field. The .get_cd() callback isn't used anymore, remove it
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
drivers/mmc/host/tmio_mmc_pio.c | 16 +---
include/linux/mfd/tmio.h| 1
Add a debounce parameter to the mmc_gpio_request_cd() function that
enables GPIO debouncing when set to a non-zero value. This can be used
by MMC host drivers to enable debouncing on the card detect signal.
Signed-off-by: Laurent Pinchart
Reviewed-by: H Hartley Sweeten
---
drivers/mmc/core
The .set_pwr() callback isn't used anymore as all platforms register
GPIO-controlled regulators. Remove it.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
drivers/mmc/host/tmio_mmc.h | 1 -
drivers/mmc/host/tmio_mmc_pio.c | 7 ---
include/linux/mfd/t
Pass the CD and RO GPIO numbers to the MMC SPI and SDHI drivers and
remove the custom .get_cd() and .get_ro() callback functions.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
arch/sh/boards/mach-ecovec24/setup.c | 42 +++-
1 file changed
All platforms now pass the CD and RO GPIOs to the MMC SPI driver, those
callbacks are not used anymore. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: H Hartley Sweeten
---
drivers/mmc/host/mmc_spi.c | 24 ++--
include/linux/spi/mmc_spi.h | 9 -
2 files
1 - 100 of 151 matches
Mail list logo