DMA configuration has been removed from function mmci_dma_setup but the
local mask variable was not removed. This remains unused hence remove
it from the function and operations on it
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/mmci.c |5 -
1 file changed, 5 deletions(-)
diff
Hi Ulf,
Any comment on this change?
Thanks
Pramod
On Tuesday 16 December 2014 07:21 PM, Pramod Gurav wrote:
> DMA configuration has been removed from function mmci_dma_setup but the
> local mask variable was not removed. This remains unused hence remove
> it from the function and oper
DMA configuration has been removed from function mmci_dma_setup but the
local mask variable was not removed. This remains unused hence remove
it from the function and operations on it
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/mmci.c |5 -
1 file changed, 5 deletions(-)
diff
Thanks Ulf,
On Thu, Oct 30, 2014 at 4:38 PM, Ulf Hansson wrote:
> On 30 October 2014 08:46, Pramod Gurav wrote:
>> The sequence of resource release in probe failure path in this
>> driver was wrong and needed fixes to cleanly unload the driver.
>> This changes does the
@vger.kernel.org
Signed-off-by: Pramod Gurav
---
Changes since v1:
- Dropped IS_ERR check on devm_ioremap() return.
- Fixed sequence on mmc_remove_host in fail as well as in remove function
drivers/mmc/host/davinci_mmc.c | 91 +++-
1 file changed, 33
Hi Ulf,
Is this good to go?
On Mon, Sep 29, 2014 at 6:55 PM, Pramod Gurav
wrote:
> This fixes below sparse warning:
> drivers/mmc/host/sdhci-pxav3.c:227:10: warning: Initializer entry defined
> twice
> drivers/mmc/host/sdhci-pxav3.c:232:10: also defined here
>
> by
: Russell King
Cc: Ulf Hansson
Cc: Chris Ball
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/sdhci-pxav3.c | 37 -
1 file changed, 37 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
Hi Arnd,
On Sat, Sep 27, 2014 at 1:04 AM, Arnd Bergmann wrote:
> As of 528bc7808f4e ("mmc: atmel-mci: Release mmc resources on failure in
> probe"),
> the atmci_probe() function calls atmci_cleanup_slot in the failure path.
>
> This causes a new warning whenever the driver is built:
>
> WARNING:
@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/davinci_mmc.c | 91 +++-
1 file changed, 33 insertions(+), 58 deletions(-)
diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index 5d4c5e0..160b7e8 100644
--- a
: Chris Ball
Cc: Ulf Hansson
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Pramod Gurav
---
Changes since v1:
- Dropped using devm_request_irq as suggested by Ludovic Desroches
as it seems there are race conditions seen with them.
- Added another patch to fix failure path in probe to call
This change takes care of releasing mmc resources on error cases in
probe function which was missing. Also release timer in remove function.
Cc: Ludovic Desroches
Cc: Chris Ball
Cc: Ulf Hansson
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Pramod Gurav
---
Changes since v1: None
drivers/mmc
: linux-mmc@vger.kernel.org
Signed-off-by: Pramod Gurav
---
Changes since v1:
- Dropped using devm_request_irq as suggested by Ludovic Desroches
as it seems there are race conditions seen with them.
- Added another patch to fix failure path in probe to call atmci_cleanup_slot
after
uest_irq and free_irq the time it takes to solve this issue
> is probably better.
Oh, Thanks for letting me know this. I will resend this patch keeping
request_irq and free_irq in driver.
>
> Regards
>
> Ludovic
>
> On Sat, Sep 20, 2014 at 12:22:30PM +0530, Pramod Gurav wrote:
This change switches to managed version of gpio_request to simplify
module unloading and failure cases and does away with code to release
gpio resources.
Cc: Balaji T K
Cc: Chris Ball
Cc: Ulf Hansson
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/omap_hsmmc.c
These headers are not required hence this change removes them from
the driver.
Cc: Guennadi Liakhovetski
Cc: Chris Ball
Cc: Ulf Hansson
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/usdhi6rol0.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a
This change removes unwanted NULL check around mmc private data
structure in remove function as the probe would not have succeeded
with this structure variable as NULL.
Cc: Chris Ball
Cc: Ulf Hansson
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/android
This change takes care of releasing mmc resources on error cases in
probe function which was missing. Also release timer in remove function.
Cc: Ludovic Desroches
Cc: Chris Ball
Cc: Ulf Hansson
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/atmel-mci.c | 13
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/atmel-mci.c | 57
1 file changed, 20 insertions(+), 37 deletions(-)
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index bb585d9..21a222c 100644
ion of mmci driver.
> From v3.17 mmci driver added support for qualcomm specific customization to
> pl180.
> So msm platform should be able to use pl180 mmci driver, rather than using
> msm_sdcc.
>
> Thanks,
> srini
>
>
>
> On 16/09/14 12:15, Pramod Gurav wrote:
>&g
ux-arm-...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/msm_sdcc.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index 2111c03..5025364 100644
--- a/drivers/mmc/host/msm_sdcc.c
+++ b/drivers/mmc/host/msm_
This removes unnecessary initialisations of resource pointers
and does away with a lable and just returns error on fail instead.
Cc: David Brown
Cc: Daniel Walker
Cc: Bryan Huntsman
CC: Ulf Hansson
CC: linux-mmc@vger.kernel.org
CC: linux-arm-...@vger.kernel.org
Signed-off-by: Pramod Gurav
This change adds remove function in platform_driver to clean unloading
Cc: David Brown
Cc: Daniel Walker
Cc: Bryan Huntsman
CC: Ulf Hansson
CC: linux-mmc@vger.kernel.org
CC: linux-arm-...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/msm_sdcc.c | 18
-...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/msm_sdcc.c | 43 +--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index 9405ecd..2b8ac9c 100644
--- a/drivers/mmc
This replaces pr_* with dev_ for message logging and also does away
with printing function names in logs.
Cc: David Brown
Cc: Daniel Walker
Cc: Bryan Huntsman
CC: Ulf Hansson
CC: linux-mmc@vger.kernel.org
CC: linux-arm-...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host
-...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/msm_sdcc.c | 43 +--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index 9405ecd..2b8ac9c 100644
--- a/drivers/mmc
25 matches
Mail list logo
