Re: [PATCH-v2 2/7] mmc: sdhci-pxav3: binding: Add pxa1928 compatible support

2015-09-08 Thread Rob Herring
On 09/07/2015 06:18 AM, Vaibhav Hiremath wrote: > With support for pxa1928 family of devices , this patch > updates the binding document with compatible property > of "marvell,pxav3-1928-sdhci". > > Signed-off-by: Vaibhav Hiremath > --- > Documentation/devicetree/bindings/mmc/sdhci-pxa.txt | 2 +

Re: [RFC PATCH] mmc: sprd: add MMC host driver for Spreadtrum SoC

2015-07-02 Thread Rob Herring
On Thu, Jul 2, 2015 at 4:26 AM, Orson Zhai wrote: > Hi Rob, > > Thanks for your quick reply. > I have one question to your last comment. > > On Thu, Jul 2, 2015 at 1:50 AM, Rob Herring wrote: >> On Wed, Jul 1, 2015 at 2:23 AM, Chunyan Zhang >> wrote: >>&g

Re: [RFC PATCH] mmc: sprd: add MMC host driver for Spreadtrum SoC

2015-07-01 Thread Rob Herring
On Wed, Jul 1, 2015 at 2:23 AM, Chunyan Zhang wrote: > From: Billows Wu > > The Spreadtrum MMC host driver is used to support EMMC, SD, and > SDIO types of memory cards. > > Signed-off-by: Billows Wu > Reviewed-by: Orson Zhai > Signed-off-by: Chunyan Zhang > --- > drivers/mmc/host/sprd_sdhost

Re: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.

2015-05-05 Thread Rob Herring
On Tue, May 5, 2015 at 4:17 AM, Suman Tripathi wrote: > This patch adds the arasan sdhc nodes to reuse the of-arasan > driver for APM X-Gene SoC. > > Signed-off-by: Suman Tripathi > --- > arch/arm64/boot/dts/apm/apm-mustang.dts | 4 +++ > arch/arm64/boot/dts/apm/apm-storm.dtsi | 44 >

Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode

2015-02-25 Thread Rob Herring
On Wed, Jan 28, 2015 at 8:41 PM, Alim Akhtar wrote: > From: Seungwon Jeon > > Implements HS400 mode support for exynos host driver. > This also include some updates as new mode is added. > > Signed-off-by: Seungwon Jeon > Signed-off-by: Alim Akhtar > [Alim: addressed review comments] > --- > .

Re: [PATCH 6/9] mmc: sdhci: host: add new f_sdh30

2014-11-20 Thread Rob Herring
On Thu, Nov 20, 2014 at 10:59 AM, Vincent Yang wrote: > 2014-11-20 23:22 GMT+08:00 Rob Herring : >> On Thu, Nov 20, 2014 at 6:38 AM, Vincent Yang >> wrote: >>> This patch adds new host controller driver for >>> Fujitsu SDHCI controller f_sdh30. >>> >

Re: [PATCH 6/9] mmc: sdhci: host: add new f_sdh30

2014-11-20 Thread Rob Herring
On Thu, Nov 20, 2014 at 6:38 AM, Vincent Yang wrote: > This patch adds new host controller driver for > Fujitsu SDHCI controller f_sdh30. > > Signed-off-by: Andy Green > Signed-off-by: Vincent Yang > Signed-off-by: Tetsuya Takinishi > --- > .../devicetree/bindings/mmc/sdhci-fujitsu.txt |

Re: [PATCH v10 1/3] mmc: sdhci-msm: Qualcomm SDHCI binding documentation

2014-03-04 Thread Rob Herring
On Tue, Mar 4, 2014 at 1:27 PM, Georgi Djakov wrote: > This patch adds the device-tree binding documentation for > Qualcomm SDHCI driver. It contains the differences between > the core properties in mmc.txt and the properties used by > the sdhci-msm driver. > > Signed-off-by: Georgi Djakov > ---

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Rob Herring
On Thu, Jan 16, 2014 at 9:08 PM, Nicolas Pitre wrote: > On Thu, 16 Jan 2014, Olof Johansson wrote: > >> "for SDIO slots" is somewhat misleading; nearly all controllers only >> do one slot/device per controller. The designware controller can do >> multiple slots, and that adds a bit of driver and b

Re: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-05 Thread Rob Herring
On Thu, Nov 7, 2013 at 11:38 PM, Zhangfei Gao wrote: > Add dw_mmc-k3.c for k3v2, support sd/emmc > > Signed-off-by: Zhangfei Gao > Tested-by: Zhigang Wang > --- > .../devicetree/bindings/mmc/k3-dw-mshc.txt | 83 +++ > drivers/mmc/host/Kconfig | 10 + >

Re: [PATCH v2 1/2] mmc: arasan: Add driver for Arasan SDHCI

2013-10-30 Thread Rob Herring
On Wed, Oct 30, 2013 at 11:38 AM, Soren Brinkmann wrote: > Add a driver for Arasan's SDHCI controller core. > > Signed-off-by: Soren Brinkmann For the binding: Acked-by: Rob Herring > --- > v2: > - document 'interrupts' and 'interrupt-parent&#

Re: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI

2013-10-28 Thread Rob Herring
On 10/15/2013 02:08 PM, Soren Brinkmann wrote: > Add a driver for Arasan's SDHCI controller core. > > Signed-off-by: Soren Brinkmann > --- > .../devicetree/bindings/mmc/arasan,sdhci.txt | 23 +++ > MAINTAINERS| 1 + > drivers/mmc/host/Kconfig

Re: [PATCH] dts: Fix misspelling of Synopsys

2013-09-16 Thread Rob Herring
On 09/16/2013 04:45 PM, Olof Johansson wrote: > On Mon, Sep 16, 2013 at 03:57:48PM -0500, dingu...@altera.com wrote: >> From: Dinh Nguyen >> >> s/Synopsis/Synopsys >> s/synopsis/synopsys >> >> Signed-off-by: Dinh Nguyen >> Cc: Pavel Machek >> C

Re: [PATCH 1/2] mmc: add Device Tree properties for UHS modes

2013-07-29 Thread Rob Herring
On 07/29/2013 02:18 AM, Guennadi Liakhovetski wrote: > On Mon, 29 Jul 2013, Guennadi Liakhovetski wrote: > >> Hi Stephen >> >> On Fri, 26 Jul 2013, Stephen Warren wrote: >> >>> On 07/26/2013 02:23 PM, Guennadi Liakhovetski wrote: Hi Stephen On Fri, 26 Jul 2013, Stephen Warren wrote:

Re: [PATCH 1/2] ARM: socfpga: dts: Add support for SD/MMC

2013-06-11 Thread Rob Herring
: Dinh Nguyen > Reviewed-by: Pavel Machek > CC: Arnd Bergmann > CC: Olof Johansson > Cc: Pavel Machek > Cc: Grant Likely > Cc: Rob Herring > Cc: Chris Ball > Cc: devicetree-disc...@lists.ozlabs.org > Cc: linux-mmc@vger.kernel.org > CC: > > v2: > - Add

Re: [RFC] dw_apb_timer_of: use clocksource_of_init

2013-06-03 Thread Rob Herring
called once for each timer node > and tracks these number of calls to attach clockevent and clocksource > devices to the nodes. > > Also convert all previous users of dw_apb_timer_init to use > clocksource_of_init. > > Tested on the upcoming rk3066 code. > > Signed-off-

Re: [PATCH v4 5/5] ARM: davinci: da850: override mmc DT node device name

2013-02-27 Thread Rob Herring
On 02/15/2013 12:22 AM, Manjunathappa, Prakash wrote: > Populate OF_DEV_AUXDATA with desired device name expected by > davinci_mmc driver. Without this clk_get of davinci_mmc DT driver > fails. > > Signed-off-by: Manjunathappa, Prakash > Cc: linux-mmc@vger.kernel.org > Cc: linux-arm-ker...@lists.

Re: [PATCH 4/4] MMC: omap_hsmmc: add DT property for max bus frequency

2012-10-12 Thread Rob Herring
On 10/12/2012 05:58 AM, Daniel Mack wrote: > Maximum bus frequency can be limited by external circuitry like level > shifters etc. Allow passing this value from DT. > > Signed-off-by: Daniel Mack > Cc: Venkatraman S > Cc: Chris Ball > Cc: Grant Likely > Cc: Ro

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Rob Herring
On 08/21/2012 10:18 AM, Chris Ball wrote: > Hi, > > On Tue, Aug 21 2012, Rob Herring wrote: >>> cd-gpios and cd-external can be present on the same node. if broken-cd >>> is present, it must be the only one of these nodes used. >> >> I don't see the p

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Rob Herring
On 08/21/2012 09:48 AM, Chris Ball wrote: > Hi, adding Shawn and Wolfram, snip... > Rob Herring said: >> This makes the most sense to me. However, I prefer broken-cd over >> cd-internal. The binding should add properties for exceptions, not SDHCI >> spec compliant impleme

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Rob Herring
On 08/21/2012 07:08 AM, Arnd Bergmann wrote: > On Tuesday 21 August 2012, Chris Ball wrote: >> How about this? >> >> broken-cd: No CD available, use polling. >> >> cd-gpios: The CD pin on the host is working and brought out to a GPIO. >> >> external-cd-gpios: The CD pin on the host is broken, but t

Re: [PATCH] mmc: omap_hsmmc: Get rid of of_have_populated_dt() usage

2012-04-11 Thread Rob Herring
_populated_dt() usage in omap_hsmmc driver and > instead use dev->of_node to make the same dicisions as earlier. > > Signed-off-by: Rajendra Nayak > Reported-by: Benoit Cousson > Cc: Balaji TK > Cc: Rob Herring Ack Rob > Cc: Sebastian Andrzej Siewior > --- > driv

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-14 Thread Rob Herring
On 03/14/2012 01:23 AM, Dong Aisheng wrote: > On Tue, Mar 13, 2012 at 09:35:43AM -0500, Rob Herring wrote: >> On 03/13/2012 03:47 AM, Dong Aisheng wrote: >>> From: Dong Aisheng >>> >>> This patch includes basic dt support which can boot via nfs rootfs.

Re: [PATCH v1 3/5] ARM: imx28evk: add mmc dt support

2012-03-13 Thread Rob Herring
On 03/13/2012 11:52 AM, Sascha Hauer wrote: > On Tue, Mar 13, 2012 at 09:39:30AM -0500, Rob Herring wrote: >> On 03/13/2012 03:47 AM, Dong Aisheng wrote: >>> From: Dong Aisheng >>> >>> Signed-off-by: Dong Aisheng >>> --- >>> arch/arm/boot

Re: [PATCH v1 3/5] ARM: imx28evk: add mmc dt support

2012-03-13 Thread Rob Herring
On 03/13/2012 03:47 AM, Dong Aisheng wrote: > From: Dong Aisheng > > Signed-off-by: Dong Aisheng > --- > arch/arm/boot/dts/imx28-evk.dts | 14 ++ > arch/arm/boot/dts/imx28.dtsi| 33 + > arch/arm/mach-mxs/imx28-dt.c|2 ++ > 3 files chan

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-13 Thread Rob Herring
On 03/13/2012 03:47 AM, Dong Aisheng wrote: > From: Dong Aisheng > > This patch includes basic dt support which can boot via nfs rootfs. > > Signed-off-by: Dong Aisheng > --- > Documentation/devicetree/bindings/arm/fsl.txt |4 + > arch/arm/boot/dts/imx28-evk.dts | 31 ++

Re: [PATCH v2 1/4] mmc: omap_hsmmc: Convert hsmmc driver to use device tree

2012-03-08 Thread Rob Herring
tree. > > Any comments on these bindings for omap hsmmc? All the dependent > patches/series on which this series was based have now made it to > the respective -next of Mark and Chris. > Acked-by: Rob Herring > >> >> Signed-off-by: Rajendra Nayak >> ---

Re: [PATCH 02/31] ARM: amba: of: convert to use amba_device_alloc

2012-01-20 Thread Rob Herring
On 01/20/2012 03:23 AM, Russell King - ARM Linux wrote: > Convert DT code to use the new amba_device_alloc APIs. > > Signed-off-by: Russell King Acked-by: Rob Herring > --- > drivers/of/platform.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >

Re: [PATCH 2/3] mmc: Add OF bindings support for mmc host controller capabilities

2011-10-05 Thread Rob Herring
Thomas, On 10/05/2011 05:13 AM, Thomas Abraham wrote: > Device nodes representing sd/mmc controllers in a device tree would include > mmc host controller capabilities. Add support for parsing of mmc host > controller capabilities included in device nodes. > > Signed-off-by: Thomas Abraham > ---

Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-04 Thread Rob Herring
On 08/04/2011 06:00 PM, Stephen Warren wrote: > Many IRQs are associated with GPIO pins. When the pin is used as an IRQ, > it can't be used as anything else; it should be requested. Enhance the > core interrupt code to call gpio_request() and gpio_direction_input() for > any IRQ that is also a GPIO

Re: [PATCH 5/7] mmc: support sdhci-esdhc-imx as an OF device

2011-03-17 Thread Rob Herring
On 03/17/2011 03:22 PM, Grant Likely wrote: [cc'ing linux-mmc to continue this discussion] On Wed, Mar 16, 2011 at 10:39:16PM +0800, Shawn Guo wrote: On Tue, Mar 15, 2011 at 01:59:26PM -0600, Grant Likely wrote: On Mon, Mar 14, 2011 at 10:25:57PM +0800, Shawn Guo wrote: Signed-off-by: Shawn G

Re: [PATCH 4/7] mmc: sdhci-of: fix build on non-powerpc platforms

2010-11-16 Thread Rob Herring
On 11/16/2010 03:44 PM, Wolfram Sang wrote: On Tue, Nov 16, 2010 at 02:33:52PM -0600, Rob Herring wrote: From: Rob Herring Explicitly include err.h, of_address.h and of_irq.h. Make use of machine_is() conditional on PPC. Signed-off-by: Rob Herring Hmm, sins of the past :/ I wonder if we can