Re: [PATCH 3/4] mmc: mediatek: Add tune support

2015-10-14 Thread Sascha Hauer
On Thu, Oct 15, 2015 at 10:46:20AM +0800, Chaotian Jing wrote: > On Wed, 2015-10-14 at 12:05 +0200, Ulf Hansson wrote: > > On 13 October 2015 at 11:37, Chaotian Jing > > wrote: > > > Add CMD19/CMD21 support for EMMC/SD/SDIO tuning > > > Add HS400 mode support > > > > > > Signed-off-by: Chaotian J

Re: [PATCH 3/4] mmc: mediatek: Add tune support

2015-10-14 Thread Sascha Hauer
Hi, On Tue, Oct 13, 2015 at 05:37:57PM +0800, Chaotian Jing wrote: > @@ -1260,6 +1547,16 @@ static int msdc_drv_probe(struct platform_device *pdev) > goto host_free; > } > > + host->src_clk_parent = clk_get_parent(host->src_clk); > + host->hs400_src = devm_clk_get(&pd

Re: SDHCI: mdelay() in hot path in esdhc_pltfm_set_clock looses CAN (!) frames

2015-07-07 Thread Sascha Hauer
On Wed, Jul 08, 2015 at 08:22:57AM +0200, Holger Schurig wrote: > Wow, at last some reaction. And I thought nobody cares ... > > BTW, removing CONFIG_MMC_CLKGATE helped a bit, because the pointless > clock-off-clock-on while the device is booting (or accessing multiple > sectors within a short tim

Re: [PATCH v4 2/7] mmc: mediatek: Add Mediatek MMC driver

2015-06-04 Thread Sascha Hauer
On Thu, Jun 04, 2015 at 10:54:03AM +0800, Chaotian Jing wrote: > On Tue, 2015-05-19 at 13:15 +0200, Sascha Hauer wrote: > > On Tue, May 19, 2015 at 02:36:46PM +0800, Chaotian Jing wrote: > > > Add Mediatek MMC driver code > > > Support eMMC/SD/SDIO > > >

Re: [PATCH v4 3/7] mmc: mediatek: Add PM support for MMC driver

2015-05-19 Thread Sascha Hauer
Hi Chaotian, On Tue, May 19, 2015 at 02:36:47PM +0800, Chaotian Jing wrote: > Add PM support for Mediatek MMC driver > Save/restore registers when PM Has anyone asked you to add a new driver in two steps? I find it hard to review if a driver is introduced and changed right afterwards. Presumably

Re: [PATCH v3 4/7] arm64: dts: mediatek: Add MT8173 MMC dts

2015-04-28 Thread Sascha Hauer
On Tue, Apr 28, 2015 at 05:48:42PM +0800, Chaotian Jing wrote: > From: Eddie Huang > > Add node mmc0 and mmc1 While at it you could add mmc2 and mmc3 to the dtsi aswell. No need to patch that again later. Sascha -- Pengutronix e.K. | | In

Re: [PATCH v3 6/7] ARM: mediatek: dts: Add emmc support to mt8135

2015-04-28 Thread Sascha Hauer
On Tue, Apr 28, 2015 at 05:48:44PM +0800, Chaotian Jing wrote: > From: Yingjoe Chen > > Add emmc node for mt8135.dtsi & mt8135-evbp1.dts > > Signed-off-by: Yingjoe Chen > Signed-off-by: Chaotian Jing > --- > arch/arm/boot/dts/mt8135-evbp1.dts | 141 > + >

Re: [PATCH v2 1/5] mmc: dt-bindings: add Mediatek MMC bindings

2015-04-20 Thread Sascha Hauer
Hi Chaotian, On Tue, Mar 17, 2015 at 11:13:51AM +0800, Chaotian Jing wrote: > Document the device-tree binding of Mediatek MMC host > > Signed-off-by: Chaotian Jing > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 33 > > 1 file changed, 33 insertions(+) > c

Re: [PATCH v2 3/5] mmc: mediatek: Add PM support for MMC driver

2015-04-19 Thread Sascha Hauer
On Tue, Mar 17, 2015 at 11:13:53AM +0800, Chaotian Jing wrote: > Add PM support for Mediatek MMC driver > > Signed-off-by: Chaotian Jing > --- > drivers/mmc/host/mtk-sd.c | 94 > ++- > 1 file changed, 93 insertions(+), 1 deletion(-) > > diff --git a/

Re: [PATCH v2 3/5] mmc: mediatek: Add PM support for MMC driver

2015-04-19 Thread Sascha Hauer
On Tue, Mar 17, 2015 at 11:13:53AM +0800, Chaotian Jing wrote: > Add PM support for Mediatek MMC driver > > Signed-off-by: Chaotian Jing > --- > drivers/mmc/host/mtk-sd.c | 94 > ++- > 1 file changed, 93 insertions(+), 1 deletion(-) > > @@ -1003,6 +1

Re: [PATCH v2 2/5] mmc: mediatek: Add Mediatek MMC driver

2015-04-17 Thread Sascha Hauer
Hi Chaotian, On Tue, Mar 17, 2015 at 11:13:52AM +0800, Chaotian Jing wrote: > Add Mediatek MMC driver code > [...] > + host->dev = &pdev->dev; > + host->mmc = mmc; > + /* Set host parameters to mmc */ > + mmc->ops = &mt_msdc_ops; > + mmc->f_min = 26; > + mmc->ocr_ava

Re: [PATCH v2 2/5] mmc: mediatek: Add Mediatek MMC driver

2015-04-17 Thread Sascha Hauer
Ulf, On Tue, Mar 31, 2015 at 02:23:06PM +0200, Ulf Hansson wrote: > On 17 March 2015 at 04:13, Chaotian Jing wrote: > > + > > + msdc_set_buswidth(host, ios->bus_width); > > + > > + /* Suspend/Resume will do power off/on */ > > + switch (ios->power_mode) { > > + case MMC_PO

Re: [PATCH V3 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-16 Thread Sascha Hauer
On Fri, Jan 16, 2015 at 01:37:41PM +0100, Ulf Hansson wrote: > On 16 January 2015 at 12:34, Tomeu Vizoso wrote: > > On 16 January 2015 at 11:47, Ulf Hansson wrote: > >> > >> int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev) > >> { > >> struct mmc_pwrseq_simple *pwrs

Re: [PATCH v2 2/2] mmc: mxcmmc: fix the default value for available voltages into mxcmci_probe

2014-10-10 Thread Sascha Hauer
omment in platform_data/mmc-mxcmmc.h, > fix it, assuming MMC_VDD_32_33 | MMC_VDD_33_34 as default value. > > Signed-off-by: Matteo Facchinetti Looks okay now. Reviewed-by: Sascha Hauer Sascha > --- > v2: > * Add test to check if mmc->ocr_avail is setted by mmc_regulator_ge

Re: [PATCH 1/2] mmc: mxcmmc: fix race condition when dma finish a data transfer

2014-10-07 Thread Sascha Hauer
re the patch behaves correctly. Acked-by: Sascha Hauer Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0

Re: [PATCH 2/2] mmc: mxcmmc: fix the default value for available voltages into mxcmci_probe

2014-10-07 Thread Sascha Hauer
On Tue, Sep 30, 2014 at 04:59:38PM +0200, Matteo Facchinetti wrote: > From: Matteo Facchinetti > > If available voltages are not given, mmc_regulator_get_supply() function > returns 0 and mxcmmc driver doesn't set a value for ocr_avail mask. > > In accordance with the comment in platform_data/mm

Re: [PATCH] mmc: mxs: fix card detection in case of 'broken-cd' flag set

2014-07-06 Thread Sascha Hauer
will not do > further card inition. > > This patch is just an attempt to partially revert the patch > a91fe279ae of Sascha Hauer, where it is claimed that upper > layer will handle broken card detection using the polling > logic and MMC_CAP_NEEDS_POLL capability, but seems it is n

Re: [PATCH 5/5] ARM: dts: imx51-babbage: Fix esdhc setup

2014-06-05 Thread Sascha Hauer
On Sun, Jun 01, 2014 at 11:22:19PM +0800, Shawn Guo wrote: > On Fri, May 23, 2014 at 02:33:04PM +0200, Sascha Hauer wrote: > > - Move cd/wp pinctrl from the hog group to the esdhc groups > > - use gpio for card detection / write protection on esdhc2 since > > the controller

Re: [linux-sunxi] [PATCH v2 1/4] dt: bindings: mmc: Document the practice of using subnodes for slots

2014-06-01 Thread Sascha Hauer
On Sun, Jun 01, 2014 at 11:23:48AM +0200, Hans de Goede wrote: > Hi, > > >Neither seems to actually ever have been used with > >more than one slot. I doubt anyone building an exynos-based system > >will ever do a multi-slot solution, and it seems that the at91 driver > >doesn't actually handle mor

Re: [PATCH 1/5] mmc: sdhci-esdhc-imx: add f_max field to private data

2014-06-01 Thread Sascha Hauer
On Sun, Jun 01, 2014 at 03:45:43PM +0800, Shawn Guo wrote: > > @@ -594,7 +592,7 @@ static inline void esdhc_pltfm_set_clock(struct > > sdhci_host *host, > > { > > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > > struct pltfm_imx_data *imx_data = pltfm_host->priv; > > - unsign

Re: adding aliases to mmc ... again

2014-05-23 Thread Sascha Hauer
On Fri, May 23, 2014 at 10:01:53AM -0600, Stephen Warren wrote: > On 05/23/2014 03:23 AM, Sascha Hauer wrote: > ... > > Speaking of which my preferred solution is another one. As a bootloader > > developer it really annoys me that I don't have the possibility to tell &

[PATCH] mmc: implement driver stage register handling

2014-05-23 Thread Sascha Hauer
card.) As the value of the dsr register is board specific this adds a 'dsr' devicetree property which is handled in mmc_of_parse. Signed-off-by: Sascha Hauer --- Documentation/devicetree/bindings/mmc/mmc.txt | 3 +++ drivers/mmc/core/host.c | 3 +++ drivers/mmc/

[PATCH 1/5] mmc: sdhci-esdhc-imx: add f_max field to private data

2014-05-23 Thread Sascha Hauer
The driver filled in the clk and clock fields in struct sdhci_pltfm_host, but they are unused in the sdhci-pltfm code and only ever used it for internal use. This adds a field f_max to private data and uses it instead. Signed-off-by: Sascha Hauer --- drivers/mmc/host/sdhci-esdhc-imx.c | 18

[PATCH 3/5] mmc: sdhci-esdhc-imx: straighten SDHCI_QUIRK_BROKEN_CARD_DETECTION flag

2014-05-23 Thread Sascha Hauer
The driver always sets the flag and clears it afterwards in some cases. Instead, leave the flag cleared and set it when needed which makes the code easier to read. Signed-off-by: Sascha Hauer --- drivers/mmc/host/sdhci-esdhc-imx.c | 9 - 1 file changed, 4 insertions(+), 5 deletions

[PATCH 4/5] mmc: sdhci-esdhc-imx: use mmc_of_parse

2014-05-23 Thread Sascha Hauer
-by: Sascha Hauer --- drivers/mmc/host/sdhci-esdhc-imx.c | 175 +++-- 1 file changed, 90 insertions(+), 85 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 620cbcd..8c0af44 100644 --- a/drivers/mmc/host/sdhci

[PATCH 2/5] mmc: sdhci-esdhc-imx: introduce function for parsing platform_data

2014-05-23 Thread Sascha Hauer
the devicetree probing path. Signed-off-by: Sascha Hauer --- drivers/mmc/host/sdhci-esdhc-imx.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index d530820..f6f7a45

[PATCH 5/5] ARM: dts: imx51-babbage: Fix esdhc setup

2014-05-23 Thread Sascha Hauer
. Signed-off-by: Sascha Hauer --- arch/arm/boot/dts/imx51-babbage.dts | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts index 9e9deb2..28d4553 100644 --- a/arch/arm/boot/dts/imx51

[PATCH] MMC: use mmc_of_parse in sdhci-esdhc-imx

2014-05-23 Thread Sascha Hauer
and move platform_data parsing out of the way for the devicetree path first. The last patch fixes the card/write protection for the babbage board and can be taken independently of the rest by Shawn. Sascha Sascha Hauer (5): mmc

Re: adding aliases to mmc ... again

2014-05-23 Thread Sascha Hauer
On Thu, May 22, 2014 at 01:23:27PM -0600, Stephen Warren wrote: > >> Does it solve the following, which AFAIK has always been the primary > >> argument against aligning block device IDs with controller IDs: > >> > >> - User inserts SD card into MMC controller ID (or alias) 1. > >> - /dev/mmcblk1 no

Re: adding aliases to mmc ... again

2014-05-22 Thread Sascha Hauer
On Thu, May 22, 2014 at 10:16:35AM -0600, Stephen Warren wrote: > On 05/22/2014 09:30 AM, Sascha Hauer wrote: > > Hi all, > > > > The wish to have persistent MMC block device names for passing a suitable > > root=/dev/mmcblkX option came up several times already and has

[PATCH 2/2] mmc: Allow setting slot index via devicetree alias

2014-05-22 Thread Sascha Hauer
act as before. Signed-off-by: Sascha Hauer --- drivers/mmc/card/block.c | 11 ++- drivers/mmc/core/core.c | 37 + drivers/mmc/core/host.c | 17 +++-- include/linux/mmc/core.h | 3 +++ 4 files changed, 65 insertions(+), 3 deletions(-) diff

[PATCH 1/2] of: Add helper for getting the maximum alias index for a stem

2014-05-22 Thread Sascha Hauer
of_alias_max_index will return the maximum number for which an alias of a given stem exists. This is useful for frameworks whishing to reserve a number of device slots from dynamic allocation. Signed-off-by: Sascha Hauer --- drivers/of/base.c | 29 + include/linux

adding aliases to mmc ... again

2014-05-22 Thread Sascha Hauer
Sascha Hauer (2): of: Add helper for getting the maximum alias index for a stem mmc: Allow setting slot index via devicetree alias drivers/mmc/card/block.c | 11 ++- drivers/mmc/core/core.c | 37 + drivers/mmc/core/host.c | 17

Re: How to fix SDIO Operating Frequency in iMX6 device tree

2014-05-15 Thread Sascha Hauer
Hi Ashutosh, On Thu, May 15, 2014 at 11:19:01AM +0530, Ashutosh Singh wrote: > I want to fixed the SDIO Operating Frequency to 25MHz for one of the > SDIO based Wifi module connected to Card slot. > How can i fixed it in my dtsi file. I am using iMX6 quard based custom board. Set the max-frequenc

Re: [PATCH] mmc: mxs: fix card detection function for broken card detect

2014-04-28 Thread Sascha Hauer
On Mon, Apr 28, 2014 at 11:31:03AM +0200, Ulf Hansson wrote: > On 28 April 2014 11:13, Sascha Hauer wrote: > > On Sat, Apr 19, 2014 at 11:59:18PM +0200, Daniel Willmann wrote: > >> Return -ENOSYS in get_cd if broken-cd is specified in the device tree. > >> > >>

Re: [PATCH] mmc: mxs: fix card detection function for broken card detect

2014-04-28 Thread Sascha Hauer
eturn value it will attempt to > initialize the card. So retuning -ENOSYS will allow the card to be > initialized. > For comparison, mmc_gpio_get_cd in slot-gpio.c also returns -ENOSYS if > the card detect GPIO is not valid. Short answer for fixing this regression: Acked-by: Sascha Hauer

[PATCH] mmc: Add SDIO function devicetree subnode parsing

2014-04-03 Thread Sascha Hauer
. SDIO drivers will find a pointer to the devicenode in their devices of_node pointer. Signed-off-by: Sascha Hauer Cc: linux-mmc@vger.kernel.org Cc: Chris Ball Cc: linux-ker...@vger.kernel.org Cc: Luciano Coelho Cc: devicet...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org

Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset

2014-01-24 Thread Sascha Hauer
On Thu, Jan 23, 2014 at 05:01:49PM +0800, Chris Ruehl wrote: > On Wednesday, January 22, 2014 03:23 PM, Sascha Hauer wrote: > >On Wed, Jan 22, 2014 at 03:19:48PM +0800, Chris Ruehl wrote: > >>On Wednesday, January 22, 2014 02:42 PM, Sascha Hauer wrote: > >>>On Wed, Ja

Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset

2014-01-21 Thread Sascha Hauer
On Wed, Jan 22, 2014 at 03:19:48PM +0800, Chris Ruehl wrote: > On Wednesday, January 22, 2014 02:42 PM, Sascha Hauer wrote: > >On Wed, Jan 22, 2014 at 12:32:39PM +0800, Chris Ruehl wrote: > >>Function mxcmci_request() throw an exception on a imx27 cpu. > >>This patch

Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset

2014-01-21 Thread Sascha Hauer
On Wed, Jan 22, 2014 at 12:32:39PM +0800, Chris Ruehl wrote: > Function mxcmci_request() throw an exception on a imx27 cpu. > This patch fix the problem by test the pointer before access it. > > diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c > index f7199c8..8645d6a 100644 > --

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-01-20 Thread Sascha Hauer
On Tue, Jan 21, 2014 at 08:24:47AM +0100, Sascha Hauer wrote: > On Sun, Jan 19, 2014 at 07:56:53PM -0800, Olof Johansson wrote: > > +Card power and reset control: > > +The following properties can be specified for cases where the MMC > > +peripheral needs additional reset

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-01-20 Thread Sascha Hauer
On Sun, Jan 19, 2014 at 07:56:53PM -0800, Olof Johansson wrote: > This patch enables support for power-on sequencing of SDIO peripherals > through DT. > > In general, it's quite common that wifi modules and other similar > peripherals have several signals in addition to the SDIO interface that >

[PATCH 3/6] mmc: mxs: use standard flag for broken card detection

2013-12-05 Thread Sascha Hauer
. Signed-off-by: Sascha Hauer --- drivers/mmc/host/mxs-mmc.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 374fca7..02210ce 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -72,7

[PATCH 2/6] mmc: mxs: use standard flag for non-removable status

2013-12-05 Thread Sascha Hauer
The standard caps already have a MMC_CAP_NONREMOVABLE flag. Use it rather than a custom non_removable flag. Signed-off-by: Sascha Hauer --- drivers/mmc/host/mxs-mmc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs

[PATCH 6/6] mmc: mxs: use mmc_of_parse to parse devicetree properties

2013-12-05 Thread Sascha Hauer
Use generic helper function. This also adds support for the cd-gpios and max-frequency devicetree properties. Signed-off-by: Sascha Hauer --- drivers/mmc/host/mxs-mmc.c | 37 +++-- 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host

mmc: mxs: Use mmc_of_parse

2013-12-05 Thread Sascha Hauer
We have a generic mmc_of_parse function. Use it in the mxs-mmc driver to make the code simpler and to parse some new devicetree propeties. Sascha Sascha Hauer (6): mmc: Do not call get_cd for non removable cards mmc

[PATCH 4/6] mmc: mxs: use standard flag for cd inverted

2013-12-05 Thread Sascha Hauer
We have a MMC_CAP2_CD_ACTIVE_HIGH flag, so use it rather than a custom driver specific flag. Signed-off-by: Sascha Hauer --- drivers/mmc/host/mxs-mmc.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c

[PATCH 5/6] mmc: mxs: use mmc_gpio_get_ro for detecting read-only status

2013-12-05 Thread Sascha Hauer
This also fixes that the read-only gpio was used without being requested. Signed-off-by: Sascha Hauer --- drivers/mmc/host/mxs-mmc.c | 34 +++--- 1 file changed, 11 insertions(+), 23 deletions(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c

[PATCH 1/6] mmc: Do not call get_cd for non removable cards

2013-12-05 Thread Sascha Hauer
Non removable cards are always present, so do not call get_cd for them. Signed-off-by: Sascha Hauer --- drivers/mmc/core/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 57a2b40..098374b 100644 --- a/drivers/mmc

Re: [PATCH 16/27] mmc: mxcmmc: Move away from using deprecated APIs

2013-09-27 Thread Sascha Hauer
> use of the deprecated APIs. > > Cc: Sascha Hauer > Cc: Anatolij Gustschin > Signed-off-by: Ulf Hansson Acked-by: Sascha Hauer Sascha > --- > drivers/mmc/host/mxcmmc.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/dr

Re: [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Sascha Hauer
On Mon, Sep 23, 2013 at 05:20:18PM +0200, Johan Hovold wrote: > On Mon, Sep 23, 2013 at 04:50:29PM +0200, Sascha Hauer wrote: > > On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote: > > > Deferred probing cannot be used with platform_driver_probe as by the > > &

Re: [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Sascha Hauer
On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote: > Deferred probing cannot be used with platform_driver_probe as by the > time probing is retried either the driver has been unregistered or its > probe function has been set to platform_drv_probe_fail. > > With commit e9354576 ("gpiolib

Re: Adding aliases to mmc

2013-09-21 Thread Sascha Hauer
On Sat, Sep 21, 2013 at 02:30:51PM +0200, Michael Olbrich wrote: > Hi, > > > > > > > An embedded system typically doesn't have an initrd. The kernel > > > boots directly into the rootfs on SD/eMMC. > > > > > > >>To my understanding, the UUID is different for each SD card/eMMC, > > > >>correct?

Re: Adding aliases to mmc

2013-09-21 Thread Sascha Hauer
Hi Dirk, On Sat, Sep 21, 2013 at 07:23:27AM +0200, Dirk Behme wrote: > Am 20.09.2013 19:03, schrieb Stephen Warren: > >On 09/20/2013 10:37 AM, Dirk Behme wrote: > >>Am 20.09.2013 18:05, schrieb Stephen Warren: > >>>On 09/18/2013 11:22 PM, Dirk Behme wrote: > >>>... > If you have an embedded sy

Re: [PATCH 8/8] ARM: dts: imx6qdl: add uhs pinctrl state for usdhc3

2013-09-05 Thread Sascha Hauer
On Wed, Sep 04, 2013 at 08:54:17PM +0800, Dong Aisheng wrote: > This is needed for supporting ultra high speed cards like SD3.0 cards. > > Signed-off-by: Dong Aisheng > --- > arch/arm/boot/dts/imx6dl.dtsi| 33 > ++ > arch/arm/boot/dts/imx6q.dtsi

Re: [PATCH v1 1/1] mmc: mxcmmc: setup mpc512x related clocks

2013-05-15 Thread Sascha Hauer
On Tue, May 14, 2013 at 05:00:09PM +0200, Gerhard Sittig wrote: > the mxcmmc(4) driver is shared across the i.MX and MPC512x platforms, > setup the 'sdhc_clk' instead of 'ipg' and 'per' in the mpc512x case > > this change re-uses the i.MX 'per' clock related variable for everything > SDHC/MMC rela

Re: [PATCH] mmc: mxcmmc: Fix bug when card is present during boot

2013-04-09 Thread Sascha Hauer
t; function is executed, but the timer is not initialized. Acked-by: Sascha Hauer Sascha > > ... > i.MX SDHC driver > mmc0: SD Status: Invalid Allocation Unit size. > mmc0: new SD card at address b368 > mmcblk0: mmc0:b368 SDC 1.91 GiB > [ cut here ]

Re: [PATCH v2 4/5] mmc: mxcmmc: enable DMA support on mpc512x

2013-04-02 Thread Sascha Hauer
On Tue, Apr 02, 2013 at 09:29:44AM +0200, Anatolij Gustschin wrote: > On Tue, 2 Apr 2013 08:56:54 +0200 > Sascha Hauer wrote: > ... > > > @@ -336,6 +359,8 @@ static int mxcmci_setup_data(struct mxcmci_host > > > *host, struct mmc_data *data) > > > }

Re: [PATCH v2 0/5] mmc: mxcmmc: add mpc512x support

2013-04-02 Thread Sascha Hauer
based on the following v3 mxcmmc DT > support patch: > >https://patchwork.kernel.org/patch/2368631 > > Changes in v2 series are mentioned in each patch With the two comments I made fixed you can add my: Acked-by: Sascha Hauer

Re: [PATCH v2 5/5] mmc: mxcmmc: fix race conditions for host->req and host->data access

2013-04-01 Thread Sascha Hauer
On Mon, Apr 01, 2013 at 12:23:05AM +0200, Anatolij Gustschin wrote: > mxcmci_dma_callback() is invoked by DMA drivers in soft-irq > context and can be interrupted by the mxcmci_irq() interrupt > which can finish the mmc request or data transfer and set > host->req or host->data pointers to NULL. Th

Re: [PATCH v2 4/5] mmc: mxcmmc: enable DMA support on mpc512x

2013-04-01 Thread Sascha Hauer
On Mon, Apr 01, 2013 at 12:23:04AM +0200, Anatolij Gustschin wrote: > Add SDHC DMA channel description to the mpc512x device > tree to enable slave channel requesting in the mxcmmc > driver. > > mpc512x DMA engine doesn't support endianness conversion > when reading/writing data from peripheral's

Re: [PATCH 4/5] mmc: mxcmmc: enable DMA support on mpc512x

2013-03-14 Thread Sascha Hauer
On Thu, Mar 14, 2013 at 05:40:53PM +0100, Anatolij Gustschin wrote: > Add SDHC DMA channel description to the mpc512x device > tree to enable slave channel requesting in the mxcmmc > driver. > > mpc512x DMA engine doesn't support endianness conversion > when reading/writing data from peripheral's

Re: [PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

2013-03-14 Thread Sascha Hauer
On Thu, Mar 14, 2013 at 07:13:32PM +0100, Anatolij Gustschin wrote: > On Thu, 14 Mar 2013 17:50:08 +0100 > Arnd Bergmann wrote: > > > On Thursday 14 March 2013 17:40:49 Anatolij Gustschin wrote: > > > > > + > > > +struct mxcmci_reg_ops mxcmci_reg_ops = { > > > + .read_l = mpcmci_readl, > > > + .

Re: [PATCH v5 03/13] mmc: provide a standard MMC device-tree binding parser centrally

2013-02-16 Thread Sascha Hauer
Hi Guennadi, On Sat, Feb 16, 2013 at 04:21:16PM +0100, Guennadi Liakhovetski wrote: > MMC defines a number of standard DT bindings. Having each driver parse > them individually adds code redundancy and is error prone. Provide a > standard function to unify the parsing. After all drivers are conver

Re: [PATCH v2] mmc: mxcmmc: fix SD cards not being detected sometimes.

2012-11-02 Thread Sascha Hauer
cted. > > In order to solve this problem, do not use DMA for transfer sizes lower > than the sector size. > > Signed-off-by: Javier Martin Acked-by: Sascha Hauer Sascha > --- > Changes since v1: > - Do not remove the check "sg->length & 3". > &g

Re: [PATCH] mmc: mxcmmc: Fix MODULE_ALIAS

2012-10-29 Thread Sascha Hauer
On Tue, Oct 09, 2012 at 04:26:05PM -0300, Fabio Estevam wrote: > The correct name for the driver is "mxc-mmc". > > Signed-off-by: Fabio Estevam Acked-by: Sascha Hauer Sascha > --- > drivers/mmc/host/mxcmmc.c |2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH 3/3] mmc: esdhc i.MX: Support 8bit mode

2012-09-25 Thread Sascha Hauer
On Tue, Sep 25, 2012 at 04:50:52PM +0800, Shawn Guo wrote: > On Tue, Sep 25, 2012 at 10:05:25AM +0200, Sascha Hauer wrote: > > Ok, how about this: > > > > - I add a bus-width = <4> property to all i.MX dtsi files > > - we merge the patch adding bus-width as an opt

Re: [PATCH 3/3] mmc: esdhc i.MX: Support 8bit mode

2012-09-25 Thread Sascha Hauer
On Tue, Sep 25, 2012 at 03:45:50PM +0800, Shawn Guo wrote: > On Tue, Sep 25, 2012 at 09:38:08AM +0200, Sascha Hauer wrote: > > So you want to make the code conform to the common spec which has > > bus-width as a required property. Is this really worth it to add an > > incom

Re: [PATCH 3/3] mmc: esdhc i.MX: Support 8bit mode

2012-09-25 Thread Sascha Hauer
On Tue, Sep 25, 2012 at 03:33:19PM +0800, Shawn Guo wrote: > On Tue, Sep 25, 2012 at 09:27:15AM +0200, Sascha Hauer wrote: > > > > Optional properties: > > > > - fsl,cd-controller : Indicate to use controller internal card > > > > detection > &g

Re: [PATCH 3/3] mmc: esdhc i.MX: Support 8bit mode

2012-09-25 Thread Sascha Hauer
On Tue, Sep 25, 2012 at 03:15:08PM +0800, Shawn Guo wrote: > On Mon, Sep 24, 2012 at 09:22:25AM +0200, Sascha Hauer wrote: > > The i.MX esdhc has a nonstandard bit layout for the SDHCI_HOST_CONTROL > > register. To support 8bit bus width on i.MX populate the platform_bus_width >

Re: [PATCH 1/3] mmc: sdhci: rename platform_8bit_width to platform_bus_width

2012-09-24 Thread Sascha Hauer
On Tue, Sep 25, 2012 at 11:35:14AM +0900, Jaehoon Chung wrote: > On 09/24/2012 04:22 PM, Sascha Hauer wrote: > > /* > > * If your platform has 8-bit width support but is not a v3 controller, > > * or if it requires special setup code, you sho

[PATCH 1/3] mmc: sdhci: rename platform_8bit_width to platform_bus_width

2012-09-24 Thread Sascha Hauer
The 8bit in the function name is misleading. When set, it will be used to set the bus width, regardless of whether 8bit or another bus width is requested, so change the function name to platform_bus_width. Signed-off-by: Sascha Hauer --- drivers/mmc/host/sdhci-pci.c |4 ++-- drivers/mmc

[PATCH] mmc: sdhci / i.MX esdhc buswidth patches

2012-09-24 Thread Sascha Hauer
The first patch is a generic sdhci driver cleanup change, the others are i.MX specific, adding 8bit bus support and fix version register readout. Sascha Sascha Hauer (3): mmc: sdhci: rename platform_8bit_width to

[PATCH 2/3] mmc: esdhc i.MX: Fix version register read

2012-09-24 Thread Sascha Hauer
by returning the version based on the devtype data leaving the useless version register untouched. Signed-off-by: Sascha Hauer --- drivers/mmc/host/sdhci-esdhc-imx.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b

[PATCH 3/3] mmc: esdhc i.MX: Support 8bit mode

2012-09-24 Thread Sascha Hauer
having a SDHCI_SPEC_300 controller, still uses the same nonstandard register layout. Signed-off-by: Sascha Hauer --- .../devicetree/bindings/mmc/fsl-imx-esdhc.txt |1 + arch/arm/plat-mxc/include/mach/esdhc.h |1 + drivers/mmc/host/sdhci-esdhc-imx.c | 56

Re: [PATCH] mmc: mxcmmc: fix SD cards not being detected sometimes.

2012-09-19 Thread Sascha Hauer
On Wed, Sep 19, 2012 at 01:21:07PM +0200, Javier Martin wrote: > When a SD card is initialized some data transfers of 64 and 8 bytes > are issued. It seems the DMA has some problems dealing with these kind > of "short" transfers, leading sometimes to the SD card not being detected. > > In order to

Re: [PATCH 00/34] i.MX multi-platform support

2012-09-18 Thread Sascha Hauer
Hi Shawn, On Mon, Sep 17, 2012 at 01:34:29PM +0800, Shawn Guo wrote: > The series enables multi-platform support for imx. Since the required > frameworks (clk, pwm) and spare_irq have already been adopted on imx, > the series is all about cleaning up mach/* headers. Along with the > changes, arc

Re: [PATCH 00/34] i.MX multi-platform support

2012-09-17 Thread Sascha Hauer
ks. The config should be updated with the last patch. I'm fine with the changes to mx2-camera, but Javier should give his ok to it, he has worked on it quite a lot recently. One other issue related to imx-dma, see comment to that patch. Otherwise

Re: [PATCH v2] mmc: mxcmmc: fix bug that may block a data transfer forever.

2012-09-10 Thread Sascha Hauer
gt; - Use DMA callbacks for reading and MMC irqs for writing instead > of monitoring both irqs for each transfer. > - Increase timeout to 10 seconds to give enough time to slow cards. > Looks good now, thanks. Reviewed-by: Sascha Hauer > --- > drivers/mmc/host/mxcmmc.c |

Re: [PATCH] mmc: mxcmmc: fix bug that may block a data transfer forever.

2012-09-06 Thread Sascha Hauer
On Thu, Sep 06, 2012 at 09:40:48AM +0200, Javier Martin wrote: > The problem can be easily reproduced using a script that loops > copying a file in an SD card to another place in the same SD card > and its related to read transfers. This only happens with DMA enabled. > > This is related to the fa

Re: [PATCH] mmc: remove imxmmc driver

2012-04-11 Thread Sascha Hauer
On Wed, Apr 11, 2012 at 04:05:51PM -0400, Chris Ball wrote: > Hi Sascha, > > On Wed, Apr 11 2012, Sascha Hauer wrote: > > This driver is broken since 2.6.31 when the traditional i.MX1 > > support was removed. > > > > In theory the i.MX1 mmc controller can be s

[PATCH v2] mmc: remove imxmmc driver

2012-04-11 Thread Sascha Hauer
in a different driver structure. At that time it seemed easier to write a second driver to support hardware without bugs. As noone cared for the i.MX1 driver for a long time and it does not compile, remove it. Signed-off-by: Sascha Hauer --- v2: Also remove imxmmc.h drivers/mmc/host/Kconfig

[PATCH] mmc: remove imxmmc driver

2012-04-11 Thread Sascha Hauer
in a different driver structure. At that time it seemed easier to write a second driver to support hardware without bugs. As noone cared for the i.MX1 driver for a long time and it does not compile, remove it. Signed-off-by: Sascha Hauer --- drivers/mmc/host/Kconfig | 10 - drivers/mmc/host

Re: [PATCH] mmc: remove linux/blkdev.h include from host drivers

2012-04-11 Thread Sascha Hauer
On Wed, Apr 11, 2012 at 11:39:12AM -0400, Chris Ball wrote: > Hi Sascha, Wolfram, > > On Tue, Apr 10 2012, Dmitry Artamonow wrote: > > I've compile tested everything with and without CONFIG_BLOCK enabled, > > except for imxmmc.c - this driver seems to be long time broken > > (at least since the re

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-14 Thread Sascha Hauer
On Tue, Mar 13, 2012 at 04:47:04PM +0800, Dong Aisheng wrote: > From: Dong Aisheng > > This patch includes basic dt support which can boot via nfs rootfs. > > Signed-off-by: Dong Aisheng > --- > Documentation/devicetree/bindings/arm/fsl.txt |4 + > arch/arm/boot/dts/imx28-evk.dts

Re: [PATCH v1 3/5] ARM: imx28evk: add mmc dt support

2012-03-13 Thread Sascha Hauer
On Tue, Mar 13, 2012 at 09:39:30AM -0500, Rob Herring wrote: > On 03/13/2012 03:47 AM, Dong Aisheng wrote: > > From: Dong Aisheng > > > > Signed-off-by: Dong Aisheng > > --- > > arch/arm/boot/dts/imx28-evk.dts | 14 ++ > > arch/arm/boot/dts/imx28.dtsi| 33 +++

Re: [PATCH] mmc sdhci i.MX5: make mmc cards work

2012-02-20 Thread Sascha Hauer
On Mon, Feb 20, 2012 at 02:31:36PM +0800, Shawn Guo wrote: > I do not have a mmc card to test the patch, but I tested it and > confirmed it does not break anything about SD support. > > On Fri, Feb 17, 2012 at 11:51:49AM +0100, Sascha Hauer wrote: > > On i.MX53 we have

[PATCH] mmc sdhci i.MX5: make mmc cards work

2012-02-17 Thread Sascha Hauer
MMC_SET_BLOCK_COUNT command aswell. Tested on a custom i.MX53 board with a Transcend MMC+ card and eMMC. Signed-off-by: Sascha Hauer --- drivers/mmc/host/sdhci-esdhc-imx.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc

Re: [alsa-devel] [PATCH 1/7 v2] dmaengine: add a simple dma library

2012-01-26 Thread Sascha Hauer
Hi Guennadi, On Thu, Jan 26, 2012 at 03:56:18PM +0100, Guennadi Liakhovetski wrote: > This patch adds a library of functions, helping to implement dmaengine > drivers for hardware, unable to handle scatter-gather lists natively. > The first version of this driver only supports memcpy and slave DMA

Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-11-28 Thread Sascha Hauer
Dooks > Cc: Viresh Kumar > Cc: Guennadi Liakhovetski > Cc: Ian Molton > Cc: Sascha Hauer > Cc: Wolfram Sang > Cc: Grant Likely > Cc: Anton Vorontsov > Cc: Linus Walleij > Signed-off-by: Axel Lin For the mx

Re: [PATCH v2] mmc mxcmmc: fix falling back to PIO

2011-11-11 Thread Sascha Hauer
On Fri, Nov 11, 2011 at 04:13:41PM +0100, Lothar Waßmann wrote: > Hi, > > Sascha Hauer writes: > > Hi Chris, > > > > Can you take this one please? > > > > Sascha > > > > On Thu, Aug 25, 2011 at 11:33:05AM +0200, Sascha Hauer wrote: > >

[PATCH] mmc mxcmmc: fix falling back to PIO

2011-11-11 Thread Sascha Hauer
When we can't configure the dma channel we want to fall back to PIO. We do this by setting host->do_dma to zero. This does not work as do_dma is used to see whether dma can be used for the current transfer. Instead, we have to set host->dma to NULL. Signed-off-by: Sascha Hauer Cc: Chr

Re: [PATCH v2] mmc mxcmmc: fix falling back to PIO

2011-11-11 Thread Sascha Hauer
Hi Chris, Can you take this one please? Sascha On Thu, Aug 25, 2011 at 11:33:05AM +0200, Sascha Hauer wrote: > When we can't configure the dma channel we want to fall > back to PIO. We do this by setting host->do_dma to zero. > This does not work as do_dma is used to see whe

Re: [PATCH V2 01/14] clk: add helper functions clk_prepare_enable and clk_disable_unprepare

2011-11-11 Thread Sascha Hauer
On Fri, Nov 11, 2011 at 10:27:27AM +, Russell King - ARM Linux wrote: > On Fri, Nov 11, 2011 at 10:15:56AM +0100, Sascha Hauer wrote: > > On Fri, Nov 11, 2011 at 05:05:47PM +0800, Richard Zhao wrote: > > > { > > > int ret; > > > > > &

Re: [PATCH V2 01/14] clk: add helper functions clk_prepare_enable and clk_disable_unprepare

2011-11-11 Thread Sascha Hauer
On Fri, Nov 11, 2011 at 05:05:47PM +0800, Richard Zhao wrote: > On Fri, Nov 11, 2011 at 09:49:50AM +0100, Sascha Hauer wrote: > > On Fri, Nov 11, 2011 at 09:10:16AM +0800, Richard Zhao wrote: > > > Signed-off-by: Richard Zhao > > > --- > &

Re: [PATCH V2 01/14] clk: add helper functions clk_prepare_enable and clk_disable_unprepare

2011-11-11 Thread Sascha Hauer
On Fri, Nov 11, 2011 at 09:10:16AM +0800, Richard Zhao wrote: > Signed-off-by: Richard Zhao > --- > include/linux/clk.h | 19 +++ > 1 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/include/linux/clk.h b/include/linux/clk.h > index 7213b52..63985f7 100644 > ---

Re: [PATCH v2] mmc mxcmmc: fix falling back to PIO

2011-08-25 Thread Sascha Hauer
On Thu, Aug 25, 2011 at 11:33:05AM +0200, Sascha Hauer wrote: > When we can't configure the dma channel we want to fall > back to PIO. We do this by setting host->do_dma to zero. > This does not work as do_dma is used to see whether dma > can be used for the current transfer. I

[PATCH v2] mmc mxcmmc: fix falling back to PIO

2011-08-25 Thread Sascha Hauer
When we can't configure the dma channel we want to fall back to PIO. We do this by setting host->do_dma to zero. This does not work as do_dma is used to see whether dma can be used for the current transfer. Instead, we have to set host->dma to NULL. Signed-off-by: Sascha Hauer Cc: Chr

Re: [PATCH] mmc mxcmmc: fix falling back to PIO

2011-08-25 Thread Sascha Hauer
On Thu, Aug 25, 2011 at 11:06:12AM +0200, Sascha Hauer wrote: > When we can't configure the dma channel we want to fall > back to PIO. We do this by setting host->do_dma to zero. > This does not work as do_dma is used to see whether dma > can be used for the current transfer. I

[PATCH] mmc mxcmmc: fix falling back to PIO

2011-08-25 Thread Sascha Hauer
When we can't configure the dma channel we want to fall back to PIO. We do this by setting host->do_dma to zero. This does not work as do_dma is used to see whether dma can be used for the current transfer. Instead, we have to set host->dma to NULL. Signed-off-by: Sascha Hauer Cc: Chr

  1   2   >