[PATCH v2] Fix for checking block numbers in disable emulation mode

2012-07-06 Thread Saugata Das
From: Saugata Das In 512B disable emulation patch, a check is done to ensure that size of the data is multiple of 4KB within mmc_blk_issue_rw_rq. However, the check is done with brq->data.blocks, which is not initialized at the point of check. This is now changed to blk_rq_sectors. In addit

Re: [PATCH] mmc: core: Revert "skip card initialization if powerclass selection fails"

2012-07-02 Thread Saugata Das
On 2 July 2012 16:47, Marc Dietrich wrote: > Am Montag, 2. Juli 2012, 14:13:31 schrieb Saugata Das: >> On 2 July 2012 12:26, Venkatraman S wrote: >> > This reverts commit 3d93576e(skip card initialization if >> > power class selection fails). >> > Problem has

Re: [PATCH] mmc: core: Revert "skip card initialization if power class selection fails"

2012-07-02 Thread Saugata Das
y: Venkatraman S > CC: Ulf Hansson > CC: Subhash Jadavani > CC: Saugata Das > --- > drivers/mmc/core/mmc.c | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index 258b203.

Re: [PATCH] [MMC 4.5] Fix for checking block numbers in disable emulation mode

2012-06-29 Thread Saugata Das
On 29 June 2012 15:42, Seungwon Jeon wrote: > Hi Saugata, > > Could you check the comment below? > > Friday, June 29, 2012, Saugata Das wrote: >> From: Saugata Das >> >> In 512B disable emulation patch, a check is done to ensure that size >> of the data is

[PATCH] MMC-4.5 Power OFF Notify Rework

2012-06-29 Thread Saugata Das
From: Saugata Das This is a rework of the existing POWER OFF NOTIFY patch. The CMD0 based reinitialization of the eMMC during mmc_resume is introduced back. Function poweroff_notify has been added as a bus_ops (as desired by the reviewers on a previous version of the patch). Removed the

[PATCH] [MMC 4.5] Fix for checking block numbers in disable emulation mode

2012-06-28 Thread Saugata Das
From: Saugata Das In 512B disable emulation patch, a check is done to ensure that size of the data is multiple of 4KB. However, the check is done with brq->data.blocks, which is not initialized at the point of check. This is now changed to blk_rq_sectors. Signed-off-by: Saugata

Re: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

2012-06-26 Thread Saugata Das
On 26 June 2012 09:18, Seungwon Jeon wrote: > Hi Subhash, > > Subhash Jadavani wrote: >> Hi Seungwon, >> >> Please one comment inline below related to large sector size handling for >> packed commands. >> >> Regards, >> Subhash >> >> > -Original Message- >> > From: linux-mmc-ow...@vger.k

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Saugata Das
On 15 June 2012 16:56, Ulf Hansson wrote: > Hi Saugata, > > snip. > > >> >> The problem in sending CMD0 without power OFF notify is possibility of >> some data loss in MMC-4.5 devices. > > > > I don't see the problem here. You will be sending power OFF notify when >

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Saugata Das
On 15 June 2012 15:22, Per Forlin wrote: > On Fri, Jun 15, 2012 at 10:34 AM, Saugata Das wrote: >> On 15 June 2012 12:52, Ulf Hansson wrote: >>> On 06/15/2012 05:49 AM, Saugata Das wrote: >>>> >>>> On 15 June 2012 00:36, Per Forlin  wrote: >>>&

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Saugata Das
On 15 June 2012 12:52, Ulf Hansson wrote: > On 06/15/2012 05:49 AM, Saugata Das wrote: >> >> On 15 June 2012 00:36, Per Forlin  wrote: >>> >>> Hi Saugata, >>> >>> I can have a go and test it. But first I would like to bring up 3 >>>

[PATCH] MMC-4.5 Power OFF Notify Rework

2012-06-14 Thread Saugata Das
From: Saugata Das This is a rework of the existing POWER OFF NOTIFY patch. The current problem with the patch comes from the ambiguity on the usage of POWER OFF NOTIFY together with SLEEP and misunderstanding on the usage of MMC_POWER_OFF power_mode from mmc_set_ios in different host controller

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-14 Thread Saugata Das
not be sent to the cc-stable list. What do you > think? The problem in sending CMD0 without power OFF notify is possibility of some data loss in MMC-4.5 devices. > > BR > /Per > > On Thu, Jun 14, 2012 at 5:15 PM, Saugata Das wrote: >> On 14 June 2012 20:20, Ulf Hansso

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-14 Thread Saugata Das
On 14 June 2012 20:20, Ulf Hansson wrote: > Hi Girish, > > On 14 June 2012 15:21, Girish K S wrote: >> On 14 June 2012 18:43, Per Forlin wrote: >>> Hi Girish and Suagata, >>> >>> I have run some regression tests with this patch on our board (ux500 >>> family) running suspend and resume of the eM

Re: [PATCH 2/3] ext4: Context support

2012-06-12 Thread Saugata Das
On 12 June 2012 18:59, Arnd Bergmann wrote: > On Tuesday 12 June 2012, Saugata Das wrote: >> On 11 June 2012 17:57, Ted Ts'o wrote: >> > On Mon, Jun 11, 2012 at 02:41:31PM +0300, Artem Bityutskiy wrote: >> > The proof-of-concept patches seem to use the inode n

Re: [PATCH 2/3] ext4: Context support

2012-06-12 Thread Saugata Das
On 11 June 2012 17:57, Ted Ts'o wrote: > On Mon, Jun 11, 2012 at 02:41:31PM +0300, Artem Bityutskiy wrote: >> >> Word "context" is very generic and it is widely used various things, and >> I believe we should try to avoid overloading this term and obfuscating >> the I/O stack with various function

[PATCH 1/3] block: Context support

2012-06-11 Thread Saugata Das
From: Saugata Das On eMMC and UFS devices there is a new feature of setting context with each read or write. The idea is to classify the data from different files and apply the realibility on the complete file instead of individual writes, which helps in performance. A new address space

[PATCH 3/3] mmc: Context support

2012-06-11 Thread Saugata Das
From: Saugata Das This patch implements the context ID support at MMC layer. From file system (ext4), the context is passed in the request structure. At MMC layer the context is retrieved from the request structure and then used in the CMD23 argument. Since number of MMC contexts is limited

[PATCH 2/3] ext4: Context support

2012-06-11 Thread Saugata Das
From: Saugata Das On eMMC and UFS devices there is a new feature of setting context with each read or write. The idea is to classify the data from different files and apply the realibility on the complete file instead of individual writes. On ext4 file system, the inode number of the file is

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-05-28 Thread Saugata Das
esday, May 22, 2012 5:15 PM >> To: linux-mmc@vger.kernel.org >> Cc: c...@laptop.org; patc...@linaro.org; ulf.hans...@stericsson.com; >> saugata@linaro.org; subha...@codeaurora.org; Girish K S >> Subject: [PATCH v5] MMC-4.5 Power OFF Notify Rework >> >> From:

Re: [RFC 3/3] mmc: Context support

2012-05-18 Thread Saugata Das
t;> ow...@vger.kernel.org] On Behalf Of Saugata Das >> Sent: Wednesday, May 16, 2012 9:01 PM >> To: linux-e...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux- >> m...@vger.kernel.org >> Cc: arnd.bergm...@linaro.org; ven...@linaro.org; saugata@linaro.org >

Re: [PATCH v3] MMC-4.5 Power OFF Notify Rework

2012-05-18 Thread Saugata Das
On 18 May 2012 16:29, Subhash Jadavani wrote: > On 5/18/2012 3:16 PM, Girish K S wrote: >> >> From: Saugata Das >> >> This is a rework of the existing POWER OFF NOTIFY patch. The current >> problem >> with the patch comes from the ambiguity on the usage of

Re: [PATCH v2 1/2] [MMC-4.5] Disable emulation

2012-05-17 Thread Saugata Das
On 17 May 2012 17:13, Subhash Jadavani wrote: > Looks good to me. > Reviewed-by: Subhash Jadavani > Thanks Subhash, Namjae Jeon. Chris, will you please merge this patch for your next release. > Regards, > Subhash > >> -Original Message----- >> Fro

Re: [PATCH 2/2] [MMC-4.5] [MMC UTIL] Disable emulation

2012-05-17 Thread Saugata Das
t; Regards, > Subhash > >> -Original Message- >> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- >> ow...@vger.kernel.org] On Behalf Of Saugata Das >> Sent: Wednesday, May 16, 2012 9:57 PM >> To: linux-mmc@vger.kernel.org; ven...@linaro.org >

[PATCH v2 2/2] [MMC-4.5] [MMC UTIL] Disable emulation

2012-05-17 Thread Saugata Das
From: Saugata Das In this patch, we add utility to disable emulation mode in the eMMC-4.5. This is done to increase the data sector size to 4KB. Signed-off-by: Saugata Das changes in v2: Removed extra blank lines around do_disable_512B_emulation Review rework based on comments

[PATCH v2 1/2] [MMC-4.5] Disable emulation

2012-05-17 Thread Saugata Das
From: Saugata Das This patch adds the support for large sector size of 4KB by disabling emulation. This patch passes eMMC DATA_SECTOR_SIZE as the logical block size during mmc_blk_alloc_req. In order to use this patch for 4KB sector size, ensure that USE_NATIVE_SECTOR is enabled, partition

Re: [PATCH 1/2] [MMC-4.5] Disable emulation

2012-05-16 Thread Saugata Das
On 17 May 2012 10:17, Saugata Das wrote: > On 17 May 2012 09:04, Namjae Jeon wrote: >> 2012/5/17, Saugata Das : >>> On 17 May 2012 06:35, Namjae Jeon wrote: >>>> 2012/5/17, Saugata Das : >>>>> From: Saugata Das >>>>> >>>>

Re: [PATCH 1/2] [MMC-4.5] Disable emulation

2012-05-16 Thread Saugata Das
On 17 May 2012 09:04, Namjae Jeon wrote: > 2012/5/17, Saugata Das : >> On 17 May 2012 06:35, Namjae Jeon wrote: >>> 2012/5/17, Saugata Das : >>>> From: Saugata Das >>>> >>>> This patch adds the support for large sector size of 4KB by

Re: [PATCH 1/2] [MMC-4.5] Disable emulation

2012-05-16 Thread Saugata Das
On 17 May 2012 06:35, Namjae Jeon wrote: > 2012/5/17, Saugata Das : >> From: Saugata Das >> >> This patch adds the support for large sector size of 4KB by disabling >> emulation. >> This patch passes eMMC DATA_SECTOR_SIZE as the logical block size during >&g

[PATCH 2/2] [MMC-4.5] [MMC UTIL] Disable emulation

2012-05-16 Thread Saugata Das
From: Saugata Das In this patch, we add utility to disable emulation mode in the eMMC-4.5. This is done to increase the data sector size to 4KB. Signed-off-by: Saugata Das changes in v2: Review rework based on comments from Subhash --- mmc.c |6 ++ mmc.h | 10

[PATCH 1/2] [MMC-4.5] Disable emulation

2012-05-16 Thread Saugata Das
From: Saugata Das This patch adds the support for large sector size of 4KB by disabling emulation. This patch passes eMMC DATA_SECTOR_SIZE as the logical block size during mmc_blk_alloc_req. In order to use this patch for 4KB sector size, ensure that USE_NATIVE_SECTOR is enabled, partition

[RFC 3/3] mmc: Context support

2012-05-16 Thread Saugata Das
From: Saugata Das This patch implements the context ID support at MMC layer. From file system (ext4), the context is passed in the request structure. At MMC layer the context is retrieved from the request structure and then used in the CMD23 argument. Since number of MMC contexts is limited

[RFC 2/3] ext4: Context support

2012-05-16 Thread Saugata Das
From: Saugata Das On eMMC and UFS devices there is a new feature of setting context with each read or write. The idea is to classify the data from different files and apply the realibility on the complete file instead of individual writes. On ext4 file system, the inode number of the file is

[RFC 1/3] block: Context support

2012-05-16 Thread Saugata Das
From: Saugata Das On eMMC and UFS devices there is a new feature of setting context with each read or write. The idea is to classify the data from different files and apply the realibility on the complete file instead of individual writes, which helps in performance. A new address space

Re: [RFC 1/2] [MMC-4.5] Disable emulation

2012-05-15 Thread Saugata Das
On 15 May 2012 15:47, S, Venkatraman wrote: > On Tue, May 15, 2012 at 12:10 PM, Subhash Jadavani > wrote: >> On 5/14/2012 8:21 PM, Saugata Das wrote: >>> >>> On 14 May 2012 15:55, Subhash Jadavani  wrote: >>>> >>>> On 5/9/2012 8:1

Re: [RFC 1/2] [MMC-4.5] Disable emulation

2012-05-15 Thread Saugata Das
On 15 May 2012 12:10, Subhash Jadavani wrote: > On 5/14/2012 8:21 PM, Saugata Das wrote: >> >> On 14 May 2012 15:55, Subhash Jadavani  wrote: >>> >>> On 5/9/2012 8:18 PM, Saugata Das wrote: >>>> >>>> From: Saugata Das >>>> >&

Re: [RFC 2/2] [MMC-4.5] [MMC UTIL] Disable emulation

2012-05-14 Thread Saugata Das
On 14 May 2012 16:09, Subhash Jadavani wrote: > On 5/9/2012 8:18 PM, Saugata Das wrote: >> >> From: Saugata Das >> >> In this patch, we add utility to disable emulation mode in the eMMC-4.5. >> This is done to increase the data sector size to 4KB. >> >>

Re: [RFC 2/2] [MMC-4.5] [MMC UTIL] Disable emulation

2012-05-14 Thread Saugata Das
On 14 May 2012 16:20, Subhash Jadavani wrote: > On 5/9/2012 8:18 PM, Saugata Das wrote: >> >> From: Saugata Das >> >> In this patch, we add utility to disable emulation mode in the eMMC-4.5. >> This is done to increase the data sector size to 4KB. >> >>

Re: [RFC 1/2] [MMC-4.5] Disable emulation

2012-05-14 Thread Saugata Das
On 14 May 2012 15:55, Subhash Jadavani wrote: > On 5/9/2012 8:18 PM, Saugata Das wrote: >> >> From: Saugata Das >> >> This patch adds the support for large sector size of 4KB by disabling >> emulation. >> This patch passes eMMC DATA_SECTO

Re: [PATCH v3 1/2] MMC-4.5 Power OFF Notify rework

2012-05-14 Thread Saugata Das
(e.g. mmc_power_restore_host, mmc_pm_notify/PM_POST_RESTORE, >>> mmc_start_host). >>> >>> This patch sets POWER_OFF_NOTIFICATION to POWER_OFF_SHORT if it is sent >>> from >>> the suspend sequence. If it is sent from shutdown sequence then it is set &

Re: [PATCH v3 1/2] MMC-4.5 Power OFF Notify rework

2012-05-14 Thread Saugata Das
ost, mmc_pm_notify/PM_POST_RESTORE, >>> mmc_start_host). >>> >>> This patch sets POWER_OFF_NOTIFICATION to POWER_OFF_SHORT if it is sent >>> from >>> the suspend sequence. If it is sent from shutdown sequence then it is set >>> to >>> POWER_OF

Re: [PATCH v3 1/2] MMC-4.5 Power OFF Notify rework

2012-05-13 Thread Saugata Das
is sent from shutdown sequence then it is set >> to >> POWER_OFF_LONG. >> >> Previuos implementation of PowerOff Notify as a core function is replaced >> as >> a device's bus operation. >> >> Signed-off-by: Saugata Das >> Signed-off-by:

[RFC 2/2] [MMC-4.5] [MMC UTIL] Disable emulation

2012-05-09 Thread Saugata Das
From: Saugata Das In this patch, we add utility to disable emulation mode in the eMMC-4.5. This is done to increase the data sector size to 4KB. Signed-off-by: Saugata Das --- mmc.c |6 ++ mmc.h |2 ++ mmc_cmds.c | 42

[RFC 1/2] [MMC-4.5] Disable emulation

2012-05-09 Thread Saugata Das
From: Saugata Das This patch adds the support for large sector size of 4KB by disabling emulation. This patch passes eMMC DATA_SECTOR_SIZE as the logical block size during mmc_blk_alloc_req. In order to use this patch for 4KB sector size, ensure that USE_NATIVE_SECTOR is enabled, partition

Re: [PATCH V2] MMC-4.5 Power OFF Notify rework

2012-04-30 Thread Saugata Das
patch sets POWER_OFF_NOTIFICATION to POWER_OFF_SHORT if it is sent >> from >> the suspend sequence. If it is sent from shutdown sequence then it is set >> to >> POWER_OFF_LONG. >> >> Previuos implementation of PowerOff Notify as a core function is replaced >

Re: [PATCH V2] MMC-4.5 Power OFF Notify rework

2012-04-30 Thread Saugata Das
wn sequence then it is set >> to >> POWER_OFF_LONG. >> >> Previuos implementation of PowerOff Notify as a core function is replaced >> as >> a device's bus operation. >> >> Signed-off-by: Saugata Das >> Signed-off-by: Girish K S >> --- &g

Re: [PATCH] MMC-4.5 Power OFF Notify rework

2012-04-27 Thread Saugata Das
gt;>>> which >>>>> does reinitialization of the eMMC on the return path of the power >>>>> management >>>>> routines (e.g. mmc_power_restore_host, mmc_pm_notify/PM_POST_RESTORE, >>>>> mmc_start_host). >>>>> >>>&

Re: [RFC] MMC-4.5 Power OFF Notify rework

2012-04-05 Thread Saugata Das
path of the power >> management >> routines (e.g. mmc_power_restore_host, mmc_pm_notify/PM_POST_RESTORE, >> mmc_start_host). >> >> Signed-off-by: Saugata Das >> Signed-off-by: Girish K S >> --- >>  drivers/mmc/core/core.c  |   36 ++---

Re: [PATCH v1 1/1] mmc: core: fix power class selection

2012-04-03 Thread Saugata Das
On 3 April 2012 22:14, Subhash Jadavani wrote: > > >> -Original Message- >> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- >> ow...@vger.kernel.org] On Behalf Of Saugata Das >> Sent: Tuesday, April 03, 2012 9:48 PM >> To: Subhash Jadavani >

Re: [PATCH v1 1/1] mmc: core: fix power class selection

2012-04-03 Thread Saugata Das
On 3 April 2012 21:20, Subhash Jadavani wrote: > > >> -Original Message----- >> From: Saugata Das [mailto:saugata@linaro.org] >> Sent: Tuesday, April 03, 2012 8:55 PM >> To: Subhash Jadavani >> Cc: linux-mmc@vger.kernel.org; linux-arm-...@v

Re: [PATCH v1 1/1] mmc: core: fix power class selection

2012-04-03 Thread Saugata Das
On 3 April 2012 12:25, Subhash Jadavani wrote: > mmc_select_powerclass() function returns error if eMMC > VDD level supported by host is between 2.7v to 3.2v. > > According to eMMC specification, valid voltage for high > voltage cards is 2.7v to 3.6v. This patch ensures that > 2.7v to 3.6v VDD ran

Re: [PATCH V2] mmc: core: Add host capability check for power class

2012-04-03 Thread Saugata Das
On 2 April 2012 16:24, Subhash Jadavani wrote: > > >> -Original Message----- >> From: Saugata Das [mailto:saugata@linaro.org] >> Sent: Monday, April 02, 2012 1:20 PM >> To: Subhash Jadavani >> Cc: Girish K S; linux-mmc@vger.kernel.org; p

Re: [RFC] MMC-4.5 Power OFF Notify rework

2012-04-03 Thread Saugata Das
On 2 April 2012 21:26, Linus Walleij wrote: > On Mon, Apr 2, 2012 at 10:47 AM, Saugata Das wrote: > >>>> +       host->power_notify_type = MMC_HOST_PW_NOTIFY_LONG; >>> >>> This looks new, can you explain in the code as comments >>> or in the comm

Re: [RFC] MMC-4.5 Power OFF Notify rework

2012-04-02 Thread Saugata Das
nagement >> routines (e.g. mmc_power_restore_host, mmc_pm_notify/PM_POST_RESTORE, >> mmc_start_host). >> >> Signed-off-by: Saugata Das >> Signed-off-by: Girish K S > > Overall this looks good! > > I think it may be possible to split the patch. > First a patch that

Re: [PATCH V2] mmc: core: Add host capability check for power class

2012-04-02 Thread Saugata Das
On 28 March 2012 16:39, Subhash Jadavani wrote: > > >> -Original Message- >> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- >> ow...@vger.kernel.org] On Behalf Of Saugata Das >> Sent: Thursday, December 15, 2011 6:35 PM >> To: Girish K S &g

[RFC] MMC-4.5 Power OFF Notify rework

2012-03-30 Thread Saugata Das
From: Saugata Das This is a rework of the existing POWER OFF NOTIFY patch. The problem with the existing patch comes from the ambiguity on the usage of POWER OFF NOTIFY together with SLEEP and misunderstanding on the usage of MMC_POWER_OFF power_mode from mmc_set_ios in different host controller

Re: [PATCH] mmc: core: Fix PowerOff Notify suspend/resume

2012-03-15 Thread Saugata Das
On 16 March 2012 09:19, Girish K S wrote: > On 14 March 2012 20:53, Ulf Hansson wrote: >> Hi Girish and Chris, >> >> I noticed that this has been pushed for 3.3, I think we need to make a >> revert of it asap if possible. >> >> I were unfortunately not able to review this patch earlier but it has

Re: [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5 device

2012-03-04 Thread Saugata Das
Hi Merez On 2 March 2012 19:56, wrote: > Hi, > > Our tests showed that the write packing improved the performance of the > write sequential operations: > > Long write operation: > -- > no-packing: 15.8 MB/s > packed commands patch (both READ and WRITE packing are enabled): 23

Re: [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5 device

2012-03-01 Thread Saugata Das
On 29 February 2012 23:40, wrote: >> This patch supports packed command of eMMC4.5 device. >> Several reads(or writes) can be grouped in packed command >> and all data of the individual commands can be sent in a >> single transfer on the bus. >> >> Signed-off-by: Seungwon Jeon >> --- >>  drivers

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-02-24 Thread Saugata Das
Hi Jaehoon Since you are planning to rework this patch, can you consider to implement the periodic BKOPS level check and triggering BKOPS at level 1 when the queue is idle ? On 24 February 2012 14:08, Jaehoon Chung wrote: > On 02/23/2012 06:05 PM, Adrian Hunter wrote: > >> On 23/02/12 04:21, Ja

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-02-14 Thread Saugata Das
On 20 January 2012 12:18, Jaehoon Chung wrote: > Enable eMMC background operations (BKOPS) feature. > > If URGENT_BKOPS is set after a response, note that BKOPS > are required. After all I/O requests are finished, run > BKOPS if required. Should read/write operations be requested > during BKOPS, f

Re: [RFC] MMC-4.5 Context ID

2012-02-13 Thread Saugata Das
On 12 February 2012 02:27, Chris Ball wrote: > Hi, > > On Mon, Feb 06 2012, Saugata Das wrote: >> Thanks for the info. Perhaps the initial MMC-4.5 device samples do not >> implement this command well. Yes, this feature is good to have in the >> kernel. I shall wait fo

Re: [PATCH] mmc: core: Substitute mmc_flush_cash for mmc_cache_ctrl in suspend

2012-02-13 Thread Saugata Das
     cancel_delayed_work(&host->detect); >        mmc_flush_scheduled_work(); >        if (mmc_try_claim_host(host)) { > -               err = mmc_cache_ctrl(host, 0); > +               err = mmc_flush_cache(host->card); >                mmc_do_release_host(host); >        } els

Re: [RFC] MMC-4.5 Context ID

2012-02-05 Thread Saugata Das
On 6 February 2012 10:56, Jaehoon Chung wrote: > On 02/06/2012 02:13 PM, Saugata Das wrote: > >> On 5 February 2012 08:15, Chris Ball wrote: >>> Hi, >>> >>> On Wed, Feb 01 2012, Saugata Das wrote: >>>> From: Saugata Das >>>>

Re: [RFC] MMC-4.5 Context ID

2012-02-05 Thread Saugata Das
On 5 February 2012 08:15, Chris Ball wrote: > Hi, > > On Wed, Feb 01 2012, Saugata Das wrote: >> From: Saugata Das >> >> This patch groups the read or write transfers to eMMC in different contexts >> based on the block number. Transfers to consecutive blocks a

Re: [RFC] MMC-4.5 Context ID

2012-02-02 Thread Saugata Das
On 3 February 2012 08:15, Jaehoon Chung wrote: > On 02/03/2012 01:08 AM, S, Venkatraman wrote: > >> On Wed, Feb 1, 2012 at 8:57 PM, Saugata Das >> wrote: >>> From: Saugata Das >>> >>> This patch groups the read or write transfers to eMMC in dif

Re: [RFC] MMC-4.5 Context ID

2012-02-02 Thread Saugata Das
On 2 February 2012 21:38, S, Venkatraman wrote: > On Wed, Feb 1, 2012 at 8:57 PM, Saugata Das > wrote: >> From: Saugata Das >> >> This patch groups the read or write transfers to eMMC in different contexts >> based on the block number. Transfers to consecutive blo

[PATCH V2] mmci.c: CMD23 support

2012-02-01 Thread Saugata Das
From: Saugata Das Support added for transmission of CMD23 during multi block read or write. In order to activate this feature, MMC_CAP_CMD23 flag needs to be enabled in the capabilities field. Note that CMD23 support is mandatory to support features like reliable write, data tag, context ID

Re: [PATCH] mmc: core: Fix PowerOff Notify suspend/resume

2012-02-01 Thread Saugata Das
t; >  #define mmc_card_set_present(c)        ((c)->state |= MMC_STATE_PRESENT) >  #define mmc_card_set_readonly(c) ((c)->state |= MMC_STATE_READONLY) > @@ -395,7 +397,9 @@ static inline void __maybe_unused remove_quirk(struct > mmc_card *card, int data) >  #define mmc_sd_card_set_uhs(c) ((c)->state |= MMC_STATE_ULTRAHIGHSPEED) >  #define mmc_card_set_ext_capacity(c) ((c)->state |= MMC_CARD_SDXC) >  #define mmc_card_set_removed(c) ((c)->state |= MMC_CARD_REMOVED) > +#define mmc_card_set_sleep(c)  ((c)->state |= MMC_STATE_SLEEP) > > +#define mmc_card_clr_sleep(c)  ((c)->state &= ~MMC_STATE_SLEEP) >  /* >  * Quirk add/remove for MMC products. >  */ > -- > 1.7.1 > Thanks for the changes. Reviewed-by: Saugata Das -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC] MMC-4.5 Context ID

2012-02-01 Thread Saugata Das
From: Saugata Das This patch groups the read or write transfers to eMMC in different contexts based on the block number. Transfers to consecutive blocks are grouped to a common context. So several small transfers combine to give performance like a large multi block transfer. The patch creates a

[PATCH] mmci.c: CMD23 support

2012-01-31 Thread Saugata Das
From: Saugata Das Support added for transmission of CMD23 during multi block read or write. In order to activate this feature, MMC_CAP_CMD23 flag needs to be enabled in the capabilities field. Note that CMD23 support is mandatory to support features like reliable write, data tag, context ID

Re: [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device

2012-01-27 Thread Saugata Das
On 27 January 2012 12:25, Seungwon Jeon wrote: > Saugata Das wrote: >> On 25 January 2012 10:47, Seungwon Jeon wrote: >> > Hi, Saugata Das. >> > >> > Saugata Das wrote: >> >> On 20 January 2012 09:36, Seungwon Jeon wrote: >> >

Re: [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device

2012-01-26 Thread Saugata Das
On 25 January 2012 10:47, Seungwon Jeon wrote: > Hi, Saugata Das. > > Saugata Das wrote: >> On 20 January 2012 09:36, Seungwon Jeon wrote: >> > This patch supports packed command of eMMC4.5 device. >> > Several reads(or writes) can be grouped in packed

Re: [PATCH v3 0/2] mmc: core: Support packed command feature of eMMC4.5

2012-01-23 Thread Saugata Das
On 20 January 2012 10:05, Kyungmin Park wrote: > Hi, > > FYI: we get performance gain using packed command at write. however in > case of small size read, there are some performance drop since > protocol overhead. > In normal case, read command uses read operation only, but in case of > packed rea

Re: [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device

2012-01-23 Thread Saugata Das
On 20 January 2012 09:36, Seungwon Jeon wrote: > This patch supports packed command of eMMC4.5 device. > Several reads(or writes) can be grouped in packed command > and all data of the individual commands can be sent in a > single transfer on the bus. > > Signed-off-by: Seungwon Jeon > --- >  dri

Re: [PATCH] MMC-4.5 Data Tag Support

2012-01-18 Thread Saugata Das
PM, Kyungmin Park >>>> wrote: >>>>> On 1/13/12, Chris Ball wrote: >>>>>> Hi, >>>>>> >>>>>> On Thu, Jan 12 2012, S, Venkatraman wrote: >>>>>>> On Wed, Dec 21, 2011 at 1:09 PM, Saugata Das >>>&g

Re: [PATCH] MMC-4.5 Data Tag Support

2011-12-21 Thread Saugata Das
On 21 December 2011 17:01, Girish K S wrote: > On 21 December 2011 16:42, Saugata Das wrote: >> On 21 December 2011 16:23, Girish K S >> wrote: >>> On 21 December 2011 13:09, Saugata Das wrote: >>>> From: Saugata Das >>>> >>>> MM

Re: [PATCH] MMC-4.5 Data Tag Support

2011-12-21 Thread Saugata Das
On 21 December 2011 16:23, Girish K S wrote: > On 21 December 2011 13:09, Saugata Das wrote: >> From: Saugata Das >> >> MMC-4.5 data tag feature will be used to store the file system meta-data in >> the >> tagged region of eMMC. This will improve the write

[PATCH] MMC-4.5 Data Tag Support

2011-12-20 Thread Saugata Das
From: Saugata Das MMC-4.5 data tag feature will be used to store the file system meta-data in the tagged region of eMMC. This will improve the write and subsequent read transfer time for the meta data. Signed-off-by: Saugata Das --- drivers/mmc/card/block.c | 17 +++-- drivers

Re: [PATCH V2] mmc: core: Add host capability check for power class

2011-12-15 Thread Saugata Das
On 15 December 2011 16:22, Girish K S wrote: > On 15 December 2011 15:34, Saugata Das wrote: >> On 15 December 2011 09:28, Girish K S >> wrote: >>> This patch adds a check whether the host supports maximum current value >>> obtained from the device'

Re: Cache Control during mmc_suspend_host

2011-12-15 Thread Saugata Das
On 14 December 2011 10:04, Seungwon Jeon wrote: > Saugata Das wrote: >> On 13 December 2011 11:57, Seungwon Jeon wrote: >> > Hi Saugata, >> > >> > Saugata Das wrote: >> >> Hi Seungwon Jeon >> >> >> >> I see a small issue wi

Re: [PATCH V2] mmc: core: Add host capability check for power class

2011-12-15 Thread Saugata Das
On 15 December 2011 09:28, Girish K S wrote: > This patch adds a check whether the host supports maximum current value > obtained from the device's extended csd register for a selected interface > voltage and frequency. > > cc: Chris Ball > Signed-off-by: Girish K S > --- > Changes in v2: >    

Re: Cache Control during mmc_suspend_host

2011-12-13 Thread Saugata Das
On 13 December 2011 11:57, Seungwon Jeon wrote: > Hi Saugata, > > Saugata Das wrote: >> Hi Seungwon Jeon >> >> I see a small issue with the implementation mmc_suspend_host, >> >> int mmc_suspend_host(struct mmc_host *host) >> { >> . &g

Re: [PATCH V5] mmc: core: HS200 mode support for eMMC 4.5

2011-12-12 Thread Saugata Das
On 13 December 2011 10:13, Girish K S wrote: > On 12 December 2011 12:20, Girish K S wrote: >> On 5 December 2011 20:29, Saugata Das wrote: >>> Hi Girish >>> >>> Please refer to Figure 71 (HS200 device output timing) of the MMC-4.5 >>> spec. It sho

Cache Control during mmc_suspend_host

2011-12-12 Thread Saugata Das
Hi Seungwon Jeon I see a small issue with the implementation mmc_suspend_host, int mmc_suspend_host(struct mmc_host *host) { . err = mmc_cache_ctrl(host, 0); } So, within mmc_suspend_host we are disabling the cache. But I do not see a corresponding enabling of cache within mmc_resume

Re: [PATCH V5] mmc: core: HS200 mode support for eMMC 4.5

2011-12-05 Thread Saugata Das
Hi Girish Please refer to Figure 71 (HS200 device output timing) of the MMC-4.5 spec. It shows that both CMD and DATA[7-0] will have some latency till valid window. This implies that even the CMD line will need tuning for reading the response. The specification talks about identifying sampling poi