Re: [PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

2015-12-22 Thread Scott Branden
Hi Stefan, On 15-12-22 07:55 AM, Stefan Wahren wrote: Hi Scott, Am 07.11.2014 um 19:31 schrieb Scott Branden: On 14-11-05 09:01 PM, Stephen Warren wrote: On 11/05/2014 12:00 AM, Scott Branden wrote: On 14-11-04 08:59 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote

Re: [PATCH 1/4] mmc: Add quirk to disable SDR50 mode

2015-11-09 Thread Scott Branden
On 15-11-09 02:45 AM, Ulf Hansson wrote: On 7 November 2015 at 00:55, Scott Branden wrote: Hi Ulf, On 15-11-06 12:14 AM, Ulf Hansson wrote: On 5 November 2015 at 23:39, Al Cooper wrote: Add quirk to disable SDR50 mode for controllers/boards that have problems with this mode. No thanks

Re: [PATCH 1/4] mmc: Add quirk to disable SDR50 mode

2015-11-06 Thread Scott Branden
Hi Ulf, On 15-11-06 12:14 AM, Ulf Hansson wrote: On 5 November 2015 at 23:39, Al Cooper wrote: Add quirk to disable SDR50 mode for controllers/boards that have problems with this mode. No thanks! No more quirks please! I'm fine with not having this quirk added (I don't need this one but u

Re: [RFC PATCH] mmc: Kconfig: Add dependency on GPIOLIB for Arasan driver

2015-07-27 Thread Scott Branden
Hi Michal, comment in line On 15-07-24 06:53 AM, Michal Simek wrote: The patch "mmc: sdhci-of-arasan: Call OF parsing for MMC" (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) introduce new dependency on GPIOLIB which calls mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which calls devm

Re: 04e079cf6b24c794 to stable

2015-04-28 Thread Scott Branden
fixes some logic paths where MMC requests are being made to non-removable devices that do not have the card detect pin connected on the hardware as it is non-removable. Signed-off-by: Scott Branden Signed-off-by: Ulf Hansson The reason I am asking is that we were seeing issues on

[PATCH] mmc: sdhci: fix card presence logic in sdhci_request function

2015-03-10 Thread Scott Branden
hardware as it is non-removable. Signed-off-by: Scott Branden --- drivers/mmc/host/sdhci.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 0ad412a..bafc7ac 100644 --- a/drivers/mmc/host/sdhci.c +++ b

[PATCH 2/4] mmc: sdhci: do not set AUTO_CMD12 for multi-block CMD53

2015-03-05 Thread Scott Branden
From: Corneliu Doban For CMD53 in block mode, the host does not need to stop the transfer, as it stops when the block count (present in CMD53) is reached. Signed-off-by: Corneliu Doban Signed-off-by: Scott Branden --- drivers/mmc/host/sdhci.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH RESEND 0/4] Add support for IPROC SDHCI controller

2015-03-05 Thread Scott Branden
This series of patchsets contains the IPROC SDHCI driver used in a series of Broadcom SoCs Quirks are also added to support this controller. Corneliu Doban (1): mmc: sdhci: do not set AUTO_CMD12 for multi-block CMD53 Scott Branden (3): mmc: sdhci: add quirk for ACMD23 broken mmc: sdhci

[PATCH 3/4] mmc: sdhci-iproc: add IPROC SDHCI driver

2015-03-05 Thread Scott Branden
Add IPROC SDHCI driver for IPROC family of Broadcom devices. Acked-by: Ray Jui Signed-off-by: Corneliu Doban Signed-off-by: Scott Branden --- drivers/mmc/host/Kconfig | 14 +++ drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-iproc.c | 241

[PATCH 1/4] mmc: sdhci: add quirk for ACMD23 broken

2015-03-05 Thread Scott Branden
: Scott Branden Signed-off-by: Scott Branden --- drivers/mmc/host/sdhci.c | 3 ++- include/linux/mmc/sdhci.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index f1a488e..fcf78ab 100644 --- a/drivers/mmc/host/sdhci.c +++ b

[PATCH 4/4] mmc: sdhci-iproc: add device tree bindings

2015-03-05 Thread Scott Branden
Add device tree binding documentation for IPROC SDHCI driver. Acked-by: Ray Jui Signed-off-by: Corneliu Doban Signed-off-by: Scott Branden --- .../devicetree/bindings/mmc/brcm,sdhci-iproc.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation

Re: [PATCH 4/4] mmc: sdhci-iproc: add device tree bindings

2015-03-04 Thread Scott Branden
Hi Florian, On 15-03-02 03:50 PM, Florian Fainelli wrote: Unless there is a re-spin, I will fix this myself while applying this patch to devicetree/next. Thanks Yes, you can patch the formatting if the driver is being integrated. But I have had no response or feedback on the sdhci driver. I

Re: [PATCH 0/4] Add support for IPROC SDHCI controller

2015-02-26 Thread Scott Branden
Hi Chris, I have not heard any more feedback on this patchset. Is it in your queue to review or merge into your tree? Thanks, Scott On 15-02-09 04:06 PM, Scott Branden wrote: This series of patchsets contains the IPROC SDHCI driver used in a series of Broadcom SoCs Quirks are also added

[PATCH 1/4] mmc: sdhci: add quirk for ACMD23 broken

2015-02-09 Thread Scott Branden
: Scott Branden Signed-off-by: Scott Branden --- drivers/mmc/host/sdhci.c | 3 ++- include/linux/mmc/sdhci.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index f1a488e..fcf78ab 100644 --- a/drivers/mmc/host/sdhci.c +++ b

[PATCH 4/4] mmc: sdhci-iproc: add device tree bindings

2015-02-09 Thread Scott Branden
Add device tree binding documentation for IPROC SDHCI driver. Acked-by: Ray Jui Signed-off-by: Corneliu Doban Signed-off-by: Scott Branden --- .../devicetree/bindings/mmc/brcm,sdhci-iproc.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation

[PATCH 0/4] Add support for IPROC SDHCI controller

2015-02-09 Thread Scott Branden
This series of patchsets contains the IPROC SDHCI driver used in a series of Broadcom SoCs Quirks are also added to support this controller. Corneliu Doban (1): mmc: sdhci: do not set AUTO_CMD12 for multi-block CMD53 Scott Branden (3): mmc: sdhci: add quirk for ACMD23 broken mmc: sdhci

[PATCH 2/4] mmc: sdhci: do not set AUTO_CMD12 for multi-block CMD53

2015-02-09 Thread Scott Branden
From: Corneliu Doban For CMD53 in block mode, the host does not need to stop the transfer, as it stops when the block count (present in CMD53) is reached. Signed-off-by: Corneliu Doban Signed-off-by: Scott Branden --- drivers/mmc/host/sdhci.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH 3/4] mmc: sdhci-iproc: add IPROC SDHCI driver

2015-02-09 Thread Scott Branden
Add IPROC SDHCI driver for IPROC family of Broadcom devices. Acked-by: Ray Jui Signed-off-by: Corneliu Doban Signed-off-by: Scott Branden --- drivers/mmc/host/Kconfig | 14 +++ drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-iproc.c | 241

Re: [PATCH v2] mmc: sdhci: add quirk for ACMD23 broken

2014-12-17 Thread Scott Branden
Hi Chris, We'll finish off cleaning up our driver that uses this patch for review then. Thanks, Scott On 14-12-17 11:48 AM, Chris Ball wrote: Hi Scott, sorry for the delay, On Fri, Dec 05 2014, Scott Branden wrote: Add quirk to handle broken auto-CMD23. Some controllers do not re

Re: [PATCH v2] mmc: sdhci: add quirk for ACMD23 broken

2014-12-17 Thread Scott Branden
Hi Chris, I have not received any feedback on this patch for the SDHCI controller. Anything I can do to help get this accepted into the codebase? Thanks, Scott On 14-12-04 04:16 PM, Scott Branden wrote: Add quirk to handle broken auto-CMD23. Some controllers do not respond after the first

[PATCH v2] mmc: sdhci: add quirk for ACMD23 broken

2014-12-04 Thread Scott Branden
: Scott Branden --- drivers/mmc/host/sdhci.c | 3 ++- include/linux/mmc/sdhci.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index ada1a3e..b37331f 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c

[PATCH] mmc: sdhci: add quirk for ACMD23 broken

2014-12-04 Thread Scott Branden
: Scott Branden --- drivers/mmc/host/sdhci.c | 3 ++- include/linux/mmc/sdhci.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index ada1a3e..b37331f 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c

Re: [PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

2014-11-07 Thread Scott Branden
On 14-11-05 09:01 PM, Stephen Warren wrote: On 11/05/2014 12:00 AM, Scott Branden wrote: On 14-11-04 08:59 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: Add a verify option to driver to print out an error message if a potential back to back write could cause a clock

Re: [PATCHv2 5/5] mmc: sdhci-bcm2835: add sdhci quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12

2014-11-07 Thread Scott Branden
On 14-11-05 08:50 PM, Stephen Warren wrote: On 11/05/2014 12:02 AM, Scott Branden wrote: On 14-11-04 09:00 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this controller. This seems fine, although any

Re: [PATCHv2 3/5] mmc: shdci-bcm2835: add efficient back-to-back write workaround

2014-11-07 Thread Scott Branden
On 14-11-05 08:48 PM, Stephen Warren wrote: On 11/04/2014 11:55 PM, Scott Branden wrote: On 14-11-04 08:57 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: The bcm2835 has clock domain issues when back to back writes to certain registers are written. The existing driver

Re: [PATCHv2 5/5] mmc: sdhci-bcm2835: add sdhci quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12

2014-11-04 Thread Scott Branden
On 14-11-04 09:00 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this controller. This seems fine, although any explanation of why this quirk is needed would be useful. I don't know who to talk to at A

Re: [PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

2014-11-04 Thread Scott Branden
On 14-11-04 08:59 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: Add a verify option to driver to print out an error message if a potential back to back write could cause a clock domain issue. index f8c450a..11af27f 100644 +#ifdef

Re: [PATCHv2 3/5] mmc: shdci-bcm2835: add efficient back-to-back write workaround

2014-11-04 Thread Scott Branden
On 14-11-04 08:57 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: The bcm2835 has clock domain issues when back to back writes to certain registers are written. The existing driver works around this issue with udelay. A more efficient method is to store the 8 and 16 bit

Re: [PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

2014-11-04 Thread Scott Branden
On 14-11-04 08:44 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: Add a verify option to driver to print out an error message if a potential back to back write could cause a clock domain issue. diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci

Re: [PATCHv2 2/5] mmc: sdhci-bcm2835: make shift calculations consistent

2014-11-04 Thread Scott Branden
On 14-11-04 08:48 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: Make the shift calculations consistent rather than having different implementations to calculate the same thing. diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c

[PATCHv2 2/5] mmc: sdhci-bcm2835: make shift calculations consistent

2014-10-29 Thread Scott Branden
Make the shift calculations consistent rather than having different implementations to calculate the same thing. Signed-off-by: Scott Branden --- drivers/mmc/host/sdhci-bcm2835.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/mmc/host/sdhci

[PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

2014-10-29 Thread Scott Branden
Add a verify option to driver to print out an error message if a potential back to back write could cause a clock domain issue. Signed-off-by: Scott Branden --- drivers/mmc/host/Kconfig |9 + drivers/mmc/host/sdhci-bcm2835.c | 17 + 2 files changed, 26

[PATCHv2 3/5] mmc: shdci-bcm2835: add efficient back-to-back write workaround

2014-10-29 Thread Scott Branden
. Signed-off-by: Scott Branden --- drivers/mmc/host/sdhci-bcm2835.c | 103 -- 1 file changed, 55 insertions(+), 48 deletions(-) diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c index b6cb365..f8c450a 100644 --- a/drivers/mmc/host

[PATCHv2 1/5] mmc: sdhci-bcm2835: group read and write functions to improve readability

2014-10-29 Thread Scott Branden
Group the read and write functions to improve readability. Now all similar functions are grouped together to evaluate behaviours. Signed-off-by: Scott Branden --- drivers/mmc/host/sdhci-bcm2835.c | 61 +++--- 1 file changed, 31 insertions(+), 30 deletions

[PATCHv2 5/5] mmc: sdhci-bcm2835: add sdhci quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12

2014-10-29 Thread Scott Branden
SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this controller. Signed-off-by: Scott Branden --- drivers/mmc/host/sdhci-bcm2835.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c index

[PATCHv2 0/5] sdhci-bcm2835: added quirk and removed udelay in write ops

2014-10-29 Thread Scott Branden
This patch contains driver cleanup of sdhci-bcm2835. Please note that this has not actually been tested on bcm2835 yet. Testing comes from other devices with the same sdhci controller. This patch is being put out for testing and acceptance on the 2835. Please test and comment. Scott Branden (5

Re: [PATCH 1/1] mmc: sdhci-bcm2835: added quirk and removed udelay in write ops

2014-10-17 Thread Scott Branden
Great review - thanks. On 14-10-17 07:37 PM, Stephen Warren wrote: On 10/15/2014 10:43 AM, Scott Branden wrote: Added quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 present in controller. Removed udelay in write ops by using shadow registers for 16 bit accesses to 32-bit registers (where necessary

[PATCH 1/1] mmc: sdhci-bcm2835: added quirk and removed udelay in write ops

2014-10-15 Thread Scott Branden
Added quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 present in controller. Removed udelay in write ops by using shadow registers for 16 bit accesses to 32-bit registers (where necessary). Optimized 32-bit operations when doing 8/16 register accesses. Signed-off-by: Scott Branden --- drivers/mmc/host

[PATCH 1/1] mmc: sdhci-bcm2835: added quirk and removed udelay in write ops

2014-10-14 Thread Scott Branden
Added quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 present in controller. Removed udelay in write ops by using shadow registers for 16 bit accesses to 32-bit registers (where necessary). Optimized 32-bit operations when doing 8/16 register accesses. Signed-off-by: Scott Branden --- drivers/mmc/host

[PATCH 0/1] sdhci-bcm2835: added quirk and removed udelay in write ops

2014-10-14 Thread Scott Branden
This patch contains driver cleanup of sdhci-bcm2835. Please note that this has not actually been tested on bcm2835 yet. Testing comes from other devices with the same sdhci controller. This patch is being put out for testing and acceptance on the 2835. Please test and comment. Scott Branden (1

RE: [PATCH] Move MMCI header to amba include dir

2009-09-28 Thread Scott Branden
Hi Linus, You changes cause the bcmring platform to fail to compile. Can you go through all the ARM platforms and make the necessary adjustments with the change in header files for mmc? Thanks, Scott > -Original Message- > From: linux-arm-kernel-boun...@lists.infradead.org > [mailto:l