Hi,
> @@ -230,7 +230,7 @@ static void tmio_mmc_reset_work(struct work_struct *work)
>*/
> if (IS_ERR_OR_NULL(mrq)
> || time_is_after_jiffies(host->last_req_ts +
> - msecs_to_jiffies(2000))) {
> + msecs_to_jiffies(5000))) {
> spin_unlock
dle. I don't expect
conflicts. So:
Acked-by: Wolfram Sang
> ---
> drivers/i2c/busses/i2c-piix4.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> index 67cbec6..630bce6 100644
>
My Pengutronix address is not valid anymore, redirect people to the Pengutronix
kernel team.
Reported-by: Harald Geyer
Signed-off-by: Wolfram Sang
Acked-by: Robert Schwebel
---
These patches shall go via the individual subsystem trees.
drivers/mmc/host/sdhci-esdhc-imx.c | 4 ++--
1 file
Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
core), we can rely on device core for setting the default pins.
Signed-off-by: Wolfram Sang
---
drivers/mmc/host/mvsdio.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc
> Would a way forward be to let you carry all the patches through your
> tree? I believe all but patch 17 can be safely merged. It is only this
> one that depends on the changes in the amba bus, so we can put this
> one on hold for a while.
I'd favour this. Will do this next week unless somebody
On Thu, Feb 13, 2014 at 03:09:02PM +0100, Ulf Hansson wrote:
> Use devm_* functions to simplify code and error handling.
>
> Cc: Alessandro Rubini
> Cc: Linus Walleij
> Cc: Wolfram Sang
> Signed-off-by: Ulf Hansson
> ---
>
> Changes in v2:
> Rebased on to
On Mon, Jan 13, 2014 at 06:04:32PM +, Chris Ball wrote:
> Hi Wolfram,
>
> On Mon, Jan 13 2014, Wolfram Sang wrote:
> > On Tue, Nov 26, 2013 at 02:16:25AM +0100, Wolfram Sang wrote:
> >> This reverts and updates commit 6fd0a4cc541b9a528eacc1d31ca47eb1ae7a
> &g
On Tue, Nov 26, 2013 at 02:16:25AM +0100, Wolfram Sang wrote:
> This reverts and updates commit 6fd0a4cc541b9a528eacc1d31ca47eb1ae7a
> ("mmc: sd: fix the maximum au_size for SD3.0"). The au_size for SD3.0
> cannot be achieved by a simple bit shift, so this needs to be
> i
On Tue, Nov 26, 2013 at 02:16:25AM +0100, Wolfram Sang wrote:
> This reverts and updates commit 6fd0a4cc541b9a528eacc1d31ca47eb1ae7a
> ("mmc: sd: fix the maximum au_size for SD3.0"). The au_size for SD3.0
> cannot be achieved by a simple bit shift, so this needs to be
> i
> Good catch. It's right. Looks good to me.
Thanks. Then this patch should probably go to stable as well...
signature.asc
Description: Digital signature
#x27;not defined' is different from 'invalid'.
Signed-off-by: Wolfram Sang
Cc: Jaehoon Chung
Cc: Kyungmin Park
Cc: H Hartley Sweeten
---
Only tested with non SD3.0 cards (au = 0 and au = 9). Testers for 3.0 cards
much appreciated.
drivers/mmc/core/sd.c | 36 +
The core does this automatically, no need to do this explicitly in drivers.
Those patchces should go via the respective subtrees. Thanks!
Wolfram Sang (4):
drivers/gpu/drm/tilcdc: don't use devm_pinctrl_get_select_default() in
probe
drivers/mmc/host: don&
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/mmc/host/mvsdio.c | 7 +--
drivers/mmc
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/mmc/host/mvsdio.c |6 --
drivers
On Mon, Apr 15, 2013 at 02:16:56PM +0200, ludovic.desroc...@atmel.com wrote:
> From: Ludovic Desroches
>
> Use generic DMA DT helper. Platforms booting with or without DT populated are
> both supported.
>
> Signed-off-by: Ludovic Desroches
Applied to for-next, thanks!
--
To unsubscribe from t
t;
> Sascha
>
>
> Sascha Hauer (3):
> mmc: sdhci: rename platform_8bit_width to platform_bus_width
> mmc: esdhc i.MX: Fix version register read
> mmc: esdhc i.MX: Support 8bit mode
Whole series:
Acked-by: Wolfram Sang
--
Pengutronix e.K.
reg = sdhci_readl(host, SDHCI_INT_ENABLE);
> + reg &= ~SDHCI_INT_CARD_INT;
> + sdhci_writel(host, reg, SDHCI_INT_ENABLE);
> + sdhci_writel(host, SDHCI_INT_CARD_INT, SDHCI_INT_STATUS);
> +
> + if (!is_imx25_esdhc(imx_data))
> +
On Wed, Apr 18, 2012 at 08:00:42PM -0400, Chris Ball wrote:
> Thanks, pushed to mmc-next for 3.4.
If not done already, I think a stable-tag would make sense.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | h
ng to do this.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
bmit the patch, you can add my
Acked-by: Wolfram Sang
Best regards.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
sts for this patch.
Please do next time.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
lution
for the errata. There might be better ones, though, but you'd need to
find out.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
build fixes)? If that doesn't work, there might be something
wrong in the sdhci-driver itself, and not the esdhc-extension.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
I may be totally wrong.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
53 has yet to be found.
Yup. Try 'git log --follow sdhci-esdhc-imx.c' to find people who worked
with MX53 or SDIO using that driver.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
recognize patterns, I guess.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
client drivers, mxs-mmc, gpmi do not break.
I'd say patch 6-10 should be squashed, simply. My personal preference is
to change #9 to simply read the register when needed and do not expand
the struct, but this is a minor thing.
Regards,
Wolfram
--
Pengutronix e.K.
educe dependencies and temporary build-failures.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
the
> patch if you agree that that's the correct solution here.)
I won't have time to look at it, but what you say sounds reasonable to me.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
x users), you don't
need properties, but could simply set it.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
try, the
> property entry can be, too.
Where is that needed? I don't see how they are board-specific.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
ble entry, e.g. if compatible == "this_controller" then
quirks |= whatever_needed. Or?
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Thu, Dec 08, 2011 at 09:17:47AM +0100, Lothar Waßmann wrote:
>
> Signed-off-by: Lothar Waßmann
> Acked-by: Shawn Guo
Acked-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengu
Lothar Waßmann
> Acked-by: Shawn Guo
Despite minor nit that using __func__ is probably overkill:
Acked-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
De
On Thu, Dec 08, 2011 at 09:17:44AM +0100, Lothar Waßmann wrote:
>
> Signed-off-by: Lothar Waßmann
> Acked-by: Shawn Guo
Acked-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengu
> - add Acked-by: where applicable
You forgot mine :( Will resend.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Tue, Dec 06, 2011 at 02:41:30PM +0100, Lothar Waßmann wrote:
>
> Signed-off-by: Lothar Waßmann
Acked-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signatu
__func__ here? dev_err and the msg itself should be indication enough?
Otherwise
Acked-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Tue, Dec 06, 2011 at 02:41:28PM +0100, Lothar Waßmann wrote:
> i.MX28 has four SSP/MMC units, only two of which are currently
> usable.
>
> Signed-off-by: Lothar Waßmann
Reviewed-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang
On Tue, Dec 06, 2011 at 02:41:26PM +0100, Lothar Waßmann wrote:
>
> Signed-off-by: Lothar Waßmann
Acked-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signatu
t; simpler.
Lost the original mail, but checked the patch using an archive.
Acked-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
about it since we are both in Prague at the moment...
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
gards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
s well, but this can
be done later if needed. Sadly, I currently don't have hardware to test
it.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
wapping that Anton (back then) intentionally
implemented.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
0 Freescale Semiconductor, Inc.
I wonder if such a small change has impact on the copyright.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
> > I would do it in the IO accessors.
> >
> > Thanks,
> Any update for your comment?
It is still valid. You can go that road.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http
update
your commit message with such infos.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
v(host->mmc),
> - "%s: div1 %d, div2 %d, ssp %d, bit %d, rate %d\n",
> - __func__, div1, div2, ssp_rate, bit_rate, rate);
> + "%s: clock_divide %d, clock_rate %d, ssp_clk %d, rate_actual
> %d, rate_requested %d\n",
> +
if you could also put the '- 1' to
the line calculating div2, that would be an extra plus. I think it is a
lot more readable to have the whole formula in one place, and not split
up.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang
On Mon, Jul 04, 2011 at 12:59:29PM +0200, Koen Beel wrote:
> On Mon, Jul 4, 2011 at 12:34 PM, Wolfram Sang wrote:
> >
> >> > > > Well, maybe not. My colleague complained and I think he is right
> >> > > > that we are
> >> > > > mapp
> > About the patch itself: I didn't verify the formulas, but it does solve one
> > special problem here. Thanks a lot! So:
>
> Does it solve any other special problem except for the wrong clock rate
> setting?
Nope, but that it does :)
--
Pengutronix e.K.
give
div2 = int(1.152) = 1 (meaning 0 + 1, because div2 - 1 will be written)
The rate will thus be:
actual_rate = 5760 / 2 * (0 + 1)
= 2880
-> too fast!
Or did I get something wrong?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Sun, Jul 03, 2011 at 05:28:52PM +0800, Shawn Guo wrote:
> On Sat, Jul 02, 2011 at 03:12:25PM +0200, Wolfram Sang wrote:
> > On Fri, Jul 01, 2011 at 11:46:29PM +0800, Shawn Guo wrote:
> > > On Fri, Jul 01, 2011 at 04:44:09PM +0200, Wolfram Sang wrote:
> > > > Hi,
&
ven't checked if you are doing the same or similar, just that you are
changing the same code. Please CC Shawn Guo and Richard Zhu if there is another
patch series needed.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Lin
On Fri, Jul 01, 2011 at 11:46:29PM +0800, Shawn Guo wrote:
> On Fri, Jul 01, 2011 at 04:44:09PM +0200, Wolfram Sang wrote:
> > Hi,
> >
> > On Fri, Jul 01, 2011 at 03:26:39PM +0200, Koen Beel wrote:
> > > I send the patch as attachment for now.
> >
> > F
onix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
gt; and corporate firewalls avoid using a different smtp server...
Good luck with that!
About the patch itself: I didn't verify the formulas, but it does solve one
special problem here. Thanks a lot! So:
Tested-by: Wolfram Sang
@chris: If Shawn also likes the patch, I think this is a stable
27;t know if git-send-email can work directly with gmail, but it
seems you need some kind of alternative approach.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
On Thu, Jun 30, 2011 at 04:55:07PM +0200, Wolfram Sang wrote:
> On Thu, Jun 30, 2011 at 12:13:34PM +0200, Koen Beel wrote:
> > Fix clock rate setting on mxs-mmc driver.
> > Previously, if div2 was zero the value for TIMING_CLOCK_RATE would
> > have been 255 instead of 0.
&g
t->base + HW_SSP_TIMING);
> val &= ~(BM_SSP_TIMING_CLOCK_DIVIDE | BM_SSP_TIMING_CLOCK_RATE);
> --
> 1.7.4.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majord...@vger.kernel.org
> More majordomo i
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
n Guo
For the third time ;)
Acked-by: Wolfram Sang
Should go to stable.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Sat, Jun 18, 2011 at 07:50:37PM +0200, Sebastian Rasmussen wrote:
> Signed-off-by: Sebastian Rasmussen
I don't think it improves readability, so not worth the change IMO.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux S
r changes are whitespace related. I think this
patch needs to be split up. If each patch does one thing, it will make
reviewing a lot easier, too.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_bit(md->name_idx, name_use);
> - }
> - else
> + } else
else-block needs braces.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
Hi Richard,
>It's strange that the sd card can't work on MX25 board without ADMA_BROKEN
>quirks.
BTW how many cards/boards have you tested?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial
On Thu, Jun 16, 2011 at 02:06:29PM +0200, Pavel Machek wrote:
> On Thu 2011-06-16 14:00:09, Wolfram Sang wrote:
> >
> > > Unfortunately register differences are common. Is there better
> > > approach than patching it in low level functions like this?
> >
Guo
Looks like right direction to me, so far; some testers would be good,
though.
Acked-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
Guo
Acked-by: Wolfram Sang
Should go to stable...
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
> Unfortunately register differences are common. Is there better
> approach than patching it in low level functions like this?
I am all ears for suggestions...
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
marked broken in mainline, cause it didn't work with a number of
cards. Richard sent a patch recently.
Both series could need some more testing :)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
sdhc_ops.get_ro in .probe only when wp_type is ESDHC_WP_GPIO,
> that works for esdhc2 but breaks esdhc1 WP function. So no, I will
> not change my code except adding NONE case handling there.
Ok, fine with me. Thanks for checking!
--
Pengutronix e.K.
d to find muxer settings but couldn't find them. It
seemed to me, GPIO is the only option there (I think I even asked
Richard). Can you route them on mx25/35, too?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
omment describing the situation.
> >
> Agreed. Will add something in commit message to mention the
> situation. That's why I hope we can get the patch on mmc-next at
I actually meant a comment in the code, so it will be obvious for later
hackers why the "extr
_probe(struct
> platform_device *pdev)
>
> return 0;
>
> - no_card_detect_irq:
> - gpio_free(boarddata->cd_gpio);
> - no_card_detect_pin:
> - boarddata->cd_gpio = err;
> - not_supported:
> - kfree(imx_data);
> - err_add_ho
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
e initial idea from
> Eric Benard.
>
> Signed-off-by: Shawn Guo
> Cc: Eric Benard
Hmm, that should get enough testing on non-imx (and even non-ARM)
devices. And a comment describing the situation.
--
Pengutronix e.K. | Wolfram Sang|
Indu
Guo
Acked-by: Wolfram Sang
Should go to stable, too.
Thanks for catching it!
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
/* DMA mode bits are shifted */
> + new_val |= (val & SDHCI_CTRL_DMA_MASK) << 5;
I think the if doesn't save much than just doing this simple operation; it also
adds another line and level of indentation.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
n's patch series turning sdhci
into a library, things might have become easier for this approach. Hmmm, I'd
like to try it, just have to see when.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_le(host, 0x, new_val, reg);
> + } else
> + esdhc_clrset_le(host, 0xff, val, reg);
Why can't we always write 16-bit? (and else-block needs braces)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
mc-next anyway, does it make sense
to squash this into the old ones to prevent the broken inbetween state?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Sat, May 28, 2011 at 10:27:41PM -0400, Chris Ball wrote:
> Hi,
>
> On Sun, Feb 06 2011, Chris Ball wrote:
> > Part of a quirk cleanup run. This quirk was only used by sdhci-esdhc.
> > This patch is untested.
> >
> > Signed-off-by: Chris Ball
> > Cc
ce problems.\n");
> >
> > I second turning the message into a warning, though.
>
> If the latter method is preferred, I'll adjust the patch and resend.
Reconsidering: Given the current situation, an error message is maybe not a
that bad idea, until the cod
amp;pdev->dev, "Invalid iomem size. You may "
> "experience problems.\n");
I second turning the message into a warning, though.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
> Any chance we can get this series into $NEXT_KERNEL?
From the looks, I think it still has problems being a module. Will try
to test it today.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix
merging the two...
> +#ifndef CONFIG_MMC_SDHCI_ESDHC_IMX
> +#define cpu_is_mx25()(0)
> +#define cpu_is_mx35()(0)
> +#define cpu_is_mx51()(0)
> +#define cpu_is_imx() (0)
> +#else
> +#define cpu_is_imx() (1)
> +#endif
... e.g. that looks a bit frightening.
--
Pen
)
> + host->quirks |= SDHCI_QUIRK_INVERTED_WRITE_PROTECT;
> +
> + clk = of_get_property(np, "clock-frequency", &size);
> + if (clk && size == sizeof(*clk) && *clk)
> +
ght be able to get rid of the migrated entries in sdhci-pltfm.h, but this
is a task for later IMO.
Reviewed-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
De
with Anton.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
ed!
ERROR: "sdhci_pltfm_init" [drivers/mmc/host/sdhci-esdhc.ko] undefined!
ERROR: "sdhci_pltfm_free" [drivers/mmc/host/sdhci-esdhc.ko] undefined!
So, the module-support seems to be missing for the library.
Regards,
Wolfram
--
Pengutronix e.K.
rther issues.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
TCH 0/x] (if you mean the whole series) or reply
to each [PATCH n/x] with something like
Reviewed-by: Your name
Tested-by: Your name
(I have keyboard macros for those ;))
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial
ose users anyway, it's not an argument here.
sdhci-dove needs to overload readw/readl. If there is a user not
needings such, i.e. only plain quirks (or even nothing, what a dream!),
then a generic driver might be worthwhile. Can wait until we see such a
user, though.
Regards,
Wolfram
--
Pen
s,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
.
Hmm, why should be there a functionality if there is no user for it? A
reference user helps people understand how it is intended to be used.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http
ally I do not even know how v2+ is stated. Do you have an example
> for me to refer?
Check davinci_mmc.c (or grep for 'any later version').
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
ugh.
> This driver has been tested on
> a) 32bit x86
> b) 64bit x86
> c) dual processor
> d) PowerPC
The test coverage is great, yet the driver needs to comply to the kernel coding
rules. I'd suggest to look at Arnd's review and fix the issues.
Regards,
Wolfram
1 - 100 of 396 matches
Mail list logo
