Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-25 Thread lautriv
On 11/24/2014 09:34 AM, Ulf Hansson wrote: > On 20 November 2014 at 15:45, lautriv wrote: >> From b0509e27e33326e6dccd67d8ebe67e2bdb0cfdde Mon Sep 17 00:00:00 2001 >> From: Helmut Stengele >> Date: Thu, 20 Nov 2014 15:27:40 +0100 >> Subject: [PATCH] mm

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-20 Thread lautriv
From b0509e27e33326e6dccd67d8ebe67e2bdb0cfdde Mon Sep 17 00:00:00 2001 From: Helmut Stengele Date: Thu, 20 Nov 2014 15:27:40 +0100 Subject: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region Current code calls release_mem_region upon module unload without requesting the region first. This

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-10 Thread lautriv
On 11/10/2014 06:15 AM, Alexey Charkov wrote: 2014-11-10 1:18 GMT+03:00 lautriv : On 11/09/2014 10:55 PM, Fabio Estevam wrote: On Sun, Nov 9, 2014 at 7:12 PM, Alexey Charkov wrote: + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + ret

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-09 Thread lautriv
On 11/09/2014 10:55 PM, Fabio Estevam wrote: On Sun, Nov 9, 2014 at 7:12 PM, Alexey Charkov wrote: + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + ret = -ENODEV; + goto fail1; You could save this NULL check... + }