Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-17 Thread micky
will lead UHSI card failed to enter UHSI mode. It is hard to control the UEFI driver leaving state, so we power off the card power during probe. Signed-off-by: Roger Tseng Signed-off-by: Micky Ching --- drivers/mmc/host/rtsx_pci_sdmmc.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-07-02 Thread micky
On 06/18/2014 04:00 PM, Lee Jones wrote: On Mon, 16 Jun 2014, Ulf Hansson wrote: On 16 June 2014 14:20, Lee Jones wrote: From: Micky Ching rtsx driver using a single function for transfer data, dma map/unmap are placed in one fix function. We need map/unmap dma in different place(for mmc

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-23 Thread micky
Hi Uffe, do you accepted this patch? if accepted, I will submit again with jones ack. Best Regards. micky. On 06/19/2014 09:57 AM, micky wrote: On 06/18/2014 07:03 PM, Ulf Hansson wrote: On 18 June 2014 12:08, micky wrote: On 06/18/2014 03:39 PM, Ulf Hansson wrote: On 18 June 2014 03:17

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-18 Thread micky
On 06/18/2014 07:03 PM, Ulf Hansson wrote: On 18 June 2014 12:08, micky wrote: On 06/18/2014 03:39 PM, Ulf Hansson wrote: On 18 June 2014 03:17, micky wrote: On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky wrote: On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-18 Thread micky
On 06/18/2014 03:39 PM, Ulf Hansson wrote: On 18 June 2014 03:17, micky wrote: On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky wrote: On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16 June 2014 11:09, micky wrote: On 06/16/2014 04:42 PM, Ulf Hansson wrote

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-17 Thread micky
On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky wrote: On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16 June 2014 11:09, micky wrote: On 06/16/2014 04:42 PM, Ulf Hansson wrote: @@ -36,7 +37,10 @@ struct realtek_pci_sdmmc { struct rtsx_pcr *pcr

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-06-16 Thread micky
gards. micky. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-16 Thread micky
On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16 June 2014 11:09, micky wrote: On 06/16/2014 04:42 PM, Ulf Hansson wrote: @@ -36,7 +37,10 @@ struct realtek_pci_sdmmc { struct rtsx_pcr *pcr; struct mmc_host *mmc; struct mmc_request *mrq

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-16 Thread micky
during handle request. So I use workq, we just queue a work and return in ops->request(), The mmc core can continue without blocking at ops->request(). Best Regards. micky. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message

Re: [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify errorhandleandremovesmatch warnings"

2014-05-08 Thread micky
e best we can do, until Chris shows up again. Kind regards Ulf Hansson From: Micky Ching This reverts commit 1f7b581b3ffcb2a8437397a02f4af89fa6934d08. The patch depend on commit c42deffd5b53c9e583d83c7964854ede2f12410d , but the previous patch was discard. So we have to delete the patch. Signed

Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req"

2014-05-07 Thread micky
Hi Lee Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqand post_req" if need for 3.15 fix. Best Regards. micky. On 04/29/2014 03:36 PM, Ulf Hansson wrote: On 29 April 2014 03:54, wrote: >From: Micky Ching > >

Re: [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handleandremove smatch warnings"

2014-05-07 Thread micky
Hi Lee It seems Chris is too busy to responding, so would you help to pick this patch for 3.15 fix. Best Regards. micky. On 04/29/2014 03:30 PM, Ulf Hansson wrote: On 29 April 2014 03:54, wrote: >From: Micky Ching > >This reverts commit 1f7b581b3ffcb2a8437397a02f4af89fa6934d0

Re: [PATCH 0/2] mmc: rtsx: revert support for mmc async request

2014-04-29 Thread micky
Hi Lee, On 04/29/2014 04:02 PM, Lee Jones wrote: From: Micky Ching The commit have some problem, using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix these problem, and better to use a new method. So just remove it. The commit depends on the previous patch. And

Re: [PATCH v2 2/2] mmc: rtsx: modify error handle and remove smatchwarnings

2014-04-28 Thread micky
Hi Chris and Ulf, This patch is denpend on commit c42deffd5b53c9e583d83c7964854ede2f12410d. , and we discard the previous commit. we want discard this patch also(it it now in linux-next), need I send another patch to revert or it will be discard automatically? Best Regards. micky. On 03/27

Re: [PATCH v2 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle

2014-04-28 Thread micky
Hi Chris and Ulf, This patch should be applied to 3.15(rc), 3.14, 3.13. without this patch the MMC card can not identified. Best Regards. micky. On 03/27/2014 01:35 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching commit a27fbf2f067b0cd6f172c8b696b9a44c58bfaa7a produced a cmd.flags

Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqand post_req"

2014-04-28 Thread micky
Hi Chris and Ulf, Since the original commit is merged into kernel 3.15-rc, we want this patch apply to the 3.15-rc to avoid cause serious problem. Is there any thing I need do? Best Regards. micky. On 04/28/2014 03:36 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching This reverts

Re: Locking issues in "mmc: rtsx: add support for pre_req and post_req"

2014-04-21 Thread micky
Hi Peter, I'm considering not using spinlock to get it work and will resend the patch later. Thank you. Best Regards. micky On 04/19/2014 07:13 AM, Peter Wu wrote: So, I reverted c42deffd5b53c9e583d83c7964854ede2f12410d ("mmc: rtsx: add support for pre_req and post_req") on t

Re: [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify errorhandle

2014-03-25 Thread micky
Hi Ulf, On 03/25/2014 06:44 PM, Ulf Hansson wrote: On 25 March 2014 10:47, wrote: From: Micky Ching Add new command type(R1 without CRC) handle, without this patch mmc card initialize will be failed. Using a more careful handle in request timeout, this would improve error recover

Re: mmc: rtsx: add support for pre_req and post_req

2014-03-02 Thread micky
On 03/01/2014 04:35 AM, Dan Carpenter wrote: Hello Micky Ching, The patch c42deffd5b53: "mmc: rtsx: add support for pre_req and post_req" from Feb 17, 2014, leads to the following static checker warning: drivers/mmc/host/rtsx_pci_sdmmc.c:525 sd_pre_dma_transfer()

Re: mmc: rtsx: add support for pre_req and post_req

2014-02-24 Thread micky
Hi Dan, I'm wondering how to get this warning info, so I can check before sending patch. Can you give me some idea? Best Regards. micky. On 02/25/2014 06:03 AM, Dan Carpenter wrote: Hello Micky Ching, This is a semi-automatic email about new static checker warnings. The

Re: [PATCH v2 0/3] mmc: rtsx: fix bug and support nonblocking request

2014-02-20 Thread micky
Hi Chris, Could you please give me some idea about this patch-set? I send this patch-set many times, but didn't get any reply. Best Regards. micky On 02/17/2014 04:45 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching First we fix the card poweroff bug: the card power is not shu

Re: [PATCH v3 0/2] fix sd power bug and modify phase-searching method

2013-12-22 Thread micky
Hi, Is there anything wrong with this patch? It seems a long time, but I didn't got any reply. On 12/03/2013 10:34 AM, micky_ch...@realsil.com.cn wrote: From: Micky Ching If the driver removed while sd card still in the slot, the card power will not power down correctly, if we inser

Re: [PATCH 2/2] mmc: rtsx: modify phase searching method for tunning

2013-11-20 Thread micky
quot; anything it only returns zero on success? "phase_point" might be helpful but I don't know what a phase_point is. Add a comment about that maybe. Yes, thank you for your suggestion, the function name is really not good. I want use test_phase_bit(u32 phase_map, unsigned int bit),

Re: [PATCH] mmc: rtsx: change phase searching method

2013-10-29 Thread micky
Hi Chris: Have you accepted this patch, I'm waiting a long time for your reply. Best Reagards. micky On 09/02/2013 05:16 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching The new phase searching method is more concise, and makes the code easier to understand. Signed-off-by:

Re: [PATCH] mmc: rtsx: change phase searching method

2013-10-16 Thread micky
Hi Chris: have you accepted this patch ? micky -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html