[PATCH] mmc: bfin_sdh: Forgot to write SDH_CFG register in function set_ios.

2013-10-15 Thread Sonic Zhang
From: Sonic Zhang The DMA operation in SDIO CMD53 may fail because the 4 bit SDIO mode is not set up correctly on BF548. Remove 2 blank lines as well. Signed-off-by: Sonic Zhang --- drivers/mmc/host/bfin_sdh.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc

Re: [PATCH 03/27] mmc: bfin_sdh: Move away from using deprecated APIs

2013-10-07 Thread Sonic Zhang
Acked-by: Sonic Zhang On Thu, Sep 26, 2013 at 10:54 PM, Ulf Hansson wrote: > Suspend and resume of cards are being handled from the protocol layer > and consequently the mmc_suspend|resume_host APIs are deprecated. > > This means we can simplify the suspend|resume callbacks by

[PATCH] mmc: bfin_sdh: Update blackfin sd driver mainainter's email in MAINTAINERS.

2012-08-07 Thread Sonic Zhang
From: Sonic Zhang Signed-off-by: Sonic Zhang --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 94b823f..72c2681 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1513,7 +1513,7 @@ S:Supported F: drivers/rtc/rtc

Re: [PATCH 1/4] mmc: bfin_sdh: limit mmc DMA segment len to 1 for bf518.

2012-08-07 Thread Sonic Zhang
Hi Chris, Could you review this series of patches for Blackfin on-chip SD controller? The head file and new BF60x machine code have been merged upstream. These patches are necessary to get SD driver built on BF60x. Thanks Sonic Zhang On Tue, Aug 7, 2012 at 11:10 AM, Sonic Zhang wrote: > F

[PATCH 2/4] mmc: bfin_sdh: Port bf5xx SD host driver to support new RSI controller in bf60x.

2012-08-06 Thread Sonic Zhang
From: Sonic Zhang In BF60x RSI controller: 1) MMR read/write width differs. 2) PWR and CTL MMRs are merged to together. 3) ROD and PD_DAT3 bit masks are obsolete. 4) New RSI block size MMR is defined. 5) The definition of DMA descriptor set size is changed. 6) set_ios should powers up controller

[PATCH 4/4] mmc: bfin_sdh: Reset SD controller when resume from power saving mode.

2012-08-06 Thread Sonic Zhang
From: Sonic Zhang Without reset, SD controller may stay in disable mode, SD card can't be detected when resume from power saving mode. Signed-off-by: Sonic Zhang --- drivers/mmc/host/bfin_sdh.c | 35 +++ 1 files changed, 19 insertions(+), 16 dele

[PATCH 3/4] mmc: bfin_sdh: Remove redundent suspend and resume setting.

2012-08-06 Thread Sonic Zhang
From: Sonic Zhang mmc core suspend and resume functions had already called sdh_set_ios with proper flags. Signed-off-by: Sonic Zhang Signed-off-by: Bob Liu --- drivers/mmc/host/bfin_sdh.c | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/drivers/mmc

[PATCH 1/4] mmc: bfin_sdh: limit mmc DMA segment len to 1 for bf518.

2012-08-06 Thread Sonic Zhang
From: Sonic Zhang bf518 RSI dma doesn't work in array mode. Signed-off-by: Sonic Zhang --- drivers/mmc/host/bfin_sdh.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c index 0366617..fd25b0c 100644

Re: [PATCH 1/5 v2] mmc: bfin_sdh: limit mmc DMA segment len to 1 for bf518.

2012-06-17 Thread Sonic Zhang
Hi Chris, Could you please comment on the patches for blackfin SD controller driver? Thanks Sonic On Thu, Jun 14, 2012 at 5:22 PM, Sonic Zhang wrote: > From: Sonic Zhang > > bf518 RSI dma doesn't work in array mode. > > Signed-off-by: Sonic Zhang > --- >  drivers/

[PATCH 1/5 v2] mmc: bfin_sdh: limit mmc DMA segment len to 1 for bf518.

2012-06-14 Thread Sonic Zhang
From: Sonic Zhang bf518 RSI dma doesn't work in array mode. Signed-off-by: Sonic Zhang --- drivers/mmc/host/bfin_sdh.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c index 0366617..fd25b0c 100644

[PATCH 4/5 v2] mmc: bfin_sdh: Remove redundent suspend and resume setting.

2012-06-14 Thread Sonic Zhang
From: Sonic Zhang mmc core suspend and resume functions had already called sdh_set_ios with proper flags. Signed-off-by: Sonic Zhang Signed-off-by: Bob Liu --- drivers/mmc/host/bfin_sdh.c | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/drivers/mmc

[PATCH 3/5 v2] mmc: bfin_sdh: Port bf5xx SD host driver to support new RSI controller in bf60x.

2012-06-14 Thread Sonic Zhang
From: Sonic Zhang In BF60x RSI controller: 1) MMR read/write width differs. 2) PWR and CTL MMRs are merged to together. 3) ROD and PD_DAT3 bit masks are obsolete. 4) New RSI block size MMR is defined. 5) The definition of DMA descriptor set size is changed. 6) set_ios should powers up controller

[PATCH 5/5 v2] mmc: bfin_sdh: Reset SD controller when resume from power saving mode.

2012-06-14 Thread Sonic Zhang
From: Sonic Zhang Without reset, SD controller may stay in disable mode, SD card can't be detected when resume from power saving mode. Signed-off-by: Sonic Zhang --- drivers/mmc/host/bfin_sdh.c | 35 +++ 1 files changed, 19 insertions(+), 16 dele

[PATCH 2/5 v2] mmc: bfin_sdh: Move descriptor array structure into blackfin dma.h head file.

2012-06-14 Thread Sonic Zhang
From: Sonic Zhang The descriptor array is common among all blackfin dma channels. Depends on commit b5affb0147cee0ea05d909396f8e389092729236 Signed-off-by: Sonic Zhang --- drivers/mmc/host/bfin_sdh.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/mmc

[PATCH 3/5 v2] mmc: bfin_sdh: Port bf5xx SD host driver to support new RSI controller in bf60x.

2012-06-04 Thread Sonic Zhang
From: Sonic Zhang In BF60x RSI controller: 1) MMR read/write width differs. 2) PWR and CTL MMRs are merged to together. 3) ROD and PD_DAT3 bit masks are obsolete. 4) New RSI block size MMR is defined. 5) The definition of DMA descriptor set size is changed. 6) set_ios should powers up controller

[PATCH] mmc: bfin_sdh: Move descriptor array structure into blackfin dma.h head file.

2012-01-18 Thread Sonic Zhang
From: Sonic Zhang The descriptor array is common among all blackfin dma channels. Signed-off-by: Sonic Zhang --- drivers/mmc/host/bfin_sdh.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c index 97182ca

Re: [PATCH v2] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI.

2010-07-16 Thread Sonic Zhang
Any comments? Sonic On Mon, Jul 12, 2010 at 3:50 PM, sonic zhang wrote: > >From 94d1ea57ac2fbe37133e25e99ccb265250f0027d Mon Sep 17 00:00:00 2001 > From: Sonic Zhang > Date: Fri, 9 Jul 2010 15:36:20 +0800 > Subject: [PATCH v2] MMC:mmc_spi: Recover from crc error for SD read/wri

[PATCH v2] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI.

2010-07-12 Thread sonic zhang
>From 94d1ea57ac2fbe37133e25e99ccb265250f0027d Mon Sep 17 00:00:00 2001 From: Sonic Zhang Date: Fri, 9 Jul 2010 15:36:20 +0800 Subject: [PATCH v2] MMC:mmc_spi: Recover from crc error for SD read/write operation over SPI. SPI bus is not reliable on all platforms when doing large data trans

[PATCH] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI.

2010-07-09 Thread sonic zhang
>From 94d1ea57ac2fbe37133e25e99ccb265250f0027d Mon Sep 17 00:00:00 2001 From: Sonic Zhang Date: Fri, 9 Jul 2010 15:36:20 +0800 Subject: [PATCH] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI. SPI bus is not reliable on all platforms when doing large dada trans