Re: [PATCH] Revert "sdhci-of-esdhc: Support 8BIT bus width."

2015-05-22 Thread Ulf Hansson
On 21 May 2015 at 13:45, Joakim Tjernlund wrote: > On Thu, 2015-05-21 at 18:56 +0800, Kevin Hao wrote: >> On Thu, May 21, 2015 at 09:24:43AM +, Joakim Tjernlund wrote: >> > The HW 8BIT can be confused with SDHCI_CTRL_HISPD(0x04) as it is the same >> > bit. >> > >> > However, now I see that e

Re: [PATCH] Revert "sdhci-of-esdhc: Support 8BIT bus width."

2015-05-21 Thread Joakim Tjernlund
On Thu, 2015-05-21 at 18:56 +0800, Kevin Hao wrote: > On Thu, May 21, 2015 at 09:24:43AM +, Joakim Tjernlund wrote: > > The HW 8BIT can be confused with SDHCI_CTRL_HISPD(0x04) as it is the same > > bit. > > > > However, now I see that esdhc_writeb() has > > /* Prevent SDHCI core from writi

Re: [PATCH] Revert "sdhci-of-esdhc: Support 8BIT bus width."

2015-05-21 Thread Kevin Hao
On Thu, May 21, 2015 at 09:24:43AM +, Joakim Tjernlund wrote: > The HW 8BIT can be confused with SDHCI_CTRL_HISPD(0x04) as it is the same bit. > > However, now I see that esdhc_writeb() has > /* Prevent SDHCI core from writing reserved bits (e.g. HISPD). */ > if (reg == SDHCI_HOST_C

Re: [PATCH] Revert "sdhci-of-esdhc: Support 8BIT bus width."

2015-05-21 Thread Joakim Tjernlund
On Thu, 2015-05-21 at 09:07 +0800, Kevin Hao wrote: > On Wed, May 20, 2015 at 02:54:27PM +, Joakim Tjernlund wrote: > > On Tue, 2015-05-19 at 17:20 +0800, Kevin Hao wrote: > > > On Sun, May 17, 2015 at 08:36:07AM +, Joakim Tjernlund wrote: > > > > On Sun, 2015-05-17 at 13:06 +0800, Kevin Ha

Re: [PATCH] Revert "sdhci-of-esdhc: Support 8BIT bus width."

2015-05-20 Thread Kevin Hao
On Wed, May 20, 2015 at 02:54:27PM +, Joakim Tjernlund wrote: > On Tue, 2015-05-19 at 17:20 +0800, Kevin Hao wrote: > > On Sun, May 17, 2015 at 08:36:07AM +, Joakim Tjernlund wrote: > > > On Sun, 2015-05-17 at 13:06 +0800, Kevin Hao wrote: > > > > > > > > > > How about this one: > > > > >

Re: [PATCH] Revert "sdhci-of-esdhc: Support 8BIT bus width."

2015-05-19 Thread Kevin Hao
On Sun, May 17, 2015 at 08:36:07AM +, Joakim Tjernlund wrote: > On Sun, 2015-05-17 at 13:06 +0800, Kevin Hao wrote: > > > > > > How about this one: > > > > > > From af6b18c056b6064424bd2ab1f9989bbadae5e701 Mon Sep 17 00:00:00 2001 > > > From: Joakim Tjernlund > > > Date: Mon, 20 Apr 2015 22:

Re: [PATCH] Revert "sdhci-of-esdhc: Support 8BIT bus width."

2015-05-15 Thread Joakim Tjernlund
On Fri, 2015-05-15 at 14:29 +0800, Kevin Hao wrote: > This reverts commit 459fe0cfda71835eacc0b24571e8425cea975688. > It causes kernel panic due to a null pointer reference to .set_bus_width > on fsl p2020rdb board. > Unable to handle kernel paging request for instruction fetch > Faulting instr