Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-28 Thread Grant Grundler
On Mon, Mar 28, 2011 at 7:21 PM, Chris Ball wrote: > Hi Grant, > > On Tue, Mar 08 2011, Grant Grundler wrote: >> Save and restore SDHCI interrupt mask during suspend/resume. >> Enables ARM Tegra2 board to suspend/resume. >> >> Signed-off-by: Venkat Rao >> Reviewed-by: Olof Johansson >> Reviewed-

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-28 Thread Chris Ball
Hi Grant, On Tue, Mar 08 2011, Grant Grundler wrote: > Save and restore SDHCI interrupt mask during suspend/resume. > Enables ARM Tegra2 board to suspend/resume. > > Signed-off-by: Venkat Rao > Reviewed-by: Olof Johansson > Reviewed-by: Grant Grundler > --- > drivers/mmc/host/sdhci.c |5 +

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-28 Thread Grant Grundler
Chris, Ping? The discussion on save/restoring SDHCI_INT_ENABLE reached consensus that this patch is needed. Can you still apply? On Tue, Mar 8, 2011 at 1:39 PM, Grant Grundler wrote: > > Save and restore SDHCI interrupt mask during suspend/resume. > Enables ARM Tegra2 board to suspend/resume. >

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-09 Thread Grant Grundler
On Wed, Mar 9, 2011 at 4:07 PM, Andrei Warkentin wrote: ... > I believe Grant's change is necessary for any SDHCI controller with > SDIO and suspend/resume. BTW, to pick nits, I'm not the author. Note the S-o-b lines in the original patch: Signed-off-by: Venkat Rao Reviewed-by: Olof Johansson

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-09 Thread Andrei Warkentin
On Wed, Mar 9, 2011 at 5:56 PM, Olof Johansson wrote: > Hi, > > On Wed, Mar 9, 2011 at 3:11 PM, Andrei Warkentin wrote: > >>> Does kernel.org still need something to deal with state of >>> SDHCI_QUIRK_NO_SDIO_IRQ quirk bit? >> >> I'm confused. I see this quirk added as part of Tegra sdhci support

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-09 Thread Olof Johansson
Hi, On Wed, Mar 9, 2011 at 3:11 PM, Andrei Warkentin wrote: >> Does kernel.org still need something to deal with state of >> SDHCI_QUIRK_NO_SDIO_IRQ quirk bit? > > I'm confused. I see this quirk added as part of Tegra sdhci support in > our K36 tree. I suppose with this patch the should be no ne

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-09 Thread Andrei Warkentin
On Wed, Mar 9, 2011 at 4:00 PM, Grant Grundler wrote: > >> I see why above patch is necessary now. > > I don't understand the relationship between the two. Can you > elaborate? Or point at docs? > I'd be happy to add comments to the code. > Ok, let me rephrase my original statement. I think I mig

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-09 Thread Grant Grundler
On Wed, Mar 9, 2011 at 1:10 PM, Andrei Warkentin wrote: > On Wed, Mar 9, 2011 at 3:01 PM, Grant Grundler wrote: >> On Wed, Mar 9, 2011 at 12:24 PM, Andrei Warkentin >> wrote: >>> On Tue, Mar 8, 2011 at 3:39 PM, Grant Grundler wrote: Save and restore SDHCI interrupt mask during suspen

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-09 Thread Andrei Warkentin
On Wed, Mar 9, 2011 at 3:10 PM, Andrei Warkentin wrote: > On Wed, Mar 9, 2011 at 3:01 PM, Grant Grundler wrote: >> On Wed, Mar 9, 2011 at 12:24 PM, Andrei Warkentin >> wrote: >>> On Tue, Mar 8, 2011 at 3:39 PM, Grant Grundler wrote: Save and restore SDHCI interrupt mask during suspen

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-09 Thread Andrei Warkentin
On Wed, Mar 9, 2011 at 3:01 PM, Grant Grundler wrote: > On Wed, Mar 9, 2011 at 12:24 PM, Andrei Warkentin > wrote: >> On Tue, Mar 8, 2011 at 3:39 PM, Grant Grundler wrote: >>> >>> Save and restore SDHCI interrupt mask during suspend/resume. >>> Enables ARM Tegra2 board to suspend/resume. >>> >>

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-09 Thread Grant Grundler
On Wed, Mar 9, 2011 at 12:24 PM, Andrei Warkentin wrote: > On Tue, Mar 8, 2011 at 3:39 PM, Grant Grundler wrote: >> >> Save and restore SDHCI interrupt mask during suspend/resume. >> Enables ARM Tegra2 board to suspend/resume. >> >> Signed-off-by: Venkat Rao >> Reviewed-by: Olof Johansson >> Re

Re: [PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-09 Thread Andrei Warkentin
On Tue, Mar 8, 2011 at 3:39 PM, Grant Grundler wrote: > > Save and restore SDHCI interrupt mask during suspend/resume. > Enables ARM Tegra2 board to suspend/resume. > > Signed-off-by: Venkat Rao > Reviewed-by: Olof Johansson > Reviewed-by: Grant Grundler > --- >  drivers/mmc/host/sdhci.c  |    

[PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-08 Thread Grant Grundler
Save and restore SDHCI interrupt mask during suspend/resume. Enables ARM Tegra2 board to suspend/resume. Signed-off-by: Venkat Rao Reviewed-by: Olof Johansson Reviewed-by: Grant Grundler --- drivers/mmc/host/sdhci.c |5 + include/linux/mmc/sdhci.h |2 ++ 2 files changed, 7 insert