Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-26 Thread zhangfei gao
On Tue, Sep 21, 2010 at 5:42 AM, claud yu wrote: > Hi , > > I had worked with MMP2 platform several weeks. The mmc/sdio interface > have constraint about transfer size. The transfer size must be 8-byte > alignment. If any transfer size is 4 byte alignment and not 8-byte > alignment. This periphera

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread Chris Ball
Hi, On Mon, Sep 20, 2010 at 11:16:18PM -0400, zhangfei gao wrote: > We have considered using the same driver with dove once saeed push the > driver, but at last we decide to use seperate driver to easy > maintaince and further extension. > > There are different IP developed by different group bet

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread Chris Ball
Hi Wolfram, On Tue, Sep 21, 2010 at 12:11:16PM +0200, Wolfram Sang wrote: > I guess to fully understand all constraints, one must really working > with your platform, what I don't do. I agree that a nicely working > driver is better than no driver; however, I fear once a driver hit the > mainline

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread Eric Miao
On Tue, Sep 21, 2010 at 6:11 PM, Wolfram Sang wrote: >> >> >> diff --git a/drivers/mmc/host/sdhci-pxa.c >> >> >> b/drivers/mmc/host/sdhci-pxa.c >> >> >> new file mode 100644 >> >> >> index 000..3e091c1 >> >> >> --- /dev/null >> >> >> +++ b/drivers/mmc/host/sdhci-pxa.c >> >> >> @@ -0,0 +1,253

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread Wolfram Sang
> >> >> diff --git a/drivers/mmc/host/sdhci-pxa.c b/drivers/mmc/host/sdhci-pxa.c > >> >> new file mode 100644 > >> >> index 000..3e091c1 > >> >> --- /dev/null > >> >> +++ b/drivers/mmc/host/sdhci-pxa.c > >> >> @@ -0,0 +1,253 @@ > >> >> +/* linux/drivers/mmc/host/sdhci-pxa.c > >> >> + * > >> >>

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread claud yu
Hi , I had worked with MMP2 platform several weeks. The mmc/sdio interface have constraint about transfer size. The transfer size must be 8-byte alignment. If any transfer size is 4 byte alignment and not 8-byte alignment. This peripheral ip can't support(miss dma end interrupt or bad transmission

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread zhangfei gao
On Mon, Sep 20, 2010 at 9:10 AM, Wolfram Sang wrote: > On Mon, Sep 20, 2010 at 08:09:26AM -0400, zhangfei gao wrote: >> On Mon, Sep 20, 2010 at 5:50 AM, Wolfram Sang wrote: >> > On Mon, Sep 20, 2010 at 05:46:02PM +0800, zhangfei gao wrote: >> > >> >> diff --git a/drivers/mmc/host/sdhci-pxa.c b/dr

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-20 Thread zhangfei gao
On Mon, Sep 20, 2010 at 9:03 PM, Chris Ball wrote: > Hi Zhangfei/Saeed, > > On Mon, Sep 20, 2010 at 05:46:02PM +0800, zhangfei gao wrote: >> Hi, Chris, >> >> Here is patch to support pxa168(aspen)/pxa910(ttc)/mmp2, the >> controller follow sdh 3.0. >> Currently verified sd, Micron 16G emmc need so

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-20 Thread Chris Ball
Hi Zhangfei/Saeed, On Mon, Sep 20, 2010 at 05:46:02PM +0800, zhangfei gao wrote: > Hi, Chris, > > Here is patch to support pxa168(aspen)/pxa910(ttc)/mmp2, the > controller follow sdh 3.0. > Currently verified sd, Micron 16G emmc need some workaround, 8G is OK, > marvell 8787 would be verified lat

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-20 Thread Wolfram Sang
On Mon, Sep 20, 2010 at 08:09:26AM -0400, zhangfei gao wrote: > On Mon, Sep 20, 2010 at 5:50 AM, Wolfram Sang wrote: > > On Mon, Sep 20, 2010 at 05:46:02PM +0800, zhangfei gao wrote: > > > >> diff --git a/drivers/mmc/host/sdhci-pxa.c b/drivers/mmc/host/sdhci-pxa.c > >> new file mode 100644 > >> in

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-20 Thread zhangfei gao
On Mon, Sep 20, 2010 at 5:50 AM, Wolfram Sang wrote: > On Mon, Sep 20, 2010 at 05:46:02PM +0800, zhangfei gao wrote: > >> diff --git a/drivers/mmc/host/sdhci-pxa.c b/drivers/mmc/host/sdhci-pxa.c >> new file mode 100644 >> index 000..3e091c1 >> --- /dev/null >> +++ b/drivers/mmc/host/sdhci-pxa.

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-20 Thread Wolfram Sang
On Mon, Sep 20, 2010 at 05:46:02PM +0800, zhangfei gao wrote: > diff --git a/drivers/mmc/host/sdhci-pxa.c b/drivers/mmc/host/sdhci-pxa.c > new file mode 100644 > index 000..3e091c1 > --- /dev/null > +++ b/drivers/mmc/host/sdhci-pxa.c > @@ -0,0 +1,253 @@ > +/* linux/drivers/mmc/host/sdhci-pxa.c

[PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-20 Thread zhangfei gao
Hi, Chris, Here is patch to support pxa168(aspen)/pxa910(ttc)/mmp2, the controller follow sdh 3.0. Currently verified sd, Micron 16G emmc need some workaround, 8G is OK, marvell 8787 would be verified later. Help review. >From 76c61b86ae8ae6b84030a31ec4ae7c08214de18b Mon Sep 17 00:00:00 2001 From