Re: [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3

2011-06-20 Thread Arnd Bergmann
On Monday 20 June 2011, zhangfei gao wrote: > Select CLKDEV_LOOKUP is compile driver/clk/clkdev.c, which only > provide clk_get, clk_put. > Is it unsafe to assume all clk_get_rate/clk_enable/clk_disable are > provided by the arch, which CLKDEV_LOOKUP? > Any possibility CLKDEV_LOOKUP is selected but

Re: [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3

2011-06-20 Thread zhangfei gao
On Mon, Jun 20, 2011 at 7:49 PM, Arnd Bergmann wrote: > On Monday 20 June 2011, zhangfei gao wrote: >> Currently, clk_enable, clk_disable, clk_get_rate realization are >> located at arch. >> Driver/clk/clkdev.c only realize clk_get/put. >> >> I am afraid it may difficult to build the driver on oth

Re: [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3

2011-06-20 Thread Arnd Bergmann
On Monday 20 June 2011, zhangfei gao wrote: > It is really a good suggestion, is include/linux/platform_data/ is newly > added? > Will move the header file to platform_data/pxa_sdhci.h > arch/arm/plat-pxa/include/plat/sdhci.h => > include/linux/platform_data/pxa_sdhci.h Yes, it is fairly new. The

Re: [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3

2011-06-20 Thread Arnd Bergmann
On Monday 20 June 2011, zhangfei gao wrote: > Currently, clk_enable, clk_disable, clk_get_rate realization are > located at arch. > Driver/clk/clkdev.c only realize clk_get/put. > > I am afraid it may difficult to build the driver on other arch, like > x86, so we may still need "depends on ARCH_M

Re: [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3

2011-06-20 Thread zhangfei gao
On Mon, Jun 20, 2011 at 6:02 PM, zhangfei gao wrote: >>> >>> Why not just move the header file to include/linux/platform_data/? >>> >>> Then you can build the driver on all platforms, which improves the >>> build test coverage. >>> >>>        Arnd >> >> Hi, Arnd, >> >> Thanks a lot again :) >> It

Re: [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3

2011-06-20 Thread zhangfei gao
>> >> Why not just move the header file to include/linux/platform_data/? >> >> Then you can build the driver on all platforms, which improves the >> build test coverage. >> >>        Arnd > > Hi, Arnd, > > Thanks a lot again :) > It is really a good suggestion, is include/linux/platform_data/ is ne

Re: [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3

2011-06-20 Thread zhangfei gao
On Mon, Jun 20, 2011 at 4:07 PM, Arnd Bergmann wrote: > On Monday 20 June 2011 08:44:47 Zhangfei Gao wrote: >>         Without depends, MMC_SDHCI_PXAV3/2 can be chosen in other platfrom. >>         Build error will occur since plat/sdhci.h is located at >> arch/arm/plat-pxa/ >> >> Signed-off-by:

Re: [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3

2011-06-20 Thread Arnd Bergmann
On Monday 20 June 2011 08:44:47 Zhangfei Gao wrote: > Without depends, MMC_SDHCI_PXAV3/2 can be chosen in other platfrom. > Build error will occur since plat/sdhci.h is located at > arch/arm/plat-pxa/ > > Signed-off-by: Zhangfei Gao > --- > drivers/mmc/host/Kconfig |2 ++ >

[PATCH] mmc: add dependence in Kconfig for pxav2/pxav3

2011-06-19 Thread Zhangfei Gao
Without depends, MMC_SDHCI_PXAV3/2 can be chosen in other platfrom. Build error will occur since plat/sdhci.h is located at arch/arm/plat-pxa/ Signed-off-by: Zhangfei Gao --- drivers/mmc/host/Kconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drive