Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-12-01 Thread Axel Lin
Hi Chris, 2011/12/2 Axel Lin : > 2011/12/2 Chris Ball : >> Hi Axel, Micha, >> >> On Fri, Nov 25 2011, Axel Lin wrote: >>> This patch converts the drivers in drivers/mmc/host/* to use the >>> module_platform_driver() macro which makes the code smaller and a bit >>> simpler. >> >> This makes cb710_m

Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-12-01 Thread Axel Lin
2011/12/2 Chris Ball : > Hi Axel, Micha, > > On Fri, Nov 25 2011, Axel Lin wrote: >> This patch converts the drivers in drivers/mmc/host/* to use the >> module_platform_driver() macro which makes the code smaller and a bit >> simpler. > > This makes cb710_mmc unhappy: > > /home/cjb/git/mmc/drivers/

Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-12-01 Thread Chris Ball
Hi Axel, Micha, On Fri, Nov 25 2011, Axel Lin wrote: > This patch converts the drivers in drivers/mmc/host/* to use the > module_platform_driver() macro which makes the code smaller and a bit > simpler. This makes cb710_mmc unhappy: /home/cjb/git/mmc/drivers/mmc/host/cb710-mmc.c:783:1: warning:

Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-11-30 Thread David Brown
On Sat, Nov 26, 2011 at 12:55:43PM +0800, Axel Lin wrote: > This patch converts the drivers in drivers/mmc/host/* to use the > module_platform_driver() macro which makes the code smaller and a bit > simpler. > drivers/mmc/host/msm_sdcc.c| 13 + Acked-by: David Brown -- Se

Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-11-28 Thread Sascha Hauer
On Sat, Nov 26, 2011 at 12:55:43PM +0800, Axel Lin wrote: > This patch converts the drivers in drivers/mmc/host/* to use the > module_platform_driver() macro which makes the code smaller and a bit > simpler. > > Cc: "Michał Mirosław" > Cc: David Brown > Cc: Ben Dooks > Cc: Viresh Kumar > Cc: G

Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-11-27 Thread Guennadi Liakhovetski
On Sat, 26 Nov 2011, Axel Lin wrote: > This patch converts the drivers in drivers/mmc/host/* to use the > module_platform_driver() macro which makes the code smaller and a bit > simpler. > > Cc: "Michał Mirosław" > Cc: David Brown > Cc: Ben Dooks > Cc: Viresh Kumar > Cc: Guennadi Liakhovetski

Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-11-27 Thread viresh kumar
On Sat, Nov 26, 2011 at 10:25 AM, Axel Lin wrote: > This patch converts the drivers in drivers/mmc/host/* to use the > module_platform_driver() macro which makes the code smaller and a bit > simpler. > > Cc: "Michał Mirosław" > Cc: David Brown > Cc: Ben Dooks > Cc: Viresh Kumar > Cc: Guennadi

Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-11-27 Thread Wolfram Sang
On Sat, Nov 26, 2011 at 04:19:53PM +0400, Anton Vorontsov wrote: > On Sat, Nov 26, 2011 at 12:55:43PM +0800, Axel Lin wrote: > > This patch converts the drivers in drivers/mmc/host/* to use the > > module_platform_driver() macro which makes the code smaller and a bit > > simpler. Lost the original

Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-11-26 Thread Micha
On Sat, Nov 26, 2011 at 12:55:43PM +0800, Axel Lin wrote: > This patch converts the drivers in drivers/mmc/host/* to use the > module_platform_driver() macro which makes the code smaller and a bit > simpler. [...] > --- a/drivers/mmc/host/cb710-mmc.c > +++ b/drivers/mmc/host/cb710-mmc.c > @@ -780,1

Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-11-26 Thread Anton Vorontsov
On Sat, Nov 26, 2011 at 12:55:43PM +0800, Axel Lin wrote: > This patch converts the drivers in drivers/mmc/host/* to use the > module_platform_driver() macro which makes the code smaller and a bit > simpler. Personally I would prefer the macro name capitalized. Other than that, it look OK. Thank

[PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()

2011-11-25 Thread Axel Lin
This patch converts the drivers in drivers/mmc/host/* to use the module_platform_driver() macro which makes the code smaller and a bit simpler. Cc: "Michał Mirosław" Cc: David Brown Cc: Ben Dooks Cc: Viresh Kumar Cc: Guennadi Liakhovetski Cc: Ian Molton Cc: Sascha Hauer Cc: Wolfram Sang Cc