Re: [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear

2013-03-22 Thread Chris Ball
Hi, On Fri, Feb 22 2013, Seungwon Jeon wrote: > On Friday, February 22, 2013, Hyeonsu Kim wrote: >> In the legacy code, driver clear not only UHS_REG 16 bit also 0-15bit. >> If we use UHS-1 mode spec card like SDR50, SDR104. UHS_REG 0-15 >> should be set by >> 1 according to slot id. In this case,

RE: [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear

2013-02-22 Thread Seungwon Jeon
On Friday, February 22, 2013, Hyeonsu Kim wrote: > In the legacy code, driver clear not only UHS_REG 16 bit also 0-15bit. > If we use UHS-1 mode spec card like SDR50, SDR104. UHS_REG 0-15 should be set > by > 1 according to slot id. In this case, legacy code can make problem. > > Signed-off-by: H

Re: [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear

2013-02-21 Thread Jaehoon Chung
On 02/22/2013 10:27 AM, Hyeonsu Kim wrote: > In the legacy code, driver clear not only UHS_REG 16 bit also 0-15bit. > If we use UHS-1 mode spec card like SDR50, SDR104. UHS_REG 0-15 should be set > by > 1 according to slot id. In this case, legacy code can make problem. UHS_REG register is consist

[PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear

2013-02-21 Thread Hyeonsu Kim
In the legacy code, driver clear not only UHS_REG 16 bit also 0-15bit. If we use UHS-1 mode spec card like SDR50, SDR104. UHS_REG 0-15 should be set by 1 according to slot id. In this case, legacy code can make problem. Signed-off-by: Hyeonsu Kim --- drivers/mmc/host/dw_mmc.c |4 ++-- 1 file

Re: [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear

2013-02-21 Thread Jaehoon Chung
Plz add the commit message and CC'd Mr.Seungwon. On 02/22/2013 09:32 AM, Hyeonsu Kim wrote: > Signed-off-by: Hyeonsu Kim > --- > drivers/mmc/host/dw_mmc.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > ind

[PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear

2013-02-21 Thread Hyeonsu Kim
Signed-off-by: Hyeonsu Kim --- drivers/mmc/host/dw_mmc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 323c502..390c15c 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -789,9 +789,9