On Wed, May 04, 2011 at 10:06:20PM +0530, Prashanth Bhat wrote:
> On Wednesday 04 May 2011 04:53 PM, Michał Mirosław wrote:
> >On Tue, May 03, 2011 at 05:00:03PM +0530, Prashanth Bhat wrote:
> >>To be more specific, I would think that the code change required in
> >>include/linux/mmc/card.h is:
> >
Interesting coincidence that the value of MMC_TYPE_SD and MMC_TYPE_SDIO
and MMC_TYPE_SD_COMBO have the relationship that SD_COMBO is the bitwise
OR of the other two. However, this seems to be more of a coincidence
than intentional. The #defines were clearly meant to be numeric values
rather tha
On Tue, May 03, 2011 at 05:00:03PM +0530, Prashanth Bhat wrote:
> To be more specific, I would think that the code change required in
> include/linux/mmc/card.h is:
>
> #define mmc_card_mmc(c) ((c)->type == MMC_TYPE_MMC)
> - #define mmc_card_sd(c) ((c)->type == MMC_TYPE_SD)
> - #d
To be more specific, I would think that the code change required in
include/linux/mmc/card.h is:
#define mmc_card_mmc(c) ((c)->type == MMC_TYPE_MMC)
- #define mmc_card_sd(c) ((c)->type == MMC_TYPE_SD)
- #define mmc_card_sdio(c)((c)->type == MMC_TYPE_SDIO)
+ #define mmc_
Michal,
I hope you remember the email exchange we had about a month ago. I think
I see an issue with SD-COMBO support.
In include/linux/mmc/card.h, there are macros:
#define mmc_card_mmc(c) ((c)->type == MMC_TYPE_MMC)
#define mmc_card_sd(c) ((c)->type == MMC_TYPE_SD)
#define
Hi,
On Sat, Apr 09 2011, Michał Mirosław wrote:
> Fixes a cosmetic bug that affects printk() for SD-combo cards.
>
> Noticed-by: Prashanth Bhat
> Signed-off-by: Michał Mirosław
> ---
> drivers/mmc/core/bus.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/m
Fixes a cosmetic bug that affects printk() for SD-combo cards.
Noticed-by: Prashanth Bhat
Signed-off-by: Michał Mirosław
---
drivers/mmc/core/bus.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
index 63667a8..d6d62fd 100
