Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-28 Thread Ulf Hansson
On 28 April 2014 14:29, Lee Jones wrote: >> >> From: Micky Ching >> >> >> >> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. >> > >> > Why was this patch even merged without an MFD Ack? >> > >> >> commit did use >> >> mutex_unlock() in tasklet, but mutex_unlock() can't used in >> >

Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-28 Thread Lee Jones
> >> From: Micky Ching > >> > >> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. > > > > Why was this patch even merged without an MFD Ack? > > > >> commit did use > >> mutex_unlock() in tasklet, but mutex_unlock() can't used in > >> tasklet(atomic context). The driver need use mute

Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-28 Thread Dan Carpenter
On Mon, Apr 28, 2014 at 11:53:50AM +0100, Lee Jones wrote: > > From: Micky Ching > > > > This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. > > Why was this patch even merged without an MFD Ack? I think process questions like this are very important. These patches touch both mmc and

Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-28 Thread Ulf Hansson
On 28 April 2014 12:53, Lee Jones wrote: >> From: Micky Ching >> >> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. > > Why was this patch even merged without an MFD Ack? > >> commit did use >> mutex_unlock() in tasklet, but mutex_unlock() can't used in >> tasklet(atomic context).

Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-28 Thread Lee Jones
> From: Micky Ching > > This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. Why was this patch even merged without an MFD Ack? > commit did use > mutex_unlock() in tasklet, but mutex_unlock() can't used in > tasklet(atomic context). The driver need use mutex to avoid concurrency, > s

Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-28 Thread Ulf Hansson
On 28 April 2014 09:36, wrote: > From: Micky Ching > > This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. > > commit did use > mutex_unlock() in tasklet, but mutex_unlock() can't used in > tasklet(atomic context). The driver need use mutex to avoid concurrency, > so we can't use task

[PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-28 Thread micky_ching
From: Micky Ching This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. commit did use mutex_unlock() in tasklet, but mutex_unlock() can't used in tasklet(atomic context). The driver need use mutex to avoid concurrency, so we can't use tasklet here, the patch need to be removed. The sp