Re: [PATCH] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently

2014-08-15 Thread Peter Griffin
Hi Russell, > > This happened in > > commit 96d7b78cfc2f ("mmc: sdhci: convert sdhci_set_uhs_signaling() into a > > library function") > > commit a702c8abb2a9 ("mmc: host: split up sdhci-pxa, create sdhci-pxav3.c")' > > This is exactly why named initialisers should always follow the > declaratio

Re: [PATCH] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently

2014-08-15 Thread Russell King - ARM Linux
On Fri, Aug 15, 2014 at 10:12:38AM +0100, Peter Griffin wrote: > .set_uhs_signaling field is currently initialised twice once to the > arch specific callback pxav3_set_uhs_signaling, and also to the generic > sdhci_set_uhs_signaling callback. > > This means that uhs is currently broken for this pl

[PATCH] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently

2014-08-15 Thread Peter Griffin
.set_uhs_signaling field is currently initialised twice once to the arch specific callback pxav3_set_uhs_signaling, and also to the generic sdhci_set_uhs_signaling callback. This means that uhs is currently broken for this platform currently, as pxav3 has some special constriants which means it ca