Re: [PATCH] sdhci-s3c: fix incorrect spinlock usage after merge

2010-09-20 Thread Chris Ball
Hi Ben, On Mon, Sep 20, 2010 at 03:03:42PM +0200, Marek Szyprowski wrote: > In the commit f522886e202a34a2191dd5d471b3c4d46410a9a0 a merge conflict > in the sdhci-s3c driver been fixed. However the fix used incorrect > spinlock operation - it cause a race with sdhci interrupt service. The > correc

Re: [PATCH] sdhci-s3c: fix incorrect spinlock usage after merge

2010-09-20 Thread Andrew Morton
On Tue, 21 Sep 2010 02:17:11 +0100 Chris Ball wrote: > On Mon, Sep 20, 2010 at 03:03:42PM +0200, Marek Szyprowski wrote: > > In the commit f522886e202a34a2191dd5d471b3c4d46410a9a0 a merge conflict > > in the sdhci-s3c driver been fixed. However the fix used incorrect > > spinlock operation - it c

Re: [PATCH] sdhci-s3c: fix incorrect spinlock usage after merge

2010-09-20 Thread Chris Ball
On Mon, Sep 20, 2010 at 03:03:42PM +0200, Marek Szyprowski wrote: > In the commit f522886e202a34a2191dd5d471b3c4d46410a9a0 a merge conflict > in the sdhci-s3c driver been fixed. However the fix used incorrect > spinlock operation - it cause a race with sdhci interrupt service. The > correct way to

[PATCH] sdhci-s3c: fix incorrect spinlock usage after merge

2010-09-20 Thread Marek Szyprowski
In the commit f522886e202a34a2191dd5d471b3c4d46410a9a0 a merge conflict in the sdhci-s3c driver been fixed. However the fix used incorrect spinlock operation - it cause a race with sdhci interrupt service. The correct way to solve it is to use spin_lock_irqsave/irqrestore() calls. Signed-off-by: M