Re: [PATCH] sdio: pass unknown cis tuples to sdio drivers

2009-09-11 Thread Albert Herranz
--- El vie, 11/9/09, Andrew Morton escribió: > > > > > > ret == -EINVAL > > > > > > > At this point ret is not -EINVAL. > > Yes it is.  We just did > >     ret = -EINVAL; > > > If that assignment happens, we leak `this'. > Hi Andrew, I misunderstood you. I thought that you were trying to

Re: [PATCH] sdio: pass unknown cis tuples to sdio drivers

2009-09-11 Thread Albert Herranz
--- El vie, 11/9/09, Pierre Ossman escribió: > The description for this patch should be made clearer. The title > suggests it adds functionality that's already in place. It should be > something along the lines of "Also pass malformed tuples to > card drivers". Hi Pierre, Thanks for your patch r

Re: [PATCH] sdio: pass unknown cis tuples to sdio drivers

2009-09-11 Thread Andrew Morton
On Fri, 11 Sep 2009 07:52:11 + (GMT) Albert Herranz wrote: > --- El vie, 11/9/09, Andrew Morton escribi__: > > > Some manufacturers provide vendor information in > > non-vendor specific CIS > > > tuples. For example, Broadcom uses an Extended > > Function tuple to provide > > > the MAC addr

Re: [PATCH] sdio: pass unknown cis tuples to sdio drivers

2009-09-11 Thread Albert Herranz
--- El vie, 11/9/09, Andrew Morton escribió: > > Some manufacturers provide vendor information in > non-vendor specific CIS > > tuples. For example, Broadcom uses an Extended > Function tuple to provide > > the MAC address on some of their network cards, as in > the case of the > > Nintendo Wii WL

Re: [PATCH] sdio: pass unknown cis tuples to sdio drivers

2009-09-10 Thread Pierre Ossman
On Thu, 10 Sep 2009 14:56:42 +0200 Albert Herranz wrote: > Some manufacturers provide vendor information in non-vendor specific CIS > tuples. For example, Broadcom uses an Extended Function tuple to provide > the MAC address on some of their network cards, as in the case of the > Nintendo Wii WLA

Re: [PATCH] sdio: pass unknown cis tuples to sdio drivers

2009-09-10 Thread Andrew Morton
On Thu, 10 Sep 2009 14:56:42 +0200 Albert Herranz wrote: > Some manufacturers provide vendor information in non-vendor specific CIS > tuples. For example, Broadcom uses an Extended Function tuple to provide > the MAC address on some of their network cards, as in the case of the > Nintendo Wii WL

[PATCH] sdio: pass unknown cis tuples to sdio drivers

2009-09-10 Thread Albert Herranz
Some manufacturers provide vendor information in non-vendor specific CIS tuples. For example, Broadcom uses an Extended Function tuple to provide the MAC address on some of their network cards, as in the case of the Nintendo Wii WLAN daughter card. This patch allows passing correct tuples unknown