Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-14 Thread wwang
于 2012年08月14日 17:32, Arnd Bergmann 写道: > When you post a new version of patches, please add a version number in the > subject line, like " [PATCH v3 1/2] drivers/mfd: Add realtek pcie card > reader driver", to make it easier for people to know what has changed. > It's also helpful to have a "[PATCH

Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-14 Thread Arnd Bergmann
On Tuesday 14 August 2012, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Realtek PCI-E card reader driver adapts requests from upper-level > sdmmc/memstick layer to the real physical card reader. > > Signed-off-by: Wei WANG When you post a new version of patches, please add a version num

Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-13 Thread Arnd Bergmann
On Monday 13 August 2012, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Realtek PCI-E card reader driver adapts requests from upper-level > sdmmc/memstick layer to the real physical card reader. > > Signed-off-by: Wei WANG Hi, This looks pretty good overall, I'm generally happy with how

Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-13 Thread Dan Carpenter
On Mon, Aug 13, 2012 at 03:10:50PM +0800, wwang wrote: > 于 2012年08月13日 14:40, Dan Carpenter 写道: > > Looks like bitwise OR was intended here. > Hi Dan: > > Thank you. I will resend the patches. > It's always best to hold off a day on resending, in case there are other comments. regards, dan carp

Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-13 Thread wwang
于 2012年08月13日 14:40, Dan Carpenter 写道: > Looks like bitwise OR was intended here. Hi Dan: Thank you. I will resend the patches. BR, wwang -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-12 Thread Dan Carpenter
On Mon, Aug 13, 2012 at 10:06:26AM +0800, wei_w...@realsil.com.cn wrote: > +int rtsx_pci_read_phy_register(struct rtsx_pcr *pcr, u8 addr, u16 *val) > +{ > + int err, i, finished = 0; > + u16 data = 0; > + u8 *ptr, tmp; > + > + rtsx_pci_init_cmd(pcr); > + > + rtsx_pci_add_cmd(pcr