Re: [PATCH 1/3] mmc: mvsdio: Support inverted CD and WP GPIO lines

2013-04-23 Thread Simon Baatz
Hi Chris, Guennadi, On Mon, Apr 22, 2013 at 05:50:17PM -0400, Chris Ball wrote: > Hi, > > On Mon, Apr 22 2013, Andrew Lunn wrote: > >> Nothing else really jumps out though. Where either of these what you > >> were thinking of? > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-De

Re: [PATCH 1/3] mmc: mvsdio: Support inverted CD and WP GPIO lines

2013-04-22 Thread Thomas Petazzoni
Dear Chris Ball, On Mon, 22 Apr 2013 17:50:17 -0400, Chris Ball wrote: > On Mon, Apr 22 2013, Andrew Lunn wrote: > >> Nothing else really jumps out though. Where either of these what you > >> were thinking of? > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-December/138514.htm

Re: [PATCH 1/3] mmc: mvsdio: Support inverted CD and WP GPIO lines

2013-04-22 Thread Jason Cooper
On Mon, Apr 22, 2013 at 11:45:43PM +0200, Andrew Lunn wrote: > > > > The core function mmc_of_parse() (new in 3.9) will do all of this DT > > > > parsing for you, and will also take care of the driver's later calls > > > > to mmc_gpio_request_{cd,wp}(). Could you try using that function > > > > in

Re: [PATCH 1/3] mmc: mvsdio: Support inverted CD and WP GPIO lines

2013-04-22 Thread Chris Ball
Hi, On Mon, Apr 22 2013, Andrew Lunn wrote: >> Nothing else really jumps out though. Where either of these what you >> were thinking of? > > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-December/138514.html > > and > > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-Decem

Re: [PATCH 1/3] mmc: mvsdio: Support inverted CD and WP GPIO lines

2013-04-22 Thread Andrew Lunn
> > > The core function mmc_of_parse() (new in 3.9) will do all of this DT > > > parsing for you, and will also take care of the driver's later calls > > > to mmc_gpio_request_{cd,wp}(). Could you try using that function > > > instead, please? > > > > Hi Chris, Simon > > > > I have a vague recol

Re: [PATCH 1/3] mmc: mvsdio: Support inverted CD and WP GPIO lines

2013-04-22 Thread Jason Cooper
On Mon, Apr 22, 2013 at 10:37:23PM +0200, Andrew Lunn wrote: > On Mon, Apr 22, 2013 at 04:03:15PM -0400, Chris Ball wrote: > > Hi Simon, > > > > On Mon, Apr 22 2013, Simon Baatz wrote: > > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > > > index 145cdaf..d444efd 100644 > >

Re: [PATCH 1/3] mmc: mvsdio: Support inverted CD and WP GPIO lines

2013-04-22 Thread Andrew Lunn
On Mon, Apr 22, 2013 at 04:03:15PM -0400, Chris Ball wrote: > Hi Simon, > > On Mon, Apr 22 2013, Simon Baatz wrote: > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > > index 145cdaf..d444efd 100644 > > --- a/drivers/mmc/host/mvsdio.c > > +++ b/drivers/mmc/host/mvsdio.c > > @

Re: [PATCH 1/3] mmc: mvsdio: Support inverted CD and WP GPIO lines

2013-04-22 Thread Chris Ball
Hi Simon, On Mon, Apr 22 2013, Simon Baatz wrote: > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > index 145cdaf..d444efd 100644 > --- a/drivers/mmc/host/mvsdio.c > +++ b/drivers/mmc/host/mvsdio.c > @@ -691,6 +691,7 @@ static int __init mvsd_probe(struct platform_device *pdev

[PATCH 1/3] mmc: mvsdio: Support inverted CD and WP GPIO lines

2013-04-22 Thread Simon Baatz
The slot-gpio helper functions allow to specify whether card detect and write protect GPIO lines are active high or active low. Since DT allows to specify active low/high for GPIO lines as well, we can simply initialize the flags for slot-gpio using the GPIO flags to support all cases. We need to