Re: [PATCH 1/3 ] mmc: add support for h/w clock gating of sd controller

2010-12-05 Thread Philip Rakity
will change tomorrow with other changes Nico Suggested. Philip On Dec 4, 2010, at 1:02 PM, Wolfram Sang wrote: > Hi, > > minor comments in addition to Nicolas: > > On Fri, Dec 03, 2010 at 11:26:50AM -0800, Philip Rakity wrote: > >> hardware clock gating is enabled by setting the mmc quirk >

Re: [PATCH 1/3 ] mmc: add support for h/w clock gating of sd controller

2010-12-04 Thread Wolfram Sang
Hi, minor comments in addition to Nicolas: On Fri, Dec 03, 2010 at 11:26:50AM -0800, Philip Rakity wrote: > hardware clock gating is enabled by setting the mmc quirk It's not a quirk, it's a capability :) > MMC_CAP_CLOCK_GATING_HW Why not MMC_CAP_HW_CLOCK_GATING? Might be a mileage, though...

Re: [PATCH 1/3 ] mmc: add support for h/w clock gating of sd controller

2010-12-03 Thread Nicolas Pitre
On Fri, 3 Dec 2010, Philip Rakity wrote: > This code extends software clock gating in the mmc layer > by adding the ability to indicate that controller support > hardware clock gating. > > hardware clock gating is enabled by setting the mmc quirk > MMC_CAP_CLOCK_GATING_HW > in the sd driver. > eg

[PATCH 1/3 ] mmc: add support for h/w clock gating of sd controller

2010-12-03 Thread Philip Rakity
This code extends software clock gating in the mmc layer by adding the ability to indicate that controller support hardware clock gating. hardware clock gating is enabled by setting the mmc quirk MMC_CAP_CLOCK_GATING_HW in the sd driver. eg: host->mmc->caps |= MMC_CAP_CLOCK_GATING_HW The approach