Re: [PATCH 1/4] mmc: sdhci: add a driver for Berlin SoCs

2014-05-09 Thread Ben Dooks
On 16/04/14 13:40, Antoine Ténart wrote: Add a Driver to support the SDHCI controller of the Marvell Berlin SoCs. This controller supports 3 sockets. [snip] + +static struct sdhci_ops sdhci_berlin_ops = { + .get_max_clock = sdhci_pltfm_clk_get_max_clock, +}; + +static struct sdhci_pltfm

Re: [PATCH 1/4] mmc: sdhci: add a driver for Berlin SoCs

2014-04-18 Thread Antoine Ténart
Hi all, On Wed, Apr 16, 2014 at 02:40:08PM +0200, Antoine Ténart wrote: > Add a Driver to support the SDHCI controller of the Marvell Berlin SoCs. > This controller supports 3 sockets. After talking a bit with Sebastian and Jisheng I decided to have a look on the pxav3 driver. I gave it a try, it

Re: [PATCH 1/4] mmc: sdhci: add a driver for Berlin SoCs

2014-04-17 Thread Jisheng Zhang
Hi, On Thu, 17 Apr 2014 06:33:59 -0700 Antoine Ténart wrote: > Sebastian, > > On Wed, Apr 16, 2014 at 04:26:06PM +0200, Sebastian Hesselbarth wrote: > > On 04/16/2014 02:40 PM, Antoine Ténart wrote: > > >Add a Driver to support the SDHCI controller of the Marvell Berlin SoCs. > > >This controll

Re: [PATCH 1/4] mmc: sdhci: add a driver for Berlin SoCs

2014-04-17 Thread Antoine Ténart
Sebastian, On Wed, Apr 16, 2014 at 04:26:06PM +0200, Sebastian Hesselbarth wrote: > On 04/16/2014 02:40 PM, Antoine Ténart wrote: > >Add a Driver to support the SDHCI controller of the Marvell Berlin SoCs. > >This controller supports 3 sockets. > > nit: Isn't it three controller with one socket e

Re: [PATCH 1/4] mmc: sdhci: add a driver for Berlin SoCs

2014-04-16 Thread Sebastian Hesselbarth
On 04/16/2014 02:40 PM, Antoine Ténart wrote: Add a Driver to support the SDHCI controller of the Marvell Berlin SoCs. This controller supports 3 sockets. nit: Isn't it three controller with one socket each? Signed-off-by: Antoine Ténart --- drivers/mmc/host/Kconfig| 11 dri

Re: [PATCH 1/4] mmc: sdhci: add a driver for Berlin SoCs

2014-04-16 Thread Antoine Ténart
Joe, On Wed, Apr 16, 2014 at 05:56:34AM -0700, Joe Perches wrote: > On Wed, 2014-04-16 at 14:40 +0200, Antoine Ténart wrote: > > Add a Driver to support the SDHCI controller of the Marvell Berlin SoCs. > > This controller supports 3 sockets. > > trivial notes: > > > diff --git a/drivers/mmc/host

Re: [PATCH 1/4] mmc: sdhci: add a driver for Berlin SoCs

2014-04-16 Thread Joe Perches
On Wed, 2014-04-16 at 14:40 +0200, Antoine Ténart wrote: > Add a Driver to support the SDHCI controller of the Marvell Berlin SoCs. > This controller supports 3 sockets. trivial notes: > diff --git a/drivers/mmc/host/sdhci-berlin.c b/drivers/mmc/host/sdhci-berlin.c [] > +static struct sdhci_ops s

[PATCH 1/4] mmc: sdhci: add a driver for Berlin SoCs

2014-04-16 Thread Antoine Ténart
Add a Driver to support the SDHCI controller of the Marvell Berlin SoCs. This controller supports 3 sockets. Signed-off-by: Antoine Ténart --- drivers/mmc/host/Kconfig| 11 drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-berlin.c | 129 ++