Re: [PATCH 2/2] mmc: rtsx: add support for sdio card

2014-11-27 Thread 敬锐
On 11/27/2014 11:43 PM, Dan Carpenter wrote: >> +int stat_idx = sd_status_index(rsp_type); > I have always hated this terrible pointer math. 5 is relative to > pcr->host_cmds_ptr + 1. It's a mess... 5 mean CRC7 offset of Response R1, see SD spec V3.01 Page 82. 4.9.1 R1 (normal response comma

Re: [PATCH 2/2] mmc: rtsx: add support for sdio card

2014-11-27 Thread Dan Carpenter
> #ifdef DEBUG > -static void sd_print_debug_regs(struct realtek_pci_sdmmc *host) > +static void dump_reg_range(struct realtek_pci_sdmmc *host, u16 start, u16 > end) > { > - struct rtsx_pcr *pcr = host->pcr; > - u16 i; > - u8 *ptr; > + u16 len = end - start + 1; > + int i; >

[PATCH 2/2] mmc: rtsx: add support for sdio card

2014-11-26 Thread micky_ching
From: Micky Ching Add support for sdio card by SD interface. The main change is data transfer mode, When read data, host wait data transfer while command start. When write data, host will start data transfer after command get response. The transfer mode modify can be applied both for SD/MMC card