Re: [PATCH 2/2] mmc: sdhci-pci: add runtime pm support

2011-10-17 Thread Adrian Hunter
On 16/10/11 05:26, Chris Ball wrote: > Hi, > > On Sat, Oct 15 2011, Chris Ball wrote: >> Card insertion detection after boot no longer works (nothing new appears >> in dmesg), so I'm unable to use the reader. Are you able to try to >> figure this out? I'm happy to try any patches you suggest. >

Re: [PATCH 2/2] mmc: sdhci-pci: add runtime pm support

2011-10-15 Thread Chris Ball
Hi, On Sat, Oct 15 2011, Chris Ball wrote: > Card insertion detection after boot no longer works (nothing new appears > in dmesg), so I'm unable to use the reader. Are you able to try to > figure this out? I'm happy to try any patches you suggest. If I boot with a card inserted, I still see rep

Re: [PATCH 2/2] mmc: sdhci-pci: add runtime pm support

2011-10-15 Thread Chris Ball
Hi Adrian, On Mon, Oct 03 2011, Adrian Hunter wrote: > Ths patch allows runtime PM for sdhci-pci, runtime suspending > after inactivity of 50ms and ensuring runtime resume before > SDHC registers are accessed. During runtime suspend, interrupts > are masked. The host controller state is restored

Re: [PATCH 2/2] mmc: sdhci-pci: add runtime pm support

2011-10-10 Thread Chris Ball
Hi, On Mon, Oct 03 2011, Adrian Hunter wrote: > Ths patch allows runtime PM for sdhci-pci, runtime suspending > after inactivity of 50ms and ensuring runtime resume before > SDHC registers are accessed. During runtime suspend, interrupts > are masked. The host controller state is restored at run

Re: [PATCH 2/2] mmc: sdhci-pci: add runtime pm support

2011-10-06 Thread Ulf Hansson
It has been discussed on the list before that the host controller driver should be solely responsible for host controller power. OK I see, sorry that I missed that discussion earlier! Anyway this should be feasible as well even it might mean duplicated code in each host driver. A positive si

Re: [PATCH 2/2] mmc: sdhci-pci: add runtime pm support

2011-10-06 Thread Adrian Hunter
On 05/10/11 17:59, Ulf Hansson wrote: I am not that into how the sdhci host drivers is working, myself is more working with the mmci driver and about to sent out patches with improved power management support soon. I would like to take the opportunity to discuss in general pm_runtime for mmc/sd/s

Re: [PATCH 2/2] mmc: sdhci-pci: add runtime pm support

2011-10-05 Thread Ulf Hansson
Adrian Hunter wrote: Ths patch allows runtime PM for sdhci-pci, runtime suspending after inactivity of 50ms and ensuring runtime resume before SDHC registers are accessed. During runtime suspend, interrupts are masked. The host controller state is restored at runtime resume. For Medfield, the

Re: [PATCH 2/2] mmc: sdhci-pci: add runtime pm support

2011-10-03 Thread Adrian Hunter
On 04/10/11 07:44, Jaehoon Chung wrote: Hi Adrian... +#ifdef CONFIG_PM_RUNTIME + +static int sdhci_pci_runtime_suspend(struct device *dev) +{ + struct pci_dev *pdev = container_of(dev, struct pci_dev, dev); + struct sdhci_pci_chip *chip; + struct sdhci_pci_slot *slot; +

Re: [PATCH 2/2] mmc: sdhci-pci: add runtime pm support

2011-10-03 Thread Jaehoon Chung
Hi Adrian... > +#ifdef CONFIG_PM_RUNTIME > + > +static int sdhci_pci_runtime_suspend(struct device *dev) > +{ > + struct pci_dev *pdev = container_of(dev, struct pci_dev, dev); > + struct sdhci_pci_chip *chip; > + struct sdhci_pci_slot *slot; > + pm_message_t state = { .event = PM_

[PATCH 2/2] mmc: sdhci-pci: add runtime pm support

2011-10-03 Thread Adrian Hunter
Ths patch allows runtime PM for sdhci-pci, runtime suspending after inactivity of 50ms and ensuring runtime resume before SDHC registers are accessed. During runtime suspend, interrupts are masked. The host controller state is restored at runtime resume. For Medfield, the host controller's card