Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-27 Thread Matt Fleming
On Sun, Sep 26, 2010 at 03:31:22PM +0800, zhangfei gao wrote: > On Thu, Sep 16, 2010 at 5:02 PM, Matt Fleming wrote: > > On Thu, Sep 16, 2010 at 03:20:08AM +0100, Chris Ball wrote: > >> Hi Matt, > >> > >> On Wed, Sep 15, 2010 at 09:38:55PM +0100, Chris Ball wrote: > >> > On Wed, Sep 15, 2010 at 04

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-26 Thread zhangfei gao
On Thu, Sep 16, 2010 at 5:02 PM, Matt Fleming wrote: > On Thu, Sep 16, 2010 at 03:20:08AM +0100, Chris Ball wrote: >> Hi Matt, >> >> On Wed, Sep 15, 2010 at 09:38:55PM +0100, Chris Ball wrote: >> > On Wed, Sep 15, 2010 at 04:11:42PM +0100, Matt Fleming wrote: >> > > Chris, are you OK to pick this

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-16 Thread Matt Fleming
On Thu, Sep 16, 2010 at 03:20:08AM +0100, Chris Ball wrote: > Hi Matt, > > On Wed, Sep 15, 2010 at 09:38:55PM +0100, Chris Ball wrote: > > On Wed, Sep 15, 2010 at 04:11:42PM +0100, Matt Fleming wrote: > > > Chris, are you OK to pick this up (including Jaehoon's change)? Or > > > would you prefer m

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-15 Thread Chris Ball
Hi Matt, On Wed, Sep 15, 2010 at 09:38:55PM +0100, Chris Ball wrote: > On Wed, Sep 15, 2010 at 04:11:42PM +0100, Matt Fleming wrote: > > Chris, are you OK to pick this up (including Jaehoon's change)? Or > > would you prefer me to resubmit? > > Thanks, that's fine, I've applied both patches to mm

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-15 Thread Chris Ball
Hi Matt, On Wed, Sep 15, 2010 at 04:11:42PM +0100, Matt Fleming wrote: > Chris, are you OK to pick this up (including Jaehoon's change)? Or > would you prefer me to resubmit? Thanks, that's fine, I've applied both patches to mmc-next: http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=commi

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-15 Thread Matt Fleming
On Wed, Sep 15, 2010 at 04:11:42PM +0100, Matt Fleming wrote: > On Wed, Sep 08, 2010 at 10:27:14AM +0900, Jaehoon Chung wrote: > > Matt Fleming wrote: > > > On Thu, Sep 02, 2010 at 05:51:45PM +0900, Jaehoon Chung wrote: > > >> Matt Fleming wrote: > > >>> From: Jaehoon Chung > > >>> > > >>> If cont

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-15 Thread Matt Fleming
On Wed, Sep 08, 2010 at 10:27:14AM +0900, Jaehoon Chung wrote: > Matt Fleming wrote: > > On Thu, Sep 02, 2010 at 05:51:45PM +0900, Jaehoon Chung wrote: > >> Matt Fleming wrote: > >>> From: Jaehoon Chung > >>> > >>> If controller use SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk, > >>> controller need al

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-07 Thread Jaehoon Chung
Matt Fleming wrote: > On Thu, Sep 02, 2010 at 05:51:45PM +0900, Jaehoon Chung wrote: >> Matt Fleming wrote: >>> From: Jaehoon Chung >>> >>> If controller use SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk, >>> controller need always polling detect >>> >>> In this case, always generated interrupt.Because

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-02 Thread Matt Fleming
On Thu, Sep 02, 2010 at 05:51:45PM +0900, Jaehoon Chung wrote: > Matt Fleming wrote: > > From: Jaehoon Chung > > > > If controller use SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk, > > controller need always polling detect > > > > In this case, always generated interrupt.Because controller checked card

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-02 Thread Jaehoon Chung
Matt Fleming wrote: > From: Jaehoon Chung > > If controller use SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk, > controller need always polling detect > > In this case, always generated interrupt.Because controller checked card > status. > I think that is not efficiently. > > But if card is nonremovabl

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-08-29 Thread Kyungmin Park
Acked-by: Kyungmin Park On Sat, Aug 28, 2010 at 10:53 PM, Matt Fleming wrote: > From: Jaehoon Chung > > If controller use SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk, > controller need always polling detect > > In this case, always generated interrupt.Because controller checked card > status. > I

[PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-08-28 Thread Matt Fleming
From: Jaehoon Chung If controller use SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk, controller need always polling detect In this case, always generated interrupt.Because controller checked card status. I think that is not efficiently. But if card is nonremovable, we need not always polling. So i ad